* [PATCH] platform/x86: sony-laptop: revert 'const' on keymap
@ 2017-06-30 15:45 Arnd Bergmann
2017-06-30 15:58 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2017-06-30 15:45 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Arnd Bergmann, Mattia Dongili, Darren Hart, Arvind Yadav,
platform-driver-x86, linux-kernel
Marking sony_laptop_input_keycode_map 'const' sounds like a good
idea in principle, but unfortunately causes a compiler warning:
drivers/platform/x86/sony-laptop.c: In function 'sony_laptop_setup_input':
drivers/platform/x86/sony-laptop.c:494:19: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-array-qualifiers]
This reverts that part of the previous cleanup patch.
Fixes: a0f0a5e1978b ("platform/x86: sony-laptop: constify few static structures")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/platform/x86/sony-laptop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index 5fc20473d51e..bfae79534f44 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -299,7 +299,7 @@ static const int sony_laptop_input_index[] = {
59, /* 72 SONYPI_EVENT_VENDOR_PRESSED */
};
-static const int sony_laptop_input_keycode_map[] = {
+static int sony_laptop_input_keycode_map[] = {
KEY_CAMERA, /* 0 SONYPI_EVENT_CAPTURE_PRESSED */
KEY_RESERVED, /* 1 SONYPI_EVENT_CAPTURE_RELEASED */
KEY_RESERVED, /* 2 SONYPI_EVENT_CAPTURE_PARTIALPRESSED */
--
2.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] platform/x86: sony-laptop: revert 'const' on keymap
2017-06-30 15:45 [PATCH] platform/x86: sony-laptop: revert 'const' on keymap Arnd Bergmann
@ 2017-06-30 15:58 ` Andy Shevchenko
2017-06-30 18:21 ` Darren Hart
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2017-06-30 15:58 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Andy Shevchenko, Mattia Dongili, Darren Hart, Arvind Yadav,
Platform Driver, linux-kernel
On Fri, Jun 30, 2017 at 6:45 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> Marking sony_laptop_input_keycode_map 'const' sounds like a good
> idea in principle, but unfortunately causes a compiler warning:
>
> drivers/platform/x86/sony-laptop.c: In function 'sony_laptop_setup_input':
> drivers/platform/x86/sony-laptop.c:494:19: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-array-qualifiers]
>
> This reverts that part of the previous cleanup patch.
Thanks, pushed directly to for-next.
I didn't get a clear result from our 0day kbuild bot, so it was in
testing previously.
Darren, it looks like we need more clear coordination on what is going
to be applied for-next from testing.
>
> Fixes: a0f0a5e1978b ("platform/x86: sony-laptop: constify few static structures")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/platform/x86/sony-laptop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
> index 5fc20473d51e..bfae79534f44 100644
> --- a/drivers/platform/x86/sony-laptop.c
> +++ b/drivers/platform/x86/sony-laptop.c
> @@ -299,7 +299,7 @@ static const int sony_laptop_input_index[] = {
> 59, /* 72 SONYPI_EVENT_VENDOR_PRESSED */
> };
>
> -static const int sony_laptop_input_keycode_map[] = {
> +static int sony_laptop_input_keycode_map[] = {
> KEY_CAMERA, /* 0 SONYPI_EVENT_CAPTURE_PRESSED */
> KEY_RESERVED, /* 1 SONYPI_EVENT_CAPTURE_RELEASED */
> KEY_RESERVED, /* 2 SONYPI_EVENT_CAPTURE_PARTIALPRESSED */
> --
> 2.9.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] platform/x86: sony-laptop: revert 'const' on keymap
2017-06-30 15:58 ` Andy Shevchenko
@ 2017-06-30 18:21 ` Darren Hart
2017-06-30 20:50 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Darren Hart @ 2017-06-30 18:21 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Arnd Bergmann, Andy Shevchenko, Mattia Dongili, Arvind Yadav,
Platform Driver, linux-kernel
On Fri, Jun 30, 2017 at 06:58:24PM +0300, Andy Shevchenko wrote:
> On Fri, Jun 30, 2017 at 6:45 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > Marking sony_laptop_input_keycode_map 'const' sounds like a good
> > idea in principle, but unfortunately causes a compiler warning:
> >
> > drivers/platform/x86/sony-laptop.c: In function 'sony_laptop_setup_input':
> > drivers/platform/x86/sony-laptop.c:494:19: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-array-qualifiers]
> >
> > This reverts that part of the previous cleanup patch.
>
> Thanks, pushed directly to for-next.
>
Thanks Andy,
> I didn't get a clear result from our 0day kbuild bot, so it was in
> testing previously.
>
> Darren, it looks like we need more clear coordination on what is going
> to be applied for-next from testing.
Indeed - and my CI build should have caught this warning. I will look into what
it's missing so this would be called out as an error.
And for this patch, I would prefer to roll this into the original. There is no
point in introducing warnings into Linus' kernel. We try not to rebase for-next,
but it happens everyday, so it isn't a huge deal for Stephen to deal with.
Will you squash it, or shall I?
--
Darren Hart
VMware Open Source Technology Center
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] platform/x86: sony-laptop: revert 'const' on keymap
2017-06-30 18:21 ` Darren Hart
@ 2017-06-30 20:50 ` Andy Shevchenko
2017-07-01 3:30 ` Darren Hart
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2017-06-30 20:50 UTC (permalink / raw)
To: Darren Hart
Cc: Arnd Bergmann, Andy Shevchenko, Mattia Dongili, Arvind Yadav,
Platform Driver, linux-kernel
On Fri, Jun 30, 2017 at 9:21 PM, Darren Hart <dvhart@infradead.org> wrote:
> On Fri, Jun 30, 2017 at 06:58:24PM +0300, Andy Shevchenko wrote:
>> On Fri, Jun 30, 2017 at 6:45 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> Will you squash it, or shall I?
Please, handle this, thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] platform/x86: sony-laptop: revert 'const' on keymap
2017-06-30 20:50 ` Andy Shevchenko
@ 2017-07-01 3:30 ` Darren Hart
0 siblings, 0 replies; 5+ messages in thread
From: Darren Hart @ 2017-07-01 3:30 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Arnd Bergmann, Andy Shevchenko, Mattia Dongili, Arvind Yadav,
Platform Driver, linux-kernel
On Fri, Jun 30, 2017 at 11:50:52PM +0300, Andy Shevchenko wrote:
> On Fri, Jun 30, 2017 at 9:21 PM, Darren Hart <dvhart@infradead.org> wrote:
> > On Fri, Jun 30, 2017 at 06:58:24PM +0300, Andy Shevchenko wrote:
> >> On Fri, Jun 30, 2017 at 6:45 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>
> > Will you squash it, or shall I?
>
> Please, handle this, thanks!
Done. Thanks all, and apologies for the noise on this one.
--
Darren Hart
VMware Open Source Technology Center
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-01 3:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-30 15:45 [PATCH] platform/x86: sony-laptop: revert 'const' on keymap Arnd Bergmann
2017-06-30 15:58 ` Andy Shevchenko
2017-06-30 18:21 ` Darren Hart
2017-06-30 20:50 ` Andy Shevchenko
2017-07-01 3:30 ` Darren Hart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.