[PATCH v1] pinctrl: jasperlake: Fix HOSTSW_OWN register offset

[PATCH v1] pinctrl: jasperlake: Fix HOSTSW_OWN register offset

[Andy Shevchenko]

Jasper Lake uses different offset for HOSTSW_OWN register.
Fix it here.

Fixes: e278dcb7048b ("pinctrl: intel: Add Intel Jasper Lake pin controller support")
Reported-by: Evan Green <evgreen@chromium.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
I have got a confirmation that PADCFGLOCK is still 0x80.
I updated my patch and put your name as Reported-by. If you want me
to have your patch instead, I can review it (it needs some massage
of the commit message)

 drivers/pinctrl/intel/pinctrl-jasperlake.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/intel/pinctrl-jasperlake.c b/drivers/pinctrl/intel/pinctrl-jasperlake.c
index c5e204c8da9c..ec435b7ab392 100644
--- a/drivers/pinctrl/intel/pinctrl-jasperlake.c
+++ b/drivers/pinctrl/intel/pinctrl-jasperlake.c
@@ -16,7 +16,7 @@
 
 #define JSL_PAD_OWN	0x020
 #define JSL_PADCFGLOCK	0x080
-#define JSL_HOSTSW_OWN	0x0b0
+#define JSL_HOSTSW_OWN	0x0c0
 #define JSL_GPI_IS	0x100
 #define JSL_GPI_IE	0x120
 
-- 
2.28.0

Re: [PATCH v1] pinctrl: jasperlake: Fix HOSTSW_OWN register offset

[Evan Green]

On Wed, Nov 11, 2020 at 1:54 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Jasper Lake uses different offset for HOSTSW_OWN register.
> Fix it here.
>
> Fixes: e278dcb7048b ("pinctrl: intel: Add Intel Jasper Lake pin controller support")
> Reported-by: Evan Green <evgreen@chromium.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> I have got a confirmation that PADCFGLOCK is still 0x80.
> I updated my patch and put your name as Reported-by. If you want me
> to have your patch instead, I can review it (it needs some massage
> of the commit message)

Either way is ok. I'm happy to spin and edit my commit message, let me
know how to change.
-Evan

Re: [PATCH v1] pinctrl: jasperlake: Fix HOSTSW_OWN register offset

[Andy Shevchenko]

On Thu, Nov 12, 2020 at 12:08 AM Evan Green <evgreen@chromium.org> wrote:
>
> On Wed, Nov 11, 2020 at 1:54 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > Jasper Lake uses different offset for HOSTSW_OWN register.
> > Fix it here.
> >
> > Fixes: e278dcb7048b ("pinctrl: intel: Add Intel Jasper Lake pin controller support")
> > Reported-by: Evan Green <evgreen@chromium.org>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > I have got a confirmation that PADCFGLOCK is still 0x80.
> > I updated my patch and put your name as Reported-by. If you want me
> > to have your patch instead, I can review it (it needs some massage
> > of the commit message)
>
> Either way is ok. I'm happy to spin and edit my commit message, let me
> know how to change.

Okay, let's drop this one, because it repeats yours 100% code wise.

-- 
With Best Regards,
Andy Shevchenko