All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Rodrigo Rolim Mendes de Alencar <455.rodrigo.alencar@gmail.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-fbdev@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	alencar.fmce@imbel.gov.br
Subject: Re: [PATCH] video: fbdev: ssd1307fb: Added support to Column offset
Date: Wed, 13 May 2020 18:03:35 +0300	[thread overview]
Message-ID: <CAHp75VfggycwYpsi024MWZYEgOpnst9NR3q-D5n30SDgmSB9Pw@mail.gmail.com> (raw)
In-Reply-To: <1589370694-14327-1-git-send-email-alencar.fmce@imbel.gov.br>

On Wed, May 13, 2020 at 2:51 PM Rodrigo Rolim Mendes de Alencar
<455.rodrigo.alencar@gmail.com> wrote:
>
> This patch provides support for displays like VGM128064B0W10,
> which requires a column offset of 2, i.e., its segments starts
> in SEG2 and ends in SEG129.

You forgot
1) version of the patch (series) to be bumped
2) Cc to fbdev maintainer (I did here FYI)

> -       ret = ssd1307fb_write_cmd(par->client, 0x0);
> +       ret = ssd1307fb_write_cmd(par->client, par->col_offset);
>         if (ret < 0)
>                 return ret;
>
> -       ret = ssd1307fb_write_cmd(par->client, par->width - 1);
> +       ret = ssd1307fb_write_cmd(par->client, par->col_offset + par->width - 1);
>         if (ret < 0)
>                 return ret;
>
> @@ -626,6 +627,9 @@ static int ssd1307fb_probe(struct i2c_client *client)
>         if (device_property_read_u32(dev, "solomon,page-offset", &par->page_offset))
>                 par->page_offset = 1;
>
> +       if (of_property_read_u32(node, "solomon,col-offset", &par->col_offset))
> +               par->col_offset = 0;

This won't work on non-OF systems, but easy to fix: simple see around
and do in the same way.

>         if (device_property_read_u32(dev, "solomon,com-offset", &par->com_offset))
>                 par->com_offset = 0;

-- 
With Best Regards,
Andy Shevchenko

WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Rodrigo Rolim Mendes de Alencar <455.rodrigo.alencar@gmail.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-fbdev@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	alencar.fmce@imbel.gov.br
Subject: Re: [PATCH] video: fbdev: ssd1307fb: Added support to Column offset
Date: Wed, 13 May 2020 15:03:35 +0000	[thread overview]
Message-ID: <CAHp75VfggycwYpsi024MWZYEgOpnst9NR3q-D5n30SDgmSB9Pw@mail.gmail.com> (raw)
In-Reply-To: <1589370694-14327-1-git-send-email-alencar.fmce@imbel.gov.br>

On Wed, May 13, 2020 at 2:51 PM Rodrigo Rolim Mendes de Alencar
<455.rodrigo.alencar@gmail.com> wrote:
>
> This patch provides support for displays like VGM128064B0W10,
> which requires a column offset of 2, i.e., its segments starts
> in SEG2 and ends in SEG129.

You forgot
1) version of the patch (series) to be bumped
2) Cc to fbdev maintainer (I did here FYI)

> -       ret = ssd1307fb_write_cmd(par->client, 0x0);
> +       ret = ssd1307fb_write_cmd(par->client, par->col_offset);
>         if (ret < 0)
>                 return ret;
>
> -       ret = ssd1307fb_write_cmd(par->client, par->width - 1);
> +       ret = ssd1307fb_write_cmd(par->client, par->col_offset + par->width - 1);
>         if (ret < 0)
>                 return ret;
>
> @@ -626,6 +627,9 @@ static int ssd1307fb_probe(struct i2c_client *client)
>         if (device_property_read_u32(dev, "solomon,page-offset", &par->page_offset))
>                 par->page_offset = 1;
>
> +       if (of_property_read_u32(node, "solomon,col-offset", &par->col_offset))
> +               par->col_offset = 0;

This won't work on non-OF systems, but easy to fix: simple see around
and do in the same way.

>         if (device_property_read_u32(dev, "solomon,com-offset", &par->com_offset))
>                 par->com_offset = 0;

-- 
With Best Regards,
Andy Shevchenko

  parent reply	other threads:[~2020-05-13 15:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13 11:51 [PATCH] video: fbdev: ssd1307fb: Added support to Column offset Rodrigo Rolim Mendes de Alencar
2020-05-13 11:51 ` Rodrigo Rolim Mendes de Alencar
2020-05-13 13:45 ` Geert Uytterhoeven
2020-05-13 13:45   ` Geert Uytterhoeven
2020-05-13 15:03 ` Andy Shevchenko [this message]
2020-05-13 15:03   ` Andy Shevchenko
2020-05-13 16:32 ` kbuild test robot
2020-05-13 16:32   ` kbuild test robot
2020-05-13 16:32   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75VfggycwYpsi024MWZYEgOpnst9NR3q-D5n30SDgmSB9Pw@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=455.rodrigo.alencar@gmail.com \
    --cc=alencar.fmce@imbel.gov.br \
    --cc=b.zolnierkie@samsung.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.