* [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions
@ 2015-11-22 17:11 Douglas Gilbert
2015-11-24 15:04 ` Hannes Reinecke
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Douglas Gilbert @ 2015-11-22 17:11 UTC (permalink / raw)
To: Martin K. Petersen, James E.J. Bottomley, SCSI development list
Cc: sweet_f_a, util-linux
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
Ruediger Meier observed a regression with the PREVENT ALLOW
MEDIUM REMOVAL command in lk 3.19:
http://www.spinics.net/lists/util-linux-ng/msg11448.html
Inspection indicated the same regression with VERIFY(10).
The patch is against lk 3.19.3 and also works with lk 4.3.0 .
With this patch both commands are accepted and do nothing.
ChangeLog:
- fix the lk 3.19 regression so that the PREVENT ALLOW
MEDIUM REMOVAL command is supported once again
- same fix for VERIFY(10)
Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
[-- Attachment #2: sdebug319regr1.patch --]
[-- Type: text/x-patch, Size: 1399 bytes --]
--- a/drivers/scsi/scsi_debug.c 2015-02-11 17:47:09.276206425 -0500
+++ b/drivers/scsi/scsi_debug.c 2015-04-03 22:42:36.343971372 -0400
@@ -455,8 +455,9 @@ static const struct opcode_info_t opcode
0} },
{0, 0, 0, F_INV_OP | FF_RESPOND, NULL, NULL, /* MAINT OUT */
{0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} },
- {0, 0, 0, F_INV_OP | FF_RESPOND, NULL, NULL, /* VERIFY */
- {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} },
+ {0, 0x2f, 0, F_D_OUT_MAYBE | FF_DIRECT_IO, NULL, NULL, /* VERIFY(10) */
+ {10, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xc7,
+ 0, 0, 0, 0, 0, 0} },
{1, 0x7f, 0x9, F_SA_HIGH | F_D_IN | FF_DIRECT_IO, resp_read_dt0,
vl_iarr, {32, 0xc7, 0, 0, 0, 0, 0x1f, 0x18, 0x0, 0x9, 0xfe, 0,
0xff, 0xff, 0xff, 0xff} },/* VARIABLE LENGTH, READ(32) */
@@ -467,8 +468,8 @@ static const struct opcode_info_t opcode
{10, 0x13, 0xff, 0xff, 0, 0, 0, 0xff, 0xff, 0xc7, 0, 0, 0, 0, 0,
0} },
/* 20 */
- {0, 0, 0, F_INV_OP | FF_RESPOND, NULL, NULL, /* ALLOW REMOVAL */
- {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} },
+ {0, 0x1e, 0, 0, NULL, NULL, /* ALLOW REMOVAL */
+ {6, 0, 0, 0, 0x3, 0xc7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} },
{0, 0x1, 0, 0, resp_start_stop, NULL, /* REWIND ?? */
{6, 0x1, 0, 0, 0, 0xc7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} },
{0, 0, 0, F_INV_OP | FF_RESPOND, NULL, NULL, /* ATA_PT */
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions
@ 2015-11-24 15:04 ` Hannes Reinecke
0 siblings, 0 replies; 11+ messages in thread
From: Hannes Reinecke @ 2015-11-24 15:04 UTC (permalink / raw)
To: dgilbert, Martin K. Petersen, James E.J. Bottomley,
SCSI development list
Cc: sweet_f_a, util-linux
On 11/22/2015 06:11 PM, Douglas Gilbert wrote:
> Ruediger Meier observed a regression with the PREVENT ALLOW
> MEDIUM REMOVAL command in lk 3.19:
> http://www.spinics.net/lists/util-linux-ng/msg11448.html
>
> Inspection indicated the same regression with VERIFY(10).
>
> The patch is against lk 3.19.3 and also works with lk 4.3.0 .
> With this patch both commands are accepted and do nothing.
>
> ChangeLog:
> - fix the lk 3.19 regression so that the PREVENT ALLOW
> MEDIUM REMOVAL command is supported once again
> - same fix for VERIFY(10)
>
> Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions
@ 2015-11-24 15:04 ` Hannes Reinecke
0 siblings, 0 replies; 11+ messages in thread
From: Hannes Reinecke @ 2015-11-24 15:04 UTC (permalink / raw)
To: dgilbert-qazKcTl6WRFWk0Htik3J/w, Martin K. Petersen,
James E.J. Bottomley, SCSI development list
Cc: sweet_f_a-Mmb7MZpHnFY, util-linux-u79uwXL29TY76Z2rM5mHXA
On 11/22/2015 06:11 PM, Douglas Gilbert wrote:
> Ruediger Meier observed a regression with the PREVENT ALLOW
> MEDIUM REMOVAL command in lk 3.19:
> http://www.spinics.net/lists/util-linux-ng/msg11448.html
>
> Inspection indicated the same regression with VERIFY(10).
>
> The patch is against lk 3.19.3 and also works with lk 4.3.0 .
> With this patch both commands are accepted and do nothing.
>
> ChangeLog:
> - fix the lk 3.19 regression so that the PREVENT ALLOW
> MEDIUM REMOVAL command is supported once again
> - same fix for VERIFY(10)
>
> Signed-off-by: Douglas Gilbert <dgilbert-qazKcTl6WRFWk0Htik3J/w@public.gmane.org>
Reviewed-by: Hannes Reinecke <hare-IBi9RG/b67k@public.gmane.org>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare-l3A5Bk7waGM@public.gmane.org +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions
2015-11-22 17:11 [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions Douglas Gilbert
2015-11-24 15:04 ` Hannes Reinecke
@ 2015-11-24 15:25 ` Ewan Milne
2015-11-24 20:25 ` Martin K. Petersen
2 siblings, 0 replies; 11+ messages in thread
From: Ewan Milne @ 2015-11-24 15:25 UTC (permalink / raw)
To: dgilbert
Cc: Martin K. Petersen, James E.J. Bottomley, SCSI development list,
sweet_f_a, util-linux
On Sun, 2015-11-22 at 12:11 -0500, Douglas Gilbert wrote:
> Ruediger Meier observed a regression with the PREVENT ALLOW
> MEDIUM REMOVAL command in lk 3.19:
> http://www.spinics.net/lists/util-linux-ng/msg11448.html
>
> Inspection indicated the same regression with VERIFY(10).
>
> The patch is against lk 3.19.3 and also works with lk 4.3.0 .
> With this patch both commands are accepted and do nothing.
>
> ChangeLog:
> - fix the lk 3.19 regression so that the PREVENT ALLOW
> MEDIUM REMOVAL command is supported once again
> - same fix for VERIFY(10)
>
> Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions
2015-11-22 17:11 [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions Douglas Gilbert
2015-11-24 15:04 ` Hannes Reinecke
2015-11-24 15:25 ` Ewan Milne
@ 2015-11-24 20:25 ` Martin K. Petersen
2015-11-25 20:51 ` Andy Shevchenko
2 siblings, 1 reply; 11+ messages in thread
From: Martin K. Petersen @ 2015-11-24 20:25 UTC (permalink / raw)
To: Douglas Gilbert
Cc: Martin K. Petersen, James E.J. Bottomley, SCSI development list,
sweet_f_a, util-linux
>>>>> "Doug" == Douglas Gilbert <dgilbert@interlog.com> writes:
Doug> Ruediger Meier observed a regression with the PREVENT ALLOW MEDIUM
Doug> REMOVAL command in lk 3.19:
Doug> http://www.spinics.net/lists/util-linux-ng/msg11448.html
Applied to 4.4.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions
@ 2015-11-25 20:51 ` Andy Shevchenko
0 siblings, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2015-11-25 20:51 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Douglas Gilbert, James E.J. Bottomley, SCSI development list,
sweet_f_a, util-linux
Martin, sorry for offtopic, but can you pay a little attention to
http://www.spinics.net/lists/linux-scsi/msg81778.html ? It seems it
wasn't applied.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions
@ 2015-11-25 20:51 ` Andy Shevchenko
0 siblings, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2015-11-25 20:51 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Douglas Gilbert, James E.J. Bottomley, SCSI development list,
sweet_f_a-Mmb7MZpHnFY, util-linux-u79uwXL29TY76Z2rM5mHXA
Martin, sorry for offtopic, but can you pay a little attention to
http://www.spinics.net/lists/linux-scsi/msg81778.html ? It seems it
wasn't applied.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions
@ 2015-11-26 2:14 ` Martin K. Petersen
0 siblings, 0 replies; 11+ messages in thread
From: Martin K. Petersen @ 2015-11-26 2:14 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Martin K. Petersen, Douglas Gilbert, James E.J. Bottomley,
SCSI development list, sweet_f_a, util-linux
>>>>> "Andy" == Andy Shevchenko <andy.shevchenko@gmail.com> writes:
Andy,
Andy> but can you pay a little attention to
Andy> http://www.spinics.net/lists/linux-scsi/msg81778.html ? It seems
Andy> it wasn't applied.
Please resubmit to linux-scsi. We'll take a look.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions
@ 2015-11-26 2:14 ` Martin K. Petersen
0 siblings, 0 replies; 11+ messages in thread
From: Martin K. Petersen @ 2015-11-26 2:14 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Martin K. Petersen, Douglas Gilbert, James E.J. Bottomley,
SCSI development list, sweet_f_a-Mmb7MZpHnFY,
util-linux-u79uwXL29TY76Z2rM5mHXA
>>>>> "Andy" == Andy Shevchenko <andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:
Andy,
Andy> but can you pay a little attention to
Andy> http://www.spinics.net/lists/linux-scsi/msg81778.html ? It seems
Andy> it wasn't applied.
Please resubmit to linux-scsi. We'll take a look.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions
@ 2015-11-27 9:19 ` Andy Shevchenko
0 siblings, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2015-11-27 9:19 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Douglas Gilbert, James E.J. Bottomley, SCSI development list,
sweet_f_a, util-linux
On Thu, Nov 26, 2015 at 4:14 AM, Martin K. Petersen
<martin.petersen@oracle.com> wrote:
>>>>>> "Andy" == Andy Shevchenko <andy.shevchenko@gmail.com> writes:
>
> Andy,
>
> Andy> but can you pay a little attention to
> Andy> http://www.spinics.net/lists/linux-scsi/msg81778.html ? It seems
> Andy> it wasn't applied.
>
> Please resubmit to linux-scsi. We'll take a look.
Done:
http://www.spinics.net/lists/linux-scsi/msg91207.html
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions
@ 2015-11-27 9:19 ` Andy Shevchenko
0 siblings, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2015-11-27 9:19 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Douglas Gilbert, James E.J. Bottomley, SCSI development list,
sweet_f_a-Mmb7MZpHnFY, util-linux-u79uwXL29TY76Z2rM5mHXA
On Thu, Nov 26, 2015 at 4:14 AM, Martin K. Petersen
<martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:
>>>>>> "Andy" == Andy Shevchenko <andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:
>
> Andy,
>
> Andy> but can you pay a little attention to
> Andy> http://www.spinics.net/lists/linux-scsi/msg81778.html ? It seems
> Andy> it wasn't applied.
>
> Please resubmit to linux-scsi. We'll take a look.
Done:
http://www.spinics.net/lists/linux-scsi/msg91207.html
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2015-11-27 9:19 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-22 17:11 [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions Douglas Gilbert
2015-11-24 15:04 ` Hannes Reinecke
2015-11-24 15:04 ` Hannes Reinecke
2015-11-24 15:25 ` Ewan Milne
2015-11-24 20:25 ` Martin K. Petersen
2015-11-25 20:51 ` Andy Shevchenko
2015-11-25 20:51 ` Andy Shevchenko
2015-11-26 2:14 ` Martin K. Petersen
2015-11-26 2:14 ` Martin K. Petersen
2015-11-27 9:19 ` Andy Shevchenko
2015-11-27 9:19 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.