* [PATCH v3 0/2] Add MSI support
@ 2018-05-11 9:15 ` Yao Chen
0 siblings, 0 replies; 19+ messages in thread
From: Yao Chen @ 2018-05-11 9:15 UTC (permalink / raw)
To: songxiaowei, wangbinghui, lorenzo.pieralisi, bhelgaas, xuwei5,
robh+dt, mark.rutland, catalin.marinas, will.deacon, linux-pci,
linux-kernel, linux-arm-kernel, devicetree
Cc: dimitrysh, guodong.xu, chenyao11, suzhuangluan, kongfei
Before Version Patches
======================
patch v2
https://www.spinics.net/lists/kernel/msg2797610.html
patch v1
https://www.spinics.net/lists/kernel/msg2796410.html
Changes between V3 and V2
=========================
1. fix issues according to review comments
(1)from Bjorn Helgaas: Check for 'pci->pp.msi_irq < 0'.
(2)from Bjorn Helgaas: Update the message of 'msi irq' in dev_err().
Changes between V2 and V1
=========================
1. seperate DT binding patch.
2. fix issues according to review comments
(1)from Bjorn Helgaas: Update the style of subject and changelog.
(2)from Bjorn Helgaas: Add msi irq number in the message.
(3)from Bjorn Helgaas: Delete unnecessary code 'pci->pp.root_bus_nr = -1'.
(4)from Dmitry Shmidt: Fix typing error. Replace 'interrupts-names' of 'interrupt-names'.
Yao Chen (2):
PCI: kirin: Add MSI support
arm64: dts: hi3660: Add pcie msi interrupt attribute
arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 ++
drivers/pci/dwc/pcie-kirin.c | 39 +++++++++++++++++++++++++++++++
2 files changed, 41 insertions(+)
--
1.9.1
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v3 0/2] Add MSI support
@ 2018-05-11 9:15 ` Yao Chen
0 siblings, 0 replies; 19+ messages in thread
From: Yao Chen @ 2018-05-11 9:15 UTC (permalink / raw)
To: songxiaowei, wangbinghui, lorenzo.pieralisi, bhelgaas, xuwei5,
robh+dt, mark.rutland, catalin.marinas, will.deacon, linux-pci,
linux-kernel, linux-arm-kernel, devicetree
Cc: dimitrysh, guodong.xu, chenyao11, suzhuangluan, kongfei
Before Version Patches
======================
patch v2
https://www.spinics.net/lists/kernel/msg2797610.html
patch v1
https://www.spinics.net/lists/kernel/msg2796410.html
Changes between V3 and V2
=========================
1. fix issues according to review comments
(1)from Bjorn Helgaas: Check for 'pci->pp.msi_irq < 0'.
(2)from Bjorn Helgaas: Update the message of 'msi irq' in dev_err().
Changes between V2 and V1
=========================
1. seperate DT binding patch.
2. fix issues according to review comments
(1)from Bjorn Helgaas: Update the style of subject and changelog.
(2)from Bjorn Helgaas: Add msi irq number in the message.
(3)from Bjorn Helgaas: Delete unnecessary code 'pci->pp.root_bus_nr = -1'.
(4)from Dmitry Shmidt: Fix typing error. Replace 'interrupts-names' of 'interrupt-names'.
Yao Chen (2):
PCI: kirin: Add MSI support
arm64: dts: hi3660: Add pcie msi interrupt attribute
arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 ++
drivers/pci/dwc/pcie-kirin.c | 39 +++++++++++++++++++++++++++++++
2 files changed, 41 insertions(+)
--
1.9.1
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v3 0/2] Add MSI support
@ 2018-05-11 9:15 ` Yao Chen
0 siblings, 0 replies; 19+ messages in thread
From: Yao Chen @ 2018-05-11 9:15 UTC (permalink / raw)
To: songxiaowei, wangbinghui, lorenzo.pieralisi, bhelgaas, xuwei5,
robh+dt, mark.rutland, catalin.marinas, will.deacon, linux-pci,
linux-kernel, linux-arm-kernel, devicetree
Cc: suzhuangluan, kongfei, dimitrysh, guodong.xu, chenyao11
Before Version Patches
======================
patch v2
https://www.spinics.net/lists/kernel/msg2797610.html
patch v1
https://www.spinics.net/lists/kernel/msg2796410.html
Changes between V3 and V2
=========================
1. fix issues according to review comments
(1)from Bjorn Helgaas: Check for 'pci->pp.msi_irq < 0'.
(2)from Bjorn Helgaas: Update the message of 'msi irq' in dev_err().
Changes between V2 and V1
=========================
1. seperate DT binding patch.
2. fix issues according to review comments
(1)from Bjorn Helgaas: Update the style of subject and changelog.
(2)from Bjorn Helgaas: Add msi irq number in the message.
(3)from Bjorn Helgaas: Delete unnecessary code 'pci->pp.root_bus_nr = -1'.
(4)from Dmitry Shmidt: Fix typing error. Replace 'interrupts-names' of 'interrupt-names'.
Yao Chen (2):
PCI: kirin: Add MSI support
arm64: dts: hi3660: Add pcie msi interrupt attribute
arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 ++
drivers/pci/dwc/pcie-kirin.c | 39 +++++++++++++++++++++++++++++++
2 files changed, 41 insertions(+)
--
1.9.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v3 0/2] Add MSI support
@ 2018-05-11 9:15 ` Yao Chen
0 siblings, 0 replies; 19+ messages in thread
From: Yao Chen @ 2018-05-11 9:15 UTC (permalink / raw)
To: linux-arm-kernel
Before Version Patches
======================
patch v2
https://www.spinics.net/lists/kernel/msg2797610.html
patch v1
https://www.spinics.net/lists/kernel/msg2796410.html
Changes between V3 and V2
=========================
1. fix issues according to review comments
(1)from Bjorn Helgaas: Check for 'pci->pp.msi_irq < 0'.
(2)from Bjorn Helgaas: Update the message of 'msi irq' in dev_err().
Changes between V2 and V1
=========================
1. seperate DT binding patch.
2. fix issues according to review comments
(1)from Bjorn Helgaas: Update the style of subject and changelog.
(2)from Bjorn Helgaas: Add msi irq number in the message.
(3)from Bjorn Helgaas: Delete unnecessary code 'pci->pp.root_bus_nr = -1'.
(4)from Dmitry Shmidt: Fix typing error. Replace 'interrupts-names' of 'interrupt-names'.
Yao Chen (2):
PCI: kirin: Add MSI support
arm64: dts: hi3660: Add pcie msi interrupt attribute
arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 ++
drivers/pci/dwc/pcie-kirin.c | 39 +++++++++++++++++++++++++++++++
2 files changed, 41 insertions(+)
--
1.9.1
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v3 1/2] PCI: kirin: Add MSI support
2018-05-11 9:15 ` Yao Chen
(?)
@ 2018-05-11 9:15 ` Yao Chen
-1 siblings, 0 replies; 19+ messages in thread
From: Yao Chen @ 2018-05-11 9:15 UTC (permalink / raw)
To: songxiaowei, wangbinghui, lorenzo.pieralisi, bhelgaas, xuwei5,
robh+dt, mark.rutland, catalin.marinas, will.deacon, linux-pci,
linux-kernel, linux-arm-kernel, devicetree
Cc: dimitrysh, guodong.xu, chenyao11, suzhuangluan, kongfei
Add support for MSI.
Signed-off-by: Yao Chen <chenyao11@huawei.com>
---
drivers/pci/dwc/pcie-kirin.c | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/drivers/pci/dwc/pcie-kirin.c b/drivers/pci/dwc/pcie-kirin.c
index d2970a0..8daab1f 100644
--- a/drivers/pci/dwc/pcie-kirin.c
+++ b/drivers/pci/dwc/pcie-kirin.c
@@ -426,9 +426,28 @@ static int kirin_pcie_establish_link(struct pcie_port *pp)
return 0;
}
+static irqreturn_t kirin_pcie_msi_irq_handler(int irq, void *arg)
+{
+ struct pcie_port *pp = arg;
+
+ return dw_handle_msi_irq(pp);
+}
+
+static void kirin_pcie_msi_init(struct pcie_port *pp)
+{
+ dw_pcie_msi_init(pp);
+}
+
+static void kirin_pcie_enable_interrupts(struct pcie_port *pp)
+{
+ if (IS_ENABLED(CONFIG_PCI_MSI))
+ kirin_pcie_msi_init(pp);
+}
+
static int kirin_pcie_host_init(struct pcie_port *pp)
{
kirin_pcie_establish_link(pp);
+ kirin_pcie_enable_interrupts(pp);
return 0;
}
@@ -448,6 +467,26 @@ static int kirin_pcie_host_init(struct pcie_port *pp)
static int __init kirin_add_pcie_port(struct dw_pcie *pci,
struct platform_device *pdev)
{
+ int ret;
+
+ if (IS_ENABLED(CONFIG_PCI_MSI)) {
+ pci->pp.msi_irq = platform_get_irq(pdev, 0);
+ if (pci->pp.msi_irq < 0) {
+ dev_err(&pdev->dev, "failed to get MSI IRQ (%d)\n",
+ pci->pp.msi_irq);
+ return -ENODEV;
+ }
+ ret = devm_request_irq(&pdev->dev, pci->pp.msi_irq,
+ kirin_pcie_msi_irq_handler,
+ IRQF_SHARED | IRQF_NO_THREAD,
+ "kirin_pcie_msi", &pci->pp);
+ if (ret) {
+ dev_err(&pdev->dev, "failed to request MSI IRQ %d\n",
+ pci->pp.msi_irq);
+ return ret;
+ }
+ }
+
pci->pp.ops = &kirin_pcie_host_ops;
return dw_pcie_host_init(&pci->pp);
--
1.9.1
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v3 1/2] PCI: kirin: Add MSI support
@ 2018-05-11 9:15 ` Yao Chen
0 siblings, 0 replies; 19+ messages in thread
From: Yao Chen @ 2018-05-11 9:15 UTC (permalink / raw)
To: songxiaowei, wangbinghui, lorenzo.pieralisi, bhelgaas, xuwei5,
robh+dt, mark.rutland, catalin.marinas, will.deacon, linux-pci,
linux-kernel, linux-arm-kernel, devicetree
Cc: dimitrysh, guodong.xu, chenyao11, suzhuangluan, kongfei
Add support for MSI.
Signed-off-by: Yao Chen <chenyao11@huawei.com>
---
drivers/pci/dwc/pcie-kirin.c | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/drivers/pci/dwc/pcie-kirin.c b/drivers/pci/dwc/pcie-kirin.c
index d2970a0..8daab1f 100644
--- a/drivers/pci/dwc/pcie-kirin.c
+++ b/drivers/pci/dwc/pcie-kirin.c
@@ -426,9 +426,28 @@ static int kirin_pcie_establish_link(struct pcie_port *pp)
return 0;
}
+static irqreturn_t kirin_pcie_msi_irq_handler(int irq, void *arg)
+{
+ struct pcie_port *pp = arg;
+
+ return dw_handle_msi_irq(pp);
+}
+
+static void kirin_pcie_msi_init(struct pcie_port *pp)
+{
+ dw_pcie_msi_init(pp);
+}
+
+static void kirin_pcie_enable_interrupts(struct pcie_port *pp)
+{
+ if (IS_ENABLED(CONFIG_PCI_MSI))
+ kirin_pcie_msi_init(pp);
+}
+
static int kirin_pcie_host_init(struct pcie_port *pp)
{
kirin_pcie_establish_link(pp);
+ kirin_pcie_enable_interrupts(pp);
return 0;
}
@@ -448,6 +467,26 @@ static int kirin_pcie_host_init(struct pcie_port *pp)
static int __init kirin_add_pcie_port(struct dw_pcie *pci,
struct platform_device *pdev)
{
+ int ret;
+
+ if (IS_ENABLED(CONFIG_PCI_MSI)) {
+ pci->pp.msi_irq = platform_get_irq(pdev, 0);
+ if (pci->pp.msi_irq < 0) {
+ dev_err(&pdev->dev, "failed to get MSI IRQ (%d)\n",
+ pci->pp.msi_irq);
+ return -ENODEV;
+ }
+ ret = devm_request_irq(&pdev->dev, pci->pp.msi_irq,
+ kirin_pcie_msi_irq_handler,
+ IRQF_SHARED | IRQF_NO_THREAD,
+ "kirin_pcie_msi", &pci->pp);
+ if (ret) {
+ dev_err(&pdev->dev, "failed to request MSI IRQ %d\n",
+ pci->pp.msi_irq);
+ return ret;
+ }
+ }
+
pci->pp.ops = &kirin_pcie_host_ops;
return dw_pcie_host_init(&pci->pp);
--
1.9.1
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v3 1/2] PCI: kirin: Add MSI support
@ 2018-05-11 9:15 ` Yao Chen
0 siblings, 0 replies; 19+ messages in thread
From: Yao Chen @ 2018-05-11 9:15 UTC (permalink / raw)
To: linux-arm-kernel
Add support for MSI.
Signed-off-by: Yao Chen <chenyao11@huawei.com>
---
drivers/pci/dwc/pcie-kirin.c | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/drivers/pci/dwc/pcie-kirin.c b/drivers/pci/dwc/pcie-kirin.c
index d2970a0..8daab1f 100644
--- a/drivers/pci/dwc/pcie-kirin.c
+++ b/drivers/pci/dwc/pcie-kirin.c
@@ -426,9 +426,28 @@ static int kirin_pcie_establish_link(struct pcie_port *pp)
return 0;
}
+static irqreturn_t kirin_pcie_msi_irq_handler(int irq, void *arg)
+{
+ struct pcie_port *pp = arg;
+
+ return dw_handle_msi_irq(pp);
+}
+
+static void kirin_pcie_msi_init(struct pcie_port *pp)
+{
+ dw_pcie_msi_init(pp);
+}
+
+static void kirin_pcie_enable_interrupts(struct pcie_port *pp)
+{
+ if (IS_ENABLED(CONFIG_PCI_MSI))
+ kirin_pcie_msi_init(pp);
+}
+
static int kirin_pcie_host_init(struct pcie_port *pp)
{
kirin_pcie_establish_link(pp);
+ kirin_pcie_enable_interrupts(pp);
return 0;
}
@@ -448,6 +467,26 @@ static int kirin_pcie_host_init(struct pcie_port *pp)
static int __init kirin_add_pcie_port(struct dw_pcie *pci,
struct platform_device *pdev)
{
+ int ret;
+
+ if (IS_ENABLED(CONFIG_PCI_MSI)) {
+ pci->pp.msi_irq = platform_get_irq(pdev, 0);
+ if (pci->pp.msi_irq < 0) {
+ dev_err(&pdev->dev, "failed to get MSI IRQ (%d)\n",
+ pci->pp.msi_irq);
+ return -ENODEV;
+ }
+ ret = devm_request_irq(&pdev->dev, pci->pp.msi_irq,
+ kirin_pcie_msi_irq_handler,
+ IRQF_SHARED | IRQF_NO_THREAD,
+ "kirin_pcie_msi", &pci->pp);
+ if (ret) {
+ dev_err(&pdev->dev, "failed to request MSI IRQ %d\n",
+ pci->pp.msi_irq);
+ return ret;
+ }
+ }
+
pci->pp.ops = &kirin_pcie_host_ops;
return dw_pcie_host_init(&pci->pp);
--
1.9.1
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v3 2/2] arm64: dts: hi3660: Add pcie msi interrupt attribute
2018-05-11 9:15 ` Yao Chen
(?)
@ 2018-05-11 9:15 ` Yao Chen
-1 siblings, 0 replies; 19+ messages in thread
From: Yao Chen @ 2018-05-11 9:15 UTC (permalink / raw)
To: songxiaowei, wangbinghui, lorenzo.pieralisi, bhelgaas, xuwei5,
robh+dt, mark.rutland, catalin.marinas, will.deacon, linux-pci,
linux-kernel, linux-arm-kernel, devicetree
Cc: dimitrysh, guodong.xu, chenyao11, suzhuangluan, kongfei
Add pcie msi interrupt attribute for hi3660 SOC.
Signed-off-by: Yao Chen <chenyao11@huawei.com>
---
arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
index ec3eb8e..2cef8f4 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
@@ -872,6 +872,8 @@
0x0 0x02000000>;
num-lanes = <1>;
#interrupt-cells = <1>;
+ interrupts = <0 283 4>;
+ interrupt-names = "msi";
interrupt-map-mask = <0xf800 0 0 7>;
interrupt-map = <0x0 0 0 1
&gic GIC_SPI 282 IRQ_TYPE_LEVEL_HIGH>,
--
1.9.1
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v3 2/2] arm64: dts: hi3660: Add pcie msi interrupt attribute
@ 2018-05-11 9:15 ` Yao Chen
0 siblings, 0 replies; 19+ messages in thread
From: Yao Chen @ 2018-05-11 9:15 UTC (permalink / raw)
To: songxiaowei, wangbinghui, lorenzo.pieralisi, bhelgaas, xuwei5,
robh+dt, mark.rutland, catalin.marinas, will.deacon, linux-pci,
linux-kernel, linux-arm-kernel, devicetree
Cc: dimitrysh, guodong.xu, chenyao11, suzhuangluan, kongfei
Add pcie msi interrupt attribute for hi3660 SOC.
Signed-off-by: Yao Chen <chenyao11@huawei.com>
---
arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
index ec3eb8e..2cef8f4 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
@@ -872,6 +872,8 @@
0x0 0x02000000>;
num-lanes = <1>;
#interrupt-cells = <1>;
+ interrupts = <0 283 4>;
+ interrupt-names = "msi";
interrupt-map-mask = <0xf800 0 0 7>;
interrupt-map = <0x0 0 0 1
&gic GIC_SPI 282 IRQ_TYPE_LEVEL_HIGH>,
--
1.9.1
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v3 2/2] arm64: dts: hi3660: Add pcie msi interrupt attribute
@ 2018-05-11 9:15 ` Yao Chen
0 siblings, 0 replies; 19+ messages in thread
From: Yao Chen @ 2018-05-11 9:15 UTC (permalink / raw)
To: linux-arm-kernel
Add pcie msi interrupt attribute for hi3660 SOC.
Signed-off-by: Yao Chen <chenyao11@huawei.com>
---
arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
index ec3eb8e..2cef8f4 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
@@ -872,6 +872,8 @@
0x0 0x02000000>;
num-lanes = <1>;
#interrupt-cells = <1>;
+ interrupts = <0 283 4>;
+ interrupt-names = "msi";
interrupt-map-mask = <0xf800 0 0 7>;
interrupt-map = <0x0 0 0 1
&gic GIC_SPI 282 IRQ_TYPE_LEVEL_HIGH>,
--
1.9.1
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v3 2/2] arm64: dts: hi3660: Add pcie msi interrupt attribute
2018-05-11 9:15 ` Yao Chen
(?)
@ 2018-05-11 14:09 ` Wei Xu
-1 siblings, 0 replies; 19+ messages in thread
From: Wei Xu @ 2018-05-11 14:09 UTC (permalink / raw)
To: Yao Chen, songxiaowei, wangbinghui, lorenzo.pieralisi, bhelgaas,
robh+dt, mark.rutland, catalin.marinas, will.deacon, linux-pci,
linux-kernel, linux-arm-kernel, devicetree
Cc: dimitrysh, guodong.xu, suzhuangluan, kongfei, xuwei5
Hi Yao,
On 2018/5/11 10:15, Yao Chen wrote:
> Add pcie msi interrupt attribute for hi3660 SOC.
>
> Signed-off-by: Yao Chen <chenyao11@huawei.com>
Applied patch 2 into the hisilicon dt tree.
Thanks!
BR,
Wei
> ---
> arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> index ec3eb8e..2cef8f4 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> @@ -872,6 +872,8 @@
> 0x0 0x02000000>;
> num-lanes = <1>;
> #interrupt-cells = <1>;
> + interrupts = <0 283 4>;
> + interrupt-names = "msi";
> interrupt-map-mask = <0xf800 0 0 7>;
> interrupt-map = <0x0 0 0 1
> &gic GIC_SPI 282 IRQ_TYPE_LEVEL_HIGH>,
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 2/2] arm64: dts: hi3660: Add pcie msi interrupt attribute
@ 2018-05-11 14:09 ` Wei Xu
0 siblings, 0 replies; 19+ messages in thread
From: Wei Xu @ 2018-05-11 14:09 UTC (permalink / raw)
To: Yao Chen, songxiaowei, wangbinghui, lorenzo.pieralisi, bhelgaas,
robh+dt, mark.rutland, catalin.marinas, will.deacon, linux-pci,
linux-kernel, linux-arm-kernel, devicetree
Cc: dimitrysh, guodong.xu, suzhuangluan, kongfei, xuwei5
Hi Yao,
On 2018/5/11 10:15, Yao Chen wrote:
> Add pcie msi interrupt attribute for hi3660 SOC.
>
> Signed-off-by: Yao Chen <chenyao11@huawei.com>
Applied patch 2 into the hisilicon dt tree.
Thanks!
BR,
Wei
> ---
> arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> index ec3eb8e..2cef8f4 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> @@ -872,6 +872,8 @@
> 0x0 0x02000000>;
> num-lanes = <1>;
> #interrupt-cells = <1>;
> + interrupts = <0 283 4>;
> + interrupt-names = "msi";
> interrupt-map-mask = <0xf800 0 0 7>;
> interrupt-map = <0x0 0 0 1
> &gic GIC_SPI 282 IRQ_TYPE_LEVEL_HIGH>,
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v3 2/2] arm64: dts: hi3660: Add pcie msi interrupt attribute
@ 2018-05-11 14:09 ` Wei Xu
0 siblings, 0 replies; 19+ messages in thread
From: Wei Xu @ 2018-05-11 14:09 UTC (permalink / raw)
To: linux-arm-kernel
Hi Yao,
On 2018/5/11 10:15, Yao Chen wrote:
> Add pcie msi interrupt attribute for hi3660 SOC.
>
> Signed-off-by: Yao Chen <chenyao11@huawei.com>
Applied patch 2 into the hisilicon dt tree.
Thanks!
BR,
Wei
> ---
> arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> index ec3eb8e..2cef8f4 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> @@ -872,6 +872,8 @@
> 0x0 0x02000000>;
> num-lanes = <1>;
> #interrupt-cells = <1>;
> + interrupts = <0 283 4>;
> + interrupt-names = "msi";
> interrupt-map-mask = <0xf800 0 0 7>;
> interrupt-map = <0x0 0 0 1
> &gic GIC_SPI 282 IRQ_TYPE_LEVEL_HIGH>,
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* 答复: [PATCH v3 2/2] arm64: dts: hi3660: Add pcie msi interrupt attribute
2018-05-11 14:09 ` Wei Xu
(?)
@ 2018-05-12 0:52 ` songxiaowei
-1 siblings, 0 replies; 19+ messages in thread
From: songxiaowei @ 2018-05-12 0:52 UTC (permalink / raw)
To: xuwei (O), chenyao (F),
Wangbinghui, lorenzo.pieralisi, bhelgaas, robh+dt, mark.rutland,
catalin.marinas, will.deacon, linux-pci, linux-kernel,
linux-arm-kernel, devicetree
Cc: Suzhuangluan, dimitrysh, guodong.xu, Kongfei
Hi Wei,
Thanks a lot.
Xiaowei.
> -----邮件原件-----
> 发件人: xuwei (O)
> 发送时间: 2018年5月11日 22:09
> 收件人: chenyao (F) <chenyao11@huawei.com>; songxiaowei
> <songxiaowei@hisilicon.com>; Wangbinghui <wangbinghui@hisilicon.com>;
> lorenzo.pieralisi@arm.com; bhelgaas@google.com; robh+dt@kernel.org;
> mark.rutland@arm.com; catalin.marinas@arm.com; will.deacon@arm.com;
> linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org
> 抄送: dimitrysh@google.com; guodong.xu@linaro.org; Suzhuangluan
> <suzhuangluan@hisilicon.com>; Kongfei <kongfei@hisilicon.com>; xuwei (O)
> <xuwei5@huawei.com>
> 主题: Re: [PATCH v3 2/2] arm64: dts: hi3660: Add pcie msi interrupt attribute
>
> Hi Yao,
>
> On 2018/5/11 10:15, Yao Chen wrote:
> > Add pcie msi interrupt attribute for hi3660 SOC.
> >
> > Signed-off-by: Yao Chen <chenyao11@huawei.com>
>
> Applied patch 2 into the hisilicon dt tree.
> Thanks!
>
> BR,
> Wei
>
> > ---
> > arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> > index ec3eb8e..2cef8f4 100644
> > --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> > +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> > @@ -872,6 +872,8 @@
> > 0x0 0x02000000>;
> > num-lanes = <1>;
> > #interrupt-cells = <1>;
> > + interrupts = <0 283 4>;
> > + interrupt-names = "msi";
> > interrupt-map-mask = <0xf800 0 0 7>;
> > interrupt-map = <0x0 0 0 1
> > &gic GIC_SPI 282 IRQ_TYPE_LEVEL_HIGH>,
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* 答复: [PATCH v3 2/2] arm64: dts: hi3660: Add pcie msi interrupt attribute
@ 2018-05-12 0:52 ` songxiaowei
0 siblings, 0 replies; 19+ messages in thread
From: songxiaowei @ 2018-05-12 0:52 UTC (permalink / raw)
To: xuwei (O), chenyao (F),
Wangbinghui, lorenzo.pieralisi, bhelgaas, robh+dt, mark.rutland,
catalin.marinas, will.deacon, linux-pci, linux-kernel,
linux-arm-kernel, devicetree
Cc: Suzhuangluan, dimitrysh, guodong.xu, Kongfei
SGkgV2VpLA0KDQpUaGFua3MgYSBsb3QuDQoNClhpYW93ZWkuDQoNCj4gLS0tLS3Tyrz+1K28/i0t
LS0tDQo+ILeivP7IyzogeHV3ZWkgKE8pDQo+ILeiy83KsbzkOiAyMDE4xOo11MIxMcjVIDIyOjA5
DQo+IMrVvP7IyzogY2hlbnlhbyAoRikgPGNoZW55YW8xMUBodWF3ZWkuY29tPjsgc29uZ3hpYW93
ZWkNCj4gPHNvbmd4aWFvd2VpQGhpc2lsaWNvbi5jb20+OyBXYW5nYmluZ2h1aSA8d2FuZ2Jpbmdo
dWlAaGlzaWxpY29uLmNvbT47DQo+IGxvcmVuem8ucGllcmFsaXNpQGFybS5jb207IGJoZWxnYWFz
QGdvb2dsZS5jb207IHJvYmgrZHRAa2VybmVsLm9yZzsNCj4gbWFyay5ydXRsYW5kQGFybS5jb207
IGNhdGFsaW4ubWFyaW5hc0Bhcm0uY29tOyB3aWxsLmRlYWNvbkBhcm0uY29tOw0KPiBsaW51eC1w
Y2lAdmdlci5rZXJuZWwub3JnOyBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnOw0KPiBsaW51
eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7IGRldmljZXRyZWVAdmdlci5rZXJuZWwu
b3JnDQo+ILOty806IGRpbWl0cnlzaEBnb29nbGUuY29tOyBndW9kb25nLnh1QGxpbmFyby5vcmc7
IFN1emh1YW5nbHVhbg0KPiA8c3V6aHVhbmdsdWFuQGhpc2lsaWNvbi5jb20+OyBLb25nZmVpIDxr
b25nZmVpQGhpc2lsaWNvbi5jb20+OyB4dXdlaSAoTykNCj4gPHh1d2VpNUBodWF3ZWkuY29tPg0K
PiDW98ziOiBSZTogW1BBVENIIHYzIDIvMl0gYXJtNjQ6IGR0czogaGkzNjYwOiBBZGQgcGNpZSBt
c2kgaW50ZXJydXB0IGF0dHJpYnV0ZQ0KPiANCj4gSGkgWWFvLA0KPiANCj4gT24gMjAxOC81LzEx
IDEwOjE1LCBZYW8gQ2hlbiB3cm90ZToNCj4gPiBBZGQgcGNpZSBtc2kgaW50ZXJydXB0IGF0dHJp
YnV0ZSBmb3IgaGkzNjYwIFNPQy4NCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6IFlhbyBDaGVuIDxj
aGVueWFvMTFAaHVhd2VpLmNvbT4NCj4gDQo+IEFwcGxpZWQgcGF0Y2ggMiBpbnRvIHRoZSBoaXNp
bGljb24gZHQgdHJlZS4NCj4gVGhhbmtzIQ0KPiANCj4gQlIsDQo+IFdlaQ0KPiANCj4gPiAtLS0N
Cj4gPiAgYXJjaC9hcm02NC9ib290L2R0cy9oaXNpbGljb24vaGkzNjYwLmR0c2kgfCAyICsrDQo+
ID4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykNCj4gPg0KPiA+IGRpZmYgLS1naXQg
YS9hcmNoL2FybTY0L2Jvb3QvZHRzL2hpc2lsaWNvbi9oaTM2NjAuZHRzaQ0KPiBiL2FyY2gvYXJt
NjQvYm9vdC9kdHMvaGlzaWxpY29uL2hpMzY2MC5kdHNpDQo+ID4gaW5kZXggZWMzZWI4ZS4uMmNl
ZjhmNCAxMDA2NDQNCj4gPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL2hpc2lsaWNvbi9oaTM2
NjAuZHRzaQ0KPiA+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvaGlzaWxpY29uL2hpMzY2MC5k
dHNpDQo+ID4gQEAgLTg3Miw2ICs4NzIsOCBAQA0KPiA+ICAJCQkJICAweDAgMHgwMjAwMDAwMD47
DQo+ID4gIAkJCW51bS1sYW5lcyA9IDwxPjsNCj4gPiAgCQkJI2ludGVycnVwdC1jZWxscyA9IDwx
PjsNCj4gPiArCQkJaW50ZXJydXB0cyA9IDwwIDI4MyA0PjsNCj4gPiArCQkJaW50ZXJydXB0LW5h
bWVzID0gIm1zaSI7DQo+ID4gIAkJCWludGVycnVwdC1tYXAtbWFzayA9IDwweGY4MDAgMCAwIDc+
Ow0KPiA+ICAJCQlpbnRlcnJ1cHQtbWFwID0gPDB4MCAwIDAgMQ0KPiA+ICAJCQkJCSAmZ2ljIEdJ
Q19TUEkgMjgyIElSUV9UWVBFX0xFVkVMX0hJR0g+LA0KPiA+DQoNCl9fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs
aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m
cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK
^ permalink raw reply [flat|nested] 19+ messages in thread
* 答复: [PATCH v3 2/2] arm64: dts: hi3660: Add pcie msi interrupt attribute
@ 2018-05-12 0:52 ` songxiaowei
0 siblings, 0 replies; 19+ messages in thread
From: songxiaowei @ 2018-05-12 0:52 UTC (permalink / raw)
To: linux-arm-kernel
Hi Wei,
Thanks a lot.
Xiaowei.
> -----????-----
> ???: xuwei (O)
> ????: 2018?5?11? 22:09
> ???: chenyao (F) <chenyao11@huawei.com>; songxiaowei
> <songxiaowei@hisilicon.com>; Wangbinghui <wangbinghui@hisilicon.com>;
> lorenzo.pieralisi at arm.com; bhelgaas at google.com; robh+dt at kernel.org;
> mark.rutland at arm.com; catalin.marinas at arm.com; will.deacon at arm.com;
> linux-pci at vger.kernel.org; linux-kernel at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; devicetree at vger.kernel.org
> ??: dimitrysh at google.com; guodong.xu at linaro.org; Suzhuangluan
> <suzhuangluan@hisilicon.com>; Kongfei <kongfei@hisilicon.com>; xuwei (O)
> <xuwei5@huawei.com>
> ??: Re: [PATCH v3 2/2] arm64: dts: hi3660: Add pcie msi interrupt attribute
>
> Hi Yao,
>
> On 2018/5/11 10:15, Yao Chen wrote:
> > Add pcie msi interrupt attribute for hi3660 SOC.
> >
> > Signed-off-by: Yao Chen <chenyao11@huawei.com>
>
> Applied patch 2 into the hisilicon dt tree.
> Thanks!
>
> BR,
> Wei
>
> > ---
> > arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> > index ec3eb8e..2cef8f4 100644
> > --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> > +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> > @@ -872,6 +872,8 @@
> > 0x0 0x02000000>;
> > num-lanes = <1>;
> > #interrupt-cells = <1>;
> > + interrupts = <0 283 4>;
> > + interrupt-names = "msi";
> > interrupt-map-mask = <0xf800 0 0 7>;
> > interrupt-map = <0x0 0 0 1
> > &gic GIC_SPI 282 IRQ_TYPE_LEVEL_HIGH>,
> >
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/2] PCI: kirin: Add MSI support
2018-05-11 9:15 ` Yao Chen
(?)
@ 2018-05-13 23:16 ` Andy Shevchenko
-1 siblings, 0 replies; 19+ messages in thread
From: Andy Shevchenko @ 2018-05-13 23:16 UTC (permalink / raw)
To: Yao Chen
Cc: songxiaowei, wangbinghui, Lorenzo Pieralisi, Bjorn Helgaas,
xuwei (O),
Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
linux-pci, Linux Kernel Mailing List, linux-arm Mailing List,
devicetree, dimitrysh, guodong.xu, suzhuangluan, kongfei
On Fri, May 11, 2018 at 12:15 PM, Yao Chen <chenyao11@huawei.com> wrote:
> Add support for MSI.
> + int ret;
> +
> + if (IS_ENABLED(CONFIG_PCI_MSI)) {
> + pci->pp.msi_irq = platform_get_irq(pdev, 0);
> + if (pci->pp.msi_irq < 0) {
> + dev_err(&pdev->dev, "failed to get MSI IRQ (%d)\n",
> + pci->pp.msi_irq);
> + return -ENODEV;
Why shadowing actual error code?
> + }
> + ret = devm_request_irq(&pdev->dev, pci->pp.msi_irq,
> + kirin_pcie_msi_irq_handler,
> + IRQF_SHARED | IRQF_NO_THREAD,
> + "kirin_pcie_msi", &pci->pp);
> + if (ret) {
> + dev_err(&pdev->dev, "failed to request MSI IRQ %d\n",
> + pci->pp.msi_irq);
> + return ret;
> + }
It would be easy to read and maintain if this would be a separate function.
> + }
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/2] PCI: kirin: Add MSI support
@ 2018-05-13 23:16 ` Andy Shevchenko
0 siblings, 0 replies; 19+ messages in thread
From: Andy Shevchenko @ 2018-05-13 23:16 UTC (permalink / raw)
To: Yao Chen
Cc: Mark Rutland, devicetree, Lorenzo Pieralisi, dimitrysh,
guodong.xu, linux-pci, Catalin Marinas, suzhuangluan,
wangbinghui, Will Deacon, Linux Kernel Mailing List, xuwei (O),
kongfei, Rob Herring, songxiaowei, Bjorn Helgaas,
linux-arm Mailing List
On Fri, May 11, 2018 at 12:15 PM, Yao Chen <chenyao11@huawei.com> wrote:
> Add support for MSI.
> + int ret;
> +
> + if (IS_ENABLED(CONFIG_PCI_MSI)) {
> + pci->pp.msi_irq = platform_get_irq(pdev, 0);
> + if (pci->pp.msi_irq < 0) {
> + dev_err(&pdev->dev, "failed to get MSI IRQ (%d)\n",
> + pci->pp.msi_irq);
> + return -ENODEV;
Why shadowing actual error code?
> + }
> + ret = devm_request_irq(&pdev->dev, pci->pp.msi_irq,
> + kirin_pcie_msi_irq_handler,
> + IRQF_SHARED | IRQF_NO_THREAD,
> + "kirin_pcie_msi", &pci->pp);
> + if (ret) {
> + dev_err(&pdev->dev, "failed to request MSI IRQ %d\n",
> + pci->pp.msi_irq);
> + return ret;
> + }
It would be easy to read and maintain if this would be a separate function.
> + }
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v3 1/2] PCI: kirin: Add MSI support
@ 2018-05-13 23:16 ` Andy Shevchenko
0 siblings, 0 replies; 19+ messages in thread
From: Andy Shevchenko @ 2018-05-13 23:16 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, May 11, 2018 at 12:15 PM, Yao Chen <chenyao11@huawei.com> wrote:
> Add support for MSI.
> + int ret;
> +
> + if (IS_ENABLED(CONFIG_PCI_MSI)) {
> + pci->pp.msi_irq = platform_get_irq(pdev, 0);
> + if (pci->pp.msi_irq < 0) {
> + dev_err(&pdev->dev, "failed to get MSI IRQ (%d)\n",
> + pci->pp.msi_irq);
> + return -ENODEV;
Why shadowing actual error code?
> + }
> + ret = devm_request_irq(&pdev->dev, pci->pp.msi_irq,
> + kirin_pcie_msi_irq_handler,
> + IRQF_SHARED | IRQF_NO_THREAD,
> + "kirin_pcie_msi", &pci->pp);
> + if (ret) {
> + dev_err(&pdev->dev, "failed to request MSI IRQ %d\n",
> + pci->pp.msi_irq);
> + return ret;
> + }
It would be easy to read and maintain if this would be a separate function.
> + }
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2018-05-13 23:16 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-11 9:15 [PATCH v3 0/2] Add MSI support Yao Chen
2018-05-11 9:15 ` Yao Chen
2018-05-11 9:15 ` Yao Chen
2018-05-11 9:15 ` Yao Chen
2018-05-11 9:15 ` [PATCH v3 1/2] PCI: kirin: " Yao Chen
2018-05-11 9:15 ` Yao Chen
2018-05-11 9:15 ` Yao Chen
2018-05-13 23:16 ` Andy Shevchenko
2018-05-13 23:16 ` Andy Shevchenko
2018-05-13 23:16 ` Andy Shevchenko
2018-05-11 9:15 ` [PATCH v3 2/2] arm64: dts: hi3660: Add pcie msi interrupt attribute Yao Chen
2018-05-11 9:15 ` Yao Chen
2018-05-11 9:15 ` Yao Chen
2018-05-11 14:09 ` Wei Xu
2018-05-11 14:09 ` Wei Xu
2018-05-11 14:09 ` Wei Xu
2018-05-12 0:52 ` 答复: " songxiaowei
2018-05-12 0:52 ` songxiaowei
2018-05-12 0:52 ` songxiaowei
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.