* RE: [PATCH v5] Support intel-vbtn based tablet mode switch
2018-01-26 11:21 [PATCH v5] Support intel-vbtn based tablet mode switch Marco Martin
@ 2018-01-26 15:01 ` Mario.Limonciello
2018-01-26 15:57 ` Andy Shevchenko
2018-01-26 16:08 ` Pali Rohár
2 siblings, 0 replies; 14+ messages in thread
From: Mario.Limonciello @ 2018-01-26 15:01 UTC (permalink / raw)
To: notmart, linux-kernel
Cc: mjg59, pali.rohar, dvhart, andy, bhush94, platform-driver-x86
> -----Original Message-----
> From: platform-driver-x86-owner@vger.kernel.org [mailto:platform-driver-x86-
> owner@vger.kernel.org] On Behalf Of Marco Martin
> Sent: Friday, January 26, 2018 5:21 AM
> To: linux-kernel@vger.kernel.org
> Cc: mjg59@srcf.ucam.org; pali.rohar@gmail.com; dvhart@infradead.org;
> andy@infradead.org; bhush94@gmail.com; platform-driver-x86@vger.kernel.org;
> Limonciello, Mario <Mario_Limonciello@Dell.com>; Marco Martin
> <notmart@gmail.com>; Limonciello, Mario <Mario_Limonciello@Dell.com>
> Subject: [PATCH v5] Support intel-vbtn based tablet mode switch
>
> Some laptops such as Dell Inspiron 7000 series have the
> tablet mode switch implemented in Intel ACPI,
> the events to enter and exit the tablet mode are 0xCC and 0xCD
>
> CC: platform-driver-x86@vger.kernel.org
> CC: Matthew Garrett <mjg59@srcf.ucam.org>
> CC: "Pali Rohár" <pali.rohar@gmail.com>
> CC: Darren Hart <dvhart@infradead.org>
> CC: Mario Limonciello <mario_limonciello@dell.com>
> CC: Andy Shevchenko <andy@infradead.org>
>
> Signed-off-by: Marco Martin <notmart@gmail.com>
> ---
> drivers/platform/x86/intel-vbtn.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
> index 58c5ff3..3765c41 100644
> --- a/drivers/platform/x86/intel-vbtn.c
> +++ b/drivers/platform/x86/intel-vbtn.c
> @@ -26,6 +26,9 @@
> #include <linux/suspend.h>
> #include <acpi/acpi_bus.h>
>
> +/* When NOT in tablet mode, VGBS returns with the flag 0x40 */
> +#define TABLET_MODE_FLAG 0x40
> +
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("AceLan Kao");
>
> @@ -42,6 +45,8 @@ static const struct key_entry intel_vbtn_keymap[] = {
> { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } }, /* volume-up key
> release */
> { KE_KEY, 0xC6, { KEY_VOLUMEDOWN } }, /* volume-down
> key press */
> { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } }, /* volume-down key
> release */
> + { KE_SW, 0xCC, { .sw = { SW_TABLET_MODE, 1 } } }, /* Tablet mode in */
> + { KE_SW, 0xCD, { .sw = { SW_TABLET_MODE, 0 } } }, /* Tablet mode out */
> { KE_END },
> };
>
> @@ -88,6 +93,7 @@ static void notify_handler(acpi_handle handle, u32 event,
> void *context)
>
> static int intel_vbtn_probe(struct platform_device *device)
> {
> + struct acpi_buffer vgbs_output = { ACPI_ALLOCATE_BUFFER, NULL };
> acpi_handle handle = ACPI_HANDLE(&device->dev);
> struct intel_vbtn_priv *priv;
> acpi_status status;
> @@ -110,6 +116,20 @@ static int intel_vbtn_probe(struct platform_device
> *device)
> return err;
> }
>
> + status = acpi_evaluate_object(handle, "VGBS", NULL, &vgbs_output);
> + /* VGBS being present and returning something means
> + * we have a tablet mode switch
> + */
> + if (ACPI_SUCCESS(status)) {
> + union acpi_object *obj = vgbs_output.pointer;
> +
> + if (obj && obj->type == ACPI_TYPE_INTEGER) {
> + input_report_switch(priv->input_dev,
> +
> SW_TABLET_MODE,
> + !(obj-
> >integer.value & TABLET_MODE_FLAG));
> + }
> + }
> +
> status = acpi_install_notify_handler(handle,
> ACPI_DEVICE_NOTIFY,
> notify_handler,
> --
> 2.7.4
Looks good to me now.
Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
^ permalink raw reply [flat|nested] 14+ messages in thread* RE: [PATCH v5] Support intel-vbtn based tablet mode switch
@ 2018-01-26 15:01 ` Mario.Limonciello
0 siblings, 0 replies; 14+ messages in thread
From: Mario.Limonciello @ 2018-01-26 15:01 UTC (permalink / raw)
To: notmart, linux-kernel
Cc: mjg59, pali.rohar, dvhart, andy, bhush94, platform-driver-x86
> -----Original Message-----
> From: platform-driver-x86-owner@vger.kernel.org [mailto:platform-driver-x86-
> owner@vger.kernel.org] On Behalf Of Marco Martin
> Sent: Friday, January 26, 2018 5:21 AM
> To: linux-kernel@vger.kernel.org
> Cc: mjg59@srcf.ucam.org; pali.rohar@gmail.com; dvhart@infradead.org;
> andy@infradead.org; bhush94@gmail.com; platform-driver-x86@vger.kernel.org;
> Limonciello, Mario <Mario_Limonciello@Dell.com>; Marco Martin
> <notmart@gmail.com>; Limonciello, Mario <Mario_Limonciello@Dell.com>
> Subject: [PATCH v5] Support intel-vbtn based tablet mode switch
>
> Some laptops such as Dell Inspiron 7000 series have the
> tablet mode switch implemented in Intel ACPI,
> the events to enter and exit the tablet mode are 0xCC and 0xCD
>
> CC: platform-driver-x86@vger.kernel.org
> CC: Matthew Garrett <mjg59@srcf.ucam.org>
> CC: "Pali Rohár" <pali.rohar@gmail.com>
> CC: Darren Hart <dvhart@infradead.org>
> CC: Mario Limonciello <mario_limonciello@dell.com>
> CC: Andy Shevchenko <andy@infradead.org>
>
> Signed-off-by: Marco Martin <notmart@gmail.com>
> ---
> drivers/platform/x86/intel-vbtn.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
> index 58c5ff3..3765c41 100644
> --- a/drivers/platform/x86/intel-vbtn.c
> +++ b/drivers/platform/x86/intel-vbtn.c
> @@ -26,6 +26,9 @@
> #include <linux/suspend.h>
> #include <acpi/acpi_bus.h>
>
> +/* When NOT in tablet mode, VGBS returns with the flag 0x40 */
> +#define TABLET_MODE_FLAG 0x40
> +
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("AceLan Kao");
>
> @@ -42,6 +45,8 @@ static const struct key_entry intel_vbtn_keymap[] = {
> { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } }, /* volume-up key
> release */
> { KE_KEY, 0xC6, { KEY_VOLUMEDOWN } }, /* volume-down
> key press */
> { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } }, /* volume-down key
> release */
> + { KE_SW, 0xCC, { .sw = { SW_TABLET_MODE, 1 } } }, /* Tablet mode in */
> + { KE_SW, 0xCD, { .sw = { SW_TABLET_MODE, 0 } } }, /* Tablet mode out */
> { KE_END },
> };
>
> @@ -88,6 +93,7 @@ static void notify_handler(acpi_handle handle, u32 event,
> void *context)
>
> static int intel_vbtn_probe(struct platform_device *device)
> {
> + struct acpi_buffer vgbs_output = { ACPI_ALLOCATE_BUFFER, NULL };
> acpi_handle handle = ACPI_HANDLE(&device->dev);
> struct intel_vbtn_priv *priv;
> acpi_status status;
> @@ -110,6 +116,20 @@ static int intel_vbtn_probe(struct platform_device
> *device)
> return err;
> }
>
> + status = acpi_evaluate_object(handle, "VGBS", NULL, &vgbs_output);
> + /* VGBS being present and returning something means
> + * we have a tablet mode switch
> + */
> + if (ACPI_SUCCESS(status)) {
> + union acpi_object *obj = vgbs_output.pointer;
> +
> + if (obj && obj->type == ACPI_TYPE_INTEGER) {
> + input_report_switch(priv->input_dev,
> +
> SW_TABLET_MODE,
> + !(obj-
> >integer.value & TABLET_MODE_FLAG));
> + }
> + }
> +
> status = acpi_install_notify_handler(handle,
> ACPI_DEVICE_NOTIFY,
> notify_handler,
> --
> 2.7.4
Looks good to me now.
Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v5] Support intel-vbtn based tablet mode switch
2018-01-26 11:21 [PATCH v5] Support intel-vbtn based tablet mode switch Marco Martin
2018-01-26 15:01 ` Mario.Limonciello
@ 2018-01-26 15:57 ` Andy Shevchenko
2018-01-26 16:18 ` Marco Martin
2018-01-26 16:08 ` Pali Rohár
2 siblings, 1 reply; 14+ messages in thread
From: Andy Shevchenko @ 2018-01-26 15:57 UTC (permalink / raw)
To: Marco Martin
Cc: Linux Kernel Mailing List, Matthew Garrett, Pali Rohár,
Darren Hart, Andy Shevchenko, Bhushan Shah, Platform Driver,
Mario Limonciello, Mario Limonciello
On Fri, Jan 26, 2018 at 1:21 PM, Marco Martin <notmart@gmail.com> wrote:
> Some laptops such as Dell Inspiron 7000 series have the
> tablet mode switch implemented in Intel ACPI,
> the events to enter and exit the tablet mode are 0xCC and 0xCD
Thanks for an update. It doesn't apply.
Please, rebase on top of our testing branch, add Mario's tag and resend.
>
> CC: platform-driver-x86@vger.kernel.org
> CC: Matthew Garrett <mjg59@srcf.ucam.org>
> CC: "Pali Rohár" <pali.rohar@gmail.com>
> CC: Darren Hart <dvhart@infradead.org>
> CC: Mario Limonciello <mario_limonciello@dell.com>
> CC: Andy Shevchenko <andy@infradead.org>
>
> Signed-off-by: Marco Martin <notmart@gmail.com>
> ---
> drivers/platform/x86/intel-vbtn.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
> index 58c5ff3..3765c41 100644
> --- a/drivers/platform/x86/intel-vbtn.c
> +++ b/drivers/platform/x86/intel-vbtn.c
> @@ -26,6 +26,9 @@
> #include <linux/suspend.h>
> #include <acpi/acpi_bus.h>
>
> +/* When NOT in tablet mode, VGBS returns with the flag 0x40 */
> +#define TABLET_MODE_FLAG 0x40
> +
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("AceLan Kao");
>
> @@ -42,6 +45,8 @@ static const struct key_entry intel_vbtn_keymap[] = {
> { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } }, /* volume-up key release */
> { KE_KEY, 0xC6, { KEY_VOLUMEDOWN } }, /* volume-down key press */
> { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } }, /* volume-down key release */
> + { KE_SW, 0xCC, { .sw = { SW_TABLET_MODE, 1 } } }, /* Tablet mode in */
> + { KE_SW, 0xCD, { .sw = { SW_TABLET_MODE, 0 } } }, /* Tablet mode out */
> { KE_END },
> };
>
> @@ -88,6 +93,7 @@ static void notify_handler(acpi_handle handle, u32 event, void *context)
>
> static int intel_vbtn_probe(struct platform_device *device)
> {
> + struct acpi_buffer vgbs_output = { ACPI_ALLOCATE_BUFFER, NULL };
> acpi_handle handle = ACPI_HANDLE(&device->dev);
> struct intel_vbtn_priv *priv;
> acpi_status status;
> @@ -110,6 +116,20 @@ static int intel_vbtn_probe(struct platform_device *device)
> return err;
> }
>
> + status = acpi_evaluate_object(handle, "VGBS", NULL, &vgbs_output);
> + /* VGBS being present and returning something means
> + * we have a tablet mode switch
> + */
> + if (ACPI_SUCCESS(status)) {
> + union acpi_object *obj = vgbs_output.pointer;
> +
> + if (obj && obj->type == ACPI_TYPE_INTEGER) {
> + input_report_switch(priv->input_dev,
> + SW_TABLET_MODE,
> + !(obj->integer.value & TABLET_MODE_FLAG));
> + }
> + }
> +
> status = acpi_install_notify_handler(handle,
> ACPI_DEVICE_NOTIFY,
> notify_handler,
> --
> 2.7.4
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v5] Support intel-vbtn based tablet mode switch
2018-01-26 15:57 ` Andy Shevchenko
@ 2018-01-26 16:18 ` Marco Martin
0 siblings, 0 replies; 14+ messages in thread
From: Marco Martin @ 2018-01-26 16:18 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Linux Kernel Mailing List, Matthew Garrett, Pali Rohár,
Darren Hart, Andy Shevchenko, Bhushan Shah, Platform Driver,
Mario Limonciello, Mario Limonciello
On Fri, Jan 26, 2018 at 4:57 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Fri, Jan 26, 2018 at 1:21 PM, Marco Martin <notmart@gmail.com> wrote:
>> Some laptops such as Dell Inspiron 7000 series have the
>> tablet mode switch implemented in Intel ACPI,
>> the events to enter and exit the tablet mode are 0xCC and 0xCD
>
> Thanks for an update. It doesn't apply.
>
> Please, rebase on top of our testing branch, add Mario's tag and resend.
what clone/branch I should look at?
--
Marco Martin
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v5] Support intel-vbtn based tablet mode switch
@ 2018-01-26 16:18 ` Marco Martin
0 siblings, 0 replies; 14+ messages in thread
From: Marco Martin @ 2018-01-26 16:18 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Linux Kernel Mailing List, Matthew Garrett, Pali Rohár,
Darren Hart, Andy Shevchenko, Bhushan Shah, Platform Driver,
Mario Limonciello, Mario Limonciello
On Fri, Jan 26, 2018 at 4:57 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Fri, Jan 26, 2018 at 1:21 PM, Marco Martin <notmart@gmail.com> wrote:
>> Some laptops such as Dell Inspiron 7000 series have the
>> tablet mode switch implemented in Intel ACPI,
>> the events to enter and exit the tablet mode are 0xCC and 0xCD
>
> Thanks for an update. It doesn't apply.
>
> Please, rebase on top of our testing branch, add Mario's tag and resend.
what clone/branch I should look at?
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH v5] Support intel-vbtn based tablet mode switch
2018-01-26 16:18 ` Marco Martin
@ 2018-01-26 16:22 ` Mario.Limonciello
-1 siblings, 0 replies; 14+ messages in thread
From: Mario.Limonciello @ 2018-01-26 16:22 UTC (permalink / raw)
To: notmart, andy.shevchenko
Cc: linux-kernel, mjg59, pali.rohar, dvhart, andy, bhush94,
platform-driver-x86
> -----Original Message-----
> From: Marco Martin [mailto:notmart@gmail.com]
> Sent: Friday, January 26, 2018 10:18 AM
> To: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Matthew Garrett
> <mjg59@srcf.ucam.org>; Pali Rohár <pali.rohar@gmail.com>; Darren Hart
> <dvhart@infradead.org>; Andy Shevchenko <andy@infradead.org>; Bhushan Shah
> <bhush94@gmail.com>; Platform Driver <platform-driver-x86@vger.kernel.org>;
> Limonciello, Mario <Mario_Limonciello@Dell.com>; Limonciello, Mario
> <Mario_Limonciello@Dell.com>
> Subject: Re: [PATCH v5] Support intel-vbtn based tablet mode switch
>
> On Fri, Jan 26, 2018 at 4:57 PM, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Fri, Jan 26, 2018 at 1:21 PM, Marco Martin <notmart@gmail.com> wrote:
> >> Some laptops such as Dell Inspiron 7000 series have the
> >> tablet mode switch implemented in Intel ACPI,
> >> the events to enter and exit the tablet mode are 0xCC and 0xCD
> >
> > Thanks for an update. It doesn't apply.
> >
> > Please, rebase on top of our testing branch, add Mario's tag and resend.
>
> what clone/branch I should look at?
>
> --
> Marco Martin
http://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git
The testing branch.
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH v5] Support intel-vbtn based tablet mode switch
@ 2018-01-26 16:22 ` Mario.Limonciello
0 siblings, 0 replies; 14+ messages in thread
From: Mario.Limonciello @ 2018-01-26 16:22 UTC (permalink / raw)
To: notmart, andy.shevchenko
Cc: linux-kernel, mjg59, pali.rohar, dvhart, andy, bhush94,
platform-driver-x86
> -----Original Message-----
> From: Marco Martin [mailto:notmart@gmail.com]
> Sent: Friday, January 26, 2018 10:18 AM
> To: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Matthew Garrett
> <mjg59@srcf.ucam.org>; Pali Rohár <pali.rohar@gmail.com>; Darren Hart
> <dvhart@infradead.org>; Andy Shevchenko <andy@infradead.org>; Bhushan Shah
> <bhush94@gmail.com>; Platform Driver <platform-driver-x86@vger.kernel.org>;
> Limonciello, Mario <Mario_Limonciello@Dell.com>; Limonciello, Mario
> <Mario_Limonciello@Dell.com>
> Subject: Re: [PATCH v5] Support intel-vbtn based tablet mode switch
>
> On Fri, Jan 26, 2018 at 4:57 PM, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Fri, Jan 26, 2018 at 1:21 PM, Marco Martin <notmart@gmail.com> wrote:
> >> Some laptops such as Dell Inspiron 7000 series have the
> >> tablet mode switch implemented in Intel ACPI,
> >> the events to enter and exit the tablet mode are 0xCC and 0xCD
> >
> > Thanks for an update. It doesn't apply.
> >
> > Please, rebase on top of our testing branch, add Mario's tag and resend.
>
> what clone/branch I should look at?
>
> --
> Marco Martin
http://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git
The testing branch.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v5] Support intel-vbtn based tablet mode switch
2018-01-26 16:22 ` Mario.Limonciello
(?)
@ 2018-01-26 16:27 ` Andy Shevchenko
2018-01-26 16:29 ` Mario.Limonciello
-1 siblings, 1 reply; 14+ messages in thread
From: Andy Shevchenko @ 2018-01-26 16:27 UTC (permalink / raw)
To: Mario Limonciello
Cc: Marco Martin, Linux Kernel Mailing List, Matthew Garrett,
Pali Rohár, Darren Hart, Andy Shevchenko, Bhushan Shah,
Platform Driver
On Fri, Jan 26, 2018 at 6:22 PM, <Mario.Limonciello@dell.com> wrote:
> http://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git
> The testing branch.
Since PDx86 subsystem is maintained by more than one person we
encourage to use impersonal URL, i.e.
http://git.infradead.org/linux-platform-drivers-x86.git
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH v5] Support intel-vbtn based tablet mode switch
2018-01-26 16:27 ` Andy Shevchenko
@ 2018-01-26 16:29 ` Mario.Limonciello
0 siblings, 0 replies; 14+ messages in thread
From: Mario.Limonciello @ 2018-01-26 16:29 UTC (permalink / raw)
To: andy.shevchenko
Cc: notmart, linux-kernel, mjg59, pali.rohar, dvhart, andy, bhush94,
platform-driver-x86
> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> Sent: Friday, January 26, 2018 10:28 AM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: Marco Martin <notmart@gmail.com>; Linux Kernel Mailing List <linux-
> kernel@vger.kernel.org>; Matthew Garrett <mjg59@srcf.ucam.org>; Pali Rohár
> <pali.rohar@gmail.com>; Darren Hart <dvhart@infradead.org>; Andy Shevchenko
> <andy@infradead.org>; Bhushan Shah <bhush94@gmail.com>; Platform Driver
> <platform-driver-x86@vger.kernel.org>
> Subject: Re: [PATCH v5] Support intel-vbtn based tablet mode switch
>
> On Fri, Jan 26, 2018 at 6:22 PM, <Mario.Limonciello@dell.com> wrote:
>
> > http://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git
> > The testing branch.
>
> Since PDx86 subsystem is maintained by more than one person we
> encourage to use impersonal URL, i.e.
>
> http://git.infradead.org/linux-platform-drivers-x86.git
>
Thx, didn't know that existed.
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH v5] Support intel-vbtn based tablet mode switch
@ 2018-01-26 16:29 ` Mario.Limonciello
0 siblings, 0 replies; 14+ messages in thread
From: Mario.Limonciello @ 2018-01-26 16:29 UTC (permalink / raw)
To: andy.shevchenko
Cc: notmart, linux-kernel, mjg59, pali.rohar, dvhart, andy, bhush94,
platform-driver-x86
> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> Sent: Friday, January 26, 2018 10:28 AM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: Marco Martin <notmart@gmail.com>; Linux Kernel Mailing List <linux-
> kernel@vger.kernel.org>; Matthew Garrett <mjg59@srcf.ucam.org>; Pali Rohár
> <pali.rohar@gmail.com>; Darren Hart <dvhart@infradead.org>; Andy Shevchenko
> <andy@infradead.org>; Bhushan Shah <bhush94@gmail.com>; Platform Driver
> <platform-driver-x86@vger.kernel.org>
> Subject: Re: [PATCH v5] Support intel-vbtn based tablet mode switch
>
> On Fri, Jan 26, 2018 at 6:22 PM, <Mario.Limonciello@dell.com> wrote:
>
> > http://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git
> > The testing branch.
>
> Since PDx86 subsystem is maintained by more than one person we
> encourage to use impersonal URL, i.e.
>
> http://git.infradead.org/linux-platform-drivers-x86.git
>
Thx, didn't know that existed.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v5] Support intel-vbtn based tablet mode switch
2018-01-26 16:29 ` Mario.Limonciello
@ 2018-01-27 10:16 ` Marco Martin
-1 siblings, 0 replies; 14+ messages in thread
From: Marco Martin @ 2018-01-27 10:16 UTC (permalink / raw)
To: Mario Limonciello
Cc: Andy Shevchenko, Linux Kernel Mailing List, Matthew Garrett,
Pali Rohár, Darren Hart, Andy Shevchenko, Bhushan Shah,
Platform Driver
On Fri, Jan 26, 2018 at 5:29 PM, <Mario.Limonciello@dell.com> wrote:
>> -----Original Message-----
>> From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
>> Sent: Friday, January 26, 2018 10:28 AM
>> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
>> Cc: Marco Martin <notmart@gmail.com>; Linux Kernel Mailing List <linux-
>> kernel@vger.kernel.org>; Matthew Garrett <mjg59@srcf.ucam.org>; Pali Rohár
>> <pali.rohar@gmail.com>; Darren Hart <dvhart@infradead.org>; Andy Shevchenko
>> <andy@infradead.org>; Bhushan Shah <bhush94@gmail.com>; Platform Driver
>> <platform-driver-x86@vger.kernel.org>
>> Subject: Re: [PATCH v5] Support intel-vbtn based tablet mode switch
>>
>> On Fri, Jan 26, 2018 at 6:22 PM, <Mario.Limonciello@dell.com> wrote:
>>
>> > http://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git
>> > The testing branch.
>>
>> Since PDx86 subsystem is maintained by more than one person we
>> encourage to use impersonal URL, i.e.
>>
>> http://git.infradead.org/linux-platform-drivers-x86.git
>>
>
> Thx, didn't know that existed.
last one is against master of that tree
--
Marco Martin
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v5] Support intel-vbtn based tablet mode switch
@ 2018-01-27 10:16 ` Marco Martin
0 siblings, 0 replies; 14+ messages in thread
From: Marco Martin @ 2018-01-27 10:16 UTC (permalink / raw)
To: Mario Limonciello
Cc: Andy Shevchenko, Linux Kernel Mailing List, Matthew Garrett,
Pali Rohár, Darren Hart, Andy Shevchenko, Bhushan Shah,
Platform Driver
On Fri, Jan 26, 2018 at 5:29 PM, <Mario.Limonciello@dell.com> wrote:
>> -----Original Message-----
>> From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
>> Sent: Friday, January 26, 2018 10:28 AM
>> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
>> Cc: Marco Martin <notmart@gmail.com>; Linux Kernel Mailing List <linux-
>> kernel@vger.kernel.org>; Matthew Garrett <mjg59@srcf.ucam.org>; Pali Rohár
>> <pali.rohar@gmail.com>; Darren Hart <dvhart@infradead.org>; Andy Shevchenko
>> <andy@infradead.org>; Bhushan Shah <bhush94@gmail.com>; Platform Driver
>> <platform-driver-x86@vger.kernel.org>
>> Subject: Re: [PATCH v5] Support intel-vbtn based tablet mode switch
>>
>> On Fri, Jan 26, 2018 at 6:22 PM, <Mario.Limonciello@dell.com> wrote:
>>
>> > http://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git
>> > The testing branch.
>>
>> Since PDx86 subsystem is maintained by more than one person we
>> encourage to use impersonal URL, i.e.
>>
>> http://git.infradead.org/linux-platform-drivers-x86.git
>>
>
> Thx, didn't know that existed.
last one is against master of that tree
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v5] Support intel-vbtn based tablet mode switch
2018-01-26 11:21 [PATCH v5] Support intel-vbtn based tablet mode switch Marco Martin
2018-01-26 15:01 ` Mario.Limonciello
2018-01-26 15:57 ` Andy Shevchenko
@ 2018-01-26 16:08 ` Pali Rohár
2 siblings, 0 replies; 14+ messages in thread
From: Pali Rohár @ 2018-01-26 16:08 UTC (permalink / raw)
To: Marco Martin
Cc: linux-kernel, mjg59, dvhart, andy, bhush94, platform-driver-x86,
mario.limonciello, Mario Limonciello
[-- Attachment #1: Type: text/plain, Size: 2789 bytes --]
On Friday 26 January 2018 12:21:28 Marco Martin wrote:
> Some laptops such as Dell Inspiron 7000 series have the
> tablet mode switch implemented in Intel ACPI,
> the events to enter and exit the tablet mode are 0xCC and 0xCD
>
> CC: platform-driver-x86@vger.kernel.org
> CC: Matthew Garrett <mjg59@srcf.ucam.org>
> CC: "Pali Rohár" <pali.rohar@gmail.com>
> CC: Darren Hart <dvhart@infradead.org>
> CC: Mario Limonciello <mario_limonciello@dell.com>
> CC: Andy Shevchenko <andy@infradead.org>
>
> Signed-off-by: Marco Martin <notmart@gmail.com>
> ---
> drivers/platform/x86/intel-vbtn.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
> index 58c5ff3..3765c41 100644
> --- a/drivers/platform/x86/intel-vbtn.c
> +++ b/drivers/platform/x86/intel-vbtn.c
> @@ -26,6 +26,9 @@
> #include <linux/suspend.h>
> #include <acpi/acpi_bus.h>
>
> +/* When NOT in tablet mode, VGBS returns with the flag 0x40 */
> +#define TABLET_MODE_FLAG 0x40
> +
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("AceLan Kao");
>
> @@ -42,6 +45,8 @@ static const struct key_entry intel_vbtn_keymap[] = {
> { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } }, /* volume-up key release */
> { KE_KEY, 0xC6, { KEY_VOLUMEDOWN } }, /* volume-down key press */
> { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } }, /* volume-down key release */
> + { KE_SW, 0xCC, { .sw = { SW_TABLET_MODE, 1 } } }, /* Tablet mode in */
> + { KE_SW, 0xCD, { .sw = { SW_TABLET_MODE, 0 } } }, /* Tablet mode out */
> { KE_END },
> };
>
> @@ -88,6 +93,7 @@ static void notify_handler(acpi_handle handle, u32 event, void *context)
>
> static int intel_vbtn_probe(struct platform_device *device)
> {
> + struct acpi_buffer vgbs_output = { ACPI_ALLOCATE_BUFFER, NULL };
Memory leak. I do not see where is allocated buffer released.
> acpi_handle handle = ACPI_HANDLE(&device->dev);
> struct intel_vbtn_priv *priv;
> acpi_status status;
> @@ -110,6 +116,20 @@ static int intel_vbtn_probe(struct platform_device *device)
> return err;
> }
>
> + status = acpi_evaluate_object(handle, "VGBS", NULL, &vgbs_output);
> + /* VGBS being present and returning something means
> + * we have a tablet mode switch
> + */
> + if (ACPI_SUCCESS(status)) {
> + union acpi_object *obj = vgbs_output.pointer;
> +
> + if (obj && obj->type == ACPI_TYPE_INTEGER) {
> + input_report_switch(priv->input_dev,
> + SW_TABLET_MODE,
> + !(obj->integer.value & TABLET_MODE_FLAG));
> + }
> + }
> +
> status = acpi_install_notify_handler(handle,
> ACPI_DEVICE_NOTIFY,
> notify_handler,
> --
> 2.7.4
>
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread