[PATCH] platform/x86: intel_pmc_core: Assign boolean values to a bool variable

[PATCH] platform/x86: intel_pmc_core: Assign boolean values to a bool variable

[xiakaixu1987]

From: Kaixu Xia <kaixuxia@tencent.com>

Fix the following coccinelle warnings:

./drivers/platform/x86/intel_pmc_core.c:932:1-16: WARNING: Assignment of 0/1 to bool variable

Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
 drivers/platform/x86/intel_pmc_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
index 3e5fe66333f1..ee2f757515b0 100644
--- a/drivers/platform/x86/intel_pmc_core.c
+++ b/drivers/platform/x86/intel_pmc_core.c
@@ -929,7 +929,7 @@ static void pmc_core_slps0_dbg_latch(struct pmc_dev *pmcdev, bool reset)
 		fd |= CNP_PMC_LATCH_SLPS0_EVENTS;
 	pmc_core_reg_write(pmcdev, map->slps0_dbg_offset, fd);
 
-	slps0_dbg_latch = 0;
+	slps0_dbg_latch = false;
 
 out_unlock:
 	mutex_unlock(&pmcdev->lock);
-- 
2.20.0

Re: [PATCH] platform/x86: intel_pmc_core: Assign boolean values to a bool variable

[Andy Shevchenko]

On Sat, Nov 7, 2020 at 2:57 PM <xiakaixu1987@gmail.com> wrote:
>
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> Fix the following coccinelle warnings:
>
> ./drivers/platform/x86/intel_pmc_core.c:932:1-16: WARNING: Assignment of 0/1 to bool variable

Thanks for the patch! Looks good to me.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

P.S. Don't forget to include subsystem maintainers.

>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
> ---
>  drivers/platform/x86/intel_pmc_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
> index 3e5fe66333f1..ee2f757515b0 100644
> --- a/drivers/platform/x86/intel_pmc_core.c
> +++ b/drivers/platform/x86/intel_pmc_core.c
> @@ -929,7 +929,7 @@ static void pmc_core_slps0_dbg_latch(struct pmc_dev *pmcdev, bool reset)
>                 fd |= CNP_PMC_LATCH_SLPS0_EVENTS;
>         pmc_core_reg_write(pmcdev, map->slps0_dbg_offset, fd);
>
> -       slps0_dbg_latch = 0;
> +       slps0_dbg_latch = false;
>
>  out_unlock:
>         mutex_unlock(&pmcdev->lock);
> --
> 2.20.0
>


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] platform/x86: intel_pmc_core: Assign boolean values to a bool variable

[Hans de Goede]

Hi,

On 11/7/20 1:53 PM, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
> 
> Fix the following coccinelle warnings:
> 
> ./drivers/platform/x86/intel_pmc_core.c:932:1-16: WARNING: Assignment of 0/1 to bool variable
> 
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
>  drivers/platform/x86/intel_pmc_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
> index 3e5fe66333f1..ee2f757515b0 100644
> --- a/drivers/platform/x86/intel_pmc_core.c
> +++ b/drivers/platform/x86/intel_pmc_core.c
> @@ -929,7 +929,7 @@ static void pmc_core_slps0_dbg_latch(struct pmc_dev *pmcdev, bool reset)
>  		fd |= CNP_PMC_LATCH_SLPS0_EVENTS;
>  	pmc_core_reg_write(pmcdev, map->slps0_dbg_offset, fd);
>  
> -	slps0_dbg_latch = 0;
> +	slps0_dbg_latch = false;
>  
>  out_unlock:
>  	mutex_unlock(&pmcdev->lock);
>