All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Grünbacher" <andreas.gruenbacher@gmail.com>
To: "Darrick J. Wong" <djwong@kernel.org>,
	Matthew Wilcox <willy@infradead.org>,
	linux-erofs@lists.ozlabs.org,
	Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>,
	Andreas Gruenbacher <andreas.gruenbacher@gmail.com>
Subject: Re: [PATCH v4] iomap: support tail packing inline read
Date: Wed, 21 Jul 2021 04:26:47 +0200	[thread overview]
Message-ID: <CAHpGcM+8cp81=bkzFf3sZfKREM9VbXfePpXrswNJOLVcwEnK7A@mail.gmail.com> (raw)
In-Reply-To: <YPdrSN6Vso98bLzB@B-P7TQMD6M-0146.local>

Am Mi., 21. Juli 2021 um 02:33 Uhr schrieb Gao Xiang
<hsiangkao@linux.alibaba.com>:
> > And since you can only kmap one page at a time, an inline read grabs the
> > first part of the data in "page one" and then we have to call
> > iomap_begin a second time get a new address so that we can read the rest
> > from "page two"?
>
> Nope, currently EROFS inline data won't cross page like this.
>
> But in principle, yes, I don't want to limit it to the current
> EROFS or gfs2 usage. I think we could make this iomap function
> more generally (I mean, I'd like to make the INLINE extent
> functionity as general as possible,

Nono. Can we please limit this patch what we actually need right now,
and worry about extending it later?

> my v1 original approach
> in principle can support any inline extent in the middle of
> file rather than just tail blocks, but zeroing out post-EOF
> needs another iteration) and I don't see it add more code and
> complexity.

Thanks,
Andreas

  reply	other threads:[~2021-07-21  2:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20 13:35 [PATCH v4] iomap: support tail packing inline read Gao Xiang
2021-07-20 13:35 ` Gao Xiang
2021-07-20 20:42 ` Darrick J. Wong
2021-07-20 20:42   ` Darrick J. Wong
2021-07-20 21:18   ` Matthew Wilcox
2021-07-20 21:18     ` Matthew Wilcox
2021-07-21  0:03     ` Gao Xiang
2021-07-21  0:03       ` Gao Xiang
2021-07-21  0:17       ` Darrick J. Wong
2021-07-21  0:33         ` Gao Xiang
2021-07-21  0:33           ` Gao Xiang
2021-07-21  2:26           ` Andreas Grünbacher [this message]
2021-07-21  2:26             ` Andreas Grünbacher
2021-07-21  2:53             ` Gao Xiang
2021-07-21  2:53               ` Gao Xiang
2021-07-21  6:43               ` Andreas Grünbacher
2021-07-21  7:28                 ` Gao Xiang
2021-07-21  7:28                   ` Gao Xiang
2021-07-21  6:33     ` Andreas Grünbacher
2021-07-21  6:33       ` Andreas Grünbacher
2021-07-20 23:46   ` Gao Xiang
2021-07-20 23:46     ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHpGcM+8cp81=bkzFf3sZfKREM9VbXfePpXrswNJOLVcwEnK7A@mail.gmail.com' \
    --to=andreas.gruenbacher@gmail.com \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.