[rtc-linux] Re: [PATCH v2 0/7] Change snvs rtc and poweroff to use syscon add pwrkey driver

From: Zhi Li <lznuaa@gmail.com>
To: Joshua Clayton <stillcompiling@gmail.com>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Shawn Guo <shawn.guo@linaro.org>,
	Alessandro Zummo <a.zummo@towertech.it>,
	"Frank.Li@freescale.com" <Frank.Li@freescale.com>,
	rtc-linux@googlegroups.com,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	linux-pm@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	alexandre.belloni@free-electrons.com,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-input@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>
Subject: [rtc-linux] Re: [PATCH v2 0/7] Change snvs rtc and poweroff to use syscon add pwrkey driver
Date: Wed, 20 May 2015 10:03:46 -0500	[thread overview]
Message-ID: <CAHrpEqQ9F1qXw6RmKPgwpqsFOq=O0dsNL7YtqNQ2ZUVBYz6DSw@mail.gmail.com> (raw)
In-Reply-To: <6111368.e0EOBSJsmZ@jclayton-pc>

On Wed, May 20, 2015 at 9:46 AM, Joshua Clayton
<stillcompiling@gmail.com> wrote:
>>
>> +       snvs_np = of_get_parent(pdev->dev.of_node);
>> +       if (!snvs_np)
>> +               return -ENODEV;
>> +
>> +       data->snvs = syscon_node_to_regmap(snvs_np);
>> +       of_node_put(snvs_np);
>> +
>> +       if (!data->snvs) {
>> +               pr_err("Can't snvs syscon\n");
>> +               return -ENODEV;
>> +       }
>>
>> How about change error message to " Can't snvs syscon, probably use
>> old dts file"?
> How about simply: "Cannot find snvs syscon node in devicetree."

Shawn:
          Are you okay for that?

best regards
Frank Li

>
>
> --
> ~Joshua Clayton

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.