All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhan Jianyu <nasa4836@gmail.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Balbir Singh <bsingharora@gmail.com>,
	kamezawa.hiroyu@jp.fujitsu.com,
	Andrew Morton <akpm@linux-foundation.org>,
	cgroups@vger.kernel.org,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/memcontrol.c: make mem_cgroup_read_stat() read all interested stat item in one go
Date: Wed, 16 Apr 2014 23:22:51 +0800	[thread overview]
Message-ID: <CAHz2CGXiRnBuza6ByvuDZpuxB4sP3wDBZ2OiLTACEX7ZMAuvXw@mail.gmail.com> (raw)
In-Reply-To: <20140416092245.GD12866@dhcp22.suse.cz>

On Wed, Apr 16, 2014 at 5:22 PM, Michal Hocko <mhocko@suse.cz> wrote:
> cannot say I like the new code much more than the previous one and
> I've never seen the old one being a bottleneck. So I am not entirely
> fond of optimization without a good reason. (Hint, if you are optimizing
> something always show us numbers which support the optimization)

Hmm, actually I now have no workload to support this optimizaton, I will
refine patch if I have one.  Thanks for all your comments.

Thanks,
Jianyu Zhan

WARNING: multiple messages have this Message-ID (diff)
From: Zhan Jianyu <nasa4836@gmail.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Balbir Singh <bsingharora@gmail.com>,
	kamezawa.hiroyu@jp.fujitsu.com,
	Andrew Morton <akpm@linux-foundation.org>,
	cgroups@vger.kernel.org,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/memcontrol.c: make mem_cgroup_read_stat() read all interested stat item in one go
Date: Wed, 16 Apr 2014 23:22:51 +0800	[thread overview]
Message-ID: <CAHz2CGXiRnBuza6ByvuDZpuxB4sP3wDBZ2OiLTACEX7ZMAuvXw@mail.gmail.com> (raw)
In-Reply-To: <20140416092245.GD12866@dhcp22.suse.cz>

On Wed, Apr 16, 2014 at 5:22 PM, Michal Hocko <mhocko@suse.cz> wrote:
> cannot say I like the new code much more than the previous one and
> I've never seen the old one being a bottleneck. So I am not entirely
> fond of optimization without a good reason. (Hint, if you are optimizing
> something always show us numbers which support the optimization)

Hmm, actually I now have no workload to support this optimizaton, I will
refine patch if I have one.  Thanks for all your comments.

Thanks,
Jianyu Zhan

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2014-04-16 15:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10 17:11 [PATCH] mm/memcontrol.c: make mem_cgroup_read_stat() read all interested stat item in one go Jianyu Zhan
2014-04-10 17:11 ` Jianyu Zhan
2014-04-10 17:11 ` Jianyu Zhan
2014-04-15  1:52 ` Johannes Weiner
2014-04-15  1:52   ` Johannes Weiner
2014-04-16  9:22 ` Michal Hocko
2014-04-16  9:22   ` Michal Hocko
2014-04-16  9:22   ` Michal Hocko
2014-04-16 15:22   ` Zhan Jianyu [this message]
2014-04-16 15:22     ` Zhan Jianyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHz2CGXiRnBuza6ByvuDZpuxB4sP3wDBZ2OiLTACEX7ZMAuvXw@mail.gmail.com \
    --to=nasa4836@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bsingharora@gmail.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.