* [Qemu-devel] [PATCH] helpers: build vhost-user-gpu only for softmmu
@ 2019-06-14 17:49 Laurent Vivier
2019-06-17 15:00 ` Marc-André Lureau
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Vivier @ 2019-06-14 17:49 UTC (permalink / raw)
To: qemu-devel; +Cc: Laurent Vivier, marcandre.lureau
with
./configure --enable-user --disable-tools --disable-system
it fails with:
/usr/bin/ld: contrib/vhost-user-gpu/main.o: in function `vg_resource_destroy':
.../contrib/vhost-user-gpu/main.c:382: undefined reference to `pixman_image_unref'
/usr/bin/ld: contrib/vhost-user-gpu/main.o: in function `vg_resource_flush':
.../contrib/vhost-user-gpu/main.c:694: undefined reference to `pixman_region_init_rect'
/usr/bin/ld: .../contrib/vhost-user-gpu/main.c:763: undefined reference to `pixman_region_fini'
Fixes: d52c454aadcd ("contrib: add vhost-user-gpu")
Cc: marcandre.lureau@redhat.com
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Makefile b/Makefile
index 8e2fc6624c31..49ddec1dcf35 100644
--- a/Makefile
+++ b/Makefile
@@ -322,11 +322,13 @@ HELPERS-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_LINUX)) = qemu-bridge-helper$(EXE
ifdef CONFIG_LINUX
ifdef CONFIG_VIRGL
ifdef CONFIG_GBM
+ifdef CONFIG_SOFTMMU
HELPERS-y += vhost-user-gpu$(EXESUF)
vhost-user-json-y += contrib/vhost-user-gpu/50-qemu-gpu.json
endif
endif
endif
+endif
ifdef BUILD_DOCS
DOCS=qemu-doc.html qemu-doc.txt qemu.1 qemu-img.1 qemu-nbd.8 qemu-ga.8
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] helpers: build vhost-user-gpu only for softmmu
2019-06-14 17:49 [Qemu-devel] [PATCH] helpers: build vhost-user-gpu only for softmmu Laurent Vivier
@ 2019-06-17 15:00 ` Marc-André Lureau
0 siblings, 0 replies; 2+ messages in thread
From: Marc-André Lureau @ 2019-06-17 15:00 UTC (permalink / raw)
To: Laurent Vivier; +Cc: QEMU
On Fri, Jun 14, 2019 at 8:46 PM Laurent Vivier <lvivier@redhat.com> wrote:
>
> with
>
> ./configure --enable-user --disable-tools --disable-system
>
> it fails with:
>
> /usr/bin/ld: contrib/vhost-user-gpu/main.o: in function `vg_resource_destroy':
> .../contrib/vhost-user-gpu/main.c:382: undefined reference to `pixman_image_unref'
> /usr/bin/ld: contrib/vhost-user-gpu/main.o: in function `vg_resource_flush':
> .../contrib/vhost-user-gpu/main.c:694: undefined reference to `pixman_region_init_rect'
> /usr/bin/ld: .../contrib/vhost-user-gpu/main.c:763: undefined reference to `pixman_region_fini'
>
> Fixes: d52c454aadcd ("contrib: add vhost-user-gpu")
> Cc: marcandre.lureau@redhat.com
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 8e2fc6624c31..49ddec1dcf35 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -322,11 +322,13 @@ HELPERS-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_LINUX)) = qemu-bridge-helper$(EXE
> ifdef CONFIG_LINUX
> ifdef CONFIG_VIRGL
> ifdef CONFIG_GBM
> +ifdef CONFIG_SOFTMMU
> HELPERS-y += vhost-user-gpu$(EXESUF)
> vhost-user-json-y += contrib/vhost-user-gpu/50-qemu-gpu.json
> endif
> endif
> endif
> +endif
>
> ifdef BUILD_DOCS
> DOCS=qemu-doc.html qemu-doc.txt qemu.1 qemu-img.1 qemu-nbd.8 qemu-ga.8
> --
> 2.21.0
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-17 15:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-14 17:49 [Qemu-devel] [PATCH] helpers: build vhost-user-gpu only for softmmu Laurent Vivier
2019-06-17 15:00 ` Marc-André Lureau
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.