Re: [Qemu-devel] [PATCH v6 0/5] Simplify qobject refcount - Marc-André Lureau

From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: Eric Blake <eblake@redhat.com>
Cc: QEMU <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>,
	Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 0/5] Simplify qobject refcount
Date: Thu, 19 Apr 2018 18:02:26 +0200	[thread overview]
Message-ID: <CAJ+F1C+ffbXOU7+xr_mhcXxt2=zu76URC4kFLM-7EskKrhj0XQ@mail.gmail.com> (raw)
In-Reply-To: <86162f1a-842b-f7aa-7781-f4260309925f@redhat.com>

Hi

On Thu, Apr 19, 2018 at 5:45 PM, Eric Blake <eblake@redhat.com> wrote:
> On 04/19/2018 10:01 AM, Marc-André Lureau wrote:
>> Hi,
>>
>> This series aims to get rid of the distinction between QObject, that
>> must use qobject_incref/qobject_decref and its various derived types
>> that have to use QINCREF/QDECREF. Instead, replace it with
>> qobject_ref/qobject_unref for all types.
>
> Related question: should we do the same thing for qdict_put() vs.
> qdict_put_obj()?  That is, now that we have an easy way to always use
> QOBJECT(), it makes more sense to just have:
>
> QObject *o;
> QDict *d;
> qdict_put(dict, key1, o);
> qdict_put(dict, key2, d);
>
> rather than having to distinguish based on the type of the third argument.
>
> Similar for QList additions.

Good idea, that would be a lovely follow-up indeed.

-- 
Marc-André Lureau