* [Qemu-devel] [PATCH] vnc: Clarify documentation of QMP command change
@ 2017-07-19 7:09 Markus Armbruster
2017-07-19 10:06 ` Marc-André Lureau
0 siblings, 1 reply; 7+ messages in thread
From: Markus Armbruster @ 2017-07-19 7:09 UTC (permalink / raw)
To: qemu-devel; +Cc: kraxel, eblake
QMP command
{ "execute": "change",
"arguments": { "device": "vnc", "target": "password", "arg": PWD } }
behaves just like
{ "execute": "change-vnc-password",
"arguments": { "password", "arg": PWD } }
Their documentation differs, however. According to
change-vnc-password's documentation, "an empty password [...] will set
the password to the empty string", while change's documentation claims
"no future logins will be allowed". The former is actually correct.
Replace the incorrect claim by a reference to change-vnc-password.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
qapi-schema.json | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index 8b015be..58d3a02 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3011,8 +3011,7 @@
# @arg: If @device is a block device, then this is an optional format to open
# the device with.
# If @device is 'vnc' and @target is 'password', this is the new VNC
-# password to set. If this argument is an empty string, then no future
-# logins will be allowed.
+# password to set. See change-vnc-password for additional notes.
#
# Returns: Nothing on success.
# If @device is not a valid block device, DeviceNotFound
--
2.7.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] vnc: Clarify documentation of QMP command change
2017-07-19 7:09 [Qemu-devel] [PATCH] vnc: Clarify documentation of QMP command change Markus Armbruster
@ 2017-07-19 10:06 ` Marc-André Lureau
2017-07-19 12:10 ` Markus Armbruster
2017-07-19 14:25 ` Gerd Hoffmann
0 siblings, 2 replies; 7+ messages in thread
From: Marc-André Lureau @ 2017-07-19 10:06 UTC (permalink / raw)
To: Markus Armbruster; +Cc: QEMU, Gerd Hoffmann
Hi
On Wed, Jul 19, 2017 at 9:09 AM, Markus Armbruster <armbru@redhat.com> wrote:
> QMP command
>
> { "execute": "change",
> "arguments": { "device": "vnc", "target": "password", "arg": PWD } }
>
> behaves just like
>
> { "execute": "change-vnc-password",
> "arguments": { "password", "arg": PWD } }
>
> Their documentation differs, however. According to
> change-vnc-password's documentation, "an empty password [...] will set
> the password to the empty string", while change's documentation claims
> "no future logins will be allowed". The former is actually correct.
> Replace the incorrect claim by a reference to change-vnc-password.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
The password would have to be NULL to disallow further login, is that
what your other series will allow to do?
> ---
> qapi-schema.json | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 8b015be..58d3a02 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3011,8 +3011,7 @@
> # @arg: If @device is a block device, then this is an optional format to open
> # the device with.
> # If @device is 'vnc' and @target is 'password', this is the new VNC
> -# password to set. If this argument is an empty string, then no future
> -# logins will be allowed.
> +# password to set. See change-vnc-password for additional notes.
> #
> # Returns: Nothing on success.
> # If @device is not a valid block device, DeviceNotFound
> --
> 2.7.5
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] vnc: Clarify documentation of QMP command change
2017-07-19 10:06 ` Marc-André Lureau
@ 2017-07-19 12:10 ` Markus Armbruster
2017-07-19 13:47 ` Markus Armbruster
2017-07-19 13:48 ` Eric Blake
2017-07-19 14:25 ` Gerd Hoffmann
1 sibling, 2 replies; 7+ messages in thread
From: Markus Armbruster @ 2017-07-19 12:10 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: QEMU, Gerd Hoffmann
Marc-André Lureau <marcandre.lureau@gmail.com> writes:
> Hi
>
> On Wed, Jul 19, 2017 at 9:09 AM, Markus Armbruster <armbru@redhat.com> wrote:
>> QMP command
>>
>> { "execute": "change",
>> "arguments": { "device": "vnc", "target": "password", "arg": PWD } }
>>
>> behaves just like
>>
>> { "execute": "change-vnc-password",
>> "arguments": { "password", "arg": PWD } }
>>
>> Their documentation differs, however. According to
>> change-vnc-password's documentation, "an empty password [...] will set
>> the password to the empty string", while change's documentation claims
>> "no future logins will be allowed". The former is actually correct.
>> Replace the incorrect claim by a reference to change-vnc-password.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>
>
> The password would have to be NULL to disallow further login, is that
> what your other series will allow to do?
I guess it could be applied to change-vnc-password that way.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] vnc: Clarify documentation of QMP command change
2017-07-19 12:10 ` Markus Armbruster
@ 2017-07-19 13:47 ` Markus Armbruster
2017-07-19 13:48 ` Eric Blake
1 sibling, 0 replies; 7+ messages in thread
From: Markus Armbruster @ 2017-07-19 13:47 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: QEMU, Gerd Hoffmann
Markus Armbruster <armbru@redhat.com> writes:
> Marc-André Lureau <marcandre.lureau@gmail.com> writes:
>
>> Hi
>>
>> On Wed, Jul 19, 2017 at 9:09 AM, Markus Armbruster <armbru@redhat.com> wrote:
>>> QMP command
>>>
>>> { "execute": "change",
>>> "arguments": { "device": "vnc", "target": "password", "arg": PWD } }
>>>
>>> behaves just like
>>>
>>> { "execute": "change-vnc-password",
>>> "arguments": { "password", "arg": PWD } }
This should be
"arguments": { "password": PWD } }
>>> Their documentation differs, however. According to
>>> change-vnc-password's documentation, "an empty password [...] will set
>>> the password to the empty string", while change's documentation claims
>>> "no future logins will be allowed". The former is actually correct.
>>> Replace the incorrect claim by a reference to change-vnc-password.
>>>
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>
>> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>>
>>
>> The password would have to be NULL to disallow further login, is that
>> what your other series will allow to do?
>
> I guess it could be applied to change-vnc-password that way.
However, making @password optional would be even simpler. Absent
@password = no password feels natural to me.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] vnc: Clarify documentation of QMP command change
2017-07-19 12:10 ` Markus Armbruster
2017-07-19 13:47 ` Markus Armbruster
@ 2017-07-19 13:48 ` Eric Blake
1 sibling, 0 replies; 7+ messages in thread
From: Eric Blake @ 2017-07-19 13:48 UTC (permalink / raw)
To: Markus Armbruster, Marc-André Lureau; +Cc: QEMU, Gerd Hoffmann
[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]
On 07/19/2017 07:10 AM, Markus Armbruster wrote:
> Marc-André Lureau <marcandre.lureau@gmail.com> writes:
>
>> Hi
>>
>> On Wed, Jul 19, 2017 at 9:09 AM, Markus Armbruster <armbru@redhat.com> wrote:
>>> QMP command
>>>
>>> { "execute": "change",
>>> "arguments": { "device": "vnc", "target": "password", "arg": PWD } }
>>>
>>> behaves just like
>>>
>>> { "execute": "change-vnc-password",
>>> "arguments": { "password", "arg": PWD } }
>>>
>>> Their documentation differs, however. According to
>>> change-vnc-password's documentation, "an empty password [...] will set
>>> the password to the empty string", while change's documentation claims
>>> "no future logins will be allowed". The former is actually correct.
>>> Replace the incorrect claim by a reference to change-vnc-password.
>>>
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>
>> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>>
>>
>> The password would have to be NULL to disallow further login, is that
>> what your other series will allow to do?
>
> I guess it could be applied to change-vnc-password that way.
Ideally, 'change' will be deprecated (and certainly we shouldn't add
anything further to it), but yes, 'change-vnc-password' could be
enhanced in 2.11 to use the StrOrNull alternate to use null as the
request for no password (since the empty string "" _is_ hashable as a
password, whether or not we currently allow it to be one).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] vnc: Clarify documentation of QMP command change
2017-07-19 10:06 ` Marc-André Lureau
2017-07-19 12:10 ` Markus Armbruster
@ 2017-07-19 14:25 ` Gerd Hoffmann
2017-07-19 16:17 ` Markus Armbruster
1 sibling, 1 reply; 7+ messages in thread
From: Gerd Hoffmann @ 2017-07-19 14:25 UTC (permalink / raw)
To: Marc-André Lureau, Markus Armbruster; +Cc: QEMU
Hi,
> The password would have to be NULL to disallow further login, is that
> what your other series will allow to do?
Disallow logins can be done using "expire-password vnc now".
I think having multiple ways to archive the same thing is a bad idea
from a security point of view, so I'd suggest to not touch the behavior
of the various set-password command variants.
cheers,
Gerd
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] vnc: Clarify documentation of QMP command change
2017-07-19 14:25 ` Gerd Hoffmann
@ 2017-07-19 16:17 ` Markus Armbruster
0 siblings, 0 replies; 7+ messages in thread
From: Markus Armbruster @ 2017-07-19 16:17 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: Marc-André Lureau, QEMU
Gerd Hoffmann <kraxel@redhat.com> writes:
> Hi,
>
>> The password would have to be NULL to disallow further login, is that
>> what your other series will allow to do?
>
> Disallow logins can be done using "expire-password vnc now".
>
> I think having multiple ways to archive the same thing is a bad idea
> from a security point of view, so I'd suggest to not touch the behavior
> of the various set-password command variants.
Makes sense.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-07-19 16:17 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-19 7:09 [Qemu-devel] [PATCH] vnc: Clarify documentation of QMP command change Markus Armbruster
2017-07-19 10:06 ` Marc-André Lureau
2017-07-19 12:10 ` Markus Armbruster
2017-07-19 13:47 ` Markus Armbruster
2017-07-19 13:48 ` Eric Blake
2017-07-19 14:25 ` Gerd Hoffmann
2017-07-19 16:17 ` Markus Armbruster
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.