[PATCH 2/2] audio: improve out.voices test

[PATCH 2/2] audio: improve out.voices test

[Helge Konetzka]

Improve readability of audio out.voices test:
If 1 is logged and set after positive test, 1 should be tested.

Signed-off-by: Helge Konetzka <hk@zapateado.de>
---
  audio/audio.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/audio/audio.c b/audio/audio.c
index 8a0ade4052..912b456058 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -1750,7 +1750,7 @@ static AudioState *audio_init(Audiodev *dev, const 
char *name)
      s->nb_hw_voices_out = audio_get_pdo_out(dev)->voices;
      s->nb_hw_voices_in = audio_get_pdo_in(dev)->voices;

-    if (s->nb_hw_voices_out <= 0) {
+    if (s->nb_hw_voices_out < 1) {
          dolog ("Bogus number of playback voices %d, setting to 1\n",
                 s->nb_hw_voices_out);
          s->nb_hw_voices_out = 1;
-- 
2.37.3

Re: [PATCH 2/2] audio: improve out.voices test

[Marc-André Lureau]

[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]

Hi

On Sun, Sep 25, 2022 at 1:05 PM Helge Konetzka <hk@zapateado.de> wrote:

>
> Improve readability of audio out.voices test:
> If 1 is logged and set after positive test, 1 should be tested.
>
> Signed-off-by: Helge Konetzka <hk@zapateado.de>
>

That's not helping much, but why not. I'll let Gerd decide.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>



> ---
>   audio/audio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/audio/audio.c b/audio/audio.c
> index 8a0ade4052..912b456058 100644
> --- a/audio/audio.c
> +++ b/audio/audio.c
> @@ -1750,7 +1750,7 @@ static AudioState *audio_init(Audiodev *dev, const
> char *name)
>       s->nb_hw_voices_out = audio_get_pdo_out(dev)->voices;
>       s->nb_hw_voices_in = audio_get_pdo_in(dev)->voices;
>
> -    if (s->nb_hw_voices_out <= 0) {
> +    if (s->nb_hw_voices_out < 1) {
>           dolog ("Bogus number of playback voices %d, setting to 1\n",
>                  s->nb_hw_voices_out);
>           s->nb_hw_voices_out = 1;
> --
> 2.37.3
>
>

-- 
Marc-André Lureau

[-- Attachment #2: Type: text/html, Size: 1900 bytes --]