All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] Drop duplicate display option documentation
@ 2017-01-15 20:30 Samuel Thibault
  2017-01-16 12:10 ` Marc-André Lureau
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Samuel Thibault @ 2017-01-15 20:30 UTC (permalink / raw)
  To: Paolo Bonzini, Stefan Hajnoczi, Michael S. Tsirkin,
	Michael Tokarev, Jason Wang
  Cc: qemu-devel

The curses and none possibilities are already documented on a separate line,
so documenting it on the sdl line was both unneeded and confusing.

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

diff --git a/qemu-options.hx b/qemu-options.hx
index c534a2f7f9..9c81d3752d 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -927,7 +927,7 @@ ETEXI
 
 DEF("display", HAS_ARG, QEMU_OPTION_display,
     "-display sdl[,frame=on|off][,alt_grab=on|off][,ctrl_grab=on|off]\n"
-    "            [,window_close=on|off][,gl=on|off]|curses|none|\n"
+    "            [,window_close=on|off][,gl=on|off]\n"
     "-display gtk[,grab_on_hover=on|off][,gl=on|off]|\n"
     "-display vnc=<display>[,<optargs>]\n"
     "-display curses\n"

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Qemu-devel] [PATCH] Drop duplicate display option documentation
  2017-01-15 20:30 [Qemu-devel] [PATCH] Drop duplicate display option documentation Samuel Thibault
@ 2017-01-16 12:10 ` Marc-André Lureau
  2017-01-16 12:26 ` Paolo Bonzini
  2017-01-21 16:36 ` Michael Tokarev
  2 siblings, 0 replies; 4+ messages in thread
From: Marc-André Lureau @ 2017-01-16 12:10 UTC (permalink / raw)
  To: Samuel Thibault, Paolo Bonzini, Stefan Hajnoczi,
	Michael S. Tsirkin, Michael Tokarev, Jason Wang
  Cc: qemu-devel

Hi

On Mon, Jan 16, 2017 at 12:30 AM Samuel Thibault <samuel.thibault@gnu.org>
wrote:

> The curses and none possibilities are already documented on a separate
> line,
> so documenting it on the sdl line was both unneeded and confusing.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>

Introduced in commit f04ec5afbb7d60a56863add800fd90ceee66f362


Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>




> diff --git a/qemu-options.hx b/qemu-options.hx
> index c534a2f7f9..9c81d3752d 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -927,7 +927,7 @@ ETEXI
>
>  DEF("display", HAS_ARG, QEMU_OPTION_display,
>      "-display sdl[,frame=on|off][,alt_grab=on|off][,ctrl_grab=on|off]\n"
> -    "            [,window_close=on|off][,gl=on|off]|curses|none|\n"
> +    "            [,window_close=on|off][,gl=on|off]\n"
>      "-display gtk[,grab_on_hover=on|off][,gl=on|off]|\n"
>      "-display vnc=<display>[,<optargs>]\n"
>      "-display curses\n"
>
> --
Marc-André Lureau

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Qemu-devel] [PATCH] Drop duplicate display option documentation
  2017-01-15 20:30 [Qemu-devel] [PATCH] Drop duplicate display option documentation Samuel Thibault
  2017-01-16 12:10 ` Marc-André Lureau
@ 2017-01-16 12:26 ` Paolo Bonzini
  2017-01-21 16:36 ` Michael Tokarev
  2 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2017-01-16 12:26 UTC (permalink / raw)
  To: Samuel Thibault, Stefan Hajnoczi, Michael S. Tsirkin,
	Michael Tokarev, Jason Wang
  Cc: qemu-devel, qemu-trivial

Cc: qemu-trivial@nongnu.org

On 15/01/2017 21:30, Samuel Thibault wrote:
> The curses and none possibilities are already documented on a separate line,
> so documenting it on the sdl line was both unneeded and confusing.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index c534a2f7f9..9c81d3752d 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -927,7 +927,7 @@ ETEXI
>  
>  DEF("display", HAS_ARG, QEMU_OPTION_display,
>      "-display sdl[,frame=on|off][,alt_grab=on|off][,ctrl_grab=on|off]\n"
> -    "            [,window_close=on|off][,gl=on|off]|curses|none|\n"
> +    "            [,window_close=on|off][,gl=on|off]\n"
>      "-display gtk[,grab_on_hover=on|off][,gl=on|off]|\n"
>      "-display vnc=<display>[,<optargs>]\n"
>      "-display curses\n"
> 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Qemu-devel] [PATCH] Drop duplicate display option documentation
  2017-01-15 20:30 [Qemu-devel] [PATCH] Drop duplicate display option documentation Samuel Thibault
  2017-01-16 12:10 ` Marc-André Lureau
  2017-01-16 12:26 ` Paolo Bonzini
@ 2017-01-21 16:36 ` Michael Tokarev
  2 siblings, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2017-01-21 16:36 UTC (permalink / raw)
  To: Samuel Thibault, Paolo Bonzini, Stefan Hajnoczi,
	Michael S. Tsirkin, Jason Wang
  Cc: qemu-devel, QEMU Trivial

15.01.2017 23:30, Samuel Thibault wrote:
> The curses and none possibilities are already documented on a separate line,
> so documenting it on the sdl line was both unneeded and confusing.

Applied to -trivial, thanks!

/mjt

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-01-21 16:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-15 20:30 [Qemu-devel] [PATCH] Drop duplicate display option documentation Samuel Thibault
2017-01-16 12:10 ` Marc-André Lureau
2017-01-16 12:26 ` Paolo Bonzini
2017-01-21 16:36 ` Michael Tokarev

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.