* [PATCH] ui/egl-headless: Remove a check for CONFIG_OPENGL
@ 2021-07-14 5:56 Akihiko Odaki
2021-07-16 8:20 ` Marc-André Lureau
0 siblings, 1 reply; 2+ messages in thread
From: Akihiko Odaki @ 2021-07-14 5:56 UTC (permalink / raw)
Cc: qemu-devel, Akihiko Odaki, Gerd Hoffmann
ui/egl-headless is only built when CONFIG_OPENGL is defined because it
depends on CONFIG_OPENGL without condition. Remove a redundant
conditonal in ui/egl-headless.c
Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
---
ui/egl-headless.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/ui/egl-headless.c b/ui/egl-headless.c
index 75404e0e870..a26a2520c49 100644
--- a/ui/egl-headless.c
+++ b/ui/egl-headless.c
@@ -214,6 +214,4 @@ static void register_egl(void)
type_init(register_egl);
-#ifdef CONFIG_OPENGL
module_dep("ui-opengl");
-#endif
--
2.30.1 (Apple Git-130)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ui/egl-headless: Remove a check for CONFIG_OPENGL
2021-07-14 5:56 [PATCH] ui/egl-headless: Remove a check for CONFIG_OPENGL Akihiko Odaki
@ 2021-07-16 8:20 ` Marc-André Lureau
0 siblings, 0 replies; 2+ messages in thread
From: Marc-André Lureau @ 2021-07-16 8:20 UTC (permalink / raw)
To: Akihiko Odaki; +Cc: QEMU, Gerd Hoffmann
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
On Wed, Jul 14, 2021 at 9:57 AM Akihiko Odaki <akihiko.odaki@gmail.com>
wrote:
> ui/egl-headless is only built when CONFIG_OPENGL is defined because it
> depends on CONFIG_OPENGL without condition. Remove a redundant
> conditonal in ui/egl-headless.c
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
> ui/egl-headless.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/ui/egl-headless.c b/ui/egl-headless.c
> index 75404e0e870..a26a2520c49 100644
> --- a/ui/egl-headless.c
> +++ b/ui/egl-headless.c
> @@ -214,6 +214,4 @@ static void register_egl(void)
>
> type_init(register_egl);
>
> -#ifdef CONFIG_OPENGL
> module_dep("ui-opengl");
> -#endif
> --
> 2.30.1 (Apple Git-130)
>
>
>
--
Marc-André Lureau
[-- Attachment #2: Type: text/html, Size: 1563 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-16 8:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-14 5:56 [PATCH] ui/egl-headless: Remove a check for CONFIG_OPENGL Akihiko Odaki
2021-07-16 8:20 ` Marc-André Lureau
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.