* [Intel-wired-lan] [bug report] ixgbe: added Rx/Tx ring disable/enable functions
@ 2018-10-11 11:47 Dan Carpenter
2018-10-12 8:41 ` =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2018-10-11 11:47 UTC (permalink / raw)
To: intel-wired-lan
Hello Bj?rn T?pel,
This is a semi-automatic email about new static checker warnings.
The patch 024aa5800f32: "ixgbe: added Rx/Tx ring disable/enable
functions" from Oct 2, 2018, leads to the following Smatch complaint:
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:10520 ixgbe_txrx_ring_enable()
error: we previously assumed 'xdp_ring' could be null (see line 10515)
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
10514 ixgbe_configure_tx_ring(adapter, tx_ring);
10515 if (xdp_ring)
^^^^^^^^
The patch adds a check for NULL.
10516 ixgbe_configure_tx_ring(adapter, xdp_ring);
10517 ixgbe_configure_rx_ring(adapter, rx_ring);
10518
10519 clear_bit(__IXGBE_TX_DISABLED, &tx_ring->state);
10520 clear_bit(__IXGBE_TX_DISABLED, &xdp_ring->state);
^^^^^^^^^^^^^^^
but it also adds an unchecked dereference.
10521 }
10522
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Intel-wired-lan] [bug report] ixgbe: added Rx/Tx ring disable/enable functions
2018-10-11 11:47 [Intel-wired-lan] [bug report] ixgbe: added Rx/Tx ring disable/enable functions Dan Carpenter
@ 2018-10-12 8:41 ` =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
0 siblings, 0 replies; 2+ messages in thread
From: =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?= @ 2018-10-12 8:41 UTC (permalink / raw)
To: intel-wired-lan
Den tors 11 okt. 2018 kl 13:48 skrev Dan Carpenter <dan.carpenter@oracle.com>:
>
> Hello Bj?rn T?pel,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 024aa5800f32: "ixgbe: added Rx/Tx ring disable/enable
> functions" from Oct 2, 2018, leads to the following Smatch complaint:
>
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:10520 ixgbe_txrx_ring_enable()
> error: we previously assumed 'xdp_ring' could be null (see line 10515)
>
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> 10514 ixgbe_configure_tx_ring(adapter, tx_ring);
> 10515 if (xdp_ring)
> ^^^^^^^^
> The patch adds a check for NULL.
>
> 10516 ixgbe_configure_tx_ring(adapter, xdp_ring);
> 10517 ixgbe_configure_rx_ring(adapter, rx_ring);
> 10518
> 10519 clear_bit(__IXGBE_TX_DISABLED, &tx_ring->state);
> 10520 clear_bit(__IXGBE_TX_DISABLED, &xdp_ring->state);
> ^^^^^^^^^^^^^^^
> but it also adds an unchecked dereference.
>
> 10521 }
> 10522
>
> regards,
> dan carpenter
Thank you. I'll have a look and get back with a patch.
Bj?rn
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-12 8:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-11 11:47 [Intel-wired-lan] [bug report] ixgbe: added Rx/Tx ring disable/enable functions Dan Carpenter
2018-10-12 8:41 ` =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.