Re: [devfreq:testing/kozlowski 12/12] warning: (ARM_EXYNOS_BUS_DEVFREQ) selects DEVFREQ_EVENT_EXYNOS_PPMU which has unmet direct dependencies (PM_DEVFREQ && ..)

Re: [devfreq:testing/kozlowski 12/12] warning: (ARM_EXYNOS_BUS_DEVFREQ) selects DEVFREQ_EVENT_EXYNOS_PPMU which has unmet direct dependencies (PM_DEVFREQ && ..)

[Krzysztof Kozlowski]

On 07/12/2016 01:45 PM, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git testing/kozlowski
> head:   dacb9d6e4946a56f550f706ee4361a6d68dc513a
> commit: dacb9d6e4946a56f550f706ee4361a6d68dc513a [12/12] PM / devfreq: Add COMPILE_TEST for build coverage
> config: sparc64-allyesconfig (attached as .config)
> compiler: sparc64-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout dacb9d6e4946a56f550f706ee4361a6d68dc513a
>         # save the attached .config to linux build tree
>         make.cross ARCH=sparc64 
> 
> All warnings (new ones prefixed by >>):
> 
> warning: (ARM_EXYNOS_BUS_DEVFREQ) selects DEVFREQ_EVENT_EXYNOS_PPMU which has unmet direct dependencies (PM_DEVFREQ && PM_DEVFREQ_EVENT && ARCH_EXYNOS)

Hi MyungJoo,

Thanks for applying the patch.

The commit
https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/commit/?h=testing/kozlowski&id=dacb9d6e4946a56f550f706ee4361a6d68dc513a
looks wrong. It contains only half of necessary changes. It is missing
defreq/event changes:
https://patchwork.kernel.org/patch/9200657/
This is the reason behind this kbuild warning.

Additionally I see you cherry-picked dependency ("clk: Provide notifier
stubs when !COMMON_CLK") but:
1. There is no signed-off-by of yours,
2. It should be merged (pulled), not cherry-picked, because otherwise
the commit will appear twice - both from clk tree and from yours. This
is why Stephen provided a stable branch so just:
$ git pull git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git
clk-notify

Best regards,
Krzysztof

Re: [devfreq:testing/kozlowski 12/12] warning: (ARM_EXYNOS_BUS_DEVFREQ) selects DEVFREQ_EVENT_EXYNOS_PPMU which has unmet direct dependencies (PM_DEVFREQ && ..)

[MyungJoo Ham]

On Tue, Jul 12, 2016 at 9:30 PM, Krzysztof Kozlowski
<k.kozlowski@samsung.com> wrote:
> On 07/12/2016 01:45 PM, kbuild test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git testing/kozlowski
>> head:   dacb9d6e4946a56f550f706ee4361a6d68dc513a
>> commit: dacb9d6e4946a56f550f706ee4361a6d68dc513a [12/12] PM / devfreq: Add COMPILE_TEST for build coverage
>> config: sparc64-allyesconfig (attached as .config)
>> compiler: sparc64-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
>> reproduce:
>>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         git checkout dacb9d6e4946a56f550f706ee4361a6d68dc513a
>>         # save the attached .config to linux build tree
>>         make.cross ARCH=sparc64
>>
>> All warnings (new ones prefixed by >>):
>>
>> warning: (ARM_EXYNOS_BUS_DEVFREQ) selects DEVFREQ_EVENT_EXYNOS_PPMU which has unmet direct dependencies (PM_DEVFREQ && PM_DEVFREQ_EVENT && ARCH_EXYNOS)
>
> Hi MyungJoo,
>
> Thanks for applying the patch.
>
> The commit
> https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/commit/?h=testing/kozlowski&id=dacb9d6e4946a56f550f706ee4361a6d68dc513a
> looks wrong. It contains only half of necessary changes. It is missing
> defreq/event changes:
> https://patchwork.kernel.org/patch/9200657/
> This is the reason behind this kbuild warning.
>
> Additionally I see you cherry-picked dependency ("clk: Provide notifier
> stubs when !COMMON_CLK") but:
> 1. There is no signed-off-by of yours,

It is intentional, which is why the branch name is "testing/*", not "fixes*".

Anyway, the patch is updated.

> 2. It should be merged (pulled), not cherry-picked, because otherwise
> the commit will appear twice - both from clk tree and from yours. This
> is why Stephen provided a stable branch so just:
> $ git pull git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git
> clk-notify

I wouldn't cherry-pick this clk-notify patch in the fixes branch
(after I can put Signoff on the patch).
That's why I asked you about the status of this prerequisite patch.

So, may I assume that this clk-notify patch is already being merged?



>
> Best regards,
> Krzysztof
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
MyungJoo Ham, Ph.D.
Frontier CS Lab, S/W Center, Samsung Electronics

Re: [devfreq:testing/kozlowski 12/12] warning: (ARM_EXYNOS_BUS_DEVFREQ) selects DEVFREQ_EVENT_EXYNOS_PPMU which has unmet direct dependencies (PM_DEVFREQ && ..)

[Krzysztof Kozlowski]

On Thu, Jul 14, 2016 at 8:03 AM, MyungJoo Ham <myungjoo.ham@samsung.com> wrote:
> On Tue, Jul 12, 2016 at 9:30 PM, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
>> On 07/12/2016 01:45 PM, kbuild test robot wrote:
>>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git testing/kozlowski
>>> head:   dacb9d6e4946a56f550f706ee4361a6d68dc513a
>>> commit: dacb9d6e4946a56f550f706ee4361a6d68dc513a [12/12] PM / devfreq: Add COMPILE_TEST for build coverage
>>> config: sparc64-allyesconfig (attached as .config)
>>> compiler: sparc64-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
>>> reproduce:
>>>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>>>         chmod +x ~/bin/make.cross
>>>         git checkout dacb9d6e4946a56f550f706ee4361a6d68dc513a
>>>         # save the attached .config to linux build tree
>>>         make.cross ARCH=sparc64
>>>
>>> All warnings (new ones prefixed by >>):
>>>
>>> warning: (ARM_EXYNOS_BUS_DEVFREQ) selects DEVFREQ_EVENT_EXYNOS_PPMU which has unmet direct dependencies (PM_DEVFREQ && PM_DEVFREQ_EVENT && ARCH_EXYNOS)
>>
>> Hi MyungJoo,
>>
>> Thanks for applying the patch.
>>
>> The commit
>> https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/commit/?h=testing/kozlowski&id=dacb9d6e4946a56f550f706ee4361a6d68dc513a
>> looks wrong. It contains only half of necessary changes. It is missing
>> defreq/event changes:
>> https://patchwork.kernel.org/patch/9200657/
>> This is the reason behind this kbuild warning.
>>
>> Additionally I see you cherry-picked dependency ("clk: Provide notifier
>> stubs when !COMMON_CLK") but:
>> 1. There is no signed-off-by of yours,
>
> It is intentional, which is why the branch name is "testing/*", not "fixes*".
>
> Anyway, the patch is updated.
>
>> 2. It should be merged (pulled), not cherry-picked, because otherwise
>> the commit will appear twice - both from clk tree and from yours. This
>> is why Stephen provided a stable branch so just:
>> $ git pull git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git
>> clk-notify
>
> I wouldn't cherry-pick this clk-notify patch in the fixes branch
> (after I can put Signoff on the patch).
> That's why I asked you about the status of this prerequisite patch.
>
> So, may I assume that this clk-notify patch is already being merged?

Yes, the clk-notify will be merged in upcoming merge window. The
branch should be also stable (not rebased).

Thanks!

Best regards,
Krzysztof