All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Kostiuk <konstantin@daynix.com>
To: Developers <qemu-devel@nongnu.org>
Cc: Yan Vugenfirer <yan@daynix.com>, Michael Roth <michael.roth@amd.com>
Subject: Re: [PATCH 1/3] qga-win: Increase VSS freeze timeout to 60 secs instead of 10
Date: Fri, 11 Jun 2021 09:56:05 +0300	[thread overview]
Message-ID: <CAJ28CFQPkZ=GwhKTFUZJg3Qpwr2PW-uT+HAvUDX6LsqyihVjVg@mail.gmail.com> (raw)
In-Reply-To: <20210405131420.598273-1-basil@daynix.com>

[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]

ping

On Mon, Apr 5, 2021 at 4:14 PM Basil Salman <basil@daynix.com> wrote:

> Currently Requester freeze times out after 10 seconds, while
> the default timeout for Writer Freeze is 60 seconds. according to
> VSS Documentation [1].
> [1]:
> https://docs.microsoft.com/en-us/windows/win32/vss/overview-of-processing-a-backup-under-vss
>
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1909073
>
> Signed-off-by: Basil Salman <bsalman@daynix.com>
> Signed-off-by: Basil Salman <basil@daynix.com>
> ---
>  qga/vss-win32/requester.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp
> index 5378c55d23..940a2c8f55 100644
> --- a/qga/vss-win32/requester.cpp
> +++ b/qga/vss-win32/requester.cpp
> @@ -18,7 +18,7 @@
>  #include <inc/win2003/vsbackup.h>
>
>  /* Max wait time for frozen event (VSS can only hold writes for 10
> seconds) */
> -#define VSS_TIMEOUT_FREEZE_MSEC 10000
> +#define VSS_TIMEOUT_FREEZE_MSEC 60000
>
>  /* Call QueryStatus every 10 ms while waiting for frozen event */
>  #define VSS_TIMEOUT_EVENT_MSEC 10
> --
> 2.17.2
>
>

[-- Attachment #2: Type: text/html, Size: 1883 bytes --]

  parent reply	other threads:[~2021-06-11  6:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-05 13:14 [PATCH 1/3] qga-win: Increase VSS freeze timeout to 60 secs instead of 10 Basil Salman
2021-04-05 13:14 ` [PATCH 2/3] qga-win: Fix build_guest_fsinfo() close of nonexistent handle Basil Salman
2021-04-05 13:14 ` [PATCH 3/3] qga-win: Fix handle leak in ga_get_win_product_name() Basil Salman
2021-04-22  7:43 ` [PATCH 1/3] qga-win: Increase VSS freeze timeout to 60 secs instead of 10 Konstantin Kostiuk
2021-04-29  8:51   ` Konstantin Kostiuk
2021-07-13 18:40   ` Michael Roth
2021-07-14  6:17     ` Konstantin Kostiuk
2021-07-28  7:53       ` Konstantin Kostiuk
2021-05-28 11:21 ` Konstantin Kostiuk
2021-06-11  6:56 ` Konstantin Kostiuk [this message]
2021-07-04  5:52 ` Konstantin Kostiuk
2021-07-11 17:18   ` Konstantin Kostiuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ28CFQPkZ=GwhKTFUZJg3Qpwr2PW-uT+HAvUDX6LsqyihVjVg@mail.gmail.com' \
    --to=konstantin@daynix.com \
    --cc=michael.roth@amd.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yan@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.