[review-request] adamian/20150603_remove_managed

[review-request] adamian/20150603_remove_managed

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

Hi,

This is the first review request for merging of "managed" and "analysis"
modes.

The branch is here:
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/20150603_remove_managed

The major changes are:

- the code paths in templates for "MANAGED" and non-"MANAGED" mode have
been merged, with the MANAGED considered always True
- the interface no longer manipulates BuildRequest objects, only Build
objects; this simplifies the searching, displaying and manipulating builds.
- the toaster logger has improved error logging, as we can now attach
correct errors to Builds
- in the interactive-command-line mode, all builds go by default to the
Project with id 0.

What remains to be done is:

- Bring the UI up to the design, including the capability to create
analysis-only Projects; and the ability to configure the project ID for
interactive command-line builds.

-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 1960 bytes --]

Re: [review-request] adamian/20150603_remove_managed

[Michael Wood]

On 17/06/15 17:37, Damian, Alexandru wrote:
> Hi,
>
> This is the first review request for merging of "managed" and 
> "analysis" modes.
>
> The branch is here:
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/20150603_remove_managed
>
Not that familiar with this part of toaster, but noticed a few things:

Do you know why the migration generated is so large?

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/diff/bitbake/lib/toaster/orm/migrations/0023_auto__del_field_build_warnings_no__del_field_build_errors_no__del_fiel.py?h=adamian/20150603_remove_managed&id=4d25bdde275293cbecfe7d27ac249ac976210bef

Strangely appears to have unmodified tables in there.


You have also pushed these commits so I can't currently test the branch.

commit 3339d75d6bc1bcfdff50969bc49110b632f28f4a
Author: Alexandru DAMIAN <alexandru.damian@intel.com>
Date:   Mon Jun 8 11:10:03 2015 +0100

     debug versions of js libraries

commit b23670f47fc97f7660d6a51f6d6881b94f84d62d
Author: Alexandru DAMIAN <alexandru.damian@intel.com>
Date:   Tue Jun 9 13:42:09 2015 +0100

     enable sentry on icarus.local for debugging

     Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>


Thanks,

Michael

> The major changes are:
>
> - the code paths in templates for "MANAGED" and non-"MANAGED" mode 
> have been merged, with the MANAGED considered always True
> - the interface no longer manipulates BuildRequest objects, only Build 
> objects; this simplifies the searching, displaying and manipulating 
> builds.
> - the toaster logger has improved error logging, as we can now attach 
> correct errors to Builds
> - in the interactive-command-line mode, all builds go by default to 
> the Project with id 0.
>
> What remains to be done is:
>
> - Bring the UI up to the design, including the capability to create 
> analysis-only Projects; and the ability to configure the project ID 
> for interactive command-line builds.
>
> -- 
> Alex Damian
> Yocto Project
> SSG / OTC
>
>

Re: [review-request] adamian/20150603_remove_managed

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 3190 bytes --]

Hi,

Comments below,
Alex

On Fri, Jun 19, 2015 at 11:58 AM, Michael Wood <michael.g.wood@intel.com>
wrote:

> On 17/06/15 17:37, Damian, Alexandru wrote:
>
>> Hi,
>>
>> This is the first review request for merging of "managed" and "analysis"
>> modes.
>>
>> The branch is here:
>>
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/20150603_remove_managed
>>
>>  Not that familiar with this part of toaster, but noticed a few things:
>
> Do you know why the migration generated is so large?
>
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/diff/bitbake/lib/toaster/orm/migrations/0023_auto__del_field_build_warnings_no__del_field_build_errors_no__del_fiel.py?h=adamian/20150603_remove_managed&id=4d25bdde275293cbecfe7d27ac249ac976210bef
>
> Strangely appears to have unmodified tables in there.
>
>
​The migrations in South are functional, not descriptive. The migration
class has backward() and forward() methods that perform needed changes on
the database schema in backward and forward migrations.

The "models" contains a complete dump of the current database schema. This
is used when the next migration is made to compute differences between
current database schema and the database schema that is desired.


>
> You have also pushed these commits so I can't currently test the branch.
>
> commit 3339d75d6bc1bcfdff50969bc49110b632f28f4a
> Author: Alexandru DAMIAN <alexandru.damian@intel.com>
> Date:   Mon Jun 8 11:10:03 2015 +0100
>
>     debug versions of js libraries
>
> commit b23670f47fc97f7660d6a51f6d6881b94f84d62d
> Author: Alexandru DAMIAN <alexandru.damian@intel.com>
> Date:   Tue Jun 9 13:42:09 2015 +0100
>
>     enable sentry on icarus.local for debugging
>
>     Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
>
>
These commits should not impede execution - I let them on purposefully for
reviewing, but they are not intended to be  submitted upstream; I hoped to
catch errors on Sentry that don't occur during my personal testing.

I'll double check to see what errors are you seeing.


>
> Thanks,
>
> Michael
>
>
>  The major changes are:
>>
>> - the code paths in templates for "MANAGED" and non-"MANAGED" mode have
>> been merged, with the MANAGED considered always True
>> - the interface no longer manipulates BuildRequest objects, only Build
>> objects; this simplifies the searching, displaying and manipulating builds.
>> - the toaster logger has improved error logging, as we can now attach
>> correct errors to Builds
>> - in the interactive-command-line mode, all builds go by default to the
>> Project with id 0.
>>
>> What remains to be done is:
>>
>> - Bring the UI up to the design, including the capability to create
>> analysis-only Projects; and the ability to configure the project ID for
>> interactive command-line builds.
>>
>> --
>> Alex Damian
>> Yocto Project
>> SSG / OTC
>>
>>
>>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 5842 bytes --]

Re: [review-request] adamian/20150603_remove_managed

[Michael Wood]

On 19/06/15 13:29, Damian, Alexandru wrote:
> Hi,
>
> Comments below,
> Alex
>
> On Fri, Jun 19, 2015 at 11:58 AM, Michael Wood 
> <michael.g.wood@intel.com <mailto:michael.g.wood@intel.com>> wrote:
>
>     On 17/06/15 17:37, Damian, Alexandru wrote:
>
>         Hi,
>
>         This is the first review request for merging of "managed" and
>         "analysis" modes.
>
>         The branch is here:
>         http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/20150603_remove_managed
>
>     Not that familiar with this part of toaster, but noticed a few things:
>
>     Do you know why the migration generated is so large?
>
>     http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/diff/bitbake/lib/toaster/orm/migrations/0023_auto__del_field_build_warnings_no__del_field_build_errors_no__del_fiel.py?h=adamian/20150603_remove_managed&id=4d25bdde275293cbecfe7d27ac249ac976210bef
>
>     Strangely appears to have unmodified tables in there.
>
>
> ​The migrations in South are functional, not descriptive. The 
> migration class has backward() and forward() methods that perform 
> needed changes on the database schema in backward and forward migrations.
>
> The "models" contains a complete dump of the current database schema. 
> This is used when the next migration is made to compute differences 
> between current database schema and the database schema that is desired.
>
>
>     You have also pushed these commits so I can't currently test the
>     branch.
>
>     commit 3339d75d6bc1bcfdff50969bc49110b632f28f4a
>     Author: Alexandru DAMIAN <alexandru.damian@intel.com
>     <mailto:alexandru.damian@intel.com>>
>     Date:   Mon Jun 8 11:10:03 2015 +0100
>
>         debug versions of js libraries
>
>     commit b23670f47fc97f7660d6a51f6d6881b94f84d62d
>     Author: Alexandru DAMIAN <alexandru.damian@intel.com
>     <mailto:alexandru.damian@intel.com>>
>     Date:   Tue Jun 9 13:42:09 2015 +0100
>
>         enable sentry on icarus.local for debugging
>
>         Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com
>     <mailto:alexandru.damian@intel.com>>
>
>
> These commits should not impede execution - I let them on purposefully 
> for reviewing, but they are not intended to be  submitted upstream; I 
> hoped to catch errors on Sentry that don't occur during my personal 
> testing.
>
> I'll double check to see what errors are you seeing.

I'd argue that review needs to be done on what will end up upstream.

This is the error with the current branch:

'raven' is not a valid tag library: Template library raven not found, tried django.templatetags.raven,django.contrib.admin.templatetags.raven,django.contrib.staticfiles.templatetags.raven,django.contrib.humanize.templatetags.raven,toastergui.templatetags.raven


>
>     Thanks,
>
>     Michael
>
>
>         The major changes are:
>
>         - the code paths in templates for "MANAGED" and non-"MANAGED"
>         mode have been merged, with the MANAGED considered always True
>         - the interface no longer manipulates BuildRequest objects,
>         only Build objects; this simplifies the searching, displaying
>         and manipulating builds.
>         - the toaster logger has improved error logging, as we can now
>         attach correct errors to Builds
>         - in the interactive-command-line mode, all builds go by
>         default to the Project with id 0.
>
>         What remains to be done is:
>
>         - Bring the UI up to the design, including the capability to
>         create analysis-only Projects; and the ability to configure
>         the project ID for interactive command-line builds.
>
>         -- 
>         Alex Damian
>         Yocto Project
>         SSG / OTC
>
>
>
>     -- 
>     _______________________________________________
>     toaster mailing list
>     toaster@yoctoproject.org <mailto:toaster@yoctoproject.org>
>     https://lists.yoctoproject.org/listinfo/toaster
>
>
>
>
> -- 
> Alex Damian
> Yocto Project
> SSG / OTC
>
> ---------------------------------------------------------------------
> Intel Corporation (UK) Limited
> Registered No. 1134945 (England)
> Registered Office: Pipers Way, Swindon SN3 1RJ
> VAT No: 860 2173 47
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>

Re: [review-request] adamian/20150603_remove_managed

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 5550 bytes --]

You are right - I removed the debug patches, and added project types in new
project page.

I've pushed a ready-to-submit version at adamian/20150603_remove_managed

Cheers,
Alex

On Fri, Jun 19, 2015 at 2:51 PM, Michael Wood <michael.g.wood@intel.com>
wrote:

> On 19/06/15 13:29, Damian, Alexandru wrote:
>
>> Hi,
>>
>> Comments below,
>> Alex
>>
>> On Fri, Jun 19, 2015 at 11:58 AM, Michael Wood <michael.g.wood@intel.com
>> <mailto:michael.g.wood@intel.com>> wrote:
>>
>>     On 17/06/15 17:37, Damian, Alexandru wrote:
>>
>>         Hi,
>>
>>         This is the first review request for merging of "managed" and
>>         "analysis" modes.
>>
>>         The branch is here:
>>
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/20150603_remove_managed
>>
>>     Not that familiar with this part of toaster, but noticed a few things:
>>
>>     Do you know why the migration generated is so large?
>>
>>
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/diff/bitbake/lib/toaster/orm/migrations/0023_auto__del_field_build_warnings_no__del_field_build_errors_no__del_fiel.py?h=adamian/20150603_remove_managed&id=4d25bdde275293cbecfe7d27ac249ac976210bef
>>
>>     Strangely appears to have unmodified tables in there.
>>
>>
>> ​The migrations in South are functional, not descriptive. The migration
>> class has backward() and forward() methods that perform needed changes on
>> the database schema in backward and forward migrations.
>>
>> The "models" contains a complete dump of the current database schema.
>> This is used when the next migration is made to compute differences between
>> current database schema and the database schema that is desired.
>>
>>
>>     You have also pushed these commits so I can't currently test the
>>     branch.
>>
>>     commit 3339d75d6bc1bcfdff50969bc49110b632f28f4a
>>     Author: Alexandru DAMIAN <alexandru.damian@intel.com
>>     <mailto:alexandru.damian@intel.com>>
>>     Date:   Mon Jun 8 11:10:03 2015 +0100
>>
>>         debug versions of js libraries
>>
>>     commit b23670f47fc97f7660d6a51f6d6881b94f84d62d
>>     Author: Alexandru DAMIAN <alexandru.damian@intel.com
>>     <mailto:alexandru.damian@intel.com>>
>>     Date:   Tue Jun 9 13:42:09 2015 +0100
>>
>>         enable sentry on icarus.local for debugging
>>
>>         Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com
>>     <mailto:alexandru.damian@intel.com>>
>>
>>
>> These commits should not impede execution - I let them on purposefully
>> for reviewing, but they are not intended to be  submitted upstream; I hoped
>> to catch errors on Sentry that don't occur during my personal testing.
>>
>> I'll double check to see what errors are you seeing.
>>
>
> I'd argue that review needs to be done on what will end up upstream.
>
> This is the error with the current branch:
>
> 'raven' is not a valid tag library: Template library raven not found,
> tried
> django.templatetags.raven,django.contrib.admin.templatetags.raven,django.contrib.staticfiles.templatetags.raven,django.contrib.humanize.templatetags.raven,toastergui.templatetags.raven
>
>
>
>>     Thanks,
>>
>>     Michael
>>
>>
>>         The major changes are:
>>
>>         - the code paths in templates for "MANAGED" and non-"MANAGED"
>>         mode have been merged, with the MANAGED considered always True
>>         - the interface no longer manipulates BuildRequest objects,
>>         only Build objects; this simplifies the searching, displaying
>>         and manipulating builds.
>>         - the toaster logger has improved error logging, as we can now
>>         attach correct errors to Builds
>>         - in the interactive-command-line mode, all builds go by
>>         default to the Project with id 0.
>>
>>         What remains to be done is:
>>
>>         - Bring the UI up to the design, including the capability to
>>         create analysis-only Projects; and the ability to configure
>>         the project ID for interactive command-line builds.
>>
>>         --         Alex Damian
>>         Yocto Project
>>         SSG / OTC
>>
>>
>>
>>     --     _______________________________________________
>>     toaster mailing list
>>     toaster@yoctoproject.org <mailto:toaster@yoctoproject.org>
>>     https://lists.yoctoproject.org/listinfo/toaster
>>
>>
>>
>>
>> --
>> Alex Damian
>> Yocto Project
>> SSG / OTC
>>
>> ---------------------------------------------------------------------
>> Intel Corporation (UK) Limited
>> Registered No. 1134945 (England)
>> Registered Office: Pipers Way, Swindon SN3 1RJ
>> VAT No: 860 2173 47
>>
>> This e-mail and any attachments may contain confidential material for
>> the sole use of the intended recipient(s). Any review or distribution
>> by others is strictly prohibited. If you are not the intended
>> recipient, please contact the sender and delete all copies.
>>
>>
> ---------------------------------------------------------------------
> Intel Corporation (UK) Limited
> Registered No. 1134945 (England)
> Registered Office: Pipers Way, Swindon SN3 1RJ
> VAT No: 860 2173 47
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>



-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 8389 bytes --]