* [review-request][PATCH] bitbake: toaster: importlayer Remove description input field
@ 2015-02-18 15:18 Michael Wood
2015-02-18 19:00 ` Damian, Alexandru
0 siblings, 1 reply; 4+ messages in thread
From: Michael Wood @ 2015-02-18 15:18 UTC (permalink / raw)
To: toaster
This wasn't required or working due to a typo and adds ambiguity between
the summary and description. The correct method for changing the description
or summary is via the layerdetails page.
[YOCTO #7190]
Signed-off-by: Michael Wood <michael.g.wood@intel.com>
---
bitbake/lib/toaster/toastergui/static/js/importlayer.js | 1 -
bitbake/lib/toaster/toastergui/templates/importlayer.html | 6 ------
bitbake/lib/toaster/toastergui/views.py | 3 ---
3 files changed, 10 deletions(-)
diff --git a/bitbake/lib/toaster/toastergui/static/js/importlayer.js b/bitbake/lib/toaster/toastergui/static/js/importlayer.js
index e782bda..9d54286 100644
--- a/bitbake/lib/toaster/toastergui/static/js/importlayer.js
+++ b/bitbake/lib/toaster/toastergui/static/js/importlayer.js
@@ -136,7 +136,6 @@ function importLayerPageInit (ctx) {
name: layerNameInput.val(),
vcs_url: vcsURLInput.val(),
git_ref: gitRefInput.val(),
- summary: $("#layer-summary").val(),
dir_path: $("#layer-subdir").val(),
project_id: ctx.projectId,
layer_deps: layerDepsCsv,
diff --git a/bitbake/lib/toaster/toastergui/templates/importlayer.html b/bitbake/lib/toaster/toastergui/templates/importlayer.html
index a4d8ee1..1196e0c 100644
--- a/bitbake/lib/toaster/toastergui/templates/importlayer.html
+++ b/bitbake/lib/toaster/toastergui/templates/importlayer.html
@@ -84,12 +84,6 @@
</div>
</div>
- <label class="project-form" for="layer-description">Layer description
- <span class="muted">(optional)</span>
- <span class="icon-question-sign get-help" title="A short layer explanation" />
- </label>
- <textarea id="layer-description" class="input-xxlarge"></textarea>
-
</fieldset>
<fieldset class="air">
<legend>
diff --git a/bitbake/lib/toaster/toastergui/views.py b/bitbake/lib/toaster/toastergui/views.py
index b5ff9b1..825cf80 100755
--- a/bitbake/lib/toaster/toastergui/views.py
+++ b/bitbake/lib/toaster/toastergui/views.py
@@ -2413,9 +2413,6 @@ if toastermain.settings.MANAGED:
if layer_created:
layer.layer_source = layer_source
layer.vcs_url = post_data['vcs_url']
- if post_data.has_key('summary'):
- layer.summary = layer.description = post_data['summary']
-
layer.up_date = timezone.now()
layer.save()
else:
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [review-request][PATCH] bitbake: toaster: importlayer Remove description input field
2015-02-18 15:18 [review-request][PATCH] bitbake: toaster: importlayer Remove description input field Michael Wood
@ 2015-02-18 19:00 ` Damian, Alexandru
2015-02-19 10:58 ` Barros Pena, Belen
0 siblings, 1 reply; 4+ messages in thread
From: Damian, Alexandru @ 2015-02-18 19:00 UTC (permalink / raw)
To: Michael Wood; +Cc: toaster
[-- Attachment #1: Type: text/plain, Size: 3191 bytes --]
Taken for submission,
Thank you,
Alex
On Wed, Feb 18, 2015 at 3:18 PM, Michael Wood <michael.g.wood@intel.com>
wrote:
> This wasn't required or working due to a typo and adds ambiguity between
> the summary and description. The correct method for changing the
> description
> or summary is via the layerdetails page.
>
> [YOCTO #7190]
>
> Signed-off-by: Michael Wood <michael.g.wood@intel.com>
> ---
> bitbake/lib/toaster/toastergui/static/js/importlayer.js | 1 -
> bitbake/lib/toaster/toastergui/templates/importlayer.html | 6 ------
> bitbake/lib/toaster/toastergui/views.py | 3 ---
> 3 files changed, 10 deletions(-)
>
> diff --git a/bitbake/lib/toaster/toastergui/static/js/importlayer.js
> b/bitbake/lib/toaster/toastergui/static/js/importlayer.js
> index e782bda..9d54286 100644
> --- a/bitbake/lib/toaster/toastergui/static/js/importlayer.js
> +++ b/bitbake/lib/toaster/toastergui/static/js/importlayer.js
> @@ -136,7 +136,6 @@ function importLayerPageInit (ctx) {
> name: layerNameInput.val(),
> vcs_url: vcsURLInput.val(),
> git_ref: gitRefInput.val(),
> - summary: $("#layer-summary").val(),
> dir_path: $("#layer-subdir").val(),
> project_id: ctx.projectId,
> layer_deps: layerDepsCsv,
> diff --git a/bitbake/lib/toaster/toastergui/templates/importlayer.html
> b/bitbake/lib/toaster/toastergui/templates/importlayer.html
> index a4d8ee1..1196e0c 100644
> --- a/bitbake/lib/toaster/toastergui/templates/importlayer.html
> +++ b/bitbake/lib/toaster/toastergui/templates/importlayer.html
> @@ -84,12 +84,6 @@
> </div>
> </div>
>
> - <label class="project-form"
> for="layer-description">Layer description
> - <span class="muted">(optional)</span>
> - <span class="icon-question-sign get-help"
> title="A short layer explanation" />
> - </label>
> - <textarea id="layer-description"
> class="input-xxlarge"></textarea>
> -
> </fieldset>
> <fieldset class="air">
> <legend>
> diff --git a/bitbake/lib/toaster/toastergui/views.py
> b/bitbake/lib/toaster/toastergui/views.py
> index b5ff9b1..825cf80 100755
> --- a/bitbake/lib/toaster/toastergui/views.py
> +++ b/bitbake/lib/toaster/toastergui/views.py
> @@ -2413,9 +2413,6 @@ if toastermain.settings.MANAGED:
> if layer_created:
> layer.layer_source = layer_source
> layer.vcs_url = post_data['vcs_url']
> - if post_data.has_key('summary'):
> - layer.summary = layer.description =
> post_data['summary']
> -
> layer.up_date = timezone.now()
> layer.save()
> else:
> --
> 2.1.0
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>
--
Alex Damian
Yocto Project
SSG / OTC
[-- Attachment #2: Type: text/html, Size: 4451 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [review-request][PATCH] bitbake: toaster: importlayer Remove description input field
2015-02-18 19:00 ` Damian, Alexandru
@ 2015-02-19 10:58 ` Barros Pena, Belen
2015-02-24 16:29 ` Damian, Alexandru
0 siblings, 1 reply; 4+ messages in thread
From: Barros Pena, Belen @ 2015-02-19 10:58 UTC (permalink / raw)
To: Damian, Alexandru, Wood, Michael G; +Cc: toaster
I know this was taken, but the revision label is missing the class
project-form, which sets the correct spacing :/ I've pushed a patch to
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=bbarrosp/7
190&id=d6a7416c8e9efe4222fa54d8ff9d96076d56a00a
Any chance you can take it with Michael's patch?
Thanks!!
Belén
On 18/02/2015 19:00, "Damian, Alexandru" <alexandru.damian@intel.com>
wrote:
>Taken for submission,
>
>Thank you,
>Alex
>
>
>
>On Wed, Feb 18, 2015 at 3:18 PM, Michael Wood
><michael.g.wood@intel.com> wrote:
>
>This wasn't required or working due to a typo and adds ambiguity between
>the summary and description. The correct method for changing the
>description
>or summary is via the layerdetails page.
>
>[YOCTO #7190]
>
>Signed-off-by: Michael Wood <michael.g.wood@intel.com>
>---
> bitbake/lib/toaster/toastergui/static/js/importlayer.js | 1 -
> bitbake/lib/toaster/toastergui/templates/importlayer.html | 6 ------
> bitbake/lib/toaster/toastergui/views.py | 3 ---
> 3 files changed, 10 deletions(-)
>
>diff --git a/bitbake/lib/toaster/toastergui/static/js/importlayer.js
>b/bitbake/lib/toaster/toastergui/static/js/importlayer.js
>index e782bda..9d54286 100644
>--- a/bitbake/lib/toaster/toastergui/static/js/importlayer.js
>+++ b/bitbake/lib/toaster/toastergui/static/js/importlayer.js
>@@ -136,7 +136,6 @@ function importLayerPageInit (ctx) {
> name: layerNameInput.val(),
> vcs_url: vcsURLInput.val(),
> git_ref: gitRefInput.val(),
>- summary: $("#layer-summary").val(),
> dir_path: $("#layer-subdir").val(),
> project_id: ctx.projectId,
> layer_deps: layerDepsCsv,
>diff --git a/bitbake/lib/toaster/toastergui/templates/importlayer.html
>b/bitbake/lib/toaster/toastergui/templates/importlayer.html
>index a4d8ee1..1196e0c 100644
>--- a/bitbake/lib/toaster/toastergui/templates/importlayer.html
>+++ b/bitbake/lib/toaster/toastergui/templates/importlayer.html
>@@ -84,12 +84,6 @@
> </div>
> </div>
>
>- <label class="project-form"
>for="layer-description">Layer description
>- <span class="muted">(optional)</span>
>- <span class="icon-question-sign get-help"
>title="A short layer explanation" />
>- </label>
>- <textarea id="layer-description"
>class="input-xxlarge"></textarea>
>-
> </fieldset>
> <fieldset class="air">
> <legend>
>diff --git a/bitbake/lib/toaster/toastergui/views.py
>b/bitbake/lib/toaster/toastergui/views.py
>index b5ff9b1..825cf80 100755
>--- a/bitbake/lib/toaster/toastergui/views.py
>+++ b/bitbake/lib/toaster/toastergui/views.py
>@@ -2413,9 +2413,6 @@ if toastermain.settings.MANAGED:
> if layer_created:
> layer.layer_source = layer_source
> layer.vcs_url = post_data['vcs_url']
>- if post_data.has_key('summary'):
>- layer.summary = layer.description =
>post_data['summary']
>-
> layer.up_date = timezone.now()
> layer.save()
> else:
>--
>2.1.0
>
>--
>_______________________________________________
>toaster mailing list
>toaster@yoctoproject.org
>https://lists.yoctoproject.org/listinfo/toaster
>
>
>
>
>
>
>--
>Alex Damian
>Yocto Project
>
>SSG / OTC
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [review-request][PATCH] bitbake: toaster: importlayer Remove description input field
2015-02-19 10:58 ` Barros Pena, Belen
@ 2015-02-24 16:29 ` Damian, Alexandru
0 siblings, 0 replies; 4+ messages in thread
From: Damian, Alexandru @ 2015-02-24 16:29 UTC (permalink / raw)
To: Barros Pena, Belen; +Cc: toaster
[-- Attachment #1: Type: text/plain, Size: 4006 bytes --]
Extra patch taken for submission.
Cheers,
Alex
On Thu, Feb 19, 2015 at 10:58 AM, Barros Pena, Belen <
belen.barros.pena@intel.com> wrote:
> I know this was taken, but the revision label is missing the class
> project-form, which sets the correct spacing :/ I've pushed a patch to
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=bbarrosp/7
> 190&id=d6a7416c8e9efe4222fa54d8ff9d96076d56a00a
>
> Any chance you can take it with Michael's patch?
>
> Thanks!!
>
> Belén
>
> On 18/02/2015 19:00, "Damian, Alexandru" <alexandru.damian@intel.com>
> wrote:
>
> >Taken for submission,
> >
> >Thank you,
> >Alex
> >
> >
> >
> >On Wed, Feb 18, 2015 at 3:18 PM, Michael Wood
> ><michael.g.wood@intel.com> wrote:
> >
> >This wasn't required or working due to a typo and adds ambiguity between
> >the summary and description. The correct method for changing the
> >description
> >or summary is via the layerdetails page.
> >
> >[YOCTO #7190]
> >
> >Signed-off-by: Michael Wood <michael.g.wood@intel.com>
> >---
> > bitbake/lib/toaster/toastergui/static/js/importlayer.js | 1 -
> > bitbake/lib/toaster/toastergui/templates/importlayer.html | 6 ------
> > bitbake/lib/toaster/toastergui/views.py | 3 ---
> > 3 files changed, 10 deletions(-)
> >
> >diff --git a/bitbake/lib/toaster/toastergui/static/js/importlayer.js
> >b/bitbake/lib/toaster/toastergui/static/js/importlayer.js
> >index e782bda..9d54286 100644
> >--- a/bitbake/lib/toaster/toastergui/static/js/importlayer.js
> >+++ b/bitbake/lib/toaster/toastergui/static/js/importlayer.js
> >@@ -136,7 +136,6 @@ function importLayerPageInit (ctx) {
> > name: layerNameInput.val(),
> > vcs_url: vcsURLInput.val(),
> > git_ref: gitRefInput.val(),
> >- summary: $("#layer-summary").val(),
> > dir_path: $("#layer-subdir").val(),
> > project_id: ctx.projectId,
> > layer_deps: layerDepsCsv,
> >diff --git a/bitbake/lib/toaster/toastergui/templates/importlayer.html
> >b/bitbake/lib/toaster/toastergui/templates/importlayer.html
> >index a4d8ee1..1196e0c 100644
> >--- a/bitbake/lib/toaster/toastergui/templates/importlayer.html
> >+++ b/bitbake/lib/toaster/toastergui/templates/importlayer.html
> >@@ -84,12 +84,6 @@
> > </div>
> > </div>
> >
> >- <label class="project-form"
> >for="layer-description">Layer description
> >- <span class="muted">(optional)</span>
> >- <span class="icon-question-sign get-help"
> >title="A short layer explanation" />
> >- </label>
> >- <textarea id="layer-description"
> >class="input-xxlarge"></textarea>
> >-
> > </fieldset>
> > <fieldset class="air">
> > <legend>
> >diff --git a/bitbake/lib/toaster/toastergui/views.py
> >b/bitbake/lib/toaster/toastergui/views.py
> >index b5ff9b1..825cf80 100755
> >--- a/bitbake/lib/toaster/toastergui/views.py
> >+++ b/bitbake/lib/toaster/toastergui/views.py
> >@@ -2413,9 +2413,6 @@ if toastermain.settings.MANAGED:
> > if layer_created:
> > layer.layer_source = layer_source
> > layer.vcs_url = post_data['vcs_url']
> >- if post_data.has_key('summary'):
> >- layer.summary = layer.description =
> >post_data['summary']
> >-
> > layer.up_date = timezone.now()
> > layer.save()
> > else:
> >--
> >2.1.0
> >
> >--
> >_______________________________________________
> >toaster mailing list
> >toaster@yoctoproject.org
> >https://lists.yoctoproject.org/listinfo/toaster
> >
> >
> >
> >
> >
> >
> >--
> >Alex Damian
> >Yocto Project
> >
> >SSG / OTC
> >
> >
> >
>
>
--
Alex Damian
Yocto Project
SSG / OTC
[-- Attachment #2: Type: text/html, Size: 6096 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-24 16:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-18 15:18 [review-request][PATCH] bitbake: toaster: importlayer Remove description input field Michael Wood
2015-02-18 19:00 ` Damian, Alexandru
2015-02-19 10:58 ` Barros Pena, Belen
2015-02-24 16:29 ` Damian, Alexandru
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.