[review-request] 6483 – “feature unavailable page needed”

[review-request] 6483 – “feature unavailable page needed”

[Reyna, David]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

Hi Belen and Alex,

I have pushed the implementation for 6483<https://bugzilla.yoctoproject.org/show_bug.cgi?id=6483> – “feature unavailable page needed”

  dreyna/landing_not_managed_6682

(Yes, the number in the branch name is wrong, but the content and commit are correct).

My test was to:
  (a) Start Toaster in normal non-managed mode
  (b) Select an unsupported page (“…/toastergui/projects/1”)
  (c) Observe my new landing page appear
  (d) Follow the two links to see that they connect

- David



[-- Attachment #2: Type: text/html, Size: 1236 bytes --]

Re: [review-request] 6483 ­ ³feature unavailable page needed²

[Barros Pena, Belen]

On 18/02/2015 08:25, "Reyna, David" <david.reyna@windriver.com> wrote:

>Hi Belen and Alex,
> 
>I have pushed the implementation for
>6483 <https://bugzilla.yoctoproject.org/show_bug.cgi?id=6483> ­ ³feature
>unavailable page needed²

Hi David,

This seems to be working ok. I've made a couple of tiny changes and pushed
them here

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=bbarrosp/land
ing-not-managed

Any chance you could take a look at those, and if ok integrate them with
your branch and send a v2?

Thanks!!

Belén

>
> 
>  dreyna/landing_not_managed_6682
> 
>(Yes, the number in the branch name is wrong, but the content and commit
>are correct).
> 
>My test was to:
>  (a) Start Toaster in normal non-managed mode
>  (b) Select an unsupported page (³Š/toastergui/projects/1²)
>  (c) Observe my new landing page appear
>  (d) Follow the two links to see that they connect
> 
>- David
> 
> 

Re: [review-request] 6483 ­ ³feature unavailable page needed²

[Reyna, David]

I am looking at it now.

- David

> -----Original Message-----
> From: Barros Pena, Belen [mailto:belen.barros.pena@intel.com]
> Sent: Wednesday, February 18, 2015 10:39 AM
> To: Reyna, David; DAMIAN, ALEXANDRU
> Cc: toaster@yoctoproject.org
> Subject: Re: [Toaster] [review-request] 6483  ³feature unavailable page
> needed²
> 
> 
> 
> On 18/02/2015 08:25, "Reyna, David" <david.reyna@windriver.com> wrote:
> 
> >Hi Belen and Alex,
> >
> >I have pushed the implementation for
> >6483 <https://bugzilla.yoctoproject.org/show_bug.cgi?id=6483> ­
> ³feature
> >unavailable page needed²
> 
> Hi David,
> 
> This seems to be working ok. I've made a couple of tiny changes and
> pushed
> them here
> 
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-
> contrib/log/?h=bbarrosp/land
> ing-not-managed
> 
> Any chance you could take a look at those, and if ok integrate them
> with
> your branch and send a v2?
> 
> Thanks!!
> 
> Belén
> 
> >
> >
> >  dreyna/landing_not_managed_6682
> >
> >(Yes, the number in the branch name is wrong, but the content and
> commit
> >are correct).
> >
> >My test was to:
> >  (a) Start Toaster in normal non-managed mode
> >  (b) Select an unsupported page (³Š/toastergui/projects/1²)
> >  (c) Observe my new landing page appear
> >  (d) Follow the two links to see that they connect
> >
> >- David
> >
> >
> 

Re: [review-request] 6483 – “feature unavailable page needed”

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]

Taken for submission,

Thank you,
Alex

On Wed, Feb 18, 2015 at 8:25 AM, Reyna, David <david.reyna@windriver.com>
wrote:

>  Hi Belen and Alex,
>
> I have pushed the implementation for *6483*
> <https://bugzilla.yoctoproject.org/show_bug.cgi?id=6483> – “feature
> unavailable page needed”
>
>   dreyna/landing_not_managed_6682
>
> (Yes, the number in the branch name is wrong, but the content and commit
> are correct).
>
> My test was to:
>   (a) Start Toaster in normal non-managed mode
>   (b) Select an unsupported page (“…/toastergui/projects/1”)
>   (c) Observe my new landing page appear
>   (d) Follow the two links to see that they connect
>
> - David
>
>
>



-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 1619 bytes --]

Re: [review-request] 6483 ­ ³feature unavailable page needed²

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 1757 bytes --]

Hi,

I actually performed those changes inline on the previous patch -

Cheers,
Alex

On Wed, Feb 18, 2015 at 6:40 PM, Reyna, David L (Wind River) <
david.reyna@windriver.com> wrote:

> I am looking at it now.
>
> - David
>
> > -----Original Message-----
> > From: Barros Pena, Belen [mailto:belen.barros.pena@intel.com]
> > Sent: Wednesday, February 18, 2015 10:39 AM
> > To: Reyna, David; DAMIAN, ALEXANDRU
> > Cc: toaster@yoctoproject.org
> > Subject: Re: [Toaster] [review-request] 6483  ³feature unavailable page
> > needed²
> >
> >
> >
> > On 18/02/2015 08:25, "Reyna, David" <david.reyna@windriver.com> wrote:
> >
> > >Hi Belen and Alex,
> > >
> > >I have pushed the implementation for
> > >6483 <https://bugzilla.yoctoproject.org/show_bug.cgi?id=6483> ­
> > ³feature
> > >unavailable page needed²
> >
> > Hi David,
> >
> > This seems to be working ok. I've made a couple of tiny changes and
> > pushed
> > them here
> >
> > http://git.yoctoproject.org/cgit/cgit.cgi/poky-
> > contrib/log/?h=bbarrosp/land
> > ing-not-managed
> >
> > Any chance you could take a look at those, and if ok integrate them
> > with
> > your branch and send a v2?
> >
> > Thanks!!
> >
> > Belén
> >
> > >
> > >
> > >  dreyna/landing_not_managed_6682
> > >
> > >(Yes, the number in the branch name is wrong, but the content and
> > commit
> > >are correct).
> > >
> > >My test was to:
> > >  (a) Start Toaster in normal non-managed mode
> > >  (b) Select an unsupported page (³Š/toastergui/projects/1²)
> > >  (c) Observe my new landing page appear
> > >  (d) Follow the two links to see that they connect
> > >
> > >- David
> > >
> > >
> >
>
>


-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 3096 bytes --]