Re: toaster: review request for build dash board page

Re: toaster: review request for build dash board page

[Amit Kumar Chaudhary]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

Hi David,

This was just a trial review. We are waiting for your commit to be pushed so that we can properly merge with it, as per my request. In our Wednesday call.
I think I missed that part, but I do remember saying ok to rebasing the code to the latest toaster/master. I have done that now and it is available at 

achaudhary/errors_warnings_ondashboard_v3

Thanks,

—amit

[-- Attachment #2: Type: text/html, Size: 1424 bytes --]

Re: toaster: review request for build dash board page

[Reyna, David]

[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]

Hi Amit,

Thanks. By the way, I am getting an error from HTML Validator saying that the “name” attributes are not longer allowed in <div>’s for HTML5.

  +<div class="accordion span10 pull-right" id="errors" name="errors">
--------------------------------------------------------^^^^^^^^^^^^^

  +<div class="accordion span10 pull-right" id="warnings" name="warnings">
----------------------------------------------------------^^^^^^^^^^^^^

I also had to remove those when I picked them up from Belen’s sample code for my recipe detail page.

- David

From: Amit Kumar Chaudhary [mailto:amit@floatingpondtech.com]
Sent: Friday, March 07, 2014 4:26 AM
To: Reyna, David; Wymore, Farrell; BARROS PENA, BELEN
Cc: 'toaster@yoctoproject.org'
Subject: Re: [Toaster] toaster: review request for build dash board page

Hi David,


This was just a trial review. We are waiting for your commit to be pushed so that we can properly merge with it, as per my request. In our Wednesday call.

I think I missed that part, but I do remember saying ok to rebasing the code to the latest toaster/master. I have done that now and it is available at

achaudhary/errors_warnings_ondashboard_v3

Thanks,

—amit

[-- Attachment #2: Type: text/html, Size: 6802 bytes --]

Re: toaster: review request for build dash board page

[Amit Kumar Chaudhary]

[-- Attachment #1: Type: text/plain, Size: 1607 bytes --]

Hi David, 

Thanks. Fixed it, the branch containing the revised patch is available as achaudhary/errors_warnings_ondashboard_v4.

The smaller patch that makes this particular edit is also available, at the tip of _v3.

—amit


On 7 March 2014 at 7:05:32 pm, Reyna, David (david.reyna@windriver.com) wrote:
Hi Amit,

 

Thanks. By the way, I am getting an error from HTML Validator saying that the “name” attributes are not longer allowed in <div>’s for HTML5.

 

  +<div class="accordion span10 pull-right" id="errors" name="errors">

--------------------------------------------------------^^^^^^^^^^^^^

  

  +<div class="accordion span10 pull-right" id="warnings" name="warnings">

----------------------------------------------------------^^^^^^^^^^^^^

 

I also had to remove those when I picked them up from Belen’s sample code for my recipe detail page.

 

- David

 

From: Amit Kumar Chaudhary [mailto:amit@floatingpondtech.com]
Sent: Friday, March 07, 2014 4:26 AM
To: Reyna, David; Wymore, Farrell; BARROS PENA, BELEN
Cc: 'toaster@yoctoproject.org'
Subject: Re: [Toaster] toaster: review request for build dash board page

 

Hi David,




This was just a trial review. We are waiting for your commit to be pushed so that we can properly merge with it, as per my request. In our Wednesday call.

I think I missed that part, but I do remember saying ok to rebasing the code to the latest toaster/master. I have done that now and it is available at 

achaudhary/errors_warnings_ondashboard_v3

Thanks,

—amit

[-- Attachment #2: Type: text/html, Size: 6846 bytes --]

Re: toaster: review request for build dash board page

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 2399 bytes --]

Hello Amit,

Regarding patch on head of
contrib/achaudhary/errors_warnings_ondashboard_v4

I am not sure why you add Javascript code inside "base.html" that only
works on the "builddashboard.html" page. Are the classes and identifiers
reused elsewhere ?

If not, the javascript code should be in the same file as the elements it
changes.

Cheers,
Alex



On Mon, Mar 10, 2014 at 1:31 PM, Amit Kumar Chaudhary <
amit@floatingpondtech.com> wrote:

> Hi David,
>
> Thanks. Fixed it, the branch containing the revised patch is available as
> achaudhary/errors_warnings_ondashboard_v4.
>
> The smaller patch that makes this particular edit is also available, at
> the tip of _v3.
>
> —amit
>
>
> On 7 March 2014 at 7:05:32 pm, Reyna, David (david.reyna@windriver.com)
> wrote:
>
>   Hi Amit,
>
>
>
> Thanks. By the way, I am getting an error from HTML Validator saying that
> the “name” attributes are not longer allowed in <div>’s for HTML5.
>
>
>
>   +<div class="accordion span10 pull-right" id="errors" name="errors">
>
> --------------------------------------------------------^^^^^^^^^^^^^
>
>
>
>   +<div class="accordion span10 pull-right" id="warnings" name="warnings">
>
> ----------------------------------------------------------^^^^^^^^^^^^^
>
>
>
> I also had to remove those when I picked them up from Belen’s sample code
> for my recipe detail page.
>
>
>
> - David
>
>
>
> * From:* Amit Kumar Chaudhary [mailto:amit@floatingpondtech.com]
>
> *Sent:* Friday, March 07, 2014 4:26 AM
> *To:* Reyna, David; Wymore, Farrell; BARROS PENA, BELEN
> *Cc:* 'toaster@yoctoproject.org'
> *Subject:* Re: [Toaster] toaster: review request for build dash board page
>
>
>
> Hi David,
>
>
>
>   This was just a trial review. We are waiting for your commit to be
> pushed so that we can properly merge with it, as per my request. In our
> Wednesday call.
>
> I think I missed that part, but I do remember saying ok to rebasing the
> code to the latest toaster/master. I have done that now and it is available
> at
>
> achaudhary/errors_warnings_ondashboard_v3
>
> Thanks,
>
> —amit
>
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>
>


-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 8052 bytes --]

Re: toaster: review request for build dash board page

[Amit Kumar Chaudhary]

[-- Attachment #1: Type: text/plain, Size: 2552 bytes --]

Hi Alex, 
On 12 March 2014 at 8:25:16 pm, Damian, Alexandru (alexandru.damian@intel.com) wrote:

Hello Amit,

Regarding patch on head of
contrib/achaudhary/errors_warnings_ondashboard_v4

I am not sure why you add Javascript code inside "base.html" that only works on the "builddashboard.html" page. Are the classes and identifiers reused elsewhere ?
No, not at the moment, I wasn’t sure about its placement, but it did look like something that could be used again.



If not, the javascript code should be in the same file as the elements it changes.
Yes, seems correct.

Thanks,

—amit



Cheers,
Alex



On Mon, Mar 10, 2014 at 1:31 PM, Amit Kumar Chaudhary <amit@floatingpondtech.com> wrote:
Hi David, 

Thanks. Fixed it, the branch containing the revised patch is available as achaudhary/errors_warnings_ondashboard_v4.

The smaller patch that makes this particular edit is also available, at the tip of _v3.

—amit


On 7 March 2014 at 7:05:32 pm, Reyna, David (david.reyna@windriver.com) wrote:
Hi Amit,

 

Thanks. By the way, I am getting an error from HTML Validator saying that the “name” attributes are not longer allowed in <div>’s for HTML5.

 

  +<div class="accordion span10 pull-right" id="errors" name="errors">

--------------------------------------------------------^^^^^^^^^^^^^

  

  +<div class="accordion span10 pull-right" id="warnings" name="warnings">

----------------------------------------------------------^^^^^^^^^^^^^

 

I also had to remove those when I picked them up from Belen’s sample code for my recipe detail page.

 

- David

 

From: Amit Kumar Chaudhary [mailto:amit@floatingpondtech.com]


Sent: Friday, March 07, 2014 4:26 AM
To: Reyna, David; Wymore, Farrell; BARROS PENA, BELEN
Cc: 'toaster@yoctoproject.org'
Subject: Re: [Toaster] toaster: review request for build dash board page
 

Hi David,




This was just a trial review. We are waiting for your commit to be pushed so that we can properly merge with it, as per my request. In our Wednesday call.

I think I missed that part, but I do remember saying ok to rebasing the code to the latest toaster/master. I have done that now and it is available at 

achaudhary/errors_warnings_ondashboard_v3

Thanks,

—amit


--
_______________________________________________
toaster mailing list
toaster@yoctoproject.org
https://lists.yoctoproject.org/listinfo/toaster




--
Alex Damian
Yocto Project
SSG / OTC 

[-- Attachment #2: Type: text/html, Size: 10203 bytes --]

Re: toaster: review request for build dash board page

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 3097 bytes --]

Would you terribly mind to make this change and push it ?
I'd like it to go into the today's upstream submission.

Alex


On Wed, Mar 12, 2014 at 3:10 PM, Amit Kumar Chaudhary <
amit@floatingpondtech.com> wrote:

> Hi Alex,
>
> On 12 March 2014 at 8:25:16 pm, Damian, Alexandru (
> alexandru.damian@intel.com) wrote:
>
> Hello Amit,
>
> Regarding patch on head of
> contrib/achaudhary/errors_warnings_ondashboard_v4
>
> I am not sure why you add Javascript code inside "base.html" that only
> works on the "builddashboard.html" page. Are the classes and identifiers
> reused elsewhere ?
>
> No, not at the moment, I wasn’t sure about its placement, but it did look
> like something that could be used again.
>
>
>
> If not, the javascript code should be in the same file as the elements it
> changes.
>
> Yes, seems correct.
>
> Thanks,
>
> —amit
>
>
>
> Cheers,
> Alex
>
>
>
> On Mon, Mar 10, 2014 at 1:31 PM, Amit Kumar Chaudhary <
> amit@floatingpondtech.com> wrote:
>
>> Hi David,
>>
>> Thanks. Fixed it, the branch containing the revised patch is available as
>> achaudhary/errors_warnings_ondashboard_v4.
>>
>> The smaller patch that makes this particular edit is also available, at
>> the tip of _v3.
>>
>> —amit
>>
>>
>> On 7 March 2014 at 7:05:32 pm, Reyna, David (david.reyna@windriver.com)
>> wrote:
>>
>> Hi Amit,
>>
>>
>>
>> Thanks. By the way, I am getting an error from HTML Validator saying that
>> the “name” attributes are not longer allowed in <div>’s for HTML5.
>>
>>
>>
>>   +<div class="accordion span10 pull-right" id="errors" name="errors">
>>
>> --------------------------------------------------------^^^^^^^^^^^^^
>>
>>
>>
>>   +<div class="accordion span10 pull-right" id="warnings" name="warnings">
>>
>> ----------------------------------------------------------^^^^^^^^^^^^^
>>
>>
>>
>> I also had to remove those when I picked them up from Belen’s sample code
>> for my recipe detail page.
>>
>>
>>
>> - David
>>
>>
>>
>> *From:* Amit Kumar Chaudhary [mailto:amit@floatingpondtech.com]
>>
>> *Sent:* Friday, March 07, 2014 4:26 AM
>> *To:* Reyna, David; Wymore, Farrell; BARROS PENA, BELEN
>> *Cc:* 'toaster@yoctoproject.org'
>> *Subject:* Re: [Toaster] toaster: review request for build dash board
>> page
>>
>>
>>
>> Hi David,
>>
>>
>>
>> This was just a trial review. We are waiting for your commit to be pushed
>> so that we can properly merge with it, as per my request. In our Wednesday
>> call.
>>
>> I think I missed that part, but I do remember saying ok to rebasing the
>> code to the latest toaster/master. I have done that now and it is available
>> at
>>
>> achaudhary/errors_warnings_ondashboard_v3
>>
>> Thanks,
>>
>> —amit
>>
>>
>> --
>> _______________________________________________
>> toaster mailing list
>> toaster@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/toaster
>>
>>
>
>
> --
> Alex Damian
> Yocto Project
> SSG / OTC
>
>


-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 9986 bytes --]

Re: toaster: review request for build dash board page

[Barros Pena, Belen]

On 12/03/2014 15:10, "Amit Kumar Chaudhary" <amit@floatingpondtech.com>
wrote:
>
>If not, the javascript code should be in the same file as the elements it
>changes.

FWIW, I have been putting all javascript code in static/js/main.js

Cheers,

Belén

Re: toaster: review request for build dash board page

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

this is also a good solution :)

Alex


On Wed, Mar 12, 2014 at 4:03 PM, Barros Pena, Belen <
belen.barros.pena@intel.com> wrote:

> On 12/03/2014 15:10, "Amit Kumar Chaudhary" <amit@floatingpondtech.com>
> wrote:
> >
> >If not, the javascript code should be in the same file as the elements it
> >changes.
>
> FWIW, I have been putting all javascript code in static/js/main.js
>
> Cheers,
>
> Belén
>
>


-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 1039 bytes --]

Re: toaster: review request for build dash board page

[Amit Kumar Chaudhary]

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

Hi Alex, Belen, 

Thanks, that’s where I have added it, pushed the branch to  achaudhary/errors_warnings_ondashboard_v6.


-- 
Amit Kumar Chaudhary

On 12 March 2014 at 11:33:50 pm, Damian, Alexandru (alexandru.damian@intel.com) wrote:

this is also a good solution :)

Alex


On Wed, Mar 12, 2014 at 4:03 PM, Barros Pena, Belen <belen.barros.pena@intel.com> wrote:
On 12/03/2014 15:10, "Amit Kumar Chaudhary" <amit@floatingpondtech.com>
wrote:
>
>If not, the javascript code should be in the same file as the elements it
>changes.

FWIW, I have been putting all javascript code in static/js/main.js

Cheers,

Belén




--
Alex Damian
Yocto Project
SSG / OTC 

[-- Attachment #2: Type: text/html, Size: 2764 bytes --]

Re: toaster: review request for build dash board page

[Barros Pena, Belen]

On 12/03/2014 18:13, "Amit Kumar Chaudhary" <amit@floatingpondtech.com>
wrote:

>
>Hi Alex, Belen, 
>
>
>Thanks, that¹s where I have added it, pushed the branch to
>achaudhary/errors_warnings_ondashboard_v6.

Hi Amit,

This is looking good, although you don't need lines 95 and 113, since
there is already a $(document).ready(function(){}); block in the script.
You just need to paste the additional lines inside it.

Cheers

Belén
 


>
>
>
>
>-- 
>Amit Kumar Chaudhary
>
>
>
>On 12 March 2014 at 11:33:50 pm, Damian, Alexandru
>(alexandru.damian@intel.com) wrote:
>
>this is also a good solution :)
>
>Alex
>
>
>
>
>On Wed, Mar 12, 2014 at 4:03 PM, Barros Pena, Belen
><belen.barros.pena@intel.com> wrote:
>
>On 12/03/2014 15:10, "Amit Kumar Chaudhary" <amit@floatingpondtech.com>
>wrote:
>>
>>If not, the javascript code should be in the same file as the elements it
>>changes.
>
>
>FWIW, I have been putting all javascript code in static/js/main.js
>
>Cheers,
>
>Belén
>
>
>
>
>
>
>
>--
>Alex Damian
>Yocto Project
>
>SSG / OTC 
>
>
>
>
>
>

Re: toaster: review request for build dash board page

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 1515 bytes --]

Let's keep it like this for now, since I want it merged, Farrell depends on
this.

Taken in.

Alex


On Wed, Mar 12, 2014 at 6:20 PM, Barros Pena, Belen <
belen.barros.pena@intel.com> wrote:

> On 12/03/2014 18:13, "Amit Kumar Chaudhary" <amit@floatingpondtech.com>
> wrote:
>
> >
> >Hi Alex, Belen,
> >
> >
> >Thanks, that¹s where I have added it, pushed the branch to
> >achaudhary/errors_warnings_ondashboard_v6.
>
> Hi Amit,
>
> This is looking good, although you don't need lines 95 and 113, since
> there is already a $(document).ready(function(){}); block in the script.
> You just need to paste the additional lines inside it.
>
> Cheers
>
> Belén
>
>
>
> >
> >
> >
> >
> >--
> >Amit Kumar Chaudhary
> >
> >
> >
> >On 12 March 2014 at 11:33:50 pm, Damian, Alexandru
> >(alexandru.damian@intel.com) wrote:
> >
> >this is also a good solution :)
> >
> >Alex
> >
> >
> >
> >
> >On Wed, Mar 12, 2014 at 4:03 PM, Barros Pena, Belen
> ><belen.barros.pena@intel.com> wrote:
> >
> >On 12/03/2014 15:10, "Amit Kumar Chaudhary" <amit@floatingpondtech.com>
> >wrote:
> >>
> >>If not, the javascript code should be in the same file as the elements it
> >>changes.
> >
> >
> >FWIW, I have been putting all javascript code in static/js/main.js
> >
> >Cheers,
> >
> >Belén
> >
> >
> >
> >
> >
> >
> >
> >--
> >Alex Damian
> >Yocto Project
> >
> >SSG / OTC
> >
> >
> >
> >
> >
> >
>
>


-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 2685 bytes --]

Re: toaster: review request for build dash board page

[Amit Kumar Chaudhary]

[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]

Hi Alex, Belen, 

I will submit a patch to fix it later. 

Thanks for sending it out for the merge.

—amit
On 12 March 2014 at 11:55:30 pm, Damian, Alexandru (alexandru.damian@intel.com) wrote:

Let's keep it like this for now, since I want it merged, Farrell depends on this.

Taken in.

Alex


On Wed, Mar 12, 2014 at 6:20 PM, Barros Pena, Belen <belen.barros.pena@intel.com> wrote:
On 12/03/2014 18:13, "Amit Kumar Chaudhary" <amit@floatingpondtech.com>
wrote:

>
>Hi Alex, Belen,
>
>
>Thanks, that¹s where I have added it, pushed the branch to
>achaudhary/errors_warnings_ondashboard_v6.

Hi Amit,

This is looking good, although you don't need lines 95 and 113, since
there is already a $(document).ready(function(){}); block in the script.
You just need to paste the additional lines inside it.

Cheers

Belén



>
>
>
>
>--
>Amit Kumar Chaudhary
>
>
>
>On 12 March 2014 at 11:33:50 pm, Damian, Alexandru
>(alexandru.damian@intel.com) wrote:
>
>this is also a good solution :)
>
>Alex
>
>
>
>
>On Wed, Mar 12, 2014 at 4:03 PM, Barros Pena, Belen
><belen.barros.pena@intel.com> wrote:
>
>On 12/03/2014 15:10, "Amit Kumar Chaudhary" <amit@floatingpondtech.com>
>wrote:
>>
>>If not, the javascript code should be in the same file as the elements it
>>changes.
>
>
>FWIW, I have been putting all javascript code in static/js/main.js
>
>Cheers,
>
>Belén
>
>
>
>
>
>
>
>--
>Alex Damian
>Yocto Project
>
>SSG / OTC
>
>
>
>
>
>




--
Alex Damian
Yocto Project
SSG / OTC 

[-- Attachment #2: Type: text/html, Size: 4314 bytes --]

Re: toaster: review request for build dash board page

[Reyna, David]

[-- Attachment #1: Type: text/plain, Size: 2819 bytes --]

Hi Amit,

FYI, I noticed that your commit is missing the “[YOCTO # 4283]” line. You should probably make sure you include that when you post your final fix for this feature.

Thanks,
David

============================
commit d3d3a2c6ba71767e49a5b62fe74bf3b47688b911
Author: Amit Kumar Chaudhary <amit@floatingpondtech.com>
Date:   Wed Mar 12 18:47:42 2014 +0000

    bitbake: toaster: add errors and warnings listing

    Add the errors and warnings listing to the build
    dashboard page.

    (Bitbake rev: 2004c0fd1dd049d26279ee10a18e69e6852247fa)

    Signed-off-by: Amit Kumar Chaudhary <amit@floatingpondtech.com>
    Signed-off-by: Richard Purdie richard.purdie@linuxfoundation.org<mailto:richard.purdie@linuxfoundation.org>


From: Amit Kumar Chaudhary [mailto:amit@floatingpondtech.com]
Sent: Thursday, March 13, 2014 7:13 AM
To: DAMIAN, ALEXANDRU; BARROS PENA, BELEN
Cc: toaster@yoctoproject.org; Wymore, Farrell; Reyna, David
Subject: Re: [Toaster] toaster: review request for build dash board page

Hi Alex, Belen,

I will submit a patch to fix it later.

Thanks for sending it out for the merge.

—amit

On 12 March 2014 at 11:55:30 pm, Damian, Alexandru (alexandru.damian@intel.com<mailto:alexandru.damian@intel.com>) wrote:
Let's keep it like this for now, since I want it merged, Farrell depends on this.

Taken in.
Alex

On Wed, Mar 12, 2014 at 6:20 PM, Barros Pena, Belen <belen.barros.pena@intel.com<mailto:belen.barros.pena@intel.com>> wrote:
On 12/03/2014 18:13, "Amit Kumar Chaudhary" <amit@floatingpondtech.com<mailto:amit@floatingpondtech.com>>
wrote:

>
>Hi Alex, Belen,
>
>
>Thanks, that¹s where I have added it, pushed the branch to
>achaudhary/errors_warnings_ondashboard_v6.
Hi Amit,

This is looking good, although you don't need lines 95 and 113, since
there is already a $(document).ready(function(){}); block in the script.
You just need to paste the additional lines inside it.

Cheers

Belén



>
>
>
>
>--
>Amit Kumar Chaudhary
>
>
>
>On 12 March 2014 at 11:33:50 pm, Damian, Alexandru
>(alexandru.damian@intel.com<mailto:alexandru.damian@intel.com>) wrote:
>
>this is also a good solution :)
>
>Alex
>
>
>
>
>On Wed, Mar 12, 2014 at 4:03 PM, Barros Pena, Belen
><belen.barros.pena@intel.com<mailto:belen.barros.pena@intel.com>> wrote:
>
>On 12/03/2014 15:10, "Amit Kumar Chaudhary" <amit@floatingpondtech.com<mailto:amit@floatingpondtech.com>>
>wrote:
>>
>>If not, the javascript code should be in the same file as the elements it
>>changes.
>
>
>FWIW, I have been putting all javascript code in static/js/main.js
>
>Cheers,
>
>Belén
>
>
>
>
>
>
>
>--
>Alex Damian
>Yocto Project
>
>SSG / OTC
>
>
>
>
>
>



--
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 12693 bytes --]

Re: toaster: review request for build dash board page

[Amit Kumar Chaudhary]

[-- Attachment #1: Type: text/plain, Size: 2895 bytes --]

Hi David, 

Right, I will take care of this in the next patches.

Thanks,
—amit

On 16 March 2014 at 3:43:34 am, Reyna, David (david.reyna@windriver.com) wrote:

Hi Amit,

 

FYI, I noticed that your commit is missing the “[YOCTO # 4283]” line. You should probably make sure you include that when you post your final fix for this feature.

 

Thanks,

David

 

============================

commit d3d3a2c6ba71767e49a5b62fe74bf3b47688b911

Author: Amit Kumar Chaudhary <amit@floatingpondtech.com>

Date:   Wed Mar 12 18:47:42 2014 +0000

 

    bitbake: toaster: add errors and warnings listing

   

    Add the errors and warnings listing to the build

    dashboard page.

   

    (Bitbake rev: 2004c0fd1dd049d26279ee10a18e69e6852247fa)

   

    Signed-off-by: Amit Kumar Chaudhary <amit@floatingpondtech.com>

    Signed-off-by: Richard Purdie richard.purdie@linuxfoundation.org

 

 

From: Amit Kumar Chaudhary [mailto:amit@floatingpondtech.com]
Sent: Thursday, March 13, 2014 7:13 AM
To: DAMIAN, ALEXANDRU; BARROS PENA, BELEN
Cc: toaster@yoctoproject.org; Wymore, Farrell; Reyna, David
Subject: Re: [Toaster] toaster: review request for build dash board page

 

Hi Alex, Belen, 

 

I will submit a patch to fix it later. 

 

Thanks for sending it out for the merge.

 

—amit

On 12 March 2014 at 11:55:30 pm, Damian, Alexandru (alexandru.damian@intel.com) wrote:

Let's keep it like this for now, since I want it merged, Farrell depends on this.

Taken in.

Alex

 

On Wed, Mar 12, 2014 at 6:20 PM, Barros Pena, Belen <belen.barros.pena@intel.com> wrote:

On 12/03/2014 18:13, "Amit Kumar Chaudhary" <amit@floatingpondtech.com>
wrote:

>

>Hi Alex, Belen,
>
>
>Thanks, that¹s where I have added it, pushed the branch to
>achaudhary/errors_warnings_ondashboard_v6.

Hi Amit,

This is looking good, although you don't need lines 95 and 113, since
there is already a $(document).ready(function(){}); block in the script.
You just need to paste the additional lines inside it.

Cheers

Belén




>
>
>
>
>--
>Amit Kumar Chaudhary
>
>
>
>On 12 March 2014 at 11:33:50 pm, Damian, Alexandru
>(alexandru.damian@intel.com) wrote:
>
>this is also a good solution :)
>
>Alex
>
>
>
>
>On Wed, Mar 12, 2014 at 4:03 PM, Barros Pena, Belen
><belen.barros.pena@intel.com> wrote:
>
>On 12/03/2014 15:10, "Amit Kumar Chaudhary" <amit@floatingpondtech.com>
>wrote:
>>
>>If not, the javascript code should be in the same file as the elements it
>>changes.
>
>
>FWIW, I have been putting all javascript code in static/js/main.js
>
>Cheers,
>
>Belén
>
>
>
>
>
>
>
>--
>Alex Damian
>Yocto Project
>
>SSG / OTC
>
>
>
>
>
>




--

Alex Damian

Yocto Project

SSG / OTC 

[-- Attachment #2: Type: text/html, Size: 12109 bytes --]

Re: toaster: review request for build dash board page

[Amit Kumar Chaudhary]

[-- Attachment #1: Type: text/plain, Size: 1503 bytes --]

Hi Belen,

Fixed this one, combined the two calls into one, patch is available at achaudhary/combine_ready_calls

Thanks,

-- 
Amit Kumar Chaudhary

On 12 March 2014 at 11:50:22 pm, Barros Pena, Belen (belen.barros.pena@intel.com) wrote:

On 12/03/2014 18:13, "Amit Kumar Chaudhary" <amit@floatingpondtech.com>  
wrote:  

>  
>Hi Alex, Belen,  
>  
>  
>Thanks, that¹s where I have added it, pushed the branch to  
>achaudhary/errors_warnings_ondashboard_v6.  

Hi Amit,  

This is looking good, although you don't need lines 95 and 113, since  
there is already a $(document).ready(function(){}); block in the script.  
You just need to paste the additional lines inside it.  

Cheers  

Belén  



>  
>  
>  
>  
>--  
>Amit Kumar Chaudhary  
>  
>  
>  
>On 12 March 2014 at 11:33:50 pm, Damian, Alexandru  
>(alexandru.damian@intel.com) wrote:  
>  
>this is also a good solution :)  
>  
>Alex  
>  
>  
>  
>  
>On Wed, Mar 12, 2014 at 4:03 PM, Barros Pena, Belen  
><belen.barros.pena@intel.com> wrote:  
>  
>On 12/03/2014 15:10, "Amit Kumar Chaudhary" <amit@floatingpondtech.com>  
>wrote:  
>>  
>>If not, the javascript code should be in the same file as the elements it  
>>changes.  
>  
>  
>FWIW, I have been putting all javascript code in static/js/main.js  
>  
>Cheers,  
>  
>Belén  
>  
>  
>  
>  
>  
>  
>  
>--  
>Alex Damian  
>Yocto Project  
>  
>SSG / OTC  
>  
>  
>  
>  
>  
>  


[-- Attachment #2: Type: text/html, Size: 3583 bytes --]

Re: [review-request] toaster: review request for build dash board page

[Amit Kumar Chaudhary]

[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]

Edited subject line to have [review-request] in it, to make it filter friendly.

-- 
Amit Kumar Chaudhary

On 19 March 2014 at 5:13:13 pm, Amit Kumar Chaudhary (amit@floatingpondtech.com) wrote:

Hi Belen,

Fixed this one, combined the two calls into one, patch is available at achaudhary/combine_ready_calls

Thanks,

-- 
Amit Kumar Chaudhary

On 12 March 2014 at 11:50:22 pm, Barros Pena, Belen (belen.barros.pena@intel.com) wrote:

On 12/03/2014 18:13, "Amit Kumar Chaudhary" <amit@floatingpondtech.com>
wrote:

>
>Hi Alex, Belen,
>
>
>Thanks, that¹s where I have added it, pushed the branch to
>achaudhary/errors_warnings_ondashboard_v6.

Hi Amit,

This is looking good, although you don't need lines 95 and 113, since
there is already a $(document).ready(function(){}); block in the script.
You just need to paste the additional lines inside it.

Cheers

Belén



>
>
>
>
>--
>Amit Kumar Chaudhary
>
>
>
>On 12 March 2014 at 11:33:50 pm, Damian, Alexandru
>(alexandru.damian@intel.com) wrote:
>
>this is also a good solution :)
>
>Alex
>
>
>
>
>On Wed, Mar 12, 2014 at 4:03 PM, Barros Pena, Belen
><belen.barros.pena@intel.com> wrote:
>
>On 12/03/2014 15:10, "Amit Kumar Chaudhary" <amit@floatingpondtech.com>
>wrote:
>>
>>If not, the javascript code should be in the same file as the elements it
>>changes.
>
>
>FWIW, I have been putting all javascript code in static/js/main.js
>
>Cheers,
>
>Belén
>
>
>
>
>
>
>
>--
>Alex Damian
>Yocto Project
>
>SSG / OTC
>
>
>
>
>
>


[-- Attachment #2: Type: text/html, Size: 4549 bytes --]

Re: [review-request] toaster: review request for build dash board page

[Barros Pena, Belen]

On 19/03/2014 11:53, "Amit Kumar Chaudhary" <amit@floatingpondtech.com>
wrote:

>On 19 March 2014 at 5:13:13 pm, Amit Kumar Chaudhary
>(amit@floatingpondtech.com) wrote:
>
>Hi Belen,
>
>Fixed this one, combined the two calls into one, patch is available at
>achaudhary/combine_ready_calls

This looks good to me. Thanks!

>
>Thanks,
>

Re: [review-request] toaster: review request for build dash board page

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]

Taken in.

Alex


On Thu, Mar 20, 2014 at 12:10 PM, Barros Pena, Belen <
belen.barros.pena@intel.com> wrote:

> On 19/03/2014 11:53, "Amit Kumar Chaudhary" <amit@floatingpondtech.com>
> wrote:
>
> >On 19 March 2014 at 5:13:13 pm, Amit Kumar Chaudhary
> >(amit@floatingpondtech.com) wrote:
> >
> >Hi Belen,
> >
> >Fixed this one, combined the two calls into one, patch is available at
> >achaudhary/combine_ready_calls
>
> This looks good to me. Thanks!
>
> >
> >Thanks,
> >
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 1686 bytes --]

Re: toaster: review request for build dash board page

[Barros Pena, Belen]

On 07/03/2014 13:46, "Reyna, David" <david.reyna@windriver.com> wrote:

>Hi Belen,
>
>Thanks for your advice. A few comments:
>
>>* The breadcrumb should not have the last Dashboard item. It is
>>represented by the build target + machine + completed on time stamp,
>>which should be the final, not clickable element of the breadcrumb
>
>We can certainly remove the "> dashboard" from the breadcrumb. Farrell
>did however notice that this was the only clue that this page was in fact
>a "dashboard" page, since the title is the images names.

>So, is "dashboard" purely an internal reference that will not appear in
>the documentation,

Well, yes, it kind of is: it is a dashboard in the sense that it provides
an overview of the information available for a build. But the page is
represented in Toaster by the build identifier, which right now is made of
the build target(s), the build machine and the completed on time. The
build identifier is also the page heading and the active item in the
breadcrumb.

>or should we keep this (or use some other method) to mark this page as a
>dashboard?

To be honest, I think that the fact that we call it dashboard (or summary
or whatever) is irrelevant. What is really happening is that this is the
page that represents a build within Toaster, and constitutes the point of
entry to all the information available about that build. That is why we
name it as the build it represents.

I hope this makes sense.

>
>We noticed that the breadcrumb for the build target is made _globally_
>clickable in the "basebuildpage.html". We can still do what you wish, I
>guess by having the dashboard page's context define a special value such
>that if it is defined there is no href, else it is display in the default
>manner with the href.

The last element of the breadcrumb should have the .active class applied
and should not be nested in an <a> tag. I have no idea what's the best way
of achieving this: I am happy with whatever you suggest! :)

>
>Thanks,
>David
>
>
>> -----Original Message-----
>> From: toaster-bounces@yoctoproject.org [mailto:toaster-
>> bounces@yoctoproject.org] On Behalf Of Barros Pena, Belen
>> Sent: Friday, March 07, 2014 2:55 AM
>> To: Wymore, Farrell
>> Cc: toaster@yoctoproject.org
>> Subject: Re: [Toaster] toaster: review request for build dash board page
>> 
>> On 06/03/2014 18:36, "Wymore, Farrell" <Farrell.Wymore@windriver.com>
>> wrote:
>> 
>> >Hi Belen,
>> >
>> >Thanks for the thorough comments.
>> >Questions/comments embedded.
>> >
>> >    - fw
>> >
>> >-----Original Message-----
>> >From: Barros Pena, Belen [mailto:belen.barros.pena@intel.com]
>> >Sent: Thursday, March 06, 2014 6:40 AM
>> >To: Wymore, Farrell
>> >Cc: toaster@yoctoproject.org
>> >Subject: Re: toaster: review request for build dash board page
>> >
>> >Hi Farrell,
>> >
>> >Thanks for this. I have a few comments, but I think they should be all
>> >easy to fix. There they go:
>> >
>> >* The breadcrumb should not have the last Dashboard item. It is
>> >represented by the build target + machine + completed on time stamp,
>> >which should be the final, not clickable element of the breadcrumb
>> 
>> >I'm not sure what you mean by 'breadcrumb': is this the links on the
>>All
>> >Builds page? The title on the Dashboard page?
>> 
>> Right, sorry: the breadcrumb is the element at the top of the page that
>> indicates the path to the current page. It is mainly set in the
>> basebuildpage.html template, but then builddashboard.html is adding:
>> 
>> {% block localbreadcrumb %}
>> <li>Dashboard</li>
>> {% endblock %}
>> 
>> That is what needs to go
>> 
>> >
>> >* If a build has multiple targets, the breadcrumb should only show the
>> >first one (in alphabetical order). For example, I have a build that
>>has 2
>> >targets: core-image-base and core-image-minimal. The breadcrumb for
>>this
>> >build should say: "core-image-base (+1)" but it says
>>"core-image-minimal
>> >(+1)" instead.
>> >Again, I'm not sure what breadcrumb means. I guess it's the links on
>>the
>> >All Builds page? In any event, I can fix that too, if no one else is
>> >working on this.
>> 
>> I hope the above explains! This is probably coming from
>>basebuildpage.html
>> though, not your page.
>> 
>> >
>> >* The same with the left navigation, in the Images section targets
>>should
>> >be listed in ascending alphabetical order. For the same build as
>>above, I
>> >have again core-image-minimal displaying above core-image-base. It
>>should
>> >be the other way around.
>> >Ok.
>> >
>> >* The same with the order in the h1.
>> >Ok.
>> >
>> >* Also, the in the h1 target names should be separated by commands.
>> >You mean commas?
>> 
>> Yes, I did mean commas (damn you autocorrect!)
>> 
>> >
>> >* The build status notification should say "Completed on" or "Failed
>>on"
>> >before the time stamp. It should only say 'with' if there are errors or
>> >warnings.
>> >Since you pointed this out, I realized how weird it appears.
>> 
>> :)
>> 
>> >
>> >* If there are errors and warnings the build status notification should
>> >say 'with # errors and # warnings'. Also, remove the .span2 class from
>> >the <span> tags that contain the number of errors and warnings. That
>>way
>> >things look a bit more like a sentence.
>> >Ok.
>> >
>> >* The link to the build time page is not working. The URL is set to
>> >/build/build-time/ so it is missing the build id:
>> >/build/<build_id>/build-time
>> >I don't think build-time.html has been defined yet. Of course,  I'm
>>happy
>> >to implement it, if no one else is trying to work on it.
>> 
>> David built that page, but sorry, it is not called built-time: it is
>> buildtime. So the right url is /build/<build_id>/buildtime
>> 
>> >
>> >* The image content module should only exist for those targets that are
>> >image recipes (things like core-image-minimal). Right now it is also
>> >showing for recipes (things like bash or busybox). When you have more
>> >than one target that is an image recipe within a build, the image
>>modules
>> >should also be sorted in alphabetical order, so they match the
>>navigation
>> >and the page heading.
>> >Ok.
>> >
>> >* The URL of the number of packages installed is not correct. It is set
>> >to /build/image-information-packages.html but it should be set to
>> >/build/<build_id>/target/<target_id>
>> >Do you mean 'Packages included'? I believe this html is an
>>unimplemented
>> >place holder. If the url is set to /build/<build id>/target/<target
>>id>,
>> >this would be the same url  for as for each image title.  Is this
>>correct?
>> 
>> Yes, that's correct. Dave Lerner has that page well underway, so it
>>should
>> be ready soon.
>> 
>> >
>> >* The label "License manifest² should be a link to the 'Packages
>>included'
>> >tab in the corresponding '1.1 Image information' page, showing the
>> >following columns: Package, Package version, License and Recipe (i.e.
>>the
>> >information provided by the package manifest file).
>> >Ok, I'm still a bit worried about where the content (anchor text) is
>> >coming from.
>> >
>> >* In the Configuration information, the layers should be listed in
>> >alphabetical order
>> >Ok.
>> >
>> >* In the Tasks information, instead of 'Tasks prebuilt' it should say
>> >'Tasks not executed'
>> >I'm not sure what you're referring to: is this the pop-down in the
>> >Outcome colume?
>> 
>> This is the tasks content module, the middle box under the "Build
>>summary"
>> heading
>> 
>> >
>> >* In the Tasks information we are missing the Failed tasks (if there
>>are
>> >any). We are also missing the links:
>> >
>> >** The number of tasks is a link to the tasks table
>> >** The number of executed tasks is a link to the tasks table with the
>> >'Executed tasks' filter applied
>> >** The number of not executed tasks is a link to the tasks table with
>>the
>> >³Not executed tasks² filter applied
>> >Ok.
>> >
>> >* In the Recipes and Packages information, the recipes item should say
>> >'Recipes built'. We are also missing the links:
>> >
>> >** The number of recipes should be a link to the recipes table
>> >** The number of packages should be a link to the packages built table
>> >Ok.
>> >
>> >* I am not able to collapse the errors module
>> >Hmm... works for me.
>> >
>> >* I am not able to expand the warnings module
>> >Ditto - what browser are you using?
>> 
>> Firefox 26.0 on Fedora 18
>> 
>> >
>> >* If a build throws no warnings, the warnings module should not display
>> >(right now it shows with heading '0 warnings').
>> >Ok.
>> >
>> >If you have any questions, let me know.
>> >
>> >Cheers
>> >
>> >Belén
>> >
>> >
>> >
>> >On 05/03/2014 18:24, "Wymore, Farrell" <Farrell.Wymore@windriver.com>
>> >wrote:
>> >
>> >>Dear Belen,
>> >>
>> >>I have pushed my first request for the build dash board page.
>> >>I have tested for multiple build targets and targets that are not
>> >>images.
>> >>
>> >>I¹ve applied Alex¹s patch for the database changes and manually
>> >>included Amit¹s error and warning  code.
>> >>
>> >>    fwymore/build-dashboard
>> >>
>> >>The exceptions for this review are:
>> >>· Waiting for license manifest decision · Waiting for image file table
>> >>population from Alex · Issue around cached packages installed list We
>> >>plan to review these in tomorrow¹s call.
>> >>
>> >>Thanks ­ Farrell
>> >>
>> >>
>> >
>> >
>> 
>> _______________________________________________
>> toaster mailing list
>> toaster@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/toaster

Re: toaster: review request for build dash board page

[Reyna, David]

Hi Belen,

Thanks for your advice. A few comments:

>* The breadcrumb should not have the last Dashboard item. It is
>represented by the build target + machine + completed on time stamp,
>which should be the final, not clickable element of the breadcrumb

We can certainly remove the "> dashboard" from the breadcrumb. Farrell did however notice that this was the only clue that this page was in fact a "dashboard" page, since the title is the images names. So, is "dashboard" purely an internal reference that will not appear in the documentation, or should we keep this (or use some other method) to mark this page as a dashboard?

We noticed that the breadcrumb for the build target is made _globally_ clickable in the "basebuildpage.html". We can still do what you wish, I guess by having the dashboard page's context define a special value such that if it is defined there is no href, else it is display in the default manner with the href.

Thanks,
David


> -----Original Message-----
> From: toaster-bounces@yoctoproject.org [mailto:toaster-
> bounces@yoctoproject.org] On Behalf Of Barros Pena, Belen
> Sent: Friday, March 07, 2014 2:55 AM
> To: Wymore, Farrell
> Cc: toaster@yoctoproject.org
> Subject: Re: [Toaster] toaster: review request for build dash board page
> 
> On 06/03/2014 18:36, "Wymore, Farrell" <Farrell.Wymore@windriver.com>
> wrote:
> 
> >Hi Belen,
> >
> >Thanks for the thorough comments.
> >Questions/comments embedded.
> >
> >    - fw
> >
> >-----Original Message-----
> >From: Barros Pena, Belen [mailto:belen.barros.pena@intel.com]
> >Sent: Thursday, March 06, 2014 6:40 AM
> >To: Wymore, Farrell
> >Cc: toaster@yoctoproject.org
> >Subject: Re: toaster: review request for build dash board page
> >
> >Hi Farrell,
> >
> >Thanks for this. I have a few comments, but I think they should be all
> >easy to fix. There they go:
> >
> >* The breadcrumb should not have the last Dashboard item. It is
> >represented by the build target + machine + completed on time stamp,
> >which should be the final, not clickable element of the breadcrumb
> 
> >I'm not sure what you mean by 'breadcrumb': is this the links on the All
> >Builds page? The title on the Dashboard page?
> 
> Right, sorry: the breadcrumb is the element at the top of the page that
> indicates the path to the current page. It is mainly set in the
> basebuildpage.html template, but then builddashboard.html is adding:
> 
> {% block localbreadcrumb %}
> <li>Dashboard</li>
> {% endblock %}
> 
> That is what needs to go
> 
> >
> >* If a build has multiple targets, the breadcrumb should only show the
> >first one (in alphabetical order). For example, I have a build that has 2
> >targets: core-image-base and core-image-minimal. The breadcrumb for this
> >build should say: "core-image-base (+1)" but it says "core-image-minimal
> >(+1)" instead.
> >Again, I'm not sure what breadcrumb means. I guess it's the links on the
> >All Builds page? In any event, I can fix that too, if no one else is
> >working on this.
> 
> I hope the above explains! This is probably coming from basebuildpage.html
> though, not your page.
> 
> >
> >* The same with the left navigation, in the Images section targets should
> >be listed in ascending alphabetical order. For the same build as above, I
> >have again core-image-minimal displaying above core-image-base. It should
> >be the other way around.
> >Ok.
> >
> >* The same with the order in the h1.
> >Ok.
> >
> >* Also, the in the h1 target names should be separated by commands.
> >You mean commas?
> 
> Yes, I did mean commas (damn you autocorrect!)
> 
> >
> >* The build status notification should say "Completed on" or "Failed on"
> >before the time stamp. It should only say 'with' if there are errors or
> >warnings.
> >Since you pointed this out, I realized how weird it appears.
> 
> :)
> 
> >
> >* If there are errors and warnings the build status notification should
> >say 'with # errors and # warnings'. Also, remove the .span2 class from
> >the <span> tags that contain the number of errors and warnings. That way
> >things look a bit more like a sentence.
> >Ok.
> >
> >* The link to the build time page is not working. The URL is set to
> >/build/build-time/ so it is missing the build id:
> >/build/<build_id>/build-time
> >I don't think build-time.html has been defined yet. Of course,  I'm happy
> >to implement it, if no one else is trying to work on it.
> 
> David built that page, but sorry, it is not called built-time: it is
> buildtime. So the right url is /build/<build_id>/buildtime
> 
> >
> >* The image content module should only exist for those targets that are
> >image recipes (things like core-image-minimal). Right now it is also
> >showing for recipes (things like bash or busybox). When you have more
> >than one target that is an image recipe within a build, the image modules
> >should also be sorted in alphabetical order, so they match the navigation
> >and the page heading.
> >Ok.
> >
> >* The URL of the number of packages installed is not correct. It is set
> >to /build/image-information-packages.html but it should be set to
> >/build/<build_id>/target/<target_id>
> >Do you mean 'Packages included'? I believe this html is an unimplemented
> >place holder. If the url is set to /build/<build id>/target/<target id>,
> >this would be the same url  for as for each image title.  Is this correct?
> 
> Yes, that's correct. Dave Lerner has that page well underway, so it should
> be ready soon.
> 
> >
> >* The label "License manifest² should be a link to the 'Packages included'
> >tab in the corresponding '1.1 Image information' page, showing the
> >following columns: Package, Package version, License and Recipe (i.e. the
> >information provided by the package manifest file).
> >Ok, I'm still a bit worried about where the content (anchor text) is
> >coming from.
> >
> >* In the Configuration information, the layers should be listed in
> >alphabetical order
> >Ok.
> >
> >* In the Tasks information, instead of 'Tasks prebuilt' it should say
> >'Tasks not executed'
> >I'm not sure what you're referring to: is this the pop-down in the
> >Outcome colume?
> 
> This is the tasks content module, the middle box under the "Build summary"
> heading
> 
> >
> >* In the Tasks information we are missing the Failed tasks (if there are
> >any). We are also missing the links:
> >
> >** The number of tasks is a link to the tasks table
> >** The number of executed tasks is a link to the tasks table with the
> >'Executed tasks' filter applied
> >** The number of not executed tasks is a link to the tasks table with the
> >³Not executed tasks² filter applied
> >Ok.
> >
> >* In the Recipes and Packages information, the recipes item should say
> >'Recipes built'. We are also missing the links:
> >
> >** The number of recipes should be a link to the recipes table
> >** The number of packages should be a link to the packages built table
> >Ok.
> >
> >* I am not able to collapse the errors module
> >Hmm... works for me.
> >
> >* I am not able to expand the warnings module
> >Ditto - what browser are you using?
> 
> Firefox 26.0 on Fedora 18
> 
> >
> >* If a build throws no warnings, the warnings module should not display
> >(right now it shows with heading '0 warnings').
> >Ok.
> >
> >If you have any questions, let me know.
> >
> >Cheers
> >
> >Belén
> >
> >
> >
> >On 05/03/2014 18:24, "Wymore, Farrell" <Farrell.Wymore@windriver.com>
> >wrote:
> >
> >>Dear Belen,
> >>
> >>I have pushed my first request for the build dash board page.
> >>I have tested for multiple build targets and targets that are not
> >>images.
> >>
> >>I¹ve applied Alex¹s patch for the database changes and manually
> >>included Amit¹s error and warning  code.
> >>
> >>    fwymore/build-dashboard
> >>
> >>The exceptions for this review are:
> >>· Waiting for license manifest decision · Waiting for image file table
> >>population from Alex · Issue around cached packages installed list We
> >>plan to review these in tomorrow¹s call.
> >>
> >>Thanks ­ Farrell
> >>
> >>
> >
> >
> 
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster

Re: toaster: review request for build dash board page

[Barros Pena, Belen]

On 06/03/2014 18:36, "Wymore, Farrell" <Farrell.Wymore@windriver.com>
wrote:

>Hi Belen,
>
>Thanks for the thorough comments.
>Questions/comments embedded.
>
>    - fw
>
>-----Original Message-----
>From: Barros Pena, Belen [mailto:belen.barros.pena@intel.com]
>Sent: Thursday, March 06, 2014 6:40 AM
>To: Wymore, Farrell
>Cc: toaster@yoctoproject.org
>Subject: Re: toaster: review request for build dash board page
>
>Hi Farrell,
>
>Thanks for this. I have a few comments, but I think they should be all
>easy to fix. There they go:
>
>* The breadcrumb should not have the last Dashboard item. It is
>represented by the build target + machine + completed on time stamp,
>which should be the final, not clickable element of the breadcrumb

>I'm not sure what you mean by 'breadcrumb': is this the links on the All
>Builds page? The title on the Dashboard page?

Right, sorry: the breadcrumb is the element at the top of the page that
indicates the path to the current page. It is mainly set in the
basebuildpage.html template, but then builddashboard.html is adding:

{% block localbreadcrumb %}
<li>Dashboard</li>
{% endblock %}

That is what needs to go

>
>* If a build has multiple targets, the breadcrumb should only show the
>first one (in alphabetical order). For example, I have a build that has 2
>targets: core-image-base and core-image-minimal. The breadcrumb for this
>build should say: "core-image-base (+1)" but it says "core-image-minimal
>(+1)" instead.
>Again, I'm not sure what breadcrumb means. I guess it's the links on the
>All Builds page? In any event, I can fix that too, if no one else is
>working on this.

I hope the above explains! This is probably coming from basebuildpage.html
though, not your page.

>
>* The same with the left navigation, in the Images section targets should
>be listed in ascending alphabetical order. For the same build as above, I
>have again core-image-minimal displaying above core-image-base. It should
>be the other way around.
>Ok.
>
>* The same with the order in the h1.
>Ok.
>
>* Also, the in the h1 target names should be separated by commands.
>You mean commas?

Yes, I did mean commas (damn you autocorrect!)

>
>* The build status notification should say "Completed on" or "Failed on"
>before the time stamp. It should only say 'with' if there are errors or
>warnings.
>Since you pointed this out, I realized how weird it appears.

:)

>
>* If there are errors and warnings the build status notification should
>say 'with # errors and # warnings'. Also, remove the .span2 class from
>the <span> tags that contain the number of errors and warnings. That way
>things look a bit more like a sentence.
>Ok.
>
>* The link to the build time page is not working. The URL is set to
>/build/build-time/ so it is missing the build id:
>/build/<build_id>/build-time
>I don't think build-time.html has been defined yet. Of course,  I'm happy
>to implement it, if no one else is trying to work on it.

David built that page, but sorry, it is not called built-time: it is
buildtime. So the right url is /build/<build_id>/buildtime

>
>* The image content module should only exist for those targets that are
>image recipes (things like core-image-minimal). Right now it is also
>showing for recipes (things like bash or busybox). When you have more
>than one target that is an image recipe within a build, the image modules
>should also be sorted in alphabetical order, so they match the navigation
>and the page heading.
>Ok.
>
>* The URL of the number of packages installed is not correct. It is set
>to /build/image-information-packages.html but it should be set to
>/build/<build_id>/target/<target_id>
>Do you mean 'Packages included'? I believe this html is an unimplemented
>place holder. If the url is set to /build/<build id>/target/<target id>,
>this would be the same url  for as for each image title.  Is this correct?

Yes, that's correct. Dave Lerner has that page well underway, so it should
be ready soon.

>
>* The label "License manifest² should be a link to the 'Packages included'
>tab in the corresponding '1.1 Image information' page, showing the
>following columns: Package, Package version, License and Recipe (i.e. the
>information provided by the package manifest file).
>Ok, I'm still a bit worried about where the content (anchor text) is
>coming from.
>
>* In the Configuration information, the layers should be listed in
>alphabetical order
>Ok.
>
>* In the Tasks information, instead of 'Tasks prebuilt' it should say
>'Tasks not executed'
>I'm not sure what you're referring to: is this the pop-down in the
>Outcome colume?

This is the tasks content module, the middle box under the "Build summary"
heading

>
>* In the Tasks information we are missing the Failed tasks (if there are
>any). We are also missing the links:
>
>** The number of tasks is a link to the tasks table
>** The number of executed tasks is a link to the tasks table with the
>'Executed tasks' filter applied
>** The number of not executed tasks is a link to the tasks table with the
>³Not executed tasks² filter applied
>Ok.
>
>* In the Recipes and Packages information, the recipes item should say
>'Recipes built'. We are also missing the links:
>
>** The number of recipes should be a link to the recipes table
>** The number of packages should be a link to the packages built table
>Ok.
>
>* I am not able to collapse the errors module
>Hmm... works for me.
>
>* I am not able to expand the warnings module
>Ditto - what browser are you using?

Firefox 26.0 on Fedora 18

>
>* If a build throws no warnings, the warnings module should not display
>(right now it shows with heading '0 warnings').
>Ok.
>
>If you have any questions, let me know.
>
>Cheers
>
>Belén
>
>
>
>On 05/03/2014 18:24, "Wymore, Farrell" <Farrell.Wymore@windriver.com>
>wrote:
>
>>Dear Belen,
>> 
>>I have pushed my first request for the build dash board page.
>>I have tested for multiple build targets and targets that are not
>>images.
>> 
>>I¹ve applied Alex¹s patch for the database changes and manually
>>included Amit¹s error and warning  code.
>> 
>>    fwymore/build-dashboard
>> 
>>The exceptions for this review are:
>>· Waiting for license manifest decision · Waiting for image file table
>>population from Alex · Issue around cached packages installed list We
>>plan to review these in tomorrow¹s call.
>> 
>>Thanks ­ Farrell
>> 
>>
>
>

Re: toaster: review request for build dash board page

[Wymore, Farrell]

Hi Belen,

Thanks for the thorough comments.
Questions/comments embedded.

    - fw

-----Original Message-----
From: Barros Pena, Belen [mailto:belen.barros.pena@intel.com] 
Sent: Thursday, March 06, 2014 6:40 AM
To: Wymore, Farrell
Cc: toaster@yoctoproject.org
Subject: Re: toaster: review request for build dash board page

Hi Farrell,

Thanks for this. I have a few comments, but I think they should be all easy to fix. There they go:

* The breadcrumb should not have the last Dashboard item. It is represented by the build target + machine + completed on time stamp, which should be the final, not clickable element of the breadcrumb
I'm not sure what you mean by 'breadcrumb': is this the links on the All Builds page? The title on the Dashboard page?

* If a build has multiple targets, the breadcrumb should only show the first one (in alphabetical order). For example, I have a build that has 2
targets: core-image-base and core-image-minimal. The breadcrumb for this build should say: "core-image-base (+1)" but it says "core-image-minimal (+1)" instead.
Again, I'm not sure what breadcrumb means. I guess it's the links on the All Builds page? In any event, I can fix that too, if no one else is working on this.

* The same with the left navigation, in the Images section targets should be listed in ascending alphabetical order. For the same build as above, I have again core-image-minimal displaying above core-image-base. It should be the other way around.
Ok.

* The same with the order in the h1.
Ok.

* Also, the in the h1 target names should be separated by commands.
You mean commas?

* The build status notification should say "Completed on" or "Failed on"
before the time stamp. It should only say 'with' if there are errors or warnings.
Since you pointed this out, I realized how weird it appears.

* If there are errors and warnings the build status notification should say 'with # errors and # warnings'. Also, remove the .span2 class from the <span> tags that contain the number of errors and warnings. That way things look a bit more like a sentence.
Ok.

* The link to the build time page is not working. The URL is set to /build/build-time/ so it is missing the build id:
/build/<build_id>/build-time
I don't think build-time.html has been defined yet. Of course,  I'm happy to implement it, if no one else is trying to work on it.

* The image content module should only exist for those targets that are image recipes (things like core-image-minimal). Right now it is also showing for recipes (things like bash or busybox). When you have more than one target that is an image recipe within a build, the image modules should also be sorted in alphabetical order, so they match the navigation and the page heading.
Ok.

* The URL of the number of packages installed is not correct. It is set to /build/image-information-packages.html but it should be set to /build/<build_id>/target/<target_id>
Do you mean 'Packages included'? I believe this html is an unimplemented place holder. If the url is set to /build/<build id>/target/<target id>, this would be the same url  for as for each image title.  Is this correct?

* The label "License manifest² should be a link to the 'Packages included'
tab in the corresponding '1.1 Image information' page, showing the following columns: Package, Package version, License and Recipe (i.e. the information provided by the package manifest file).
Ok, I'm still a bit worried about where the content (anchor text) is coming from.

* In the Configuration information, the layers should be listed in alphabetical order
Ok.

* In the Tasks information, instead of 'Tasks prebuilt' it should say 'Tasks not executed'
I'm not sure what you're referring to: is this the pop-down in the Outcome colume?

* In the Tasks information we are missing the Failed tasks (if there are any). We are also missing the links:

** The number of tasks is a link to the tasks table
** The number of executed tasks is a link to the tasks table with the 'Executed tasks' filter applied
** The number of not executed tasks is a link to the tasks table with the ³Not executed tasks² filter applied
Ok.

* In the Recipes and Packages information, the recipes item should say 'Recipes built'. We are also missing the links:

** The number of recipes should be a link to the recipes table
** The number of packages should be a link to the packages built table
Ok.

* I am not able to collapse the errors module
Hmm... works for me.

* I am not able to expand the warnings module
Ditto - what browser are you using?

* If a build throws no warnings, the warnings module should not display (right now it shows with heading '0 warnings').
Ok.

If you have any questions, let me know.

Cheers

Belén



On 05/03/2014 18:24, "Wymore, Farrell" <Farrell.Wymore@windriver.com>
wrote:

>Dear Belen,
> 
>I have pushed my first request for the build dash board page.
>I have tested for multiple build targets and targets that are not 
>images.
> 
>I¹ve applied Alex¹s patch for the database changes and manually 
>included Amit¹s error and warning  code.
> 
>    fwymore/build-dashboard
> 
>The exceptions for this review are:
>· Waiting for license manifest decision · Waiting for image file table 
>population from Alex · Issue around cached packages installed list We 
>plan to review these in tomorrow¹s call.
> 
>Thanks ­ Farrell
> 
>

Re: toaster: review request for build dash board page

[Reyna, David]

[-- Attachment #1: Type: text/plain, Size: 1680 bytes --]

Hi Amit,

This was just a trial review. We are waiting for your commit to be pushed so that we can properly merge with it, as per my request. In our Wednesday call.

David


From: Amit Kumar Chaudhary [mailto:amit@floatingpondtech.com]
Sent: Thursday, March 06, 2014 03:12 AM
To: Wymore, Farrell; BARROS PENA, BELEN
Cc: toaster@yoctoproject.org <toaster@yoctoproject.org>
Subject: Re: [Toaster] toaster: review request for build dash board page

Hello Farrell,


On 5 March 2014 at 11:54:26 pm, Wymore, Farrell (farrell.wymore@windriver.com<mailto:farrell.wymore@windriver.com>) wrote:
Dear Belen,

I have pushed my first request for the build dash board page.
I have tested for multiple build targets and targets that are
not images.

I’ve applied Alex’s patch for the database changes and
manually included Amit’s error and warning  code.

Thanks for the patch, and including my work. But could you please pick the whole patch with header and everything, rather than merging it manually, because by doing it manually the credits gets left behind, and I would really like them to go with the patch. I would be happy to help in anyway I can with the merging.

Thanks,

—amit


    fwymore/build-dashboard

The exceptions for this review are:

•         Waiting for license manifest decision

•         Waiting for image file table population from Alex

•         Issue around cached packages installed list
We plan to review these in tomorrow’s call.

Thanks – Farrell

_______________________________________________
toaster mailing list
toaster@yoctoproject.org
https://lists.yoctoproject.org/listinfo/toaster

[-- Attachment #2: Type: text/html, Size: 5687 bytes --]

Re: toaster: review request for build dash board page

[Barros Pena, Belen]

Hi Farrell,

Thanks for this. I have a few comments, but I think they should be all
easy to fix. There they go:

* The breadcrumb should not have the last Dashboard item. It is
represented by the build target + machine + completed on time stamp, which
should be the final, not clickable element of the breadcrumb

* If a build has multiple targets, the breadcrumb should only show the
first one (in alphabetical order). For example, I have a build that has 2
targets: core-image-base and core-image-minimal. The breadcrumb for this
build should say: "core-image-base (+1)" but it says "core-image-minimal
(+1)" instead.

* The same with the left navigation, in the Images section targets should
be listed in ascending alphabetical order. For the same build as above, I
have again core-image-minimal displaying above core-image-base. It should
be the other way around.

* The same with the order in the h1.

* Also, the in the h1 target names should be separated by commands.

* The build status notification should say "Completed on" or "Failed on"
before the time stamp. It should only say 'with' if there are errors or
warnings.

* If there are errors and warnings the build status notification should
say 'with # errors and # warnings'. Also, remove the .span2 class from the
<span> tags that contain the number of errors and warnings. That way
things look a bit more like a sentence.

* The link to the build time page is not working. The URL is set to
/build/build-time/ so it is missing the build id:
/build/<build_id>/build-time

* The image content module should only exist for those targets that are
image recipes (things like core-image-minimal). Right now it is also
showing for recipes (things like bash or busybox). When you have more than
one target that is an image recipe within a build, the image modules
should also be sorted in alphabetical order, so they match the navigation
and the page heading.

* The URL of the number of packages installed is not correct. It is set to
/build/image-information-packages.html but it should be set to
/build/<build_id>/target/<target_id>

* The label "License manifest² should be a link to the 'Packages included'
tab in the corresponding '1.1 Image information' page, showing the
following columns: Package, Package version, License and Recipe (i.e. the
information provided by the package manifest file).

* In the Configuration information, the layers should be listed in
alphabetical order

* In the Tasks information, instead of 'Tasks prebuilt' it should say
'Tasks not executed'

* In the Tasks information we are missing the Failed tasks (if there are
any). We are also missing the links:

** The number of tasks is a link to the tasks table
** The number of executed tasks is a link to the tasks table with the
'Executed tasks' filter applied
** The number of not executed tasks is a link to the tasks table with the
³Not executed tasks² filter applied

* In the Recipes and Packages information, the recipes item should say
'Recipes built'. We are also missing the links:

** The number of recipes should be a link to the recipes table
** The number of packages should be a link to the packages built table

* I am not able to collapse the errors module

* I am not able to expand the warnings module

* If a build throws no warnings, the warnings module should not display
(right now it shows with heading '0 warnings').

If you have any questions, let me know.

Cheers

Belén



On 05/03/2014 18:24, "Wymore, Farrell" <Farrell.Wymore@windriver.com>
wrote:

>Dear Belen,
> 
>I have pushed my first request for the build dash board page.
>I have tested for multiple build targets and targets that are
>not images. 
> 
>I¹ve applied Alex¹s patch for the database changes and
>manually included Amit¹s error and warning  code.
> 
>    fwymore/build-dashboard
> 
>The exceptions for this review are:
>· Waiting for license manifest decision
>· Waiting for image file table population from Alex
>· Issue around cached packages installed list
>We plan to review these in tomorrow¹s call.
> 
>Thanks ­ Farrell
> 
>

Re: toaster: review request for build dash board page

[Amit Kumar Chaudhary]

[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]

Hello Farrell,

On 5 March 2014 at 11:54:26 pm, Wymore, Farrell (farrell.wymore@windriver.com) wrote:

Dear Belen,

 

I have pushed my first request for the build dash board page.

I have tested for multiple build targets and targets that are

not images.

 

I’ve applied Alex’s patch for the database changes and

manually included Amit’s error and warning  code.

Thanks for the patch, and including my work. But could you please pick the whole patch with header and everything, rather than merging it manually, because by doing it manually the credits gets left behind, and I would really like them to go with the patch. I would be happy to help in anyway I can with the merging.

Thanks,

—amit


 

    fwymore/build-dashboard

 

The exceptions for this review are:

·         Waiting for license manifest decision

·         Waiting for image file table population from Alex

·         Issue around cached packages installed list

We plan to review these in tomorrow’s call.

 

Thanks – Farrell

 

_______________________________________________ 
toaster mailing list 
toaster@yoctoproject.org 
https://lists.yoctoproject.org/listinfo/toaster 

[-- Attachment #2: Type: text/html, Size: 4627 bytes --]

toaster: review request for build dash board page

[Wymore, Farrell]

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

Dear Belen,

I have pushed my first request for the build dash board page.
I have tested for multiple build targets and targets that are
not images.

I've applied Alex's patch for the database changes and
manually included Amit's error and warning  code.

    fwymore/build-dashboard

The exceptions for this review are:

*         Waiting for license manifest decision

*         Waiting for image file table population from Alex

*         Issue around cached packages installed list
We plan to review these in tomorrow's call.

Thanks - Farrell


[-- Attachment #2: Type: text/html, Size: 6080 bytes --]