V2: review request Bug #5960 "No help text next to the "Apply" button when a filter from a different column is applied to a table."

* V2: review request Bug #5960 "No help text next to the "Apply" button when a filter from a different column is applied to a table."
@ 2014-03-15  5:55 Reyna, David
  2014-03-17 12:59 ` Barros Pena, Belen
  0 siblings, 1 reply; 4+ messages in thread
From: Reyna, David @ 2014-03-15  5:55 UTC (permalink / raw)
  To: BARROS PENA, BELEN, DAMIAN, ALEXANDRU; +Cc: toaster

[-- Attachment #1: Type: text/plain, Size: 2881 bytes --]

Hi Belen,

The review branch is here:  dreyna/second_filter_5960

I will disclose that I lost several hours testing this. I will summarize what I found out:

  * For FireFox 27.0.1 (with Windows 7), the "help-inline" style was strangely limited. If present it provided only an effective "margin-left: 5px" _regardless_ of any other settings, for example for margin, font, or color (those later items were from when I was getting desperate to prove that it was noticed at all).

  * It wasn't until I tried Firefox 26.0 (Ubuntu ) or Safari 5.1.7 (Windows 7), which worked as expected, that I realized that the limitation was due to this particular Firefox (IE 8.0 was totally broken for filter popups, so forget that).

  * I may file a low level bug later just to track this issue. This is the first time with this browser that I have seen a rendering limitation. The only observable artifact is that it is aligned high instead of vertically centered.

- David

      _____________________________________________
      From: Reyna, David
      Sent: Friday, March 14, 2014 12:41 AM
      To: belen.barros.pena@intel.com; Damian, Alexandru (alexandru.damian@intel.com)
      Cc: toaster@yoctoproject.org
      Subject: review request Bug #5960 "No help text next to the "Apply" button when a filter from a different column is applied to a table."

      Hi Belen,

      Here is another review request. This is to add (in the filter pop-up dialog) the message "You can only apply one filter to the table. This filter will override the current filter" when a different filter is currently applied, as per your design document "Filtering the 'All builds' table" page 7.

      The review branch is here:  dreyna/second_filter_5960

      Notes:
        1. Currently the warning string is right-justified, but your design document has it left-justified next to the button. Is that ok? Otherwise, can you tell me how to adjust the CSS for "modal-footer"?

        2. I ended up with a nested IF for the test to show the message , because I could not get Django to accept the two tests in one IF.

      The test is (a) if there is an existing filter string in the session, and (b) the existing filter has a different prefix from this dialog's filter prefix, then show the warning string.

      Here is the code in "filtersnippet.html":
              <div class="modal-footer">
                  <button type="submit" class="btn btn-primary">Apply</button>
                  {% if request.GET.filter %}
                      {% if request.GET.filter|string_remove_regex:':.*' != f.options.0.1|string_remove_regex:':.*' %}
                      You can only apply one filter to the table. This filter will override the current filter.
                      {% endif %}
                  {% endif %}
              </div>

      - David

[-- Attachment #2: Type: text/html, Size: 5872 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread