7414 example for layer 'meta', is it really a layer?

7414 example for layer 'meta', is it really a layer?

[Lerner, Dave]

The 7414 bug states:
"
For example, instead of 
  /home/user/_poky_master.toaster_cloned/meta/conf/bitbake.conf
only
  meta/conf/bitbake.conf
"

So for example for a 'Yocto Project master' project selection with 5 layers 
* the 3 default: oe-embedded, meta-yocto, meta-yocto-bsp 
* and two added: meta-oe and meta-games, 
then for variable "COMBINED_FEATURES", the path is exactly as in your example, but there is no layer named 'meta' is not in the layer table.  

Is 'meta' a layer that is 'built-in'?

I'm using a string matching algorithm on the directory name to locate the layer in a local path string, layer name length >=4, matching either '/' + layer name or '/_' + layer name, with the layer names sorted descending so that longest layer names match first.

Dave

Re: 7414 example for layer 'meta', is it really a layer?

[Barros Pena, Belen]

On 11/03/2015 22:07, "Lerner, Dave" <dave.lerner@windriver.com> wrote:

>The 7414 bug states:
>"
>For example, instead of
>  /home/user/_poky_master.toaster_cloned/meta/conf/bitbake.conf
>only
>  meta/conf/bitbake.conf
>"
>
>So for example for a 'Yocto Project master' project selection with 5
>layers 
>* the 3 default: oe-embedded, meta-yocto, meta-yocto-bsp
>* and two added: meta-oe and meta-games,
>then for variable "COMBINED_FEATURES", the path is exactly as in your
>example, but there is no layer named 'meta' is not in the layer table.
>
>Is 'meta' a layer that is 'built-in'?

Meta is pretty much openembedded-core. I've asked Paul Eggleton why the
openembedded-core layer is called 'meta' inside the poky repository, and
it is one of those "historical" things. Not much we can do about it at the
moment, I'm afraid.

Cheers

Belén

>
>I'm using a string matching algorithm on the directory name to locate the
>layer in a local path string, layer name length >=4, matching either '/'
>+ layer name or '/_' + layer name, with the layer names sorted descending
>so that longest layer names match first.
>
>Dave

Re: 7414 example for layer 'meta', is it really a layer?

[Lerner, Dave]

> -----Original Message-----
> From: Barros Pena, Belen [mailto:belen.barros.pena@intel.com]
> Sent: Thursday, March 12, 2015 5:08 AM
> To: Lerner, Dave; DAMIAN, ALEXANDRU
> Cc: toaster@yoctoproject.org
> Subject: Re: 7414 example for layer 'meta', is it really a layer?
> 
> 
> On 11/03/2015 22:07, "Lerner, Dave" <dave.lerner@windriver.com> wrote:
> 
> >The 7414 bug states:
> >"
> >For example, instead of
> >  /home/user/_poky_master.toaster_cloned/meta/conf/bitbake.conf
> >only
> >  meta/conf/bitbake.conf
> >"
> >
> >So for example for a 'Yocto Project master' project selection with 5
> >layers
> >* the 3 default: oe-embedded, meta-yocto, meta-yocto-bsp
> >* and two added: meta-oe and meta-games,
> >then for variable "COMBINED_FEATURES", the path is exactly as in your
> >example, but there is no layer named 'meta' is not in the layer table.
> >
> >Is 'meta' a layer that is 'built-in'?
> 
> Meta is pretty much openembedded-core. I've asked Paul Eggleton why the
> openembedded-core layer is called 'meta' inside the poky repository, and
> it is one of those "historical" things. Not much we can do about it at the
> moment, I'm afraid.
> 
> Cheers
> 
> Belén

I fixed this by adding 'meta' to the end of the list of project-specific layers names. 'meta' becomes a 'built-in' layer and is only used as a match candidate if none of the project-specific layer names match.  It looks good.  Working on the review-request for AM UTC-6:00.

Dave


> 
> >
> >I'm using a string matching algorithm on the directory name to locate the
> >layer in a local path string, layer name length >=4, matching either '/'
> >+ layer name or '/_' + layer name, with the layer names sorted descending
> >so that longest layer names match first.
> >
> >Dave
> 

Re: 7414 example for layer 'meta', is it really a layer?

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 2490 bytes --]

Ufff, I've just seen this email now.

We do have a matching algorithm in - buildinfohelper.py.

The idea is that, if we control the build, we already know where the
sources are checked out (bc.be.sourcedir), and what is the layer directory
name (bc.getGitCloneDirectory(brl.giturl, brl.commit), so we can match the
layer.

On the latest submission, for _recipes_, we already logging only the short
path (i.e. relative to the layer) !

Hope this helps,
Alex


 707             # Heuristics: we match the path to where the layers have
been checked out
 708             for brl in sorted(BuildRequest.objects.get(pk =
br_id).brlayer_set.all(), reverse = True, key = _slkey_managed):
 709                 localdirname =
os.path.join(bc.getGitCloneDirectory(brl.giturl, brl.commit), brl.dirpath)
 710                 # we get a relative path, unless running in HEAD mode
where the path is absolute
 711                 if not localdirname.startswith("/"):
 712                     localdirname = os.path.join(bc.be.sourcedir,
localdirname)
 713                 if path.startswith(localdirname):
 714                     #logger.warn("-- managed: matched path %s with
layer %s " % (path, localdirname))
 715                     # we matched the BRLayer, but we need the
layer_version that generated this br
 716                     for lvo in self.orm_wrapper.layer_version_objects:
 717                         if brl.name == lvo.layer.name:
 718                             return lvo



On Wed, Mar 11, 2015 at 10:07 PM, Lerner, Dave <dave.lerner@windriver.com>
wrote:

> The 7414 bug states:
> "
> For example, instead of
>   /home/user/_poky_master.toaster_cloned/meta/conf/bitbake.conf
> only
>   meta/conf/bitbake.conf
> "
>
> So for example for a 'Yocto Project master' project selection with 5 layers
> * the 3 default: oe-embedded, meta-yocto, meta-yocto-bsp
> * and two added: meta-oe and meta-games,
> then for variable "COMBINED_FEATURES", the path is exactly as in your
> example, but there is no layer named 'meta' is not in the layer table.
>
> Is 'meta' a layer that is 'built-in'?
>
> I'm using a string matching algorithm on the directory name to locate the
> layer in a local path string, layer name length >=4, matching either '/' +
> layer name or '/_' + layer name, with the layer names sorted descending so
> that longest layer names match first.
>
> Dave
>



-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 3974 bytes --]