From: Yash Shah <yash.shah@sifive.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Palmer Dabbelt <palmer@sifive.com>,
linux-pwm@vger.kernel.org, linux-riscv@lists.infradead.org,
Thierry Reding <thierry.reding@gmail.com>,
robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Sachin Ghadi <sachin.ghadi@sifive.com>,
Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH v8 0/2] PWM support for HiFive Unleashed
Date: Tue, 5 Mar 2019 13:55:41 +0530 [thread overview]
Message-ID: <CAJ2_jOE=8_c6aN2FTQVt0wTpBAkL8BYyF3UFaMmqdvWYWAAmvg@mail.gmail.com> (raw)
In-Reply-To: <mvmfts228vu.fsf@suse.de>
On Mon, Mar 4, 2019 at 4:39 PM Andreas Schwab <schwab@suse.de> wrote:
>
> On Mär 01 2019, Yash Shah <yash.shah@sifive.com> wrote:
>
> > This patch series adds a PWM driver and DT documentation
> > for HiFive Unleashed board. The patches are mostly based on
> > Wesley's patch.
>
> That doesn't appear to work with the heartbeat trigger, the led doesn't
> flash.
Make sure you modify the DTS file since with this patch the period is
now passed through the conventional way.
Example:
pwmleds {
compatible = "pwm-leds";
heartbeat {
pwms = <&L45 0 100000 0>;
max-brightness = <255>;
linux,default-trigger = "heartbeat";
};
};
I have tested the heartbeat trigger on HiFive Unleashed board and it's
working with this PWM patch.
>
> Andreas.
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."
WARNING: multiple messages have this Message-ID (diff)
From: Yash Shah <yash.shah@sifive.com>
To: Andreas Schwab <schwab@suse.de>
Cc: mark.rutland@arm.com, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, Palmer Dabbelt <palmer@sifive.com>,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
Sachin Ghadi <sachin.ghadi@sifive.com>,
Thierry Reding <thierry.reding@gmail.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v8 0/2] PWM support for HiFive Unleashed
Date: Tue, 5 Mar 2019 13:55:41 +0530 [thread overview]
Message-ID: <CAJ2_jOE=8_c6aN2FTQVt0wTpBAkL8BYyF3UFaMmqdvWYWAAmvg@mail.gmail.com> (raw)
In-Reply-To: <mvmfts228vu.fsf@suse.de>
On Mon, Mar 4, 2019 at 4:39 PM Andreas Schwab <schwab@suse.de> wrote:
>
> On Mär 01 2019, Yash Shah <yash.shah@sifive.com> wrote:
>
> > This patch series adds a PWM driver and DT documentation
> > for HiFive Unleashed board. The patches are mostly based on
> > Wesley's patch.
>
> That doesn't appear to work with the heartbeat trigger, the led doesn't
> flash.
Make sure you modify the DTS file since with this patch the period is
now passed through the conventional way.
Example:
pwmleds {
compatible = "pwm-leds";
heartbeat {
pwms = <&L45 0 100000 0>;
max-brightness = <255>;
linux,default-trigger = "heartbeat";
};
};
I have tested the heartbeat trigger on HiFive Unleashed board and it's
working with this PWM patch.
>
> Andreas.
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-03-05 8:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 10:53 [PATCH v8 0/2] PWM support for HiFive Unleashed Yash Shah
2019-03-01 10:53 ` Yash Shah
2019-03-01 10:53 ` [PATCH v8 1/2] pwm: sifive: Add DT documentation for SiFive PWM Controller Yash Shah
2019-03-01 10:53 ` Yash Shah
2019-03-01 10:53 ` Yash Shah
2019-03-01 10:53 ` [PATCH v8 2/2] pwm: sifive: Add a driver for SiFive SoC PWM Yash Shah
2019-03-01 10:53 ` Yash Shah
2019-03-07 15:27 ` Uwe Kleine-König
2019-03-07 15:27 ` Uwe Kleine-König
2019-03-08 11:29 ` Yash Shah
2019-03-08 11:29 ` Yash Shah
2019-03-08 11:57 ` Uwe Kleine-König
2019-03-08 11:57 ` Uwe Kleine-König
2019-03-11 11:40 ` Yash Shah
2019-03-11 11:40 ` Yash Shah
2019-03-11 13:29 ` Uwe Kleine-König
2019-03-11 13:29 ` Uwe Kleine-König
2019-03-12 6:52 ` Yash Shah
2019-03-12 6:52 ` Yash Shah
2019-03-04 11:09 ` [PATCH v8 0/2] PWM support for HiFive Unleashed Andreas Schwab
2019-03-04 11:09 ` Andreas Schwab
2019-03-05 8:25 ` Yash Shah [this message]
2019-03-05 8:25 ` Yash Shah
2019-03-05 8:32 ` Andreas Schwab
2019-03-05 8:32 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ2_jOE=8_c6aN2FTQVt0wTpBAkL8BYyF3UFaMmqdvWYWAAmvg@mail.gmail.com' \
--to=yash.shah@sifive.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sachin.ghadi@sifive.com \
--cc=schwab@suse.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.