All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yash Shah <yash.shah@sifive.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Palmer Dabbelt <palmer@sifive.com>,
	linux-pwm@vger.kernel.org, linux-riscv@lists.infradead.org,
	Thierry Reding <thierry.reding@gmail.com>,
	robh+dt@kernel.org, mark.rutland@arm.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Sachin Ghadi <sachin.ghadi@sifive.com>,
	Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH v11 0/2] PWM support for HiFive Unleashed
Date: Thu, 2 May 2019 09:31:16 +0530	[thread overview]
Message-ID: <CAJ2_jOFu-yCZV_A4B48_fLq7h7UA6LUWhgpxr0uuh7vhW9Q8pA@mail.gmail.com> (raw)
In-Reply-To: <mvmpnqcsn6u.fsf@suse.de>

Hi Andreas,

On Wed, Mar 27, 2019 at 2:34 PM Andreas Schwab <schwab@suse.de> wrote:
>
> I have now found out that the ledtrig modules don't load automatically.
> I would have expected that the linux,default-trigger entries would cause
> the load of the corresponding ledtrig modules.
>
> But there is another problem, that the leds are on by default.
> Shouldn't they be off by default?

The PWM default output state is high (When duty cycle is 0), So I
guess leds will remain on by default.

Are you able to test the PWM driver at your end? or you still facing
some issues?

>
> Andreas.
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."

WARNING: multiple messages have this Message-ID (diff)
From: Yash Shah <yash.shah@sifive.com>
To: Andreas Schwab <schwab@suse.de>
Cc: mark.rutland@arm.com, linux-pwm@vger.kernel.org,
	devicetree@vger.kernel.org, Palmer Dabbelt <palmer@sifive.com>,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	Sachin Ghadi <sachin.ghadi@sifive.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH v11 0/2] PWM support for HiFive Unleashed
Date: Thu, 2 May 2019 09:31:16 +0530	[thread overview]
Message-ID: <CAJ2_jOFu-yCZV_A4B48_fLq7h7UA6LUWhgpxr0uuh7vhW9Q8pA@mail.gmail.com> (raw)
In-Reply-To: <mvmpnqcsn6u.fsf@suse.de>

Hi Andreas,

On Wed, Mar 27, 2019 at 2:34 PM Andreas Schwab <schwab@suse.de> wrote:
>
> I have now found out that the ledtrig modules don't load automatically.
> I would have expected that the linux,default-trigger entries would cause
> the load of the corresponding ledtrig modules.
>
> But there is another problem, that the leds are on by default.
> Shouldn't they be off by default?

The PWM default output state is high (When duty cycle is 0), So I
guess leds will remain on by default.

Are you able to test the PWM driver at your end? or you still facing
some issues?

>
> Andreas.
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2019-05-02  4:01 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-25 10:12 [PATCH v11 0/2] PWM support for HiFive Unleashed Yash Shah
2019-03-25 10:12 ` Yash Shah
2019-03-25 10:12 ` [PATCH v11 1/2] pwm: sifive: Add DT documentation for SiFive PWM Controller Yash Shah
2019-03-25 10:12   ` Yash Shah
2019-03-25 10:12 ` [PATCH v11 2/2] pwm: sifive: Add a driver for SiFive SoC PWM Yash Shah
2019-03-25 10:12   ` Yash Shah
2019-03-25 15:54 ` [PATCH v11 0/2] PWM support for HiFive Unleashed Andreas Schwab
2019-03-25 15:54   ` Andreas Schwab
2019-03-26  6:45   ` Yash Shah
2019-03-26  6:45     ` Yash Shah
2019-03-26  8:44     ` Andreas Schwab
2019-03-26  8:44       ` Andreas Schwab
2019-03-27  9:04   ` Andreas Schwab
2019-03-27  9:04     ` Andreas Schwab
2019-05-02  4:01     ` Yash Shah [this message]
2019-05-02  4:01       ` Yash Shah
2019-05-07  9:39       ` Andreas Schwab
2019-05-07  9:39         ` Andreas Schwab
2019-05-07 11:01         ` Yash Shah
2019-05-07 11:01           ` Yash Shah
2019-05-07 11:01           ` Yash Shah
2019-05-07 16:27           ` Andreas Schwab
2019-05-07 16:27             ` Andreas Schwab
2019-04-15  6:06 ` Yash Shah
2019-04-15  6:06   ` Yash Shah
2019-04-15  6:06   ` Yash Shah
2019-04-29 15:27   ` Uwe Kleine-König
2019-04-29 15:27     ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ2_jOFu-yCZV_A4B48_fLq7h7UA6LUWhgpxr0uuh7vhW9Q8pA@mail.gmail.com \
    --to=yash.shah@sifive.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=palmer@sifive.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh+dt@kernel.org \
    --cc=sachin.ghadi@sifive.com \
    --cc=schwab@suse.de \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.