From: Or Gerlitz <gerlitz.or@gmail.com>
To: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/5] net/mlx5e: Make the log friendly when decapsulation offload not supported
Date: Sun, 24 Feb 2019 11:23:42 +0200 [thread overview]
Message-ID: <CAJ3xEMg8_sFBsm_NXFsd=J02KncYENfiKUWPNHW2zgvKy9GKzA@mail.gmail.com> (raw)
In-Reply-To: <CAMDZJNVXUxaJp_oFOWV4=k4n+4tAM68eP84hsoNkTOb_y+1wVg@mail.gmail.com>
On Sat, Feb 23, 2019 at 9:58 AM Tonghao Zhang <xiangxia.m.yue@gmail.com> wrote:
> On Fri, Feb 22, 2019 at 5:07 PM Or Gerlitz <gerlitz.or@gmail.com> wrote:
> > On Fri, Feb 22, 2019 at 9:49 AM Tonghao Zhang <xiangxia.m.yue@gmail.com> wrote:
> > > On Fri, Feb 22, 2019 at 12:32 AM Or Gerlitz <gerlitz.or@gmail.com> wrote:
> > > > On Thu, Feb 21, 2019 at 3:42 PM <xiangxia.m.yue@gmail.com> wrote:
> > > > >
> > > > > From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> > > > >
> > > > > If we try to offload decapsulation actions to VFs hw, we get the log [1].
> > > >
> > > > but the switching was on the tunnel type (if (tunnel_type == [...]) -
> > > Yes, but we try to offload tc flow to VF device. For example
> > > the p2p1_0 is VF, but not rep
>> so this should go to the nic and not esw tc offload code path in en_tc.c
> nic and esw will call parse_cls_flower() to parse the flower flows,
> and more information is shown as below.
ok, got you. We err on the match parsing stage, this is relatively
new.. up to 5.0
we were erring only on the action parsing stage. The patch seems fine, it would
be good to modify mlx5e_netdev_kind() to return "unkown" and not the
empty string
("") when the netdev doesn't have a kind assigned (can do this in this patch).
next prev parent reply other threads:[~2019-02-24 9:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 2:14 [PATCH net-next 1/5] net/mlx5e: Return -EOPNOTSUPP when modify header action zero xiangxia.m.yue
2019-02-21 2:14 ` [PATCH net-next 2/5] net/mlx5e: Make the log friendly when decapsulation offload not supported xiangxia.m.yue
2019-02-21 16:31 ` Or Gerlitz
2019-02-22 7:48 ` Tonghao Zhang
2019-02-22 9:06 ` Or Gerlitz
2019-02-23 7:58 ` Tonghao Zhang
2019-02-24 9:23 ` Or Gerlitz [this message]
2019-02-21 2:14 ` [PATCH net-next 3/5] net/mlx5e: Remove 'parse_attr' argument in parse_tc_fdb_actions() xiangxia.m.yue
2019-02-21 2:14 ` [PATCH net-next 4/5] net/mlx5e: Deletes unnecessary setting of esw_attr->parse_attr xiangxia.m.yue
2019-02-21 2:14 ` [PATCH net-next 5/5] net/mlx5e: Support enable/disable VFs link state on switchdev mode xiangxia.m.yue
2019-02-21 17:03 ` Or Gerlitz
2019-02-22 7:49 ` Tonghao Zhang
2019-02-21 16:26 ` [PATCH net-next 1/5] net/mlx5e: Return -EOPNOTSUPP when modify header action zero Or Gerlitz
2019-02-22 7:39 ` Tonghao Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ3xEMg8_sFBsm_NXFsd=J02KncYENfiKUWPNHW2zgvKy9GKzA@mail.gmail.com' \
--to=gerlitz.or@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=xiangxia.m.yue@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.