From: Or Gerlitz <gerlitz.or@gmail.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Boris Pismenny <borisp@mellanox.com>,
David Ahern <dsahern@gmail.com>, Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>,
Saeed Mahameed <saeedm@nvidia.com>,
Christoph Hellwig <hch@lst.de>,
axboe@fb.com, Keith Busch <kbusch@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Eric Dumazet <edumazet@google.com>,
smalin@marvell.com, Yoray Zack <yorayz@mellanox.com>,
yorayz@nvidia.com, boris.pismenny@gmail.com,
Ben Ben-Ishay <benishay@mellanox.com>,
benishay@nvidia.com, linux-nvme@lists.infradead.org,
Linux Netdev List <netdev@vger.kernel.org>,
Or Gerlitz <ogerlitz@mellanox.com>,
Or Gerlitz <ogerlitz@nvidia.com>
Subject: Re: [PATCH v3 net-next 08/21] nvme-tcp : Recalculate crc in the end of the capsule
Date: Thu, 4 Feb 2021 20:36:31 +0200 [thread overview]
Message-ID: <CAJ3xEMhSxrjLfDvfzVRCLb27K4KmRh-KHQaKxvDF_6VDbNN8Jw@mail.gmail.com> (raw)
In-Reply-To: <a104a5d1-b4cb-4275-6ced-b80f911b6f47@grimberg.me>
On Wed, Feb 3, 2021 at 11:12 AM Sagi Grimberg <sagi@grimberg.me> wrote:
> > @@ -1841,8 +1913,10 @@ static void __nvme_tcp_stop_queue(struct nvme_tcp_queue *queue)
> > nvme_tcp_restore_sock_calls(queue);
> > cancel_work_sync(&queue->io_work);
> >
> > - if (test_bit(NVME_TCP_Q_OFF_DDP, &queue->flags))
> > + if (test_bit(NVME_TCP_Q_OFF_DDP, &queue->flags) ||
> > + test_bit(NVME_TCP_Q_OFF_DDGST_RX, &queue->flags))
> > nvme_tcp_unoffload_socket(queue);
> > +
>
> extra newline
will remove
> > }
> >
> > static void nvme_tcp_stop_queue(struct nvme_ctrl *nctrl, int qid)
> > @@ -1970,8 +2044,6 @@ static int nvme_tcp_alloc_admin_queue(struct nvme_ctrl *ctrl)
> > {
> > int ret;
> >
> > - to_tcp_ctrl(ctrl)->offloading_netdev = NULL;
> > -
>
> Unclear what is the intent here.
yep, unclear indeed.. will look and probably remove
as for your other comment on this patch, will get back to you later on
> > ret = nvme_tcp_alloc_queue(ctrl, 0, NVME_AQ_DEPTH);
> > if (ret)
> > return ret;
WARNING: multiple messages have this Message-ID (diff)
From: Or Gerlitz <gerlitz.or@gmail.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: smalin@marvell.com, linux-nvme@lists.infradead.org,
Boris Pismenny <borisp@mellanox.com>,
yorayz@nvidia.com, boris.pismenny@gmail.com,
Ben Ben-Ishay <benishay@mellanox.com>,
Yoray Zack <yorayz@mellanox.com>,
benishay@nvidia.com, David Miller <davem@davemloft.net>,
axboe@fb.com, Eric Dumazet <edumazet@google.com>,
Linux Netdev List <netdev@vger.kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
David Ahern <dsahern@gmail.com>, Keith Busch <kbusch@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Or Gerlitz <ogerlitz@mellanox.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Christoph Hellwig <hch@lst.de>, Or Gerlitz <ogerlitz@nvidia.com>
Subject: Re: [PATCH v3 net-next 08/21] nvme-tcp : Recalculate crc in the end of the capsule
Date: Thu, 4 Feb 2021 20:36:31 +0200 [thread overview]
Message-ID: <CAJ3xEMhSxrjLfDvfzVRCLb27K4KmRh-KHQaKxvDF_6VDbNN8Jw@mail.gmail.com> (raw)
In-Reply-To: <a104a5d1-b4cb-4275-6ced-b80f911b6f47@grimberg.me>
On Wed, Feb 3, 2021 at 11:12 AM Sagi Grimberg <sagi@grimberg.me> wrote:
> > @@ -1841,8 +1913,10 @@ static void __nvme_tcp_stop_queue(struct nvme_tcp_queue *queue)
> > nvme_tcp_restore_sock_calls(queue);
> > cancel_work_sync(&queue->io_work);
> >
> > - if (test_bit(NVME_TCP_Q_OFF_DDP, &queue->flags))
> > + if (test_bit(NVME_TCP_Q_OFF_DDP, &queue->flags) ||
> > + test_bit(NVME_TCP_Q_OFF_DDGST_RX, &queue->flags))
> > nvme_tcp_unoffload_socket(queue);
> > +
>
> extra newline
will remove
> > }
> >
> > static void nvme_tcp_stop_queue(struct nvme_ctrl *nctrl, int qid)
> > @@ -1970,8 +2044,6 @@ static int nvme_tcp_alloc_admin_queue(struct nvme_ctrl *ctrl)
> > {
> > int ret;
> >
> > - to_tcp_ctrl(ctrl)->offloading_netdev = NULL;
> > -
>
> Unclear what is the intent here.
yep, unclear indeed.. will look and probably remove
as for your other comment on this patch, will get back to you later on
> > ret = nvme_tcp_alloc_queue(ctrl, 0, NVME_AQ_DEPTH);
> > if (ret)
> > return ret;
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-02-04 19:14 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 10:04 [PATCH v3 net-next 00/21] nvme-tcp receive offloads Boris Pismenny
2021-02-01 10:04 ` Boris Pismenny
2021-02-01 10:04 ` [PATCH v3 net-next 01/21] iov_iter: Introduce new procedures for copy to iter/pages Boris Pismenny
2021-02-01 10:04 ` Boris Pismenny
2021-02-01 17:35 ` Christoph Hellwig
2021-02-01 17:35 ` Christoph Hellwig
2021-02-02 18:00 ` Or Gerlitz
2021-02-02 18:00 ` Or Gerlitz
2021-02-03 16:56 ` Christoph Hellwig
2021-02-03 16:56 ` Christoph Hellwig
2021-02-03 19:34 ` Ira Weiny
2021-02-03 19:34 ` Ira Weiny
2021-02-07 14:13 ` Boris Pismenny
2021-02-07 14:13 ` Boris Pismenny
2021-02-07 14:24 ` Boris Pismenny
2021-02-07 14:24 ` Boris Pismenny
2021-02-01 10:04 ` [PATCH v3 net-next 02/21] net: Introduce direct data placement tcp offload Boris Pismenny
2021-02-01 10:04 ` Boris Pismenny
2021-02-02 10:06 ` Tom Parkin
2021-02-02 10:06 ` Tom Parkin
2021-02-01 10:04 ` [PATCH v3 net-next 03/21] net: Introduce crc offload for tcp ddp ulp Boris Pismenny
2021-02-01 10:04 ` Boris Pismenny
2021-02-01 10:04 ` [PATCH v3 net-next 04/21] net: SKB copy(+hash) iterators for DDP offloads Boris Pismenny
2021-02-01 10:04 ` Boris Pismenny
2021-02-01 10:04 ` [PATCH v3 net-next 05/21] net/tls: expose get_netdev_for_sock Boris Pismenny
2021-02-01 10:04 ` Boris Pismenny
2021-02-01 10:04 ` [PATCH v3 net-next 06/21] nvme-tcp: Add DDP offload control path Boris Pismenny
2021-02-01 10:04 ` Boris Pismenny
2021-02-01 17:37 ` Christoph Hellwig
2021-02-01 17:37 ` Christoph Hellwig
2021-02-02 18:09 ` Or Gerlitz
2021-02-02 18:09 ` Or Gerlitz
2021-02-03 9:17 ` Sagi Grimberg
2021-02-03 9:17 ` Sagi Grimberg
2021-02-01 10:04 ` [PATCH v3 net-next 07/21] nvme-tcp: Add DDP data-path Boris Pismenny
2021-02-01 10:04 ` Boris Pismenny
2021-02-01 17:37 ` Christoph Hellwig
2021-02-01 17:37 ` Christoph Hellwig
2021-02-02 18:14 ` Or Gerlitz
2021-02-02 18:14 ` Or Gerlitz
2021-02-03 8:56 ` Sagi Grimberg
2021-02-03 8:56 ` Sagi Grimberg
2021-02-03 10:02 ` Christoph Hellwig
2021-02-03 10:02 ` Christoph Hellwig
2021-02-03 10:21 ` Sagi Grimberg
2021-02-03 10:21 ` Sagi Grimberg
2021-02-03 8:51 ` Sagi Grimberg
2021-02-03 8:51 ` Sagi Grimberg
2021-02-04 19:20 ` Or Gerlitz
2021-02-04 19:20 ` Or Gerlitz
2021-02-01 10:04 ` [PATCH v3 net-next 08/21] nvme-tcp : Recalculate crc in the end of the capsule Boris Pismenny
2021-02-01 10:04 ` Boris Pismenny
2021-02-03 9:06 ` Sagi Grimberg
2021-02-03 9:06 ` Sagi Grimberg
2021-02-04 18:36 ` Or Gerlitz [this message]
2021-02-04 18:36 ` Or Gerlitz
2021-02-07 16:40 ` Or Gerlitz
2021-02-07 16:40 ` Or Gerlitz
2021-02-01 10:04 ` [PATCH v3 net-next 09/21] nvme-tcp: Deal with netdevice DOWN events Boris Pismenny
2021-02-01 10:04 ` Boris Pismenny
2021-02-03 9:09 ` Sagi Grimberg
2021-02-03 9:09 ` Sagi Grimberg
2021-02-04 18:29 ` Or Gerlitz
2021-02-04 18:29 ` Or Gerlitz
2021-02-01 10:04 ` [PATCH v3 net-next 10/21] net/mlx5: Header file changes for nvme-tcp offload Boris Pismenny
2021-02-01 10:04 ` Boris Pismenny
2021-02-01 10:04 ` [PATCH v3 net-next 11/21] net/mlx5: Add 128B CQE for NVMEoTCP offload Boris Pismenny
2021-02-01 10:04 ` Boris Pismenny
2021-02-01 10:05 ` [PATCH v3 net-next 12/21] net/mlx5e: TCP flow steering for nvme-tcp Boris Pismenny
2021-02-01 10:05 ` Boris Pismenny
2021-02-01 10:05 ` [PATCH v3 net-next 13/21] net/mlx5e: NVMEoTCP offload initialization Boris Pismenny
2021-02-01 10:05 ` Boris Pismenny
2021-02-01 10:05 ` [PATCH v3 net-next 14/21] net/mlx5e: KLM UMR helper macros Boris Pismenny
2021-02-01 10:05 ` Boris Pismenny
2021-02-01 10:05 ` [PATCH v3 net-next 15/21] net/mlx5e: NVMEoTCP use KLM UMRs Boris Pismenny
2021-02-01 10:05 ` Boris Pismenny
2021-02-01 10:05 ` [PATCH v3 net-next 16/21] net/mlx5e: NVMEoTCP queue init/teardown Boris Pismenny
2021-02-01 10:05 ` Boris Pismenny
2021-02-01 10:05 ` [PATCH v3 net-next 17/21] net/mlx5e: NVMEoTCP async ddp invalidation Boris Pismenny
2021-02-01 10:05 ` Boris Pismenny
2021-02-01 10:05 ` [PATCH v3 net-next 18/21] net/mlx5e: NVMEoTCP ddp setup and resync Boris Pismenny
2021-02-01 10:05 ` Boris Pismenny
2021-02-01 10:05 ` [PATCH v3 net-next 19/21] net/mlx5e: NVMEoTCP, data-path for DDP+CRC offload Boris Pismenny
2021-02-01 10:05 ` Boris Pismenny
2021-02-01 10:05 ` [PATCH v3 net-next 20/21] net/mlx5e: NVMEoTCP statistics Boris Pismenny
2021-02-01 10:05 ` Boris Pismenny
2021-02-01 10:05 ` [PATCH v3 net-next 21/21] Documentation: add TCP DDP offload documentation Boris Pismenny
2021-02-01 10:05 ` Boris Pismenny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ3xEMhSxrjLfDvfzVRCLb27K4KmRh-KHQaKxvDF_6VDbNN8Jw@mail.gmail.com \
--to=gerlitz.or@gmail.com \
--cc=axboe@fb.com \
--cc=benishay@mellanox.com \
--cc=benishay@nvidia.com \
--cc=boris.pismenny@gmail.com \
--cc=borisp@mellanox.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=ogerlitz@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=sagi@grimberg.me \
--cc=smalin@marvell.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yorayz@mellanox.com \
--cc=yorayz@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.