All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/openrc: needs kmod
@ 2020-02-28 20:25 Yann E. MORIN
  2020-02-28 21:47 ` Carlos Santos
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Yann E. MORIN @ 2020-02-28 20:25 UTC (permalink / raw)
  To: buildroot

openrc provides scritps that have been written for the big-gun kmod, and
so use options unknown to the biusybox' provided applets:

  - Busybox modprobe does not have a "--first-time" option,
  - the "--verbose" option is just "-v",
  - the "--use-blacklist" option is just "-b". Also blacklist support is
    not selected in our default busybox configuration.

One of two options, is to "fix" or "adapt" openrc's scripts to busybox,
which means for the openrc package to go peek into files from the
busybox package, which is not nice, and can't work because that is not
available by the time we scan our Makefiles.

The other option, which this patch implements, is to just add a
dependency onto kmod and its tools.

Reported-by: Carlos Santos <unixmania@gmail.com>
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Peter Korsgaard <peter@korsgaard.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/openrc/Config.in | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/openrc/Config.in b/package/openrc/Config.in
index 796858f404..4691be63a2 100644
--- a/package/openrc/Config.in
+++ b/package/openrc/Config.in
@@ -3,6 +3,9 @@ config BR2_PACKAGE_OPENRC
 	depends on BR2_USE_MMU # fork()
 	depends on !BR2_STATIC_LIBS
 	depends on BR2_INIT_OPENRC
+	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # kmod tools
+	select BR2_PACKAGE_KMOD # runtime
+	select BR2_PACKAGE_KMOD_TOOLS # runtime
 	select BR2_PACKAGE_NCURSES
 	help
 	  Init that works on top of pid 1 (for example
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/openrc: needs kmod
  2020-02-28 20:25 [Buildroot] [PATCH] package/openrc: needs kmod Yann E. MORIN
@ 2020-02-28 21:47 ` Carlos Santos
  2020-02-29  9:38   ` Yann E. MORIN
  2020-02-29 16:45 ` Peter Korsgaard
  2020-03-14 17:51 ` Peter Korsgaard
  2 siblings, 1 reply; 6+ messages in thread
From: Carlos Santos @ 2020-02-28 21:47 UTC (permalink / raw)
  To: buildroot

On Fri, Feb 28, 2020 at 5:26 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> openrc provides scritps that have been written for the big-gun kmod, and
> so use options unknown to the biusybox' provided applets:
>
>   - Busybox modprobe does not have a "--first-time" option,
>   - the "--verbose" option is just "-v",
>   - the "--use-blacklist" option is just "-b". Also blacklist support is
>     not selected in our default busybox configuration.
>
> One of two options, is to "fix" or "adapt" openrc's scripts to busybox,
> which means for the openrc package to go peek into files from the
> busybox package, which is not nice, and can't work because that is not
> available by the time we scan our Makefiles.
>
> The other option, which this patch implements, is to just add a
> dependency onto kmod and its tools.
>
> Reported-by: Carlos Santos <unixmania@gmail.com>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Peter Korsgaard <peter@korsgaard.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  package/openrc/Config.in | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/package/openrc/Config.in b/package/openrc/Config.in
> index 796858f404..4691be63a2 100644
> --- a/package/openrc/Config.in
> +++ b/package/openrc/Config.in
> @@ -3,6 +3,9 @@ config BR2_PACKAGE_OPENRC
>         depends on BR2_USE_MMU # fork()
>         depends on !BR2_STATIC_LIBS
>         depends on BR2_INIT_OPENRC
> +       select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # kmod tools
> +       select BR2_PACKAGE_KMOD # runtime
> +       select BR2_PACKAGE_KMOD_TOOLS # runtime
>         select BR2_PACKAGE_NCURSES
>         help
>           Init that works on top of pid 1 (for example
> --
> 2.20.1
>

What about doing the opposite?

1. Always patch openrc to support busybox.' modprobe.
2. In busybox, select modprobe+blacklist if openrc is selected but
kmod tools are not selected.

This would be cleaner and seems to be reasonable, since busybox
already sets several configurations based on the selection of other
packages.

-- 
Carlos Santos <unixmania@gmail.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/openrc: needs kmod
  2020-02-28 21:47 ` Carlos Santos
@ 2020-02-29  9:38   ` Yann E. MORIN
  2020-02-29 12:13     ` Carlos Santos
  0 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2020-02-29  9:38 UTC (permalink / raw)
  To: buildroot

On 2020-02-28 18:47 -0300, Carlos Santos spake thusly:
> On Fri, Feb 28, 2020 at 5:26 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> >
> > openrc provides scritps that have been written for the big-gun kmod, and
> > so use options unknown to the biusybox' provided applets:
> >
> >   - Busybox modprobe does not have a "--first-time" option,
> >   - the "--verbose" option is just "-v",
> >   - the "--use-blacklist" option is just "-b". Also blacklist support is
> >     not selected in our default busybox configuration.
> >
> > One of two options, is to "fix" or "adapt" openrc's scripts to busybox,
> > which means for the openrc package to go peek into files from the
> > busybox package, which is not nice, and can't work because that is not
> > available by the time we scan our Makefiles.
> >
> > The other option, which this patch implements, is to just add a
> > dependency onto kmod and its tools.
> >
> > Reported-by: Carlos Santos <unixmania@gmail.com>
> > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> > Cc: Peter Korsgaard <peter@korsgaard.com>
> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> > ---
> >  package/openrc/Config.in | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/package/openrc/Config.in b/package/openrc/Config.in
> > index 796858f404..4691be63a2 100644
> > --- a/package/openrc/Config.in
> > +++ b/package/openrc/Config.in
> > @@ -3,6 +3,9 @@ config BR2_PACKAGE_OPENRC
> >         depends on BR2_USE_MMU # fork()
> >         depends on !BR2_STATIC_LIBS
> >         depends on BR2_INIT_OPENRC
> > +       select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # kmod tools
> > +       select BR2_PACKAGE_KMOD # runtime
> > +       select BR2_PACKAGE_KMOD_TOOLS # runtime
> >         select BR2_PACKAGE_NCURSES
> >         help
> >           Init that works on top of pid 1 (for example
> > --
> > 2.20.1
> >
> 
> What about doing the opposite?
> 
> 1. Always patch openrc to support busybox.' modprobe.

That is akin to a feature patch, so should have to be done upstream
first. Otherwise, we'd have to endlessly maintain that patch...

> 2. In busybox, select modprobe+blacklist if openrc is selected but
> kmod tools are not selected.

Or just tweak our default busybox config to enable modprobe + blacklist
and be done with that. And we don't care about kmod being enabled or
not, because kmod will always win against busybox in any case.

> This would be cleaner and seems to be reasonable, since busybox
> already sets several configurations based on the selection of other
> packages.

The only one that is dependent on another package is PAM support, and
that one is special. All other config tweaks only depend on architecture
(e.g. MMU support), system settings (e.g. mdev for /dev handling), or on
busybox' own config in Buildroot (e.g. support for individual binaries).

Furthermore, for the imminent release, this is currently the simplest
solution we have. We can refine it afterwards.

Regards,
Yann E. MORIN.

> -- 
> Carlos Santos <unixmania@gmail.com>

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/openrc: needs kmod
  2020-02-29  9:38   ` Yann E. MORIN
@ 2020-02-29 12:13     ` Carlos Santos
  0 siblings, 0 replies; 6+ messages in thread
From: Carlos Santos @ 2020-02-29 12:13 UTC (permalink / raw)
  To: buildroot

On Sat, Feb 29, 2020 at 6:39 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> On 2020-02-28 18:47 -0300, Carlos Santos spake thusly:
> > On Fri, Feb 28, 2020 at 5:26 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > >
> > > openrc provides scritps that have been written for the big-gun kmod, and
> > > so use options unknown to the biusybox' provided applets:
> > >
> > >   - Busybox modprobe does not have a "--first-time" option,
> > >   - the "--verbose" option is just "-v",
> > >   - the "--use-blacklist" option is just "-b". Also blacklist support is
> > >     not selected in our default busybox configuration.
> > >
> > > One of two options, is to "fix" or "adapt" openrc's scripts to busybox,
> > > which means for the openrc package to go peek into files from the
> > > busybox package, which is not nice, and can't work because that is not
> > > available by the time we scan our Makefiles.
> > >
> > > The other option, which this patch implements, is to just add a
> > > dependency onto kmod and its tools.
> > >
> > > Reported-by: Carlos Santos <unixmania@gmail.com>
> > > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> > > Cc: Peter Korsgaard <peter@korsgaard.com>
> > > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> > > ---
> > >  package/openrc/Config.in | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/package/openrc/Config.in b/package/openrc/Config.in
> > > index 796858f404..4691be63a2 100644
> > > --- a/package/openrc/Config.in
> > > +++ b/package/openrc/Config.in
> > > @@ -3,6 +3,9 @@ config BR2_PACKAGE_OPENRC
> > >         depends on BR2_USE_MMU # fork()
> > >         depends on !BR2_STATIC_LIBS
> > >         depends on BR2_INIT_OPENRC
> > > +       select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # kmod tools
> > > +       select BR2_PACKAGE_KMOD # runtime
> > > +       select BR2_PACKAGE_KMOD_TOOLS # runtime
> > >         select BR2_PACKAGE_NCURSES
> > >         help
> > >           Init that works on top of pid 1 (for example
> > > --
> > > 2.20.1
> > >
> >
> > What about doing the opposite?
> >
> > 1. Always patch openrc to support busybox.' modprobe.
>
> That is akin to a feature patch, so should have to be done upstream
> first. Otherwise, we'd have to endlessly maintain that patch...
>
> > 2. In busybox, select modprobe+blacklist if openrc is selected but
> > kmod tools are not selected.
>
> Or just tweak our default busybox config to enable modprobe + blacklist
> and be done with that. And we don't care about kmod being enabled or
> not, because kmod will always win against busybox in any case.
>
> > This would be cleaner and seems to be reasonable, since busybox
> > already sets several configurations based on the selection of other
> > packages.
>
> The only one that is dependent on another package is PAM support, and
> that one is special. All other config tweaks only depend on architecture
> (e.g. MMU support), system settings (e.g. mdev for /dev handling), or on
> busybox' own config in Buildroot (e.g. support for individual binaries).
>
> Furthermore, for the imminent release, this is currently the simplest
> solution we have. We can refine it afterwards.
>
> Regards,
> Yann E. MORIN.

OK, I submitted a pull request upstream:

    https://github.com/OpenRC/openrc/pull/354

Meanwhile,

Tested-by: Carlos Santos <unixmania@gmail.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/openrc: needs kmod
  2020-02-28 20:25 [Buildroot] [PATCH] package/openrc: needs kmod Yann E. MORIN
  2020-02-28 21:47 ` Carlos Santos
@ 2020-02-29 16:45 ` Peter Korsgaard
  2020-03-14 17:51 ` Peter Korsgaard
  2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2020-02-29 16:45 UTC (permalink / raw)
  To: buildroot

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > openrc provides scritps that have been written for the big-gun kmod, and
 > so use options unknown to the biusybox' provided applets:

 >   - Busybox modprobe does not have a "--first-time" option,
 >   - the "--verbose" option is just "-v",
 >   - the "--use-blacklist" option is just "-b". Also blacklist support is
 >     not selected in our default busybox configuration.

 > One of two options, is to "fix" or "adapt" openrc's scripts to busybox,
 > which means for the openrc package to go peek into files from the
 > busybox package, which is not nice, and can't work because that is not
 > available by the time we scan our Makefiles.

 > The other option, which this patch implements, is to just add a
 > dependency onto kmod and its tools.

 > Reported-by: Carlos Santos <unixmania@gmail.com>
 > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
 > Cc: Peter Korsgaard <peter@korsgaard.com>
 > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/openrc: needs kmod
  2020-02-28 20:25 [Buildroot] [PATCH] package/openrc: needs kmod Yann E. MORIN
  2020-02-28 21:47 ` Carlos Santos
  2020-02-29 16:45 ` Peter Korsgaard
@ 2020-03-14 17:51 ` Peter Korsgaard
  2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2020-03-14 17:51 UTC (permalink / raw)
  To: buildroot

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > openrc provides scritps that have been written for the big-gun kmod, and
 > so use options unknown to the biusybox' provided applets:

 >   - Busybox modprobe does not have a "--first-time" option,
 >   - the "--verbose" option is just "-v",
 >   - the "--use-blacklist" option is just "-b". Also blacklist support is
 >     not selected in our default busybox configuration.

 > One of two options, is to "fix" or "adapt" openrc's scripts to busybox,
 > which means for the openrc package to go peek into files from the
 > busybox package, which is not nice, and can't work because that is not
 > available by the time we scan our Makefiles.

 > The other option, which this patch implements, is to just add a
 > dependency onto kmod and its tools.

 > Reported-by: Carlos Santos <unixmania@gmail.com>
 > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
 > Cc: Peter Korsgaard <peter@korsgaard.com>
 > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2019.11.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-14 17:51 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-28 20:25 [Buildroot] [PATCH] package/openrc: needs kmod Yann E. MORIN
2020-02-28 21:47 ` Carlos Santos
2020-02-29  9:38   ` Yann E. MORIN
2020-02-29 12:13     ` Carlos Santos
2020-02-29 16:45 ` Peter Korsgaard
2020-03-14 17:51 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.