All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/qemu: move patch 3 to the 3.1.1.1 subdir
@ 2019-10-21 12:41 unixmania at gmail.com
  2019-10-21 17:09 ` Thomas Petazzoni
  2019-10-30  8:59 ` Peter Korsgaard
  0 siblings, 2 replies; 4+ messages in thread
From: unixmania at gmail.com @ 2019-10-21 12:41 UTC (permalink / raw)
  To: buildroot

From: Carlos Santos <unixmania@gmail.com>

Required since the bump from 3.1.1.

Signed-off-by: Carlos Santos <unixmania@gmail.com>
---
Do we really need the subdir? I know that qemu keeps four releases but
as far as I know Buildroot always included only one. Are there plans to
add a configuration to choose the qemu version?
---
 ...0003-util-cacheinfo-fix-crash-when-compiling-with-uClibc.patch | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename package/qemu/{3.1.1 => 3.1.1.1}/0003-util-cacheinfo-fix-crash-when-compiling-with-uClibc.patch (100%)

diff --git a/package/qemu/3.1.1/0003-util-cacheinfo-fix-crash-when-compiling-with-uClibc.patch b/package/qemu/3.1.1.1/0003-util-cacheinfo-fix-crash-when-compiling-with-uClibc.patch
similarity index 100%
rename from package/qemu/3.1.1/0003-util-cacheinfo-fix-crash-when-compiling-with-uClibc.patch
rename to package/qemu/3.1.1.1/0003-util-cacheinfo-fix-crash-when-compiling-with-uClibc.patch
-- 
2.18.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] package/qemu: move patch 3 to the 3.1.1.1 subdir
  2019-10-21 12:41 [Buildroot] [PATCH] package/qemu: move patch 3 to the 3.1.1.1 subdir unixmania at gmail.com
@ 2019-10-21 17:09 ` Thomas Petazzoni
  2019-10-21 17:57   ` Carlos Santos
  2019-10-30  8:59 ` Peter Korsgaard
  1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2019-10-21 17:09 UTC (permalink / raw)
  To: buildroot

Hello Carlos,

On Mon, 21 Oct 2019 09:41:39 -0300
unixmania at gmail.com wrote:

> From: Carlos Santos <unixmania@gmail.com>
> 
> Required since the bump from 3.1.1.
> 
> Signed-off-by: Carlos Santos <unixmania@gmail.com>
> ---
> Do we really need the subdir? I know that qemu keeps four releases but
> as far as I know Buildroot always included only one. Are there plans to
> add a configuration to choose the qemu version?

There is already such a version selection:

ifeq ($(BR2_csky),y)
QEMU_VERSION = b517e1dc3125a57555d67a8deed9eac7b42288e2
QEMU_SITE = $(call github,c-sky,qemu,$(QEMU_VERSION))
else
QEMU_VERSION = 3.1.1.1
QEMU_SOURCE = qemu-$(QEMU_VERSION).tar.xz
QEMU_SITE = http://download.qemu.org
endif

So we want the patches to only apply when the upstream 3.1.1.1 version
is used, and not when the C-SKY specific version is used.

>  ...0003-util-cacheinfo-fix-crash-when-compiling-with-uClibc.patch | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename package/qemu/{3.1.1 => 3.1.1.1}/0003-util-cacheinfo-fix-crash-when-compiling-with-uClibc.patch (100%)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] package/qemu: move patch 3 to the 3.1.1.1 subdir
  2019-10-21 17:09 ` Thomas Petazzoni
@ 2019-10-21 17:57   ` Carlos Santos
  0 siblings, 0 replies; 4+ messages in thread
From: Carlos Santos @ 2019-10-21 17:57 UTC (permalink / raw)
  To: buildroot

On Mon, Oct 21, 2019 at 2:09 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello Carlos,
>
> On Mon, 21 Oct 2019 09:41:39 -0300
> unixmania at gmail.com wrote:
>
> > From: Carlos Santos <unixmania@gmail.com>
> >
> > Required since the bump from 3.1.1.
> >
> > Signed-off-by: Carlos Santos <unixmania@gmail.com>
> > ---
> > Do we really need the subdir? I know that qemu keeps four releases but
> > as far as I know Buildroot always included only one. Are there plans to
> > add a configuration to choose the qemu version?
>
> There is already such a version selection:
>
> ifeq ($(BR2_csky),y)
> QEMU_VERSION = b517e1dc3125a57555d67a8deed9eac7b42288e2
> QEMU_SITE = $(call github,c-sky,qemu,$(QEMU_VERSION))
> else
> QEMU_VERSION = 3.1.1.1
> QEMU_SOURCE = qemu-$(QEMU_VERSION).tar.xz
> QEMU_SITE = http://download.qemu.org
> endif
>
> So we want the patches to only apply when the upstream 3.1.1.1 version
> is used, and not when the C-SKY specific version is used.

Hum, looking at their code I guess the C-SKY specific version also
needs patch #3 to work with uClibc-ng.

-- 
Carlos Santos <unixmania@gmail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] package/qemu: move patch 3 to the 3.1.1.1 subdir
  2019-10-21 12:41 [Buildroot] [PATCH] package/qemu: move patch 3 to the 3.1.1.1 subdir unixmania at gmail.com
  2019-10-21 17:09 ` Thomas Petazzoni
@ 2019-10-30  8:59 ` Peter Korsgaard
  1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2019-10-30  8:59 UTC (permalink / raw)
  To: buildroot

>>>>> "unixmania" == unixmania  <unixmania@gmail.com> writes:

 > From: Carlos Santos <unixmania@gmail.com>
 > Required since the bump from 3.1.1.

 > Signed-off-by: Carlos Santos <unixmania@gmail.com>

Committed to 2019.02.x and 2019.08.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-10-30  8:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-21 12:41 [Buildroot] [PATCH] package/qemu: move patch 3 to the 3.1.1.1 subdir unixmania at gmail.com
2019-10-21 17:09 ` Thomas Petazzoni
2019-10-21 17:57   ` Carlos Santos
2019-10-30  8:59 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.