[PATCH 0/1] lvm2: disable thin provisioning support if GPLv3 incompatible

[PATCH 0/1] lvm2: disable thin provisioning support if GPLv3 incompatible

[kai.kang]

From: Kai Kang <kai.kang@windriver.com>

Test steps:
1 add layer meta-gplv2 to conf/bblayers.conf
2 echo INCOMPATIBLE_LICENSE += \"GPLv3 LGPLv3 GPLv3+ LGPLv3+ AGPL-3.0\" >> conf/local.conf
3 bitbake lvm2

Without the patch, lvm2 fails with:

ERROR: Nothing RPROVIDES 'thin-provisioning-tools' (but /buildarea2/kkang/Yocto/repo/meta-openembedded/meta-oe
/recipes-support/lvm2/lvm2_2.02.171.bb, /buildarea2/kkang/Yocto/repo/meta-openembedded/meta-oe/recipes-support
/lvm2/libdevmapper_2.02.171.bb RDEPENDS on or otherwise requires it)
thin-provisioning-tools was skipped: it has an incompatible license: GPLv3
NOTE: Runtime target 'thin-provisioning-tools' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['thin-provisioning-tools']
ERROR: Required build target 'lvm2' has no buildable providers.
Missing or unbuildable dependency chain was: ['lvm2', 'thin-provisioning-tools']


Kai Kang (1):
  lvm2: disable thin provisioning support if GPLv3 incompatible

 meta-oe/recipes-support/lvm2/lvm2.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.14.1

[PATCH 1/1] lvm2: disable thin provisioning support if GPLv3 incompatible

[kai.kang]

From: Kai Kang <kai.kang@windriver.com>

Disable thin provisioning support for lvm2 if it is set GPLv3
incompatible.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 meta-oe/recipes-support/lvm2/lvm2.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-oe/recipes-support/lvm2/lvm2.inc b/meta-oe/recipes-support/lvm2/lvm2.inc
index ab8db9cba..9791554a9 100644
--- a/meta-oe/recipes-support/lvm2/lvm2.inc
+++ b/meta-oe/recipes-support/lvm2/lvm2.inc
@@ -23,7 +23,7 @@ inherit autotools-brokensep pkgconfig systemd
 LVM2_PACKAGECONFIG = "dmeventd lvmetad"
 LVM2_PACKAGECONFIG_append_class-target = " \
     ${@bb.utils.filter('DISTRO_FEATURES', 'selinux', d)} \
-    thin-provisioning-tools \
+    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'thin-provisioning-tools', d)} \
     udev \
 "
 
-- 
2.14.1

Re: [PATCH 1/1] lvm2: disable thin provisioning support if GPLv3 incompatible

[Khem Raj]

On Wed, Sep 20, 2017 at 11:47 PM,  <kai.kang@windriver.com> wrote:
> From: Kai Kang <kai.kang@windriver.com>
>
> Disable thin provisioning support for lvm2 if it is set GPLv3
> incompatible.
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>  meta-oe/recipes-support/lvm2/lvm2.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-support/lvm2/lvm2.inc b/meta-oe/recipes-support/lvm2/lvm2.inc
> index ab8db9cba..9791554a9 100644
> --- a/meta-oe/recipes-support/lvm2/lvm2.inc
> +++ b/meta-oe/recipes-support/lvm2/lvm2.inc
> @@ -23,7 +23,7 @@ inherit autotools-brokensep pkgconfig systemd
>  LVM2_PACKAGECONFIG = "dmeventd lvmetad"
>  LVM2_PACKAGECONFIG_append_class-target = " \
>      ${@bb.utils.filter('DISTRO_FEATURES', 'selinux', d)} \
> -    thin-provisioning-tools \
> +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'thin-provisioning-tools', d)} \
>      udev \
>  "
there are other strings like GPL-3.0, as well as other types of GPL 3
derivative licenses, I wonder if this will work for all

Re: [PATCH 1/1] lvm2: disable thin provisioning support if GPLv3 incompatible

[Andre McCurdy]

On Thu, Sep 21, 2017 at 7:16 AM, Khem Raj <raj.khem@gmail.com> wrote:
> On Wed, Sep 20, 2017 at 11:47 PM,  <kai.kang@windriver.com> wrote:
>> From: Kai Kang <kai.kang@windriver.com>
>>
>> Disable thin provisioning support for lvm2 if it is set GPLv3
>> incompatible.
>>
>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>> ---
>>  meta-oe/recipes-support/lvm2/lvm2.inc | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-oe/recipes-support/lvm2/lvm2.inc b/meta-oe/recipes-support/lvm2/lvm2.inc
>> index ab8db9cba..9791554a9 100644
>> --- a/meta-oe/recipes-support/lvm2/lvm2.inc
>> +++ b/meta-oe/recipes-support/lvm2/lvm2.inc
>> @@ -23,7 +23,7 @@ inherit autotools-brokensep pkgconfig systemd
>>  LVM2_PACKAGECONFIG = "dmeventd lvmetad"
>>  LVM2_PACKAGECONFIG_append_class-target = " \
>>      ${@bb.utils.filter('DISTRO_FEATURES', 'selinux', d)} \
>> -    thin-provisioning-tools \
>> +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'thin-provisioning-tools', d)} \
>>      udev \
>>  "
> there are other strings like GPL-3.0, as well as other types of GPL 3
> derivative licenses, I wonder if this will work for all

Perhaps something like:

  ${@incompatible_license_contains('GPLv3', '', 'thin-provisioning-tools', d)}

would work more reliably?

> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [PATCH 1/1] lvm2: disable thin provisioning support if GPLv3 incompatible

[Kang Kai]

On 2017年09月22日 03:44, Andre McCurdy wrote:
> On Thu, Sep 21, 2017 at 7:16 AM, Khem Raj <raj.khem@gmail.com> wrote:
>> On Wed, Sep 20, 2017 at 11:47 PM,  <kai.kang@windriver.com> wrote:
>>> From: Kai Kang <kai.kang@windriver.com>
>>>
>>> Disable thin provisioning support for lvm2 if it is set GPLv3
>>> incompatible.
>>>
>>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>>> ---
>>>   meta-oe/recipes-support/lvm2/lvm2.inc | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta-oe/recipes-support/lvm2/lvm2.inc b/meta-oe/recipes-support/lvm2/lvm2.inc
>>> index ab8db9cba..9791554a9 100644
>>> --- a/meta-oe/recipes-support/lvm2/lvm2.inc
>>> +++ b/meta-oe/recipes-support/lvm2/lvm2.inc
>>> @@ -23,7 +23,7 @@ inherit autotools-brokensep pkgconfig systemd
>>>   LVM2_PACKAGECONFIG = "dmeventd lvmetad"
>>>   LVM2_PACKAGECONFIG_append_class-target = " \
>>>       ${@bb.utils.filter('DISTRO_FEATURES', 'selinux', d)} \
>>> -    thin-provisioning-tools \
>>> +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'thin-provisioning-tools', d)} \
>>>       udev \
>>>   "
>> there are other strings like GPL-3.0, as well as other types of GPL 3
>> derivative licenses, I wonder if this will work for all
> Perhaps something like:
>
>    ${@incompatible_license_contains('GPLv3', '', 'thin-provisioning-tools', d)}
>
> would work more reliably?

OK. Thanks. I'll send V2.


--Kai



>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


-- 
Regards,
Neil | Kai Kang