All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] webkitgtk: remove '-fno-omit-frame-pointer' for x86
@ 2020-11-09  0:31 kai
  2020-11-09  7:32 ` [OE-core] " Alexander Kanavin
  0 siblings, 1 reply; 8+ messages in thread
From: kai @ 2020-11-09  0:31 UTC (permalink / raw)
  To: openembedded-core

From: Kai Kang <kai.kang@windriver.com>

It fails to compile webkitgtk for qemux86 if compile option
'-fno-omit-frame-pointer' is applied:

| TOPDIR/tmp-glibc/work/core2-32-wrsmllib32-linux/lib32-webkitgtk/2.30.1-r0/webkitgtk-2.30.1/
    Source/JavaScriptCore/runtime/JSFinalizationRegistry.cpp:47:1:
| internal compiler error: in find_oldest_value_reg, at regcprop.c:438
|    47 | }

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 meta/recipes-sato/webkit/webkitgtk_2.30.2.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb b/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
index 1acba6be1d..11fdb59034 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
@@ -79,6 +79,7 @@ EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF "
 # which is not enough for binaries larger than 32 MiB
 CFLAGS_append_arc = " -mlong-calls"
 CXXFLAGS_append_arc = " -mlong-calls"
+CXXFLAGS_remove_x86 = "-fno-omit-frame-pointer"
 
 # Javascript JIT is not supported on powerpc
 EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=OFF "
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [OE-core] [PATCH] webkitgtk: remove '-fno-omit-frame-pointer' for x86
  2020-11-09  0:31 [PATCH] webkitgtk: remove '-fno-omit-frame-pointer' for x86 kai
@ 2020-11-09  7:32 ` Alexander Kanavin
  2020-11-09  7:51   ` kai
  0 siblings, 1 reply; 8+ messages in thread
From: Alexander Kanavin @ 2020-11-09  7:32 UTC (permalink / raw)
  To: kai; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 1418 bytes --]

This is not seen on the autobuilder, which does world builds on qemux86.
Something might be wrong on your side?

Alex

On Mon, 9 Nov 2020 at 01:32, kai <kai.kang@windriver.com> wrote:

> From: Kai Kang <kai.kang@windriver.com>
>
> It fails to compile webkitgtk for qemux86 if compile option
> '-fno-omit-frame-pointer' is applied:
>
> |
> TOPDIR/tmp-glibc/work/core2-32-wrsmllib32-linux/lib32-webkitgtk/2.30.1-r0/webkitgtk-2.30.1/
>     Source/JavaScriptCore/runtime/JSFinalizationRegistry.cpp:47:1:
> | internal compiler error: in find_oldest_value_reg, at regcprop.c:438
> |    47 | }
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>  meta/recipes-sato/webkit/webkitgtk_2.30.2.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
> b/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
> index 1acba6be1d..11fdb59034 100644
> --- a/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
> +++ b/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
> @@ -79,6 +79,7 @@ EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF "
>  # which is not enough for binaries larger than 32 MiB
>  CFLAGS_append_arc = " -mlong-calls"
>  CXXFLAGS_append_arc = " -mlong-calls"
> +CXXFLAGS_remove_x86 = "-fno-omit-frame-pointer"
>
>  # Javascript JIT is not supported on powerpc
>  EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=OFF "
> --
> 2.17.1
>
>
> 
>
>

[-- Attachment #2: Type: text/html, Size: 2369 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core] [PATCH] webkitgtk: remove '-fno-omit-frame-pointer' for x86
  2020-11-09  7:32 ` [OE-core] " Alexander Kanavin
@ 2020-11-09  7:51   ` kai
  2020-11-09  8:07     ` Alexander Kanavin
  0 siblings, 1 reply; 8+ messages in thread
From: kai @ 2020-11-09  7:51 UTC (permalink / raw)
  To: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 2299 bytes --]

On 11/9/20 3:32 PM, Alexander Kanavin wrote:
> This is not seen on the autobuilder, which does world builds on 
> qemux86. Something might be wrong on your side?

Just the option '-fno-omit-frame-pointer' which is not set by default. 
We have a build with an extra config in local.conf:

SELECTED_OPTIMIZATION = "${PROFILING_OPTIMIZATION}"

which expands to

SELECTED_OPTIMIZATION = "${FULL_OPTIMIZATION} -fno-omit-frame-pointer 
-fvisibility=default"

then it fails to compile webkitgtk. It could be reproduced with upper 
config line.

Regards,
Kai



>
> Alex
>
> On Mon, 9 Nov 2020 at 01:32, kai <kai.kang@windriver.com 
> <mailto:kai.kang@windriver.com>> wrote:
>
>     From: Kai Kang <kai.kang@windriver.com
>     <mailto:kai.kang@windriver.com>>
>
>     It fails to compile webkitgtk for qemux86 if compile option
>     '-fno-omit-frame-pointer' is applied:
>
>     |
>     TOPDIR/tmp-glibc/work/core2-32-wrsmllib32-linux/lib32-webkitgtk/2.30.1-r0/webkitgtk-2.30.1/
>     Source/JavaScriptCore/runtime/JSFinalizationRegistry.cpp:47:1:
>     | internal compiler error: in find_oldest_value_reg, at regcprop.c:438
>     |    47 | }
>
>     Signed-off-by: Kai Kang <kai.kang@windriver.com
>     <mailto:kai.kang@windriver.com>>
>     ---
>      meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
>     <http://webkitgtk_2.30.2.bb> | 1 +
>      1 file changed, 1 insertion(+)
>
>     diff --git a/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
>     <http://webkitgtk_2.30.2.bb>
>     b/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
>     <http://webkitgtk_2.30.2.bb>
>     index 1acba6be1d..11fdb59034 100644
>     --- a/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
>     <http://webkitgtk_2.30.2.bb>
>     +++ b/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
>     <http://webkitgtk_2.30.2.bb>
>     @@ -79,6 +79,7 @@ EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF "
>      # which is not enough for binaries larger than 32 MiB
>      CFLAGS_append_arc = " -mlong-calls"
>      CXXFLAGS_append_arc = " -mlong-calls"
>     +CXXFLAGS_remove_x86 = "-fno-omit-frame-pointer"
>
>      # Javascript JIT is not supported on powerpc
>      EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=OFF "
>     -- 
>     2.17.1
>
>
>
>
>
> 
>


[-- Attachment #2: Type: text/html, Size: 4378 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core] [PATCH] webkitgtk: remove '-fno-omit-frame-pointer' for x86
  2020-11-09  7:51   ` kai
@ 2020-11-09  8:07     ` Alexander Kanavin
  2020-11-09  8:18       ` kai
  0 siblings, 1 reply; 8+ messages in thread
From: Alexander Kanavin @ 2020-11-09  8:07 UTC (permalink / raw)
  To: kai; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 2191 bytes --]

Right, but then adding _remove to the upstream recipe doesn't seem right -
rather you should use _pn-webkitgtk override in your custom config.

Alex

On Mon, 9 Nov 2020 at 08:52, kai <kai.kang@windriver.com> wrote:

> On 11/9/20 3:32 PM, Alexander Kanavin wrote:
>
> This is not seen on the autobuilder, which does world builds on qemux86.
> Something might be wrong on your side?
>
> Just the option '-fno-omit-frame-pointer' which is not set by default. We
> have a build with an extra config in local.conf:
>
> SELECTED_OPTIMIZATION = "${PROFILING_OPTIMIZATION}"
>
> which expands to
>
> SELECTED_OPTIMIZATION = "${FULL_OPTIMIZATION} -fno-omit-frame-pointer
> -fvisibility=default"
>
> then it fails to compile webkitgtk. It could be reproduced with upper
> config line.
>
> Regards,
> Kai
>
>
>
>
> Alex
>
> On Mon, 9 Nov 2020 at 01:32, kai <kai.kang@windriver.com> wrote:
>
>> From: Kai Kang <kai.kang@windriver.com>
>>
>> It fails to compile webkitgtk for qemux86 if compile option
>> '-fno-omit-frame-pointer' is applied:
>>
>> |
>> TOPDIR/tmp-glibc/work/core2-32-wrsmllib32-linux/lib32-webkitgtk/2.30.1-r0/webkitgtk-2.30.1/
>>     Source/JavaScriptCore/runtime/JSFinalizationRegistry.cpp:47:1:
>> | internal compiler error: in find_oldest_value_reg, at regcprop.c:438
>> |    47 | }
>>
>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>> ---
>>  meta/recipes-sato/webkit/webkitgtk_2.30.2.bb | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
>> b/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
>> index 1acba6be1d..11fdb59034 100644
>> --- a/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
>> +++ b/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
>> @@ -79,6 +79,7 @@ EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF "
>>  # which is not enough for binaries larger than 32 MiB
>>  CFLAGS_append_arc = " -mlong-calls"
>>  CXXFLAGS_append_arc = " -mlong-calls"
>> +CXXFLAGS_remove_x86 = "-fno-omit-frame-pointer"
>>
>>  # Javascript JIT is not supported on powerpc
>>  EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=OFF "
>> --
>> 2.17.1
>>
>>
>>
>>
>>
>
>
> 
>
>

[-- Attachment #2: Type: text/html, Size: 4382 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core] [PATCH] webkitgtk: remove '-fno-omit-frame-pointer' for x86
  2020-11-09  8:07     ` Alexander Kanavin
@ 2020-11-09  8:18       ` kai
  2020-11-09 18:58         ` Khem Raj
  0 siblings, 1 reply; 8+ messages in thread
From: kai @ 2020-11-09  8:18 UTC (permalink / raw)
  To: Alexander Kanavin; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 3039 bytes --]

On 11/9/20 4:07 PM, Alexander Kanavin wrote:
> Right, but then adding _remove to the upstream recipe doesn't seem 
> right - rather you should use _pn-webkitgtk override in your custom 
> config.

I suppose '-fomit-frame-pointer' is common compile flag that other 
people may also meet this error.

Regards,
Kai

>
> Alex
>
> On Mon, 9 Nov 2020 at 08:52, kai <kai.kang@windriver.com 
> <mailto:kai.kang@windriver.com>> wrote:
>
>     On 11/9/20 3:32 PM, Alexander Kanavin wrote:
>>     This is not seen on the autobuilder, which does world builds on
>>     qemux86. Something might be wrong on your side?
>
>     Just the option '-fno-omit-frame-pointer' which is not set by
>     default. We have a build with an extra config in local.conf:
>
>     SELECTED_OPTIMIZATION = "${PROFILING_OPTIMIZATION}"
>
>     which expands to
>
>     SELECTED_OPTIMIZATION = "${FULL_OPTIMIZATION}
>     -fno-omit-frame-pointer -fvisibility=default"
>
>     then it fails to compile webkitgtk. It could be reproduced with
>     upper config line.
>
>     Regards,
>     Kai
>
>
>
>>
>>     Alex
>>
>>     On Mon, 9 Nov 2020 at 01:32, kai <kai.kang@windriver.com
>>     <mailto:kai.kang@windriver.com>> wrote:
>>
>>         From: Kai Kang <kai.kang@windriver.com
>>         <mailto:kai.kang@windriver.com>>
>>
>>         It fails to compile webkitgtk for qemux86 if compile option
>>         '-fno-omit-frame-pointer' is applied:
>>
>>         |
>>         TOPDIR/tmp-glibc/work/core2-32-wrsmllib32-linux/lib32-webkitgtk/2.30.1-r0/webkitgtk-2.30.1/
>>         Source/JavaScriptCore/runtime/JSFinalizationRegistry.cpp:47:1:
>>         | internal compiler error: in find_oldest_value_reg, at
>>         regcprop.c:438
>>         |    47 | }
>>
>>         Signed-off-by: Kai Kang <kai.kang@windriver.com
>>         <mailto:kai.kang@windriver.com>>
>>         ---
>>          meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
>>         <http://webkitgtk_2.30.2.bb> | 1 +
>>          1 file changed, 1 insertion(+)
>>
>>         diff --git a/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
>>         <http://webkitgtk_2.30.2.bb>
>>         b/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
>>         <http://webkitgtk_2.30.2.bb>
>>         index 1acba6be1d..11fdb59034 100644
>>         --- a/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
>>         <http://webkitgtk_2.30.2.bb>
>>         +++ b/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
>>         <http://webkitgtk_2.30.2.bb>
>>         @@ -79,6 +79,7 @@ EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF "
>>          # which is not enough for binaries larger than 32 MiB
>>          CFLAGS_append_arc = " -mlong-calls"
>>          CXXFLAGS_append_arc = " -mlong-calls"
>>         +CXXFLAGS_remove_x86 = "-fno-omit-frame-pointer"
>>
>>          # Javascript JIT is not supported on powerpc
>>          EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=OFF "
>>         -- 
>>         2.17.1
>>
>>
>>
>>
>>
>
>
>     
>


[-- Attachment #2: Type: text/html, Size: 6266 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core] [PATCH] webkitgtk: remove '-fno-omit-frame-pointer' for x86
  2020-11-09  8:18       ` kai
@ 2020-11-09 18:58         ` Khem Raj
  2020-11-10  1:53           ` kai
  0 siblings, 1 reply; 8+ messages in thread
From: Khem Raj @ 2020-11-09 18:58 UTC (permalink / raw)
  To: kai; +Cc: Alexander Kanavin, OE-core

On Mon, Nov 9, 2020 at 12:18 AM kai <kai.kang@windriver.com> wrote:
>
> On 11/9/20 4:07 PM, Alexander Kanavin wrote:
>
> Right, but then adding _remove to the upstream recipe doesn't seem right - rather you should use _pn-webkitgtk override in your custom config.
>
> I suppose '-fomit-frame-pointer' is common compile flag that other people may also meet this error.
>
> Regards,
> Kai
>
>
> Alex
>
> On Mon, 9 Nov 2020 at 08:52, kai <kai.kang@windriver.com> wrote:
>>
>> On 11/9/20 3:32 PM, Alexander Kanavin wrote:
>>
>> This is not seen on the autobuilder, which does world builds on qemux86. Something might be wrong on your side?
>>
>> Just the option '-fno-omit-frame-pointer' which is not set by default. We have a build with an extra config in local.conf:
>>
>> SELECTED_OPTIMIZATION = "${PROFILING_OPTIMIZATION}"
>>
>> which expands to
>>
>> SELECTED_OPTIMIZATION = "${FULL_OPTIMIZATION} -fno-omit-frame-pointer -fvisibility=default"
>>
>> then it fails to compile webkitgtk. It could be reproduced with upper config line.
>>

since we do not have global file to control this its fine if you alter
PROFILING_OPTIMIZATION inside this recipe
something like PROFILING_OPTIMIZATION_remove = "..."

>> Regards,
>> Kai
>>
>>
>>
>>
>> Alex
>>
>> On Mon, 9 Nov 2020 at 01:32, kai <kai.kang@windriver.com> wrote:
>>>
>>> From: Kai Kang <kai.kang@windriver.com>
>>>
>>> It fails to compile webkitgtk for qemux86 if compile option
>>> '-fno-omit-frame-pointer' is applied:
>>>
>>> | TOPDIR/tmp-glibc/work/core2-32-wrsmllib32-linux/lib32-webkitgtk/2.30.1-r0/webkitgtk-2.30.1/
>>>     Source/JavaScriptCore/runtime/JSFinalizationRegistry.cpp:47:1:
>>> | internal compiler error: in find_oldest_value_reg, at regcprop.c:438
>>> |    47 | }
>>>
>>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>>> ---
>>>  meta/recipes-sato/webkit/webkitgtk_2.30.2.bb | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb b/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
>>> index 1acba6be1d..11fdb59034 100644
>>> --- a/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
>>> +++ b/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
>>> @@ -79,6 +79,7 @@ EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF "
>>>  # which is not enough for binaries larger than 32 MiB
>>>  CFLAGS_append_arc = " -mlong-calls"
>>>  CXXFLAGS_append_arc = " -mlong-calls"
>>> +CXXFLAGS_remove_x86 = "-fno-omit-frame-pointer"
>>>
>>>  # Javascript JIT is not supported on powerpc
>>>  EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=OFF "
>>> --
>>> 2.17.1
>>>
>>>
>>>
>>>
>>
>>
>>
>>
>>
>
>
> 
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core] [PATCH] webkitgtk: remove '-fno-omit-frame-pointer' for x86
  2020-11-09 18:58         ` Khem Raj
@ 2020-11-10  1:53           ` kai
  2020-11-10 20:37             ` Andre McCurdy
  0 siblings, 1 reply; 8+ messages in thread
From: kai @ 2020-11-10  1:53 UTC (permalink / raw)
  To: Khem Raj; +Cc: Alexander Kanavin, OE-core

[-- Attachment #1: Type: text/plain, Size: 2956 bytes --]

On 11/10/20 2:58 AM, Khem Raj wrote:
> On Mon, Nov 9, 2020 at 12:18 AM kai <kai.kang@windriver.com> wrote:
>> On 11/9/20 4:07 PM, Alexander Kanavin wrote:
>>
>> Right, but then adding _remove to the upstream recipe doesn't seem right - rather you should use _pn-webkitgtk override in your custom config.
>>
>> I suppose '-fomit-frame-pointer' is common compile flag that other people may also meet this error.
>>
>> Regards,
>> Kai
>>
>>
>> Alex
>>
>> On Mon, 9 Nov 2020 at 08:52, kai <kai.kang@windriver.com> wrote:
>>> On 11/9/20 3:32 PM, Alexander Kanavin wrote:
>>>
>>> This is not seen on the autobuilder, which does world builds on qemux86. Something might be wrong on your side?
>>>
>>> Just the option '-fno-omit-frame-pointer' which is not set by default. We have a build with an extra config in local.conf:
>>>
>>> SELECTED_OPTIMIZATION = "${PROFILING_OPTIMIZATION}"
>>>
>>> which expands to
>>>
>>> SELECTED_OPTIMIZATION = "${FULL_OPTIMIZATION} -fno-omit-frame-pointer -fvisibility=default"
>>>
>>> then it fails to compile webkitgtk. It could be reproduced with upper config line.
>>>
> since we do not have global file to control this its fine if you alter
> PROFILING_OPTIMIZATION inside this recipe
> something like PROFILING_OPTIMIZATION_remove = "..."

OK. I'll follow the snippet such as:

recipes-devtools/binutils/binutils_2.35.bb:SELECTED_OPTIMIZATION_remove_mipsarch 
= "-O2"

Thanks,
Kai


>
>>> Regards,
>>> Kai
>>>
>>>
>>>
>>>
>>> Alex
>>>
>>> On Mon, 9 Nov 2020 at 01:32, kai <kai.kang@windriver.com> wrote:
>>>> From: Kai Kang <kai.kang@windriver.com>
>>>>
>>>> It fails to compile webkitgtk for qemux86 if compile option
>>>> '-fno-omit-frame-pointer' is applied:
>>>>
>>>> | TOPDIR/tmp-glibc/work/core2-32-wrsmllib32-linux/lib32-webkitgtk/2.30.1-r0/webkitgtk-2.30.1/
>>>>      Source/JavaScriptCore/runtime/JSFinalizationRegistry.cpp:47:1:
>>>> | internal compiler error: in find_oldest_value_reg, at regcprop.c:438
>>>> |    47 | }
>>>>
>>>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>>>> ---
>>>>   meta/recipes-sato/webkit/webkitgtk_2.30.2.bb | 1 +
>>>>   1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb b/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
>>>> index 1acba6be1d..11fdb59034 100644
>>>> --- a/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
>>>> +++ b/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
>>>> @@ -79,6 +79,7 @@ EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF "
>>>>   # which is not enough for binaries larger than 32 MiB
>>>>   CFLAGS_append_arc = " -mlong-calls"
>>>>   CXXFLAGS_append_arc = " -mlong-calls"
>>>> +CXXFLAGS_remove_x86 = "-fno-omit-frame-pointer"
>>>>
>>>>   # Javascript JIT is not supported on powerpc
>>>>   EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=OFF "
>>>> --
>>>> 2.17.1
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>>
>>
>>
>>
>>
>> 
>>


[-- Attachment #2: Type: text/html, Size: 4525 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core] [PATCH] webkitgtk: remove '-fno-omit-frame-pointer' for x86
  2020-11-10  1:53           ` kai
@ 2020-11-10 20:37             ` Andre McCurdy
  0 siblings, 0 replies; 8+ messages in thread
From: Andre McCurdy @ 2020-11-10 20:37 UTC (permalink / raw)
  To: kai; +Cc: Khem Raj, Alexander Kanavin, OE-core

On Mon, Nov 9, 2020 at 5:53 PM kai <kai.kang@windriver.com> wrote:
>
> On 11/10/20 2:58 AM, Khem Raj wrote:
>
> On Mon, Nov 9, 2020 at 12:18 AM kai <kai.kang@windriver.com> wrote:
>
> On 11/9/20 4:07 PM, Alexander Kanavin wrote:
>
> Right, but then adding _remove to the upstream recipe doesn't seem right - rather you should use _pn-webkitgtk override in your custom config.
>
> I suppose '-fomit-frame-pointer' is common compile flag that other people may also meet this error.
>
> Regards,
> Kai
>
>
> Alex
>
> On Mon, 9 Nov 2020 at 08:52, kai <kai.kang@windriver.com> wrote:
>
> On 11/9/20 3:32 PM, Alexander Kanavin wrote:
>
> This is not seen on the autobuilder, which does world builds on qemux86. Something might be wrong on your side?
>
> Just the option '-fno-omit-frame-pointer' which is not set by default. We have a build with an extra config in local.conf:
>
> SELECTED_OPTIMIZATION = "${PROFILING_OPTIMIZATION}"
>
> which expands to
>
> SELECTED_OPTIMIZATION = "${FULL_OPTIMIZATION} -fno-omit-frame-pointer -fvisibility=default"
>
> then it fails to compile webkitgtk. It could be reproduced with upper config line.
>
> since we do not have global file to control this its fine if you alter
> PROFILING_OPTIMIZATION inside this recipe
> something like PROFILING_OPTIMIZATION_remove = "..."
>-fno-omit-frame-pointer
> OK. I'll follow the snippet such as:
>
> recipes-devtools/binutils/binutils_2.35.bb:SELECTED_OPTIMIZATION_remove_mipsarch = "-O2"

If you want to ensure that something is built without frame pointers
then appending "-fomit-frame-pointer" is clearer (and more robust)
than trying to remove "-fno-omit-frame-pointer".

> Thanks,
> Kai
>
>
>
> Regards,
> Kai
>
>
>
>
> Alex
>
> On Mon, 9 Nov 2020 at 01:32, kai <kai.kang@windriver.com> wrote:
>
> From: Kai Kang <kai.kang@windriver.com>
>
> It fails to compile webkitgtk for qemux86 if compile option
> '-fno-omit-frame-pointer' is applied:
>
> | TOPDIR/tmp-glibc/work/core2-32-wrsmllib32-linux/lib32-webkitgtk/2.30.1-r0/webkitgtk-2.30.1/
>     Source/JavaScriptCore/runtime/JSFinalizationRegistry.cpp:47:1:
> | internal compiler error: in find_oldest_value_reg, at regcprop.c:438
> |    47 | }
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>  meta/recipes-sato/webkit/webkitgtk_2.30.2.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb b/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
> index 1acba6be1d..11fdb59034 100644
> --- a/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
> +++ b/meta/recipes-sato/webkit/webkitgtk_2.30.2.bb
> @@ -79,6 +79,7 @@ EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF "
>  # which is not enough for binaries larger than 32 MiB
>  CFLAGS_append_arc = " -mlong-calls"
>  CXXFLAGS_append_arc = " -mlong-calls"
> +CXXFLAGS_remove_x86 = "-fno-omit-frame-pointer"
>
>  # Javascript JIT is not supported on powerpc
>  EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=OFF "
> --
> 2.17.1
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> 
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-11-10 20:37 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-09  0:31 [PATCH] webkitgtk: remove '-fno-omit-frame-pointer' for x86 kai
2020-11-09  7:32 ` [OE-core] " Alexander Kanavin
2020-11-09  7:51   ` kai
2020-11-09  8:07     ` Alexander Kanavin
2020-11-09  8:18       ` kai
2020-11-09 18:58         ` Khem Raj
2020-11-10  1:53           ` kai
2020-11-10 20:37             ` Andre McCurdy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.