From: Andre McCurdy <armccurdy@gmail.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: Yocto discussion list <yocto@yoctoproject.org>
Subject: Re: [meta-raspberrypi][PATCH] gstreamer1.0-plugins-bad_%.bbappend: Set PACKAGECONFIG_GL for RPi
Date: Thu, 3 Nov 2016 12:55:47 -0700 [thread overview]
Message-ID: <CAJ86T=XR2tN-56mcRoXNCNnnxOJvOb32GbvsVkGp9g1t31Yfhw@mail.gmail.com> (raw)
In-Reply-To: <20161103062937.23799-1-raj.khem@gmail.com>
On Wed, Nov 2, 2016 at 11:29 PM, Khem Raj <raj.khem@gmail.com> wrote:
> Enable dispmanx support if using bcm driver
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> .../gstreamer/gstreamer1.0-plugins-bad_%.bbappend | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend
> index ab0280e..1097e65 100644
> --- a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend
> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend
> @@ -1,2 +1,12 @@
> -EXTRA_OECONF_append_rpi = " CPPFLAGS='-I${STAGING_DIR_TARGET}/usr/include/interface/vcos/pthreads \
> - -I${STAGING_DIR_TARGET}/usr/include/interface/vmcs_host/linux'"
> +EXTRA_OECONF_append_rpi = " CPPFLAGS='-I${STAGING_INCDIR}/interface/vcos/pthreads \
> + -I${STAGING_INCDIR}/interface/vmcs_host/linux'"
> +
> +# if using bcm driver then enable dispmanx, other
Comment seems to be truncated?
> +
> +PACKAGECONFIG[dispmanx] = "--enable-dispmanx,--disable-dispmanx,userland"
Typical style is to put PACKAGECONFIG[foo] lines after defining PACKAGECONFIG.
> +PACKAGECONFIG_append_rpi = " "${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "", "dispmanx", d)}"
Typo, extra "
> +
> +PACKAGECONFIG_GL_rpi = "egl gles2"
> +PACKAGECONFIG_append_rpi = " hls libmms faad dispmanx"
Appending dispmanx is conditional on MACHINE_FEATURES 3 lines above.
It probably shouldn't be unconditional here.
> +
> --
> 2.10.2
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
prev parent reply other threads:[~2016-11-03 19:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 6:29 [meta-raspberrypi][PATCH] gstreamer1.0-plugins-bad_%.bbappend: Set PACKAGECONFIG_GL for RPi Khem Raj
2016-11-03 19:55 ` Andre McCurdy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ86T=XR2tN-56mcRoXNCNnnxOJvOb32GbvsVkGp9g1t31Yfhw@mail.gmail.com' \
--to=armccurdy@gmail.com \
--cc=raj.khem@gmail.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.