[meta-raspberrypi][PATCH] gstreamer1.0-plugins-bad_%.bbappend: Set PACKAGECONFIG_GL for RPi

[meta-raspberrypi][PATCH] gstreamer1.0-plugins-bad_%.bbappend: Set PACKAGECONFIG_GL for RPi

[Khem Raj]

Enable dispmanx support if using bcm driver

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 .../gstreamer/gstreamer1.0-plugins-bad_%.bbappend          | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend
index ab0280e..1097e65 100644
--- a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend
+++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend
@@ -1,2 +1,12 @@
-EXTRA_OECONF_append_rpi = " CPPFLAGS='-I${STAGING_DIR_TARGET}/usr/include/interface/vcos/pthreads \
-                                   -I${STAGING_DIR_TARGET}/usr/include/interface/vmcs_host/linux'"
+EXTRA_OECONF_append_rpi = " CPPFLAGS='-I${STAGING_INCDIR}/interface/vcos/pthreads \
+                                   -I${STAGING_INCDIR}/interface/vmcs_host/linux'"
+
+# if using bcm driver then enable dispmanx, other
+
+PACKAGECONFIG[dispmanx] = "--enable-dispmanx,--disable-dispmanx,userland"
+
+PACKAGECONFIG_append_rpi = " "${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "", "dispmanx", d)}"
+
+PACKAGECONFIG_GL_rpi = "egl gles2"
+PACKAGECONFIG_append_rpi = " hls libmms faad dispmanx"
+
-- 
2.10.2

Re: [meta-raspberrypi][PATCH] gstreamer1.0-plugins-bad_%.bbappend: Set PACKAGECONFIG_GL for RPi

[Andre McCurdy]

On Wed, Nov 2, 2016 at 11:29 PM, Khem Raj <raj.khem@gmail.com> wrote:
> Enable dispmanx support if using bcm driver
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  .../gstreamer/gstreamer1.0-plugins-bad_%.bbappend          | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend
> index ab0280e..1097e65 100644
> --- a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend
> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend
> @@ -1,2 +1,12 @@
> -EXTRA_OECONF_append_rpi = " CPPFLAGS='-I${STAGING_DIR_TARGET}/usr/include/interface/vcos/pthreads \
> -                                   -I${STAGING_DIR_TARGET}/usr/include/interface/vmcs_host/linux'"
> +EXTRA_OECONF_append_rpi = " CPPFLAGS='-I${STAGING_INCDIR}/interface/vcos/pthreads \
> +                                   -I${STAGING_INCDIR}/interface/vmcs_host/linux'"
> +
> +# if using bcm driver then enable dispmanx, other

Comment seems to be truncated?

> +
> +PACKAGECONFIG[dispmanx] = "--enable-dispmanx,--disable-dispmanx,userland"

Typical style is to put PACKAGECONFIG[foo] lines after defining PACKAGECONFIG.

> +PACKAGECONFIG_append_rpi = " "${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "", "dispmanx", d)}"

Typo, extra "

> +
> +PACKAGECONFIG_GL_rpi = "egl gles2"
> +PACKAGECONFIG_append_rpi = " hls libmms faad dispmanx"

Appending dispmanx is conditional on MACHINE_FEATURES 3 lines above.
It probably shouldn't be unconditional here.

> +
> --
> 2.10.2
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto