[morty][PATCH] lib/oe/terminal.py: use an absolute path to execute oe-gnome-terminal-phonehome

[morty][PATCH] lib/oe/terminal.py: use an absolute path to execute oe-gnome-terminal-phonehome

[Andre McCurdy]

From: Ming Liu <liu.ming50@gmail.com>

A flaw was found on my Ubuntu 14.04.5 LTS, on which that gnome-terminal is
the default terminal, when I run any of the tasks:
bitbake busybox -c menuconfig/devshell/devpyshell
bitbake virtual/kernel -c menuconfig/devshell/devpyshell

I got a error as follows:
"Failed to execute child process "oe-gnome-terminal-phonehome" (No such file or directory)"

Seems the environment of the process calling Popen is not passed to the
child process, this behaviour is a known issue in Python bug tracker:
http://bugs.python.org/issue8557

It could be fixed by using an absolute path instead per test.

Signed-off-by: Ming Liu <liu.ming50@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 2117c148ef07d84bc605768e3b3671b0126b9337)
Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 meta/lib/oe/terminal.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/lib/oe/terminal.py b/meta/lib/oe/terminal.py
index 3c8ef59..df4c75b 100644
--- a/meta/lib/oe/terminal.py
+++ b/meta/lib/oe/terminal.py
@@ -67,7 +67,7 @@ class Gnome(XTerminal):
         import tempfile
         pidfile = tempfile.NamedTemporaryFile(delete = False).name
         try:
-            sh_cmd = "oe-gnome-terminal-phonehome " + pidfile + " " + sh_cmd
+            sh_cmd = bb.utils.which(os.getenv('PATH'), "oe-gnome-terminal-phonehome") + " " + pidfile + " " + sh_cmd
             XTerminal.__init__(self, sh_cmd, title, env, d)
             while os.stat(pidfile).st_size <= 0:
                 continue
-- 
1.9.1

Re: [morty][PATCH] lib/oe/terminal.py: use an absolute path to execute oe-gnome-terminal-phonehome

[Andre McCurdy]

On Tue, Dec 5, 2017 at 5:35 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
> From: Ming Liu <liu.ming50@gmail.com>
>
> A flaw was found on my Ubuntu 14.04.5 LTS, on which that gnome-terminal is
> the default terminal, when I run any of the tasks:
> bitbake busybox -c menuconfig/devshell/devpyshell
> bitbake virtual/kernel -c menuconfig/devshell/devpyshell
>
> I got a error as follows:
> "Failed to execute child process "oe-gnome-terminal-phonehome" (No such file or directory)"
>
> Seems the environment of the process calling Popen is not passed to the
> child process, this behaviour is a known issue in Python bug tracker:
> http://bugs.python.org/issue8557
>
> It could be fixed by using an absolute path instead per test.

Ping.

> Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> (cherry picked from commit 2117c148ef07d84bc605768e3b3671b0126b9337)
> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> ---
>  meta/lib/oe/terminal.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/lib/oe/terminal.py b/meta/lib/oe/terminal.py
> index 3c8ef59..df4c75b 100644
> --- a/meta/lib/oe/terminal.py
> +++ b/meta/lib/oe/terminal.py
> @@ -67,7 +67,7 @@ class Gnome(XTerminal):
>          import tempfile
>          pidfile = tempfile.NamedTemporaryFile(delete = False).name
>          try:
> -            sh_cmd = "oe-gnome-terminal-phonehome " + pidfile + " " + sh_cmd
> +            sh_cmd = bb.utils.which(os.getenv('PATH'), "oe-gnome-terminal-phonehome") + " " + pidfile + " " + sh_cmd
>              XTerminal.__init__(self, sh_cmd, title, env, d)
>              while os.stat(pidfile).st_size <= 0:
>                  continue
> --
> 1.9.1
>

Re: [morty][PATCH] lib/oe/terminal.py: use an absolute path to execute oe-gnome-terminal-phonehome

[Andre McCurdy]

On Tue, Jan 23, 2018 at 12:16 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
> On Tue, Dec 5, 2017 at 5:35 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
>> From: Ming Liu <liu.ming50@gmail.com>
>>
>> A flaw was found on my Ubuntu 14.04.5 LTS, on which that gnome-terminal is
>> the default terminal, when I run any of the tasks:
>> bitbake busybox -c menuconfig/devshell/devpyshell
>> bitbake virtual/kernel -c menuconfig/devshell/devpyshell
>>
>> I got a error as follows:
>> "Failed to execute child process "oe-gnome-terminal-phonehome" (No such file or directory)"
>>
>> Seems the environment of the process calling Popen is not passed to the
>> child process, this behaviour is a known issue in Python bug tracker:
>> http://bugs.python.org/issue8557
>>
>> It could be fixed by using an absolute path instead per test.
>
> Ping.

Ping again.

>> Signed-off-by: Ming Liu <liu.ming50@gmail.com>
>> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>> (cherry picked from commit 2117c148ef07d84bc605768e3b3671b0126b9337)
>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>> ---
>>  meta/lib/oe/terminal.py | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/lib/oe/terminal.py b/meta/lib/oe/terminal.py
>> index 3c8ef59..df4c75b 100644
>> --- a/meta/lib/oe/terminal.py
>> +++ b/meta/lib/oe/terminal.py
>> @@ -67,7 +67,7 @@ class Gnome(XTerminal):
>>          import tempfile
>>          pidfile = tempfile.NamedTemporaryFile(delete = False).name
>>          try:
>> -            sh_cmd = "oe-gnome-terminal-phonehome " + pidfile + " " + sh_cmd
>> +            sh_cmd = bb.utils.which(os.getenv('PATH'), "oe-gnome-terminal-phonehome") + " " + pidfile + " " + sh_cmd
>>              XTerminal.__init__(self, sh_cmd, title, env, d)
>>              while os.stat(pidfile).st_size <= 0:
>>                  continue
>> --
>> 1.9.1
>>

Re: [morty][PATCH] lib/oe/terminal.py: use an absolute path to execute oe-gnome-terminal-phonehome

[Andre McCurdy]

On Wed, Feb 21, 2018 at 1:40 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
> On Tue, Jan 23, 2018 at 12:16 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
>> On Tue, Dec 5, 2017 at 5:35 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
>>> From: Ming Liu <liu.ming50@gmail.com>
>>>
>>> A flaw was found on my Ubuntu 14.04.5 LTS, on which that gnome-terminal is
>>> the default terminal, when I run any of the tasks:
>>> bitbake busybox -c menuconfig/devshell/devpyshell
>>> bitbake virtual/kernel -c menuconfig/devshell/devpyshell
>>>
>>> I got a error as follows:
>>> "Failed to execute child process "oe-gnome-terminal-phonehome" (No such file or directory)"
>>>
>>> Seems the environment of the process calling Popen is not passed to the
>>> child process, this behaviour is a known issue in Python bug tracker:
>>> http://bugs.python.org/issue8557
>>>
>>> It could be fixed by using an absolute path instead per test.
>>
>> Ping.
>
> Ping again.

And again...

It looks like this (and a couple of other patches) made it as far as:

  http://git.openembedded.org/openembedded-core-contrib/log/?h=stable/morty-next

but then got stuck or forgotten?

>>> Signed-off-by: Ming Liu <liu.ming50@gmail.com>
>>> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>>> (cherry picked from commit 2117c148ef07d84bc605768e3b3671b0126b9337)
>>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>>> ---
>>>  meta/lib/oe/terminal.py | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/lib/oe/terminal.py b/meta/lib/oe/terminal.py
>>> index 3c8ef59..df4c75b 100644
>>> --- a/meta/lib/oe/terminal.py
>>> +++ b/meta/lib/oe/terminal.py
>>> @@ -67,7 +67,7 @@ class Gnome(XTerminal):
>>>          import tempfile
>>>          pidfile = tempfile.NamedTemporaryFile(delete = False).name
>>>          try:
>>> -            sh_cmd = "oe-gnome-terminal-phonehome " + pidfile + " " + sh_cmd
>>> +            sh_cmd = bb.utils.which(os.getenv('PATH'), "oe-gnome-terminal-phonehome") + " " + pidfile + " " + sh_cmd
>>>              XTerminal.__init__(self, sh_cmd, title, env, d)
>>>              while os.stat(pidfile).st_size <= 0:
>>>                  continue
>>> --
>>> 1.9.1
>>>

Re: [morty][PATCH] lib/oe/terminal.py: use an absolute path to execute oe-gnome-terminal-phonehome

[Andre McCurdy]

On Fri, Mar 9, 2018 at 8:15 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
> On Wed, Feb 21, 2018 at 1:40 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
>> On Tue, Jan 23, 2018 at 12:16 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
>>> On Tue, Dec 5, 2017 at 5:35 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
>>>> From: Ming Liu <liu.ming50@gmail.com>
>>>>
>>>> A flaw was found on my Ubuntu 14.04.5 LTS, on which that gnome-terminal is
>>>> the default terminal, when I run any of the tasks:
>>>> bitbake busybox -c menuconfig/devshell/devpyshell
>>>> bitbake virtual/kernel -c menuconfig/devshell/devpyshell
>>>>
>>>> I got a error as follows:
>>>> "Failed to execute child process "oe-gnome-terminal-phonehome" (No such file or directory)"
>>>>
>>>> Seems the environment of the process calling Popen is not passed to the
>>>> child process, this behaviour is a known issue in Python bug tracker:
>>>> http://bugs.python.org/issue8557
>>>>
>>>> It could be fixed by using an absolute path instead per test.
>>>
>>> Ping.
>>
>> Ping again.
>
> And again...
>
> It looks like this (and a couple of other patches) made it as far as:
>
>   http://git.openembedded.org/openembedded-core-contrib/log/?h=stable/morty-next
>
> but then got stuck or forgotten?

Ping number four.

As an interesting data point, it's now over 20 months since the bug
was introduced and first reported on the mailing list:

  http://lists.openembedded.org/pipermail/openembedded-core/2016-July/124215.html

Re: [morty][PATCH] lib/oe/terminal.py: use an absolute path to execute oe-gnome-terminal-phonehome

[Richard Purdie]

On Wed, 2018-03-28 at 15:55 -0700, Andre McCurdy wrote:
> On Fri, Mar 9, 2018 at 8:15 PM, Andre McCurdy <armccurdy@gmail.com>
> wrote:
> > 
> > On Wed, Feb 21, 2018 at 1:40 PM, Andre McCurdy <armccurdy@gmail.com
> > > wrote:
> > > 
> > > On Tue, Jan 23, 2018 at 12:16 PM, Andre McCurdy <armccurdy@gmail.
> > > com> wrote:
> > > > 
> > > > On Tue, Dec 5, 2017 at 5:35 PM, Andre McCurdy <armccurdy@gmail.
> > > > com> wrote:
> > > > > 
> > > > > From: Ming Liu <liu.ming50@gmail.com>
> > > > > 
> > > > > A flaw was found on my Ubuntu 14.04.5 LTS, on which that
> > > > > gnome-terminal is
> > > > > the default terminal, when I run any of the tasks:
> > > > > bitbake busybox -c menuconfig/devshell/devpyshell
> > > > > bitbake virtual/kernel -c menuconfig/devshell/devpyshell
> > > > > 
> > > > > I got a error as follows:
> > > > > "Failed to execute child process "oe-gnome-terminal-
> > > > > phonehome" (No such file or directory)"
> > > > > 
> > > > > Seems the environment of the process calling Popen is not
> > > > > passed to the
> > > > > child process, this behaviour is a known issue in Python bug
> > > > > tracker:
> > > > > http://bugs.python.org/issue8557
> > > > > 
> > > > > It could be fixed by using an absolute path instead per test.
> > > > Ping.
> > > Ping again.
> > And again...
> > 
> > It looks like this (and a couple of other patches) made it as far
> > as:
> > 
> >   http://git.openembedded.org/openembedded-core-contrib/log/?h=stab
> > le/morty-next
> > 
> > but then got stuck or forgotten?
> Ping number four.
> 
> As an interesting data point, it's now over 20 months since the bug
> was introduced and first reported on the mailing list:
> 
>   http://lists.openembedded.org/pipermail/openembedded-core/2016-July
> /124215.html

Sorry, I think the problem is my mail archives don't seem to have this
original patch. Each time there is a ping, I go and try and find it,
get confused and then get distracted. I have no idea why this isn't
there.

I've queued it in morty-next which should give some hope to this
getting sorted, assuming we can fix the other morty breakage and get
clean builds.

Cheers,

Richard

Re: [morty][PATCH] lib/oe/terminal.py: use an absolute path to execute oe-gnome-terminal-phonehome

[Andre McCurdy]

On Fri, Mar 30, 2018 at 2:13 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Wed, 2018-03-28 at 15:55 -0700, Andre McCurdy wrote:
>> On Fri, Mar 9, 2018 at 8:15 PM, Andre McCurdy <armccurdy@gmail.com>
>> wrote:
>> >
>> > On Wed, Feb 21, 2018 at 1:40 PM, Andre McCurdy <armccurdy@gmail.com
>> > > wrote:
>> > >
>> > > On Tue, Jan 23, 2018 at 12:16 PM, Andre McCurdy <armccurdy@gmail.
>> > > com> wrote:
>> > > >
>> > > > On Tue, Dec 5, 2017 at 5:35 PM, Andre McCurdy <armccurdy@gmail.
>> > > > com> wrote:
>> > > > >
>> > > > > From: Ming Liu <liu.ming50@gmail.com>
>> > > > >
>> > > > > A flaw was found on my Ubuntu 14.04.5 LTS, on which that
>> > > > > gnome-terminal is
>> > > > > the default terminal, when I run any of the tasks:
>> > > > > bitbake busybox -c menuconfig/devshell/devpyshell
>> > > > > bitbake virtual/kernel -c menuconfig/devshell/devpyshell
>> > > > >
>> > > > > I got a error as follows:
>> > > > > "Failed to execute child process "oe-gnome-terminal-
>> > > > > phonehome" (No such file or directory)"
>> > > > >
>> > > > > Seems the environment of the process calling Popen is not
>> > > > > passed to the
>> > > > > child process, this behaviour is a known issue in Python bug
>> > > > > tracker:
>> > > > > http://bugs.python.org/issue8557
>> > > > >
>> > > > > It could be fixed by using an absolute path instead per test.
>> > > > Ping.
>> > > Ping again.
>> > And again...
>> >
>> > It looks like this (and a couple of other patches) made it as far
>> > as:
>> >
>> >   http://git.openembedded.org/openembedded-core-contrib/log/?h=stab
>> > le/morty-next
>> >
>> > but then got stuck or forgotten?
>> Ping number four.
>>
>> As an interesting data point, it's now over 20 months since the bug
>> was introduced and first reported on the mailing list:
>>
>>   http://lists.openembedded.org/pipermail/openembedded-core/2016-July
>> /124215.html
>
> Sorry, I think the problem is my mail archives don't seem to have this
> original patch. Each time there is a ping, I go and try and find it,
> get confused and then get distracted. I have no idea why this isn't
> there.

A bit of a mystery. It looks like Armin may have had a similar problem
taking the patch from the mailing list as the version he checked in
has a spurious whitespace change which wasn't there in the original:

  http://lists.openembedded.org/pipermail/openembedded-core/2017-December/145305.html
  http://git.openembedded.org/openembedded-core-contrib/commit/?h=stable/morty-next&id=4c36c5110b822eeac06b2b336917ba4d8b54a247

> I've queued it in morty-next which should give some hope to this
> getting sorted, assuming we can fix the other morty breakage and get
> clean builds.

Thanks.

[morty][PATCH] lib/oe/terminal.py: use an absolute path to execute oe-gnome-terminal-phonehome

[Andre McCurdy]

From: Ming Liu <liu.ming50@gmail.com>

A flaw was found on my Ubuntu 14.04.5 LTS, on which that gnome-terminal is
the default terminal, when I run any of the tasks:
bitbake busybox -c menuconfig/devshell/devpyshell
bitbake virtual/kernel -c menuconfig/devshell/devpyshell

I got a error as follows:
"Failed to execute child process "oe-gnome-terminal-phonehome" (No such file or directory)"

Seems the environment of the process calling Popen is not passed to the
child process, this behaviour is a known issue in Python bug tracker:
http://bugs.python.org/issue8557

It could be fixed by using an absolute path instead per test.

Signed-off-by: Ming Liu <liu.ming50@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 2117c148ef07d84bc605768e3b3671b0126b9337)
Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 meta/lib/oe/terminal.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/lib/oe/terminal.py b/meta/lib/oe/terminal.py
index 3c8ef59..df4c75b 100644
--- a/meta/lib/oe/terminal.py
+++ b/meta/lib/oe/terminal.py
@@ -67,7 +67,7 @@ class Gnome(XTerminal):
         import tempfile
         pidfile = tempfile.NamedTemporaryFile(delete = False).name
         try:
-            sh_cmd = "oe-gnome-terminal-phonehome " + pidfile + " " + sh_cmd
+            sh_cmd = bb.utils.which(os.getenv('PATH'), "oe-gnome-terminal-phonehome") + " " + pidfile + " " + sh_cmd
             XTerminal.__init__(self, sh_cmd, title, env, d)
             while os.stat(pidfile).st_size <= 0:
                 continue
-- 
1.9.1