From: Magnus Karlsson <magnus.karlsson@gmail.com> To: kernel test robot <lkp@intel.com> Cc: "Björn Töpel" <bjorn.topel@gmail.com>, "Network Development" <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>, kbuild-all@lists.01.org, "Björn Töpel" <bjorn.topel@intel.com>, "Karlsson, Magnus" <magnus.karlsson@intel.com>, "Alexei Starovoitov" <ast@kernel.org>, "Daniel Borkmann" <daniel@iogearbox.net>, "Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>, "Samudrala, Sridhar" <sridhar.samudrala@intel.com>, "Brandeburg, Jesse" <jesse.brandeburg@intel.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com> Subject: Re: [PATCH bpf-next v3 06/10] xsk: propagate napi_id to XDP socket Rx path Date: Thu, 30 Sep 2021 08:04:06 +0200 [thread overview] Message-ID: <CAJ8uoz3g6wzkTYRb4qq4aj+KDVGUfyZ6O6NkMK_t-EBp07igOg@mail.gmail.com> (raw) In-Reply-To: <202109300212.l6Ky1gNu-lkp@intel.com> On Wed, Sep 29, 2021 at 8:37 PM kernel test robot <lkp@intel.com> wrote: > > Hi "Björn, > > I love your patch! Yet something to improve: > > [auto build test ERROR on 4e99d115d865d45e17e83478d757b58d8fa66d3c] > > url: https://github.com/0day-ci/linux/commits/Bj-rn-T-pel/Introduce-preferred-busy-polling/20210929-234934 > base: 4e99d115d865d45e17e83478d757b58d8fa66d3c > config: um-kunit_defconfig (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce (this is a W=1 build): > # https://github.com/0day-ci/linux/commit/f481c00164924dd5d782a92cc67897cc7f804502 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Bj-rn-T-pel/Introduce-preferred-busy-polling/20210929-234934 > git checkout f481c00164924dd5d782a92cc67897cc7f804502 > # save the attached .config to linux build tree > mkdir build_dir > make W=1 O=build_dir ARCH=um SHELL=/bin/bash > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): > > cc1: warning: arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] > In file included from fs/select.c:32: > include/net/busy_poll.h: In function 'sk_mark_napi_id_once': > >> include/net/busy_poll.h:150:36: error: 'const struct sk_buff' has no member named 'napi_id' > 150 | __sk_mark_napi_id_once_xdp(sk, skb->napi_id); > | ^~ > > > vim +150 include/net/busy_poll.h > > 145 > 146 /* variant used for unconnected sockets */ > 147 static inline void sk_mark_napi_id_once(struct sock *sk, > 148 const struct sk_buff *skb) > 149 { > > 150 __sk_mark_napi_id_once_xdp(sk, skb->napi_id); > 151 } > 152 It seems that the robot tested an old commit and that this was already fixed by Daniel 10 months ago. Slow mail delivery, a robot glitch, or am I missing something? commit ba0581749fec389e55c9d761f2716f8fcbefced5 Author: Daniel Borkmann <daniel@iogearbox.net> Date: Tue Dec 1 15:22:59 2020 +0100 net, xdp, xsk: fix __sk_mark_napi_id_once napi_id error Stephen reported the following build error for !CONFIG_NET_RX_BUSY_POLL built kernels: In file included from fs/select.c:32: include/net/busy_poll.h: In function 'sk_mark_napi_id_once': include/net/busy_poll.h:150:36: error: 'const struct sk_buff' has no member named 'napi_id' 150 | __sk_mark_napi_id_once_xdp(sk, skb->napi_id); | ^~ Fix it by wrapping a CONFIG_NET_RX_BUSY_POLL around the helpers. Fixes: b02e5a0ebb17 ("xsk: Propagate napi_id to XDP socket Rx path") Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Cc: Björn Töpel <bjorn.topel@intel.com> Link: https://lore.kernel.org/linux-next/20201201190746.7d3357fb@canb.auug.org.au > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Magnus Karlsson <magnus.karlsson@gmail.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH bpf-next v3 06/10] xsk: propagate napi_id to XDP socket Rx path Date: Thu, 30 Sep 2021 08:04:06 +0200 [thread overview] Message-ID: <CAJ8uoz3g6wzkTYRb4qq4aj+KDVGUfyZ6O6NkMK_t-EBp07igOg@mail.gmail.com> (raw) In-Reply-To: <202109300212.l6Ky1gNu-lkp@intel.com> [-- Attachment #1: Type: text/plain, Size: 3317 bytes --] On Wed, Sep 29, 2021 at 8:37 PM kernel test robot <lkp@intel.com> wrote: > > Hi "Björn, > > I love your patch! Yet something to improve: > > [auto build test ERROR on 4e99d115d865d45e17e83478d757b58d8fa66d3c] > > url: https://github.com/0day-ci/linux/commits/Bj-rn-T-pel/Introduce-preferred-busy-polling/20210929-234934 > base: 4e99d115d865d45e17e83478d757b58d8fa66d3c > config: um-kunit_defconfig (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce (this is a W=1 build): > # https://github.com/0day-ci/linux/commit/f481c00164924dd5d782a92cc67897cc7f804502 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Bj-rn-T-pel/Introduce-preferred-busy-polling/20210929-234934 > git checkout f481c00164924dd5d782a92cc67897cc7f804502 > # save the attached .config to linux build tree > mkdir build_dir > make W=1 O=build_dir ARCH=um SHELL=/bin/bash > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): > > cc1: warning: arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] > In file included from fs/select.c:32: > include/net/busy_poll.h: In function 'sk_mark_napi_id_once': > >> include/net/busy_poll.h:150:36: error: 'const struct sk_buff' has no member named 'napi_id' > 150 | __sk_mark_napi_id_once_xdp(sk, skb->napi_id); > | ^~ > > > vim +150 include/net/busy_poll.h > > 145 > 146 /* variant used for unconnected sockets */ > 147 static inline void sk_mark_napi_id_once(struct sock *sk, > 148 const struct sk_buff *skb) > 149 { > > 150 __sk_mark_napi_id_once_xdp(sk, skb->napi_id); > 151 } > 152 It seems that the robot tested an old commit and that this was already fixed by Daniel 10 months ago. Slow mail delivery, a robot glitch, or am I missing something? commit ba0581749fec389e55c9d761f2716f8fcbefced5 Author: Daniel Borkmann <daniel@iogearbox.net> Date: Tue Dec 1 15:22:59 2020 +0100 net, xdp, xsk: fix __sk_mark_napi_id_once napi_id error Stephen reported the following build error for !CONFIG_NET_RX_BUSY_POLL built kernels: In file included from fs/select.c:32: include/net/busy_poll.h: In function 'sk_mark_napi_id_once': include/net/busy_poll.h:150:36: error: 'const struct sk_buff' has no member named 'napi_id' 150 | __sk_mark_napi_id_once_xdp(sk, skb->napi_id); | ^~ Fix it by wrapping a CONFIG_NET_RX_BUSY_POLL around the helpers. Fixes: b02e5a0ebb17 ("xsk: Propagate napi_id to XDP socket Rx path") Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Cc: Björn Töpel <bjorn.topel@intel.com> Link: https://lore.kernel.org/linux-next/20201201190746.7d3357fb(a)canb.auug.org.au > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2021-09-30 6:04 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-19 8:30 [PATCH bpf-next v3 00/10] Introduce preferred busy-polling Björn Töpel 2020-11-19 8:30 ` [PATCH bpf-next v3 01/10] net: introduce " Björn Töpel 2020-11-24 0:04 ` Jakub Kicinski 2020-11-24 7:58 ` Björn Töpel 2020-11-24 0:11 ` Jakub Kicinski 2020-11-24 8:47 ` Björn Töpel 2020-11-24 16:21 ` Jakub Kicinski 2020-11-19 8:30 ` [PATCH bpf-next v3 02/10] net: add SO_BUSY_POLL_BUDGET socket option Björn Töpel 2020-11-24 16:21 ` Jakub Kicinski 2020-11-19 8:30 ` [PATCH bpf-next v3 03/10] xsk: add support for recvmsg() Björn Töpel 2020-11-25 6:55 ` Magnus Karlsson 2020-11-19 8:30 ` [PATCH bpf-next v3 04/10] xsk: check need wakeup flag in sendmsg() Björn Töpel 2020-11-25 7:16 ` Magnus Karlsson 2020-11-19 8:30 ` [PATCH bpf-next v3 05/10] xsk: add busy-poll support for {recv,send}msg() Björn Töpel 2020-11-25 7:58 ` Magnus Karlsson 2020-11-19 8:30 ` [PATCH bpf-next v3 06/10] xsk: propagate napi_id to XDP socket Rx path Björn Töpel 2020-11-19 8:30 ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?= 2020-11-25 14:47 ` Magnus Karlsson 2020-11-25 14:47 ` [Intel-wired-lan] " Magnus Karlsson 2020-11-25 21:14 ` Michael S. Tsirkin 2020-11-25 21:14 ` [Intel-wired-lan] " Michael S. Tsirkin 2021-09-29 18:33 ` kernel test robot 2021-09-29 18:33 ` kernel test robot 2021-09-30 6:04 ` Magnus Karlsson [this message] 2021-09-30 6:04 ` Magnus Karlsson 2021-10-02 2:07 ` [kbuild-all] " Philip Li 2021-10-02 2:07 ` Philip Li 2021-11-05 20:17 ` kernel test robot 2021-11-05 20:17 ` kernel test robot 2020-11-19 8:30 ` [PATCH bpf-next v3 07/10] samples/bpf: use recvfrom() in xdpsock/rxdrop Björn Töpel 2020-11-25 7:59 ` Magnus Karlsson 2020-11-19 8:30 ` [PATCH bpf-next v3 08/10] samples/bpf: use recvfrom() in xdpsock/l2fwd Björn Töpel 2020-11-25 8:00 ` Magnus Karlsson 2020-11-19 8:30 ` [PATCH bpf-next v3 09/10] samples/bpf: add busy-poll support to xdpsock Björn Töpel 2020-11-25 8:19 ` Magnus Karlsson 2020-11-19 8:30 ` [PATCH bpf-next v3 10/10] samples/bpf: add option to set the busy-poll budget Björn Töpel 2020-11-25 8:23 ` Magnus Karlsson 2020-11-23 13:31 ` [PATCH bpf-next v3 00/10] Introduce preferred busy-polling Björn Töpel 2020-11-23 23:54 ` Jakub Kicinski 2020-11-24 0:14 ` Jakub Kicinski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAJ8uoz3g6wzkTYRb4qq4aj+KDVGUfyZ6O6NkMK_t-EBp07igOg@mail.gmail.com \ --to=magnus.karlsson@gmail.com \ --cc=ast@kernel.org \ --cc=bjorn.topel@gmail.com \ --cc=bjorn.topel@intel.com \ --cc=bpf@vger.kernel.org \ --cc=daniel@iogearbox.net \ --cc=jesse.brandeburg@intel.com \ --cc=kbuild-all@lists.01.org \ --cc=lkp@intel.com \ --cc=maciej.fijalkowski@intel.com \ --cc=magnus.karlsson@intel.com \ --cc=netdev@vger.kernel.org \ --cc=qi.z.zhang@intel.com \ --cc=sridhar.samudrala@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.