From: Mike Leach <mike.leach@linaro.org>
To: carsten.haitzler@foss.arm.com
Cc: linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
suzuki.poulose@arm.com, mathieu.poirier@linaro.org,
leo.yan@linaro.org, acme@kernel.org
Subject: Re: [PATCH 09/12] perf test: Add add memcpy test for coresight quality checking
Date: Fri, 4 Feb 2022 10:43:18 +0000 [thread overview]
Message-ID: <CAJ9a7VjWPP+dyXBvb0-mVYXAQV0QPd2dkyi2zdwOVg_z_AiVhw@mail.gmail.com> (raw)
In-Reply-To: <20211215160403.69264-9-carsten.haitzler@foss.arm.com>
Hi Carsten
From a trace ouput perspective, this test doesn't really add coverage
on top of what has gone before.
We only have instruction trace - so the data operations of the memcpy
do not result in any trace output.
From a trace perspective, memcpy is a tight loop - probably resulting
in a single atom element for each iteration, and nothing in between.
For this reason, I think this test, and the threaded memcpy test in
the next patch can be dropped.
Regards
Mike
On Wed, 15 Dec 2021 at 16:04, <carsten.haitzler@foss.arm.com> wrote:
>
> From: Carsten Haitzler <carsten.haitzler@arm.com>
>
> This adds memory bound tests for quality checking perf's aux data
> recording.
>
> Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
> ---
> tools/perf/tests/shell/coresight_memcpy_1m.sh | 18 +++++++++
> .../perf/tests/shell/coresight_memcpy_32m.sh | 18 +++++++++
> .../perf/tests/shell/coresight_memcpy_64k.sh | 18 +++++++++
> .../perf/tests/shell/tools/coresight/Makefile | 3 +-
> .../shell/tools/coresight/memcpy/Makefile | 29 ++++++++++++++
> .../shell/tools/coresight/memcpy/memcpy.c | 40 +++++++++++++++++++
> 6 files changed, 125 insertions(+), 1 deletion(-)
> create mode 100755 tools/perf/tests/shell/coresight_memcpy_1m.sh
> create mode 100755 tools/perf/tests/shell/coresight_memcpy_32m.sh
> create mode 100755 tools/perf/tests/shell/coresight_memcpy_64k.sh
> create mode 100644 tools/perf/tests/shell/tools/coresight/memcpy/Makefile
> create mode 100644 tools/perf/tests/shell/tools/coresight/memcpy/memcpy.c
>
> diff --git a/tools/perf/tests/shell/coresight_memcpy_1m.sh b/tools/perf/tests/shell/coresight_memcpy_1m.sh
> new file mode 100755
> index 000000000000..fa1c28d73b66
> --- /dev/null
> +++ b/tools/perf/tests/shell/coresight_memcpy_1m.sh
> @@ -0,0 +1,18 @@
> +#!/bin/sh -e
> +# Coresight / Memcpy 1M
> +
> +# SPDX-License-Identifier: GPL-2.0
> +# Carsten Haitzler <carsten.haitzler@arm.com>, 2021
> +
> +TEST="memcpy"
> +. $(dirname $0)/lib/coresight.sh
> +ARGS="1024 2"
> +DATV="1m"
> +DATA="$DATD/perf-$TEST-$DATV.data"
> +
> +perf record $PERFRECOPT -o "$DATA" "$BIN" $ARGS
> +
> +perf_dump_aux_verify "$DATA" 39 766 766
> +
> +err=$?
> +exit $err
> diff --git a/tools/perf/tests/shell/coresight_memcpy_32m.sh b/tools/perf/tests/shell/coresight_memcpy_32m.sh
> new file mode 100755
> index 000000000000..4ab5459e3824
> --- /dev/null
> +++ b/tools/perf/tests/shell/coresight_memcpy_32m.sh
> @@ -0,0 +1,18 @@
> +#!/bin/sh -e
> +# Coresight / Memcpy 32M
> +
> +# SPDX-License-Identifier: GPL-2.0
> +# Carsten Haitzler <carsten.haitzler@arm.com>, 2021
> +
> +TEST="memcpy"
> +. $(dirname $0)/lib/coresight.sh
> +ARGS="32768 1"
> +DATV="32m"
> +DATA="$DATD/perf-$TEST-$DATV.data"
> +
> +perf record $PERFRECOPT -o "$DATA" "$BIN" $ARGS
> +
> +perf_dump_aux_verify "$DATA" 39 7804 7804
> +
> +err=$?
> +exit $err
> diff --git a/tools/perf/tests/shell/coresight_memcpy_64k.sh b/tools/perf/tests/shell/coresight_memcpy_64k.sh
> new file mode 100755
> index 000000000000..5b6ba2a6d394
> --- /dev/null
> +++ b/tools/perf/tests/shell/coresight_memcpy_64k.sh
> @@ -0,0 +1,18 @@
> +#!/bin/sh -e
> +# Coresight / Memcpy 64K
> +
> +# SPDX-License-Identifier: GPL-2.0
> +# Carsten Haitzler <carsten.haitzler@arm.com>, 2021
> +
> +TEST="memcpy"
> +. $(dirname $0)/lib/coresight.sh
> +ARGS="64 40"
> +DATV="64k"
> +DATA="$DATD/perf-$TEST-$DATV.data"
> +
> +perf record $PERFRECOPT -o "$DATA" "$BIN" $ARGS
> +
> +perf_dump_aux_verify "$DATA" 40 934 934
> +
> +err=$?
> +exit $err
> diff --git a/tools/perf/tests/shell/tools/coresight/Makefile b/tools/perf/tests/shell/tools/coresight/Makefile
> index a1a752f45c46..99030c889b04 100644
> --- a/tools/perf/tests/shell/tools/coresight/Makefile
> +++ b/tools/perf/tests/shell/tools/coresight/Makefile
> @@ -8,7 +8,8 @@ SUBDIRS = \
> asm_pure_loop \
> thread_loop \
> bubble_sort \
> - bubble_sort_thread
> + bubble_sort_thread \
> + memcpy
>
> all: $(SUBDIRS)
> $(SUBDIRS):
> diff --git a/tools/perf/tests/shell/tools/coresight/memcpy/Makefile b/tools/perf/tests/shell/tools/coresight/memcpy/Makefile
> new file mode 100644
> index 000000000000..7c31fe4ec399
> --- /dev/null
> +++ b/tools/perf/tests/shell/tools/coresight/memcpy/Makefile
> @@ -0,0 +1,29 @@
> +# SPDX-License-Identifier: GPL-2.0
> +# Carsten Haitzler <carsten.haitzler@arm.com>, 2021
> +include ../Makefile.miniconfig
> +
> +BIN=memcpy
> +LIB=
> +
> +all: $(BIN)
> +
> +$(BIN): $(BIN).c
> +ifdef CORESIGHT
> +ifeq ($(ARCH),arm64)
> + $(Q)$(CC) $(BIN).c -o $(BIN) $(LIB)
> +endif
> +endif
> +
> +install-tests: all
> +ifdef CORESIGHT
> +ifeq ($(ARCH),arm64)
> + $(call QUIET_INSTALL, tests) \
> + $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/tools/$(BIN)'; \
> + $(INSTALL) $(BIN) '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/tools/$(BIN)/$(BIN)'
> +endif
> +endif
> +
> +clean:
> + $(Q)$(RM) -f $(BIN)
> +
> +.PHONY: all clean install-tests
> diff --git a/tools/perf/tests/shell/tools/coresight/memcpy/memcpy.c b/tools/perf/tests/shell/tools/coresight/memcpy/memcpy.c
> new file mode 100644
> index 000000000000..1aa0617448ad
> --- /dev/null
> +++ b/tools/perf/tests/shell/tools/coresight/memcpy/memcpy.c
> @@ -0,0 +1,40 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Carsten Haitzler <carsten.haitzler@arm.com>, 2021
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <unistd.h>
> +#include <string.h>
> +
> +int main(int argc, char **argv)
> +{
> + unsigned long i, len, size;
> + unsigned char *src, *dst;
> + long long v;
> +
> + if (argc < 3) {
> + printf("ERR: %s [copysize Kb] [numloops (hundreds)]\n", argv[0]);
> + exit(1);
> + }
> +
> + v = atoll(argv[1]);
> + if ((v < 1) || (v > (1024 * 1024))) {
> + printf("ERR: max memory 1GB (1048576 KB)\n");
> + exit(1);
> + }
> + size = v;
> + v = atoll(argv[2]);
> + if ((v < 1) || (v > 40000000000ll)) {
> + printf("ERR: loops 1-40000000000 (hundreds)\n");
> + exit(1);
> + }
> + len = v * 100;
> + src = malloc(size * 1024);
> + dst = malloc(size * 1024);
> + if ((!src) || (!dst)) {
> + printf("ERR: Can't allocate memory\n");
> + exit(1);
> + }
> + for (i = 0; i < len; i++)
> + memcpy(dst, src, size * 1024);
> + return 0;
> +}
> --
> 2.32.0
>
--
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK
next prev parent reply other threads:[~2022-02-04 10:43 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 16:03 [PATCH 01/12] perf test: Shell - Limit to only run executable scripts in tests carsten.haitzler
2021-12-15 16:03 ` [PATCH 02/12] perf test: Shell - only run .sh shell files to skip other files carsten.haitzler
2021-12-16 10:22 ` Daniel Thompson
2021-12-16 19:45 ` Carsten Haitzler
2021-12-17 15:00 ` Suzuki K Poulose
2021-12-17 17:22 ` Carsten Haitzler
2021-12-15 16:03 ` [PATCH 03/12] perf test: Use 3 digits for test numbering now we can have more tests carsten.haitzler
2021-12-21 12:35 ` Leo Yan
2021-12-21 20:51 ` Arnaldo Carvalho de Melo
2021-12-15 16:03 ` [PATCH 04/12] perf test: Add beginning of test infra + test to exercise coresight carsten.haitzler
2021-12-21 15:03 ` Leo Yan
2021-12-21 20:40 ` Arnaldo Carvalho de Melo
2022-01-04 15:15 ` Carsten Haitzler
2022-01-04 15:14 ` Carsten Haitzler
2022-01-19 16:58 ` James Clark
2022-02-04 10:21 ` Mike Leach
2021-12-15 16:03 ` [PATCH 05/12] perf test: Add coresight test to check all threads get some data logged carsten.haitzler
2022-01-03 7:07 ` Leo Yan
2022-01-04 15:01 ` Carsten Haitzler
2021-12-15 16:03 ` [PATCH 06/12] perf test: Add tests to re-use the thread loop test to check aux data carsten.haitzler
2022-02-04 10:36 ` Mike Leach
2021-12-15 16:03 ` [PATCH 07/12] perf test: Add simple bubblesort test for coresight " carsten.haitzler
2022-01-03 8:00 ` Leo Yan
2022-01-04 15:13 ` Carsten Haitzler
2022-01-12 9:54 ` Leo Yan
2021-12-15 16:03 ` [PATCH 08/12] perf test: Add threaded bubblesort tests for coresight carsten.haitzler
2021-12-15 16:04 ` [PATCH 09/12] perf test: Add add memcpy test for coresight quality checking carsten.haitzler
2022-02-04 10:43 ` Mike Leach [this message]
2021-12-15 16:04 ` [PATCH 10/12] perf test: Add threaded memcpy tests to check coresight aux data carsten.haitzler
2021-12-15 16:04 ` [PATCH 11/12] perf test: Add unrolled loop tests for " carsten.haitzler
2022-02-04 10:51 ` Mike Leach
2021-12-15 16:04 ` [PATCH 12/12] perf test: Add docs for coresight and related tests carsten.haitzler
2022-01-19 16:43 ` James Clark
2022-01-31 18:05 ` Carsten Haitzler
2022-02-04 14:50 ` Mike Leach
2022-03-09 12:25 ` Carsten Haitzler
2022-03-09 12:30 ` Carsten Haitzler
2021-12-17 14:55 ` [PATCH 01/12] perf test: Shell - Limit to only run executable scripts in tests Suzuki K Poulose
2021-12-17 17:18 ` Carsten Haitzler
-- strict thread matches above, loose matches on Subject: below --
2021-12-15 16:22 carsten.haitzler
2021-12-15 16:22 ` [PATCH 09/12] perf test: Add add memcpy test for coresight quality checking carsten.haitzler
2021-12-15 12:53 [PATCH 01/12] perf test: Shell - Limit to only run executable scripts in tests carsten.haitzler
2021-12-15 12:54 ` [PATCH 09/12] perf test: Add add memcpy test for coresight quality checking carsten.haitzler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ9a7VjWPP+dyXBvb0-mVYXAQV0QPd2dkyi2zdwOVg_z_AiVhw@mail.gmail.com \
--to=mike.leach@linaro.org \
--cc=acme@kernel.org \
--cc=carsten.haitzler@foss.arm.com \
--cc=coresight@lists.linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.