From: Mike Leach <mike.leach@linaro.org>
To: carsten.haitzler@foss.arm.com
Cc: linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
suzuki.poulose@arm.com, mathieu.poirier@linaro.org,
leo.yan@linaro.org, acme@kernel.org
Subject: Re: [PATCH 11/12] perf test: Add unrolled loop tests for coresight aux data
Date: Fri, 4 Feb 2022 10:51:15 +0000 [thread overview]
Message-ID: <CAJ9a7VjpnGOKjc-Kx6XBBLXZgBc-XzQx=GoRRQu2q7fSVCq_Pw@mail.gmail.com> (raw)
In-Reply-To: <20211215160403.69264-11-carsten.haitzler@foss.arm.com>
Hi Carsten,
Same comment here as for the memcpy tests - the unrolled loop will not
result in extra coverage. Irrespective of there being 1 add
instruction in the loop, or 100000 add instructions in the loop, the
output will be a single atom element at the end of the loop as a
result of the for() statement.
This test could also be dropped.
Regards
Mike
On Wed, 15 Dec 2021 at 16:04, <carsten.haitzler@foss.arm.com> wrote:
>
> From: Carsten Haitzler <carsten.haitzler@arm.com>
>
> These tests have large batches of code manually unrolled with macros
> to ensure that the processor has to walk through a lot of instructions
> and memory for those instructions to generate the coresight aux data.
>
> Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
> ---
> .../shell/coresight_unroll_loop_thread_1.sh | 18 +++++
> .../shell/coresight_unroll_loop_thread_10.sh | 18 +++++
> .../shell/coresight_unroll_loop_thread_2.sh | 18 +++++
> .../shell/coresight_unroll_loop_thread_25.sh | 18 +++++
> .../shell/coresight_unroll_loop_thread_250.sh | 18 +++++
> .../perf/tests/shell/tools/coresight/Makefile | 3 +-
> .../coresight/unroll_loop_thread/Makefile | 29 ++++++++
> .../unroll_loop_thread/unroll_loop_thread.c | 74 +++++++++++++++++++
> 8 files changed, 195 insertions(+), 1 deletion(-)
> create mode 100755 tools/perf/tests/shell/coresight_unroll_loop_thread_1.sh
> create mode 100755 tools/perf/tests/shell/coresight_unroll_loop_thread_10.sh
> create mode 100755 tools/perf/tests/shell/coresight_unroll_loop_thread_2.sh
> create mode 100755 tools/perf/tests/shell/coresight_unroll_loop_thread_25.sh
> create mode 100755 tools/perf/tests/shell/coresight_unroll_loop_thread_250.sh
> create mode 100644 tools/perf/tests/shell/tools/coresight/unroll_loop_thread/Makefile
> create mode 100644 tools/perf/tests/shell/tools/coresight/unroll_loop_thread/unroll_loop_thread.c
>
> diff --git a/tools/perf/tests/shell/coresight_unroll_loop_thread_1.sh b/tools/perf/tests/shell/coresight_unroll_loop_thread_1.sh
> new file mode 100755
> index 000000000000..9175ec532bd8
> --- /dev/null
> +++ b/tools/perf/tests/shell/coresight_unroll_loop_thread_1.sh
> @@ -0,0 +1,18 @@
> +#!/bin/sh -e
> +# Coresight / Unroll Loop Thread 1
> +
> +# SPDX-License-Identifier: GPL-2.0
> +# Carsten Haitzler <carsten.haitzler@arm.com>, 2021
> +
> +TEST="unroll_loop_thread"
> +. $(dirname $0)/lib/coresight.sh
> +ARGS="1"
> +DATV="1"
> +DATA="$DATD/perf-$TEST-$DATV.data"
> +
> +perf record $PERFRECOPT -o "$DATA" "$BIN" $ARGS
> +
> +perf_dump_aux_verify "$DATA" 118 14 14
> +
> +err=$?
> +exit $err
> diff --git a/tools/perf/tests/shell/coresight_unroll_loop_thread_10.sh b/tools/perf/tests/shell/coresight_unroll_loop_thread_10.sh
> new file mode 100755
> index 000000000000..66cf0245294e
> --- /dev/null
> +++ b/tools/perf/tests/shell/coresight_unroll_loop_thread_10.sh
> @@ -0,0 +1,18 @@
> +#!/bin/sh -e
> +# Coresight / Unroll Loop Thread 10
> +
> +# SPDX-License-Identifier: GPL-2.0
> +# Carsten Haitzler <carsten.haitzler@arm.com>, 2021
> +
> +TEST="unroll_loop_thread"
> +. $(dirname $0)/lib/coresight.sh
> +ARGS="10"
> +DATV="10"
> +DATA="$DATD/perf-$TEST-$DATV.data"
> +
> +perf record $PERFRECOPT -o "$DATA" "$BIN" $ARGS
> +
> +perf_dump_aux_verify "$DATA" 127 17 17
> +
> +err=$?
> +exit $err
> diff --git a/tools/perf/tests/shell/coresight_unroll_loop_thread_2.sh b/tools/perf/tests/shell/coresight_unroll_loop_thread_2.sh
> new file mode 100755
> index 000000000000..ff2e293699b0
> --- /dev/null
> +++ b/tools/perf/tests/shell/coresight_unroll_loop_thread_2.sh
> @@ -0,0 +1,18 @@
> +#!/bin/sh -e
> +# Coresight / Unroll Loop Thread 2
> +
> +# SPDX-License-Identifier: GPL-2.0
> +# Carsten Haitzler <carsten.haitzler@arm.com>, 2021
> +
> +TEST="unroll_loop_thread"
> +. $(dirname $0)/lib/coresight.sh
> +ARGS="2"
> +DATV="2"
> +DATA="$DATD/perf-$TEST-$DATV.data"
> +
> +perf record $PERFRECOPT -o "$DATA" "$BIN" $ARGS
> +
> +perf_dump_aux_verify "$DATA" 65 6 6
> +
> +err=$?
> +exit $err
> diff --git a/tools/perf/tests/shell/coresight_unroll_loop_thread_25.sh b/tools/perf/tests/shell/coresight_unroll_loop_thread_25.sh
> new file mode 100755
> index 000000000000..7d7669a797ab
> --- /dev/null
> +++ b/tools/perf/tests/shell/coresight_unroll_loop_thread_25.sh
> @@ -0,0 +1,18 @@
> +#!/bin/sh -e
> +# Coresight / Unroll Loop Thread 25
> +
> +# SPDX-License-Identifier: GPL-2.0
> +# Carsten Haitzler <carsten.haitzler@arm.com>, 2021
> +
> +TEST="unroll_loop_thread"
> +. $(dirname $0)/lib/coresight.sh
> +ARGS="25"
> +DATV="25"
> +DATA="$DATD/perf-$TEST-$DATV.data"
> +
> +perf record $PERFRECOPT -o "$DATA" "$BIN" $ARGS
> +
> +perf_dump_aux_verify "$DATA" 72 26 25
> +
> +err=$?
> +exit $err
> diff --git a/tools/perf/tests/shell/coresight_unroll_loop_thread_250.sh b/tools/perf/tests/shell/coresight_unroll_loop_thread_250.sh
> new file mode 100755
> index 000000000000..7a0e23aff0dc
> --- /dev/null
> +++ b/tools/perf/tests/shell/coresight_unroll_loop_thread_250.sh
> @@ -0,0 +1,18 @@
> +#!/bin/sh -e
> +# Coresight / Unroll Loop Thread 250
> +
> +# SPDX-License-Identifier: GPL-2.0
> +# Carsten Haitzler <carsten.haitzler@arm.com>, 2021
> +
> +TEST="unroll_loop_thread"
> +. $(dirname $0)/lib/coresight.sh
> +ARGS="250"
> +DATV="250"
> +DATA="$DATD/perf-$TEST-$DATV.data"
> +
> +perf record $PERFRECOPT -o "$DATA" "$BIN" $ARGS
> +
> +perf_dump_aux_verify "$DATA" 544 2417 2417
> +
> +err=$?
> +exit $err
> diff --git a/tools/perf/tests/shell/tools/coresight/Makefile b/tools/perf/tests/shell/tools/coresight/Makefile
> index be671aac06b8..b9cdeff1149b 100644
> --- a/tools/perf/tests/shell/tools/coresight/Makefile
> +++ b/tools/perf/tests/shell/tools/coresight/Makefile
> @@ -10,7 +10,8 @@ SUBDIRS = \
> bubble_sort \
> bubble_sort_thread \
> memcpy \
> - memcpy_thread
> + memcpy_thread \
> + unroll_loop_thread
>
> all: $(SUBDIRS)
> $(SUBDIRS):
> diff --git a/tools/perf/tests/shell/tools/coresight/unroll_loop_thread/Makefile b/tools/perf/tests/shell/tools/coresight/unroll_loop_thread/Makefile
> new file mode 100644
> index 000000000000..45ab2be8be92
> --- /dev/null
> +++ b/tools/perf/tests/shell/tools/coresight/unroll_loop_thread/Makefile
> @@ -0,0 +1,29 @@
> +# SPDX-License-Identifier: GPL-2.0
> +# Carsten Haitzler <carsten.haitzler@arm.com>, 2021
> +include ../Makefile.miniconfig
> +
> +BIN=unroll_loop_thread
> +LIB=-pthread
> +
> +all: $(BIN)
> +
> +$(BIN): $(BIN).c
> +ifdef CORESIGHT
> +ifeq ($(ARCH),arm64)
> + $(Q)$(CC) $(BIN).c -o $(BIN) $(LIB)
> +endif
> +endif
> +
> +install-tests: all
> +ifdef CORESIGHT
> +ifeq ($(ARCH),arm64)
> + $(call QUIET_INSTALL, tests) \
> + $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/tools/$(BIN)'; \
> + $(INSTALL) $(BIN) '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/tools/$(BIN)/$(BIN)'
> +endif
> +endif
> +
> +clean:
> + $(Q)$(RM) -f $(BIN)
> +
> +.PHONY: all clean install-tests
> diff --git a/tools/perf/tests/shell/tools/coresight/unroll_loop_thread/unroll_loop_thread.c b/tools/perf/tests/shell/tools/coresight/unroll_loop_thread/unroll_loop_thread.c
> new file mode 100644
> index 000000000000..cb9d22c7dfb9
> --- /dev/null
> +++ b/tools/perf/tests/shell/tools/coresight/unroll_loop_thread/unroll_loop_thread.c
> @@ -0,0 +1,74 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Carsten Haitzler <carsten.haitzler@arm.com>, 2021
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <unistd.h>
> +#include <string.h>
> +#include <pthread.h>
> +
> +struct args {
> + pthread_t th;
> + unsigned int in, out;
> + void *ret;
> +};
> +
> +static void *thrfn(void *arg)
> +{
> + struct args *a = arg;
> + unsigned int i, in = a->in;
> +
> + for (i = 0; i < 10000; i++) {
> + asm volatile (
> +// force an unroll of thia add instruction so we can test long runs of code
> +#define SNIP1 "add %[in], %[in], #1\n"
> +// 10
> +#define SNIP2 SNIP1 SNIP1 SNIP1 SNIP1 SNIP1 SNIP1 SNIP1 SNIP1 SNIP1 SNIP1
> +// 100
> +#define SNIP3 SNIP2 SNIP2 SNIP2 SNIP2 SNIP2 SNIP2 SNIP2 SNIP2 SNIP2 SNIP2
> +// 1000
> +#define SNIP4 SNIP3 SNIP3 SNIP3 SNIP3 SNIP3 SNIP3 SNIP3 SNIP3 SNIP3 SNIP3
> +// 10000
> +#define SNIP5 SNIP4 SNIP4 SNIP4 SNIP4 SNIP4 SNIP4 SNIP4 SNIP4 SNIP4 SNIP4
> +// 100000
> + SNIP5 SNIP5 SNIP5 SNIP5 SNIP5 SNIP5 SNIP5 SNIP5 SNIP5 SNIP5
> + : /* out */
> + : /* in */ [in] "r" (in)
> + : /* clobber */
> + );
> + }
> +}
> +
> +static pthread_t new_thr(void *(*fn) (void *arg), void *arg)
> +{
> + pthread_t t;
> + pthread_attr_t attr;
> +
> + pthread_attr_init(&attr);
> + pthread_create(&t, &attr, fn, arg);
> + return t;
> +}
> +
> +int main(int argc, char **argv)
> +{
> + unsigned int i, thr;
> + pthread_t threads[256];
> + struct args args[256];
> +
> + if (argc < 2) {
> + printf("ERR: %s [numthreads]\n", argv[0]);
> + exit(1);
> + }
> +
> + thr = atoi(argv[1]);
> + if ((thr > 256) || (thr < 1)) {
> + printf("ERR: threads 1-256\n");
> + exit(1);
> + }
> + for (i = 0; i < thr; i++) {
> + args[i].in = rand();
> + args[i].th = new_thr(thrfn, &(args[i]));
> + }
> + for (i = 0; i < thr; i++)
> + pthread_join(args[i].th, &(args[i].ret));
> + return 0;
> +}
> --
> 2.32.0
>
--
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK
next prev parent reply other threads:[~2022-02-04 10:51 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 16:03 [PATCH 01/12] perf test: Shell - Limit to only run executable scripts in tests carsten.haitzler
2021-12-15 16:03 ` [PATCH 02/12] perf test: Shell - only run .sh shell files to skip other files carsten.haitzler
2021-12-16 10:22 ` Daniel Thompson
2021-12-16 19:45 ` Carsten Haitzler
2021-12-17 15:00 ` Suzuki K Poulose
2021-12-17 17:22 ` Carsten Haitzler
2021-12-15 16:03 ` [PATCH 03/12] perf test: Use 3 digits for test numbering now we can have more tests carsten.haitzler
2021-12-21 12:35 ` Leo Yan
2021-12-21 20:51 ` Arnaldo Carvalho de Melo
2021-12-15 16:03 ` [PATCH 04/12] perf test: Add beginning of test infra + test to exercise coresight carsten.haitzler
2021-12-21 15:03 ` Leo Yan
2021-12-21 20:40 ` Arnaldo Carvalho de Melo
2022-01-04 15:15 ` Carsten Haitzler
2022-01-04 15:14 ` Carsten Haitzler
2022-01-19 16:58 ` James Clark
2022-02-04 10:21 ` Mike Leach
2021-12-15 16:03 ` [PATCH 05/12] perf test: Add coresight test to check all threads get some data logged carsten.haitzler
2022-01-03 7:07 ` Leo Yan
2022-01-04 15:01 ` Carsten Haitzler
2021-12-15 16:03 ` [PATCH 06/12] perf test: Add tests to re-use the thread loop test to check aux data carsten.haitzler
2022-02-04 10:36 ` Mike Leach
2021-12-15 16:03 ` [PATCH 07/12] perf test: Add simple bubblesort test for coresight " carsten.haitzler
2022-01-03 8:00 ` Leo Yan
2022-01-04 15:13 ` Carsten Haitzler
2022-01-12 9:54 ` Leo Yan
2021-12-15 16:03 ` [PATCH 08/12] perf test: Add threaded bubblesort tests for coresight carsten.haitzler
2021-12-15 16:04 ` [PATCH 09/12] perf test: Add add memcpy test for coresight quality checking carsten.haitzler
2022-02-04 10:43 ` Mike Leach
2021-12-15 16:04 ` [PATCH 10/12] perf test: Add threaded memcpy tests to check coresight aux data carsten.haitzler
2021-12-15 16:04 ` [PATCH 11/12] perf test: Add unrolled loop tests for " carsten.haitzler
2022-02-04 10:51 ` Mike Leach [this message]
2021-12-15 16:04 ` [PATCH 12/12] perf test: Add docs for coresight and related tests carsten.haitzler
2022-01-19 16:43 ` James Clark
2022-01-31 18:05 ` Carsten Haitzler
2022-02-04 14:50 ` Mike Leach
2022-03-09 12:25 ` Carsten Haitzler
2022-03-09 12:30 ` Carsten Haitzler
2021-12-17 14:55 ` [PATCH 01/12] perf test: Shell - Limit to only run executable scripts in tests Suzuki K Poulose
2021-12-17 17:18 ` Carsten Haitzler
-- strict thread matches above, loose matches on Subject: below --
2021-12-15 16:22 carsten.haitzler
2021-12-15 16:22 ` [PATCH 11/12] perf test: Add unrolled loop tests for coresight aux data carsten.haitzler
2021-12-15 12:53 [PATCH 01/12] perf test: Shell - Limit to only run executable scripts in tests carsten.haitzler
2021-12-15 12:54 ` [PATCH 11/12] perf test: Add unrolled loop tests for coresight aux data carsten.haitzler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ9a7VjpnGOKjc-Kx6XBBLXZgBc-XzQx=GoRRQu2q7fSVCq_Pw@mail.gmail.com' \
--to=mike.leach@linaro.org \
--cc=acme@kernel.org \
--cc=carsten.haitzler@foss.arm.com \
--cc=coresight@lists.linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.