* [igt-dev] [PATCH i-g-t] RFC: Fix gem test related gcc warnings. @ 2019-10-14 12:09 Juha-Pekka Heikkila 2019-10-14 12:09 ` [igt-dev] [PATCH i-g-t] RFC: gem: fix compiler warnings Juha-Pekka Heikkila ` (2 more replies) 0 siblings, 3 replies; 8+ messages in thread From: Juha-Pekka Heikkila @ 2019-10-14 12:09 UTC (permalink / raw) To: igt-dev; +Cc: tvrtko.ursulin I don't use these "for_each_engine" defines ever so I don't know if this is workable solution. I was just looking at those gem test related compile time warnings about "declaration of ‘e__’ shadows a previous local" and made this to silence them out. Juha-Pekka Heikkila (1): gem: fix compiler warnings lib/igt_gt.h | 16 ++++++++-------- tests/i915/gem_eio.c | 6 +++--- tests/i915/gem_exec_latency.c | 4 ++-- tests/i915/gem_exec_nop.c | 8 ++++---- tests/i915/gem_exec_schedule.c | 4 ++-- tests/i915/gem_sync.c | 16 ++++++++-------- 6 files changed, 27 insertions(+), 27 deletions(-) -- 2.7.4 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t] RFC: gem: fix compiler warnings 2019-10-14 12:09 [igt-dev] [PATCH i-g-t] RFC: Fix gem test related gcc warnings Juha-Pekka Heikkila @ 2019-10-14 12:09 ` Juha-Pekka Heikkila 2019-10-14 12:38 ` Chris Wilson 2019-10-14 13:37 ` Tvrtko Ursulin 2019-10-14 15:16 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2019-10-14 22:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2 siblings, 2 replies; 8+ messages in thread From: Juha-Pekka Heikkila @ 2019-10-14 12:09 UTC (permalink / raw) To: igt-dev; +Cc: tvrtko.ursulin Fix "warning: declaration of ‘e__’ shadows a previous local" complaints from gcc. There are changes in both lib/ and tests/ in this patch as changing only one will create build breakage point. Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> --- lib/igt_gt.h | 16 ++++++++-------- tests/i915/gem_eio.c | 6 +++--- tests/i915/gem_exec_latency.c | 4 ++-- tests/i915/gem_exec_nop.c | 8 ++++---- tests/i915/gem_exec_schedule.c | 4 ++-- tests/i915/gem_sync.c | 16 ++++++++-------- 6 files changed, 27 insertions(+), 27 deletions(-) diff --git a/lib/igt_gt.h b/lib/igt_gt.h index 73b5002..dcaf969 100644 --- a/lib/igt_gt.h +++ b/lib/igt_gt.h @@ -75,16 +75,16 @@ extern const struct intel_execution_engine { #define for_if(expr__) if (!(expr__)) {} else #define for_each_engine(fd__, flags__) \ - for (const struct intel_execution_engine *e__ = intel_execution_engines;\ - e__->name; \ - e__++) \ - for_if (gem_has_ring(fd__, flags__ = e__->exec_id | e__->flags)) + for (const struct intel_execution_engine *e__ ## flags__ = intel_execution_engines;\ + e__ ## flags__->name; \ + e__ ## flags__++) \ + for_if (gem_has_ring(fd__, flags__ = e__ ## flags__->exec_id | e__ ## flags__->flags)) #define for_each_physical_engine(fd__, flags__) \ - for (const struct intel_execution_engine *e__ = intel_execution_engines;\ - e__->name; \ - e__++) \ - for_if (gem_ring_has_physical_engine(fd__, flags__ = e__->exec_id | e__->flags)) + for (const struct intel_execution_engine *e__ ## flags__ = intel_execution_engines;\ + e__ ## flags__->name; \ + e__ ## flags__++) \ + for_if (gem_ring_has_physical_engine(fd__, flags__ = e__ ## flags__->exec_id | e__ ## flags__->flags)) bool gem_ring_is_physical_engine(int fd, unsigned int ring); bool gem_ring_has_physical_engine(int fd, unsigned int ring); diff --git a/tests/i915/gem_eio.c b/tests/i915/gem_eio.c index 892f365..1f95bb9 100644 --- a/tests/i915/gem_eio.c +++ b/tests/i915/gem_eio.c @@ -454,7 +454,7 @@ static void test_inflight(int fd, unsigned int wait) gem_write(fd, obj[1].handle, 0, &bbe, sizeof(bbe)); gem_quiescent_gpu(fd); - igt_debug("Starting %s on engine '%s'\n", __func__, e__->name); + igt_debug("Starting %s on engine '%s'\n", __func__, e__engine->name); igt_require(i915_reset_control(false)); hang = spin_sync(fd, 0, engine); @@ -586,7 +586,7 @@ static void test_inflight_contexts(int fd, unsigned int wait) gem_quiescent_gpu(fd); - igt_debug("Starting %s on engine '%s'\n", __func__, e__->name); + igt_debug("Starting %s on engine '%s'\n", __func__, e__engine->name); igt_require(i915_reset_control(false)); memset(obj, 0, sizeof(obj)); @@ -825,7 +825,7 @@ static void test_reset_stress(int fd, unsigned int flags) unsigned int engine; for_each_engine(fd, engine) - reset_stress(fd, ctx0, e__->name, engine, flags); + reset_stress(fd, ctx0, e__engine->name, engine, flags); gem_context_destroy(fd, ctx0); } diff --git a/tests/i915/gem_exec_latency.c b/tests/i915/gem_exec_latency.c index 9ddb348..0a1413e 100644 --- a/tests/i915/gem_exec_latency.c +++ b/tests/i915/gem_exec_latency.c @@ -394,7 +394,7 @@ static void latency_from_ring(int fd, igt_spin_free(fd, spin); igt_info("%s-%s delay: %.2fns\n", - name, e__->name, + name, e__other->name, (results[2*repeats-1] - results[0]) / (double)repeats * rcs_clock); } @@ -480,7 +480,7 @@ rthog_latency_on_ring(int fd, unsigned int engine, const char *name, unsigned in continue; engines[nengine] = engine; - names[nengine] = e__->name; + names[nengine] = e__engine->name; nengine++; } igt_require(nengine > 1); diff --git a/tests/i915/gem_exec_nop.c b/tests/i915/gem_exec_nop.c index 8922685..66c6216 100644 --- a/tests/i915/gem_exec_nop.c +++ b/tests/i915/gem_exec_nop.c @@ -440,12 +440,12 @@ static void parallel(int fd, uint32_t handle, int timeout) nengine = 0; for_each_physical_engine(fd, engine) { engines[nengine] = engine; - names[nengine] = e__->name; + names[nengine] = e__engine->name; nengine++; time = nop_on_ring(fd, handle, engine, 1, &count) / count; sum += time; - igt_debug("%s: %.3fus\n", e__->name, 1e6*time); + igt_debug("%s: %.3fus\n", e__engine->name, 1e6*time); } igt_require(nengine); igt_info("average (individually): %.3fus\n", sum/nengine*1e6); @@ -503,7 +503,7 @@ static void series(int fd, uint32_t handle, int timeout) for_each_physical_engine(fd, engine) { time = nop_on_ring(fd, handle, engine, 1, &count) / count; if (time > max) { - name = e__->name; + name = e__engine->name; max = time; } if (time < min) @@ -600,7 +600,7 @@ static void sequential(int fd, uint32_t handle, unsigned flags, int timeout) time = nop_on_ring(fd, handle, n, 1, &count) / count; sum += time; - igt_debug("%s: %.3fus\n", e__->name, 1e6*time); + igt_debug("%s: %.3fus\n", e__n->name, 1e6*time); engines[nengine++] = n; } diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c index ddcb1f2..a03d8dd 100644 --- a/tests/i915/gem_exec_schedule.c +++ b/tests/i915/gem_exec_schedule.c @@ -956,7 +956,7 @@ static void preempt_other(int fd, unsigned ring, unsigned int flags) gem_context_set_priority(fd, ctx[HI], MAX_PRIO); for_each_physical_engine(fd, primary) { - igt_debug("Primary engine: %s\n", e__->name); + igt_debug("Primary engine: %s\n", e__primary->name); __preempt_other(fd, ctx, ring, primary, flags); } @@ -1655,7 +1655,7 @@ static void measure_semaphore_power(int i915) total = gpu_power_W(&power, &s_sema[0], &s_sema[1]); igt_info("%s: %.1fmW + %.1fmW (total %1.fmW)\n", - e__->name, + e__signaler->name, 1e3 * baseline, 1e3 * (total - baseline), 1e3 * total); diff --git a/tests/i915/gem_sync.c b/tests/i915/gem_sync.c index 8c5aaa1..1922256 100644 --- a/tests/i915/gem_sync.c +++ b/tests/i915/gem_sync.c @@ -87,7 +87,7 @@ sync_ring(int fd, unsigned ring, int num_children, int timeout) if (ring == ALL_ENGINES) { for_each_physical_engine(fd, ring) { - names[num_engines] = e__->name; + names[num_engines] = e__ring->name; engines[num_engines++] = ring; if (num_engines == ARRAY_SIZE(engines)) break; @@ -189,7 +189,7 @@ wakeup_ring(int fd, unsigned ring, int timeout, int wlen) if (!gem_can_store_dword(fd, ring)) continue; - names[num_engines] = e__->name; + names[num_engines] = e__ring->name; engines[num_engines++] = ring; if (num_engines == ARRAY_SIZE(engines)) break; @@ -301,7 +301,7 @@ static void active_ring(int fd, unsigned ring, int timeout) if (!gem_can_store_dword(fd, ring)) continue; - names[num_engines] = e__->name; + names[num_engines] = e__ring->name; engines[num_engines++] = ring; if (num_engines == ARRAY_SIZE(engines)) break; @@ -368,7 +368,7 @@ active_wakeup_ring(int fd, unsigned ring, int timeout, int wlen) if (!gem_can_store_dword(fd, ring)) continue; - names[num_engines] = e__->name; + names[num_engines] = e__ring->name; engines[num_engines++] = ring; if (num_engines == ARRAY_SIZE(engines)) break; @@ -503,7 +503,7 @@ store_ring(int fd, unsigned ring, int num_children, int timeout) if (!gem_can_store_dword(fd, ring)) continue; - names[num_engines] = e__->name; + names[num_engines] = e__ring->name; engines[num_engines++] = ring; if (num_engines == ARRAY_SIZE(engines)) break; @@ -620,7 +620,7 @@ switch_ring(int fd, unsigned ring, int num_children, int timeout) if (!gem_can_store_dword(fd, ring)) continue; - names[num_engines] = e__->name; + names[num_engines] = e__ring->name; engines[num_engines++] = ring; if (num_engines == ARRAY_SIZE(engines)) break; @@ -953,7 +953,7 @@ store_many(int fd, unsigned ring, int timeout) timeout, &shared[n]); - names[n++] = e__->name; + names[n++] = e__ring->name; } igt_waitchildren(); } else { @@ -1140,7 +1140,7 @@ preempt(int fd, unsigned ring, int num_children, int timeout) if (ring == ALL_ENGINES) { for_each_physical_engine(fd, ring) { - names[num_engines] = e__->name; + names[num_engines] = e__ring->name; engines[num_engines++] = ring; if (num_engines == ARRAY_SIZE(engines)) break; -- 2.7.4 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] RFC: gem: fix compiler warnings 2019-10-14 12:09 ` [igt-dev] [PATCH i-g-t] RFC: gem: fix compiler warnings Juha-Pekka Heikkila @ 2019-10-14 12:38 ` Chris Wilson 2019-10-14 13:16 ` Andi Shyti 2019-10-14 13:37 ` Tvrtko Ursulin 1 sibling, 1 reply; 8+ messages in thread From: Chris Wilson @ 2019-10-14 12:38 UTC (permalink / raw) To: Juha-Pekka Heikkila, igt-dev; +Cc: tvrtko.ursulin Quoting Juha-Pekka Heikkila (2019-10-14 13:09:05) > Fix "warning: declaration of ‘e__’ shadows a previous local" > complaints from gcc. There are changes in both lib/ and tests/ > in this patch as changing only one will create build breakage point. > > Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> > --- > lib/igt_gt.h | 16 ++++++++-------- > tests/i915/gem_eio.c | 6 +++--- > tests/i915/gem_exec_latency.c | 4 ++-- > tests/i915/gem_exec_nop.c | 8 ++++---- > tests/i915/gem_exec_schedule.c | 4 ++-- > tests/i915/gem_sync.c | 16 ++++++++-------- > 6 files changed, 27 insertions(+), 27 deletions(-) > > diff --git a/lib/igt_gt.h b/lib/igt_gt.h > index 73b5002..dcaf969 100644 > --- a/lib/igt_gt.h > +++ b/lib/igt_gt.h > @@ -75,16 +75,16 @@ extern const struct intel_execution_engine { > #define for_if(expr__) if (!(expr__)) {} else > > #define for_each_engine(fd__, flags__) \ > - for (const struct intel_execution_engine *e__ = intel_execution_engines;\ > - e__->name; \ > - e__++) \ > - for_if (gem_has_ring(fd__, flags__ = e__->exec_id | e__->flags)) > + for (const struct intel_execution_engine *e__ ## flags__ = intel_execution_engines;\ > + e__ ## flags__->name; \ > + e__ ## flags__++) \ > + for_if (gem_has_ring(fd__, flags__ = e__ ## flags__->exec_id | e__ ## flags__->flags)) > > #define for_each_physical_engine(fd__, flags__) \ > - for (const struct intel_execution_engine *e__ = intel_execution_engines;\ > - e__->name; \ > - e__++) \ > - for_if (gem_ring_has_physical_engine(fd__, flags__ = e__->exec_id | e__->flags)) > + for (const struct intel_execution_engine *e__ ## flags__ = intel_execution_engines;\ > + e__ ## flags__->name; \ > + e__ ## flags__++) \ > + for_if (gem_ring_has_physical_engine(fd__, flags__ = e__ ## flags__->exec_id | e__ ## flags__->flags)) The plan had been to pass the iterator name to the macros. That plan got lost somewhere along the way. -Chris _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] RFC: gem: fix compiler warnings 2019-10-14 12:38 ` Chris Wilson @ 2019-10-14 13:16 ` Andi Shyti 0 siblings, 0 replies; 8+ messages in thread From: Andi Shyti @ 2019-10-14 13:16 UTC (permalink / raw) To: Chris Wilson; +Cc: igt-dev, tvrtko.ursulin Hi, > > diff --git a/lib/igt_gt.h b/lib/igt_gt.h > > index 73b5002..dcaf969 100644 > > --- a/lib/igt_gt.h > > +++ b/lib/igt_gt.h > > @@ -75,16 +75,16 @@ extern const struct intel_execution_engine { > > #define for_if(expr__) if (!(expr__)) {} else > > > > #define for_each_engine(fd__, flags__) \ > > - for (const struct intel_execution_engine *e__ = intel_execution_engines;\ > > - e__->name; \ > > - e__++) \ > > - for_if (gem_has_ring(fd__, flags__ = e__->exec_id | e__->flags)) > > + for (const struct intel_execution_engine *e__ ## flags__ = intel_execution_engines;\ > > + e__ ## flags__->name; \ > > + e__ ## flags__++) \ > > + for_if (gem_has_ring(fd__, flags__ = e__ ## flags__->exec_id | e__ ## flags__->flags)) > > > > #define for_each_physical_engine(fd__, flags__) \ > > - for (const struct intel_execution_engine *e__ = intel_execution_engines;\ > > - e__->name; \ > > - e__++) \ > > - for_if (gem_ring_has_physical_engine(fd__, flags__ = e__->exec_id | e__->flags)) > > + for (const struct intel_execution_engine *e__ ## flags__ = intel_execution_engines;\ > > + e__ ## flags__->name; \ > > + e__ ## flags__++) \ > > + for_if (gem_ring_has_physical_engine(fd__, flags__ = e__ ## flags__->exec_id | e__ ## flags__->flags)) > > The plan had been to pass the iterator name to the macros. That plan got > lost somewhere along the way. yes, we forgot to get rid of this part, but before that we need to do some refactoring of the gem_engine_topology, because many things can go wrong there. If CI does not complain, we can, in the meantime, get this in and mute the warnings, it's not perfect, but works. Acked-by: Andi Shyti <andi.shyti@intel.com> Thanks JP, Andi _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] RFC: gem: fix compiler warnings 2019-10-14 12:09 ` [igt-dev] [PATCH i-g-t] RFC: gem: fix compiler warnings Juha-Pekka Heikkila 2019-10-14 12:38 ` Chris Wilson @ 2019-10-14 13:37 ` Tvrtko Ursulin 2019-10-14 14:01 ` Juha-Pekka Heikkilä 1 sibling, 1 reply; 8+ messages in thread From: Tvrtko Ursulin @ 2019-10-14 13:37 UTC (permalink / raw) To: Juha-Pekka Heikkila, igt-dev; +Cc: tvrtko.ursulin On 14/10/2019 13:09, Juha-Pekka Heikkila wrote: > Fix "warning: declaration of ‘e__’ shadows a previous local" > complaints from gcc. There are changes in both lib/ and tests/ > in this patch as changing only one will create build breakage point. > > Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> > --- > lib/igt_gt.h | 16 ++++++++-------- > tests/i915/gem_eio.c | 6 +++--- > tests/i915/gem_exec_latency.c | 4 ++-- > tests/i915/gem_exec_nop.c | 8 ++++---- > tests/i915/gem_exec_schedule.c | 4 ++-- > tests/i915/gem_sync.c | 16 ++++++++-------- > 6 files changed, 27 insertions(+), 27 deletions(-) > > diff --git a/lib/igt_gt.h b/lib/igt_gt.h > index 73b5002..dcaf969 100644 > --- a/lib/igt_gt.h > +++ b/lib/igt_gt.h > @@ -75,16 +75,16 @@ extern const struct intel_execution_engine { > #define for_if(expr__) if (!(expr__)) {} else > > #define for_each_engine(fd__, flags__) \ > - for (const struct intel_execution_engine *e__ = intel_execution_engines;\ > - e__->name; \ > - e__++) \ > - for_if (gem_has_ring(fd__, flags__ = e__->exec_id | e__->flags)) > + for (const struct intel_execution_engine *e__ ## flags__ = intel_execution_engines;\ > + e__ ## flags__->name; \ > + e__ ## flags__++) \ > + for_if (gem_has_ring(fd__, flags__ = e__ ## flags__->exec_id | e__ ## flags__->flags)) > > #define for_each_physical_engine(fd__, flags__) \ > - for (const struct intel_execution_engine *e__ = intel_execution_engines;\ > - e__->name; \ > - e__++) \ > - for_if (gem_ring_has_physical_engine(fd__, flags__ = e__->exec_id | e__->flags)) > + for (const struct intel_execution_engine *e__ ## flags__ = intel_execution_engines;\ > + e__ ## flags__->name; \ > + e__ ## flags__++) \ > + for_if (gem_ring_has_physical_engine(fd__, flags__ = e__ ## flags__->exec_id | e__ ## flags__->flags)) > > bool gem_ring_is_physical_engine(int fd, unsigned int ring); > bool gem_ring_has_physical_engine(int fd, unsigned int ring); > diff --git a/tests/i915/gem_eio.c b/tests/i915/gem_eio.c > index 892f365..1f95bb9 100644 > --- a/tests/i915/gem_eio.c > +++ b/tests/i915/gem_eio.c > @@ -454,7 +454,7 @@ static void test_inflight(int fd, unsigned int wait) > gem_write(fd, obj[1].handle, 0, &bbe, sizeof(bbe)); > > gem_quiescent_gpu(fd); > - igt_debug("Starting %s on engine '%s'\n", __func__, e__->name); > + igt_debug("Starting %s on engine '%s'\n", __func__, e__engine->name); This is a bit novel solution and I can't say I like it. Mostly because it is churn, while possibly for same amount of churn we could fix it properly by passing in the iterator local explicitly. Regards, Tvrtko > igt_require(i915_reset_control(false)); > > hang = spin_sync(fd, 0, engine); > @@ -586,7 +586,7 @@ static void test_inflight_contexts(int fd, unsigned int wait) > > gem_quiescent_gpu(fd); > > - igt_debug("Starting %s on engine '%s'\n", __func__, e__->name); > + igt_debug("Starting %s on engine '%s'\n", __func__, e__engine->name); > igt_require(i915_reset_control(false)); > > memset(obj, 0, sizeof(obj)); > @@ -825,7 +825,7 @@ static void test_reset_stress(int fd, unsigned int flags) > unsigned int engine; > > for_each_engine(fd, engine) > - reset_stress(fd, ctx0, e__->name, engine, flags); > + reset_stress(fd, ctx0, e__engine->name, engine, flags); > > gem_context_destroy(fd, ctx0); > } > diff --git a/tests/i915/gem_exec_latency.c b/tests/i915/gem_exec_latency.c > index 9ddb348..0a1413e 100644 > --- a/tests/i915/gem_exec_latency.c > +++ b/tests/i915/gem_exec_latency.c > @@ -394,7 +394,7 @@ static void latency_from_ring(int fd, > igt_spin_free(fd, spin); > > igt_info("%s-%s delay: %.2fns\n", > - name, e__->name, > + name, e__other->name, > (results[2*repeats-1] - results[0]) / (double)repeats * rcs_clock); > } > > @@ -480,7 +480,7 @@ rthog_latency_on_ring(int fd, unsigned int engine, const char *name, unsigned in > continue; > > engines[nengine] = engine; > - names[nengine] = e__->name; > + names[nengine] = e__engine->name; > nengine++; > } > igt_require(nengine > 1); > diff --git a/tests/i915/gem_exec_nop.c b/tests/i915/gem_exec_nop.c > index 8922685..66c6216 100644 > --- a/tests/i915/gem_exec_nop.c > +++ b/tests/i915/gem_exec_nop.c > @@ -440,12 +440,12 @@ static void parallel(int fd, uint32_t handle, int timeout) > nengine = 0; > for_each_physical_engine(fd, engine) { > engines[nengine] = engine; > - names[nengine] = e__->name; > + names[nengine] = e__engine->name; > nengine++; > > time = nop_on_ring(fd, handle, engine, 1, &count) / count; > sum += time; > - igt_debug("%s: %.3fus\n", e__->name, 1e6*time); > + igt_debug("%s: %.3fus\n", e__engine->name, 1e6*time); > } > igt_require(nengine); > igt_info("average (individually): %.3fus\n", sum/nengine*1e6); > @@ -503,7 +503,7 @@ static void series(int fd, uint32_t handle, int timeout) > for_each_physical_engine(fd, engine) { > time = nop_on_ring(fd, handle, engine, 1, &count) / count; > if (time > max) { > - name = e__->name; > + name = e__engine->name; > max = time; > } > if (time < min) > @@ -600,7 +600,7 @@ static void sequential(int fd, uint32_t handle, unsigned flags, int timeout) > > time = nop_on_ring(fd, handle, n, 1, &count) / count; > sum += time; > - igt_debug("%s: %.3fus\n", e__->name, 1e6*time); > + igt_debug("%s: %.3fus\n", e__n->name, 1e6*time); > > engines[nengine++] = n; > } > diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c > index ddcb1f2..a03d8dd 100644 > --- a/tests/i915/gem_exec_schedule.c > +++ b/tests/i915/gem_exec_schedule.c > @@ -956,7 +956,7 @@ static void preempt_other(int fd, unsigned ring, unsigned int flags) > gem_context_set_priority(fd, ctx[HI], MAX_PRIO); > > for_each_physical_engine(fd, primary) { > - igt_debug("Primary engine: %s\n", e__->name); > + igt_debug("Primary engine: %s\n", e__primary->name); > __preempt_other(fd, ctx, ring, primary, flags); > > } > @@ -1655,7 +1655,7 @@ static void measure_semaphore_power(int i915) > total = gpu_power_W(&power, &s_sema[0], &s_sema[1]); > > igt_info("%s: %.1fmW + %.1fmW (total %1.fmW)\n", > - e__->name, > + e__signaler->name, > 1e3 * baseline, > 1e3 * (total - baseline), > 1e3 * total); > diff --git a/tests/i915/gem_sync.c b/tests/i915/gem_sync.c > index 8c5aaa1..1922256 100644 > --- a/tests/i915/gem_sync.c > +++ b/tests/i915/gem_sync.c > @@ -87,7 +87,7 @@ sync_ring(int fd, unsigned ring, int num_children, int timeout) > > if (ring == ALL_ENGINES) { > for_each_physical_engine(fd, ring) { > - names[num_engines] = e__->name; > + names[num_engines] = e__ring->name; > engines[num_engines++] = ring; > if (num_engines == ARRAY_SIZE(engines)) > break; > @@ -189,7 +189,7 @@ wakeup_ring(int fd, unsigned ring, int timeout, int wlen) > if (!gem_can_store_dword(fd, ring)) > continue; > > - names[num_engines] = e__->name; > + names[num_engines] = e__ring->name; > engines[num_engines++] = ring; > if (num_engines == ARRAY_SIZE(engines)) > break; > @@ -301,7 +301,7 @@ static void active_ring(int fd, unsigned ring, int timeout) > if (!gem_can_store_dword(fd, ring)) > continue; > > - names[num_engines] = e__->name; > + names[num_engines] = e__ring->name; > engines[num_engines++] = ring; > if (num_engines == ARRAY_SIZE(engines)) > break; > @@ -368,7 +368,7 @@ active_wakeup_ring(int fd, unsigned ring, int timeout, int wlen) > if (!gem_can_store_dword(fd, ring)) > continue; > > - names[num_engines] = e__->name; > + names[num_engines] = e__ring->name; > engines[num_engines++] = ring; > if (num_engines == ARRAY_SIZE(engines)) > break; > @@ -503,7 +503,7 @@ store_ring(int fd, unsigned ring, int num_children, int timeout) > if (!gem_can_store_dword(fd, ring)) > continue; > > - names[num_engines] = e__->name; > + names[num_engines] = e__ring->name; > engines[num_engines++] = ring; > if (num_engines == ARRAY_SIZE(engines)) > break; > @@ -620,7 +620,7 @@ switch_ring(int fd, unsigned ring, int num_children, int timeout) > if (!gem_can_store_dword(fd, ring)) > continue; > > - names[num_engines] = e__->name; > + names[num_engines] = e__ring->name; > engines[num_engines++] = ring; > if (num_engines == ARRAY_SIZE(engines)) > break; > @@ -953,7 +953,7 @@ store_many(int fd, unsigned ring, int timeout) > timeout, > &shared[n]); > > - names[n++] = e__->name; > + names[n++] = e__ring->name; > } > igt_waitchildren(); > } else { > @@ -1140,7 +1140,7 @@ preempt(int fd, unsigned ring, int num_children, int timeout) > > if (ring == ALL_ENGINES) { > for_each_physical_engine(fd, ring) { > - names[num_engines] = e__->name; > + names[num_engines] = e__ring->name; > engines[num_engines++] = ring; > if (num_engines == ARRAY_SIZE(engines)) > break; > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] RFC: gem: fix compiler warnings 2019-10-14 13:37 ` Tvrtko Ursulin @ 2019-10-14 14:01 ` Juha-Pekka Heikkilä 0 siblings, 0 replies; 8+ messages in thread From: Juha-Pekka Heikkilä @ 2019-10-14 14:01 UTC (permalink / raw) To: Tvrtko Ursulin; +Cc: igt-dev, tvrtko.ursulin On Mon, Oct 14, 2019 at 4:37 PM Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote: > > > On 14/10/2019 13:09, Juha-Pekka Heikkila wrote: > > Fix "warning: declaration of ‘e__’ shadows a previous local" > > complaints from gcc. There are changes in both lib/ and tests/ > > in this patch as changing only one will create build breakage point. > > > > Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> > > --- > > lib/igt_gt.h | 16 ++++++++-------- > > tests/i915/gem_eio.c | 6 +++--- > > tests/i915/gem_exec_latency.c | 4 ++-- > > tests/i915/gem_exec_nop.c | 8 ++++---- > > tests/i915/gem_exec_schedule.c | 4 ++-- > > tests/i915/gem_sync.c | 16 ++++++++-------- > > 6 files changed, 27 insertions(+), 27 deletions(-) > > > > diff --git a/lib/igt_gt.h b/lib/igt_gt.h > > index 73b5002..dcaf969 100644 > > --- a/lib/igt_gt.h > > +++ b/lib/igt_gt.h > > @@ -75,16 +75,16 @@ extern const struct intel_execution_engine { > > #define for_if(expr__) if (!(expr__)) {} else > > > > #define for_each_engine(fd__, flags__) \ > > - for (const struct intel_execution_engine *e__ = intel_execution_engines;\ > > - e__->name; \ > > - e__++) \ > > - for_if (gem_has_ring(fd__, flags__ = e__->exec_id | e__->flags)) > > + for (const struct intel_execution_engine *e__ ## flags__ = intel_execution_engines;\ > > + e__ ## flags__->name; \ > > + e__ ## flags__++) \ > > + for_if (gem_has_ring(fd__, flags__ = e__ ## flags__->exec_id | e__ ## flags__->flags)) > > > > #define for_each_physical_engine(fd__, flags__) \ > > - for (const struct intel_execution_engine *e__ = intel_execution_engines;\ > > - e__->name; \ > > - e__++) \ > > - for_if (gem_ring_has_physical_engine(fd__, flags__ = e__->exec_id | e__->flags)) > > + for (const struct intel_execution_engine *e__ ## flags__ = intel_execution_engines;\ > > + e__ ## flags__->name; \ > > + e__ ## flags__++) \ > > + for_if (gem_ring_has_physical_engine(fd__, flags__ = e__ ## flags__->exec_id | e__ ## flags__->flags)) > > > > bool gem_ring_is_physical_engine(int fd, unsigned int ring); > > bool gem_ring_has_physical_engine(int fd, unsigned int ring); > > diff --git a/tests/i915/gem_eio.c b/tests/i915/gem_eio.c > > index 892f365..1f95bb9 100644 > > --- a/tests/i915/gem_eio.c > > +++ b/tests/i915/gem_eio.c > > @@ -454,7 +454,7 @@ static void test_inflight(int fd, unsigned int wait) > > gem_write(fd, obj[1].handle, 0, &bbe, sizeof(bbe)); > > > > gem_quiescent_gpu(fd); > > - igt_debug("Starting %s on engine '%s'\n", __func__, e__->name); > > + igt_debug("Starting %s on engine '%s'\n", __func__, e__engine->name); > > This is a bit novel solution and I can't say I like it. Mostly because > it is churn, while possibly for same amount of churn we could fix it > properly by passing in the iterator local explicitly. > I agree it is churn, of the most obvious type. Reason for this is I have not touched these gem tests before, to add meaningfully named iterators I would need to know what is going on in those places where these defines are used. This is why I opted to just use names currently in use in those places and blame macros for funny naming :) /Juha-Pekka _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for RFC: gem: fix compiler warnings 2019-10-14 12:09 [igt-dev] [PATCH i-g-t] RFC: Fix gem test related gcc warnings Juha-Pekka Heikkila 2019-10-14 12:09 ` [igt-dev] [PATCH i-g-t] RFC: gem: fix compiler warnings Juha-Pekka Heikkila @ 2019-10-14 15:16 ` Patchwork 2019-10-14 22:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2 siblings, 0 replies; 8+ messages in thread From: Patchwork @ 2019-10-14 15:16 UTC (permalink / raw) To: Juha-Pekka Heikkilä; +Cc: igt-dev == Series Details == Series: RFC: gem: fix compiler warnings URL : https://patchwork.freedesktop.org/series/67976/ State : success == Summary == CI Bug Log - changes from CI_DRM_7086 -> IGTPW_3567 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/index.html Known issues ------------ Here are the changes found in IGTPW_3567 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s4-devices: - fi-blb-e6850: [PASS][1] -> [INCOMPLETE][2] ([fdo#107718]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html * igt@gem_mmap_gtt@basic-copy: - fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/fi-icl-u3/igt@gem_mmap_gtt@basic-copy.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/fi-icl-u3/igt@gem_mmap_gtt@basic-copy.html * igt@kms_chamelium@dp-crc-fast: - fi-kbl-7500u: [PASS][5] -> [FAIL][6] ([fdo#109635 ] / [fdo#110387]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html #### Possible fixes #### * igt@gem_flink_basic@flink-lifetime: - fi-icl-u3: [DMESG-WARN][7] ([fdo#107724]) -> [PASS][8] +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/fi-icl-u3/igt@gem_flink_basic@flink-lifetime.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/fi-icl-u3/igt@gem_flink_basic@flink-lifetime.html * igt@kms_chamelium@common-hpd-after-suspend: - fi-icl-u2: [DMESG-WARN][9] ([fdo#102505] / [fdo#110390]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#102505]: https://bugs.freedesktop.org/show_bug.cgi?id=102505 [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635 [fdo#110387]: https://bugs.freedesktop.org/show_bug.cgi?id=110387 [fdo#110390]: https://bugs.freedesktop.org/show_bug.cgi?id=110390 [fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045 [fdo#111880]: https://bugs.freedesktop.org/show_bug.cgi?id=111880 Participating hosts (52 -> 45) ------------------------------ Missing (7): fi-ilk-m540 fi-hsw-4200u fi-bsw-n3050 fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5225 -> IGTPW_3567 CI-20190529: 20190529 CI_DRM_7086: cb64ca78fe223a03a902aa10ddbfb672ccad1630 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_3567: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/index.html IGT_5225: 991ce4eede1c52f76378aebf162a13c20d6f6293 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/index.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for RFC: gem: fix compiler warnings 2019-10-14 12:09 [igt-dev] [PATCH i-g-t] RFC: Fix gem test related gcc warnings Juha-Pekka Heikkila 2019-10-14 12:09 ` [igt-dev] [PATCH i-g-t] RFC: gem: fix compiler warnings Juha-Pekka Heikkila 2019-10-14 15:16 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork @ 2019-10-14 22:00 ` Patchwork 2 siblings, 0 replies; 8+ messages in thread From: Patchwork @ 2019-10-14 22:00 UTC (permalink / raw) To: Juha-Pekka Heikkilä; +Cc: igt-dev == Series Details == Series: RFC: gem: fix compiler warnings URL : https://patchwork.freedesktop.org/series/67976/ State : success == Summary == CI Bug Log - changes from CI_DRM_7086_full -> IGTPW_3567_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/index.html Known issues ------------ Here are the changes found in IGTPW_3567_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_balancer@smoke: - shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#110854]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-iclb2/igt@gem_exec_balancer@smoke.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-iclb6/igt@gem_exec_balancer@smoke.html * igt@gem_exec_schedule@in-order-bsd: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#111325]) +6 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-iclb6/igt@gem_exec_schedule@in-order-bsd.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-iclb4/igt@gem_exec_schedule@in-order-bsd.html * igt@gem_exec_schedule@promotion-bsd1: - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276]) +16 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-iclb2/igt@gem_exec_schedule@promotion-bsd1.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-iclb6/igt@gem_exec_schedule@promotion-bsd1.html * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup: - shard-snb: [PASS][7] -> [DMESG-WARN][8] ([fdo#111870]) +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html * igt@kms_color@pipe-a-ctm-blue-to-red: - shard-kbl: [PASS][9] -> [FAIL][10] ([fdo#107201]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-kbl4/igt@kms_color@pipe-a-ctm-blue-to-red.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-kbl2/igt@kms_color@pipe-a-ctm-blue-to-red.html - shard-apl: [PASS][11] -> [FAIL][12] ([fdo#107201]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-apl4/igt@kms_color@pipe-a-ctm-blue-to-red.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-apl6/igt@kms_color@pipe-a-ctm-blue-to-red.html * igt@kms_cursor_crc@pipe-b-cursor-128x128-sliding: - shard-snb: [PASS][13] -> [SKIP][14] ([fdo#109271]) +1 similar issue [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-snb7/igt@kms_cursor_crc@pipe-b-cursor-128x128-sliding.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-snb4/igt@kms_cursor_crc@pipe-b-cursor-128x128-sliding.html * igt@kms_cursor_legacy@cursor-vs-flip-toggle: - shard-hsw: [PASS][15] -> [FAIL][16] ([fdo#103355]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-hsw1/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html * igt@kms_flip@flip-vs-expired-vblank: - shard-glk: [PASS][17] -> [FAIL][18] ([fdo#105363]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-glk5/igt@kms_flip@flip-vs-expired-vblank.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-glk7/igt@kms_flip@flip-vs-expired-vblank.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-cpu: - shard-glk: [PASS][19] -> [FAIL][20] ([fdo#103167]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-glk8/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-cpu.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-cpu.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite: - shard-iclb: [PASS][21] -> [FAIL][22] ([fdo#103167]) +2 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html * igt@kms_plane_lowres@pipe-a-tiling-y: - shard-iclb: [PASS][23] -> [FAIL][24] ([fdo#103166]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-y.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-y.html * igt@kms_psr@no_drrs: - shard-iclb: [PASS][25] -> [FAIL][26] ([fdo#108341]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-iclb2/igt@kms_psr@no_drrs.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-iclb1/igt@kms_psr@no_drrs.html * igt@kms_psr@psr2_cursor_blt: - shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109441]) +2 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-iclb4/igt@kms_psr@psr2_cursor_blt.html * igt@kms_vblank@pipe-b-ts-continuation-suspend: - shard-apl: [PASS][29] -> [DMESG-WARN][30] ([fdo#108566]) +5 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-apl1/igt@kms_vblank@pipe-b-ts-continuation-suspend.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-apl4/igt@kms_vblank@pipe-b-ts-continuation-suspend.html #### Possible fixes #### * igt@gem_eio@in-flight-suspend: - shard-iclb: [DMESG-WARN][31] ([fdo#111764]) -> [PASS][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-iclb5/igt@gem_eio@in-flight-suspend.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-iclb1/igt@gem_eio@in-flight-suspend.html * igt@gem_exec_schedule@reorder-wide-bsd: - shard-iclb: [SKIP][33] ([fdo#111325]) -> [PASS][34] +5 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-iclb2/igt@gem_exec_schedule@reorder-wide-bsd.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-iclb8/igt@gem_exec_schedule@reorder-wide-bsd.html * igt@gem_userptr_blits@map-fixed-invalidate-busy: - shard-snb: [DMESG-WARN][35] ([fdo#111870]) -> [PASS][36] +2 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-busy.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-busy.html - shard-hsw: [DMESG-WARN][37] ([fdo#111870]) -> [PASS][38] +1 similar issue [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-hsw4/igt@gem_userptr_blits@map-fixed-invalidate-busy.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy.html * {igt@i915_pm_dc@dc6-dpms}: - shard-iclb: [FAIL][39] ([fdo#110548]) -> [PASS][40] [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-iclb5/igt@i915_pm_dc@dc6-dpms.html * igt@kms_busy@basic-modeset-c: - shard-iclb: [INCOMPLETE][41] ([fdo#107713]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-iclb7/igt@kms_busy@basic-modeset-c.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-iclb7/igt@kms_busy@basic-modeset-c.html * igt@kms_flip@flip-vs-fences: - shard-hsw: [INCOMPLETE][43] ([fdo#103540]) -> [PASS][44] +1 similar issue [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-hsw4/igt@kms_flip@flip-vs-fences.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-hsw1/igt@kms_flip@flip-vs-fences.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-move: - shard-glk: [FAIL][45] ([fdo#103167]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-glk4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-move.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-glk8/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-move.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt: - shard-iclb: [FAIL][47] ([fdo#103167]) -> [PASS][48] +3 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes: - shard-apl: [DMESG-WARN][49] ([fdo#108566]) -> [PASS][50] +4 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-apl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-apl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html * igt@kms_psr@psr2_cursor_render: - shard-iclb: [SKIP][51] ([fdo#109441]) -> [PASS][52] +1 similar issue [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-iclb4/igt@kms_psr@psr2_cursor_render.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-iclb2/igt@kms_psr@psr2_cursor_render.html * igt@prime_busy@hang-bsd2: - shard-iclb: [SKIP][53] ([fdo#109276]) -> [PASS][54] +13 similar issues [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-iclb5/igt@prime_busy@hang-bsd2.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-iclb2/igt@prime_busy@hang-bsd2.html #### Warnings #### * igt@gem_mocs_settings@mocs-reset-bsd2: - shard-iclb: [SKIP][55] ([fdo#109276]) -> [FAIL][56] ([fdo#111330]) +1 similar issue [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/shard-iclb5/igt@gem_mocs_settings@mocs-reset-bsd2.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/shard-iclb1/igt@gem_mocs_settings@mocs-reset-bsd2.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355 [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#107201]: https://bugs.freedesktop.org/show_bug.cgi?id=107201 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#110548]: https://bugs.freedesktop.org/show_bug.cgi?id=110548 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325 [fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330 [fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764 [fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832 [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870 Participating hosts (11 -> 7) ------------------------------ Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5225 -> IGTPW_3567 * Piglit: piglit_4509 -> None CI-20190529: 20190529 CI_DRM_7086: cb64ca78fe223a03a902aa10ddbfb672ccad1630 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_3567: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/index.html IGT_5225: 991ce4eede1c52f76378aebf162a13c20d6f6293 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3567/index.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-10-14 22:00 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-10-14 12:09 [igt-dev] [PATCH i-g-t] RFC: Fix gem test related gcc warnings Juha-Pekka Heikkila 2019-10-14 12:09 ` [igt-dev] [PATCH i-g-t] RFC: gem: fix compiler warnings Juha-Pekka Heikkila 2019-10-14 12:38 ` Chris Wilson 2019-10-14 13:16 ` Andi Shyti 2019-10-14 13:37 ` Tvrtko Ursulin 2019-10-14 14:01 ` Juha-Pekka Heikkilä 2019-10-14 15:16 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2019-10-14 22:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.