All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn@kryo.se>
To: Suman Anna <s-anna@ti.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robherring2@gmail.com>,
	Kumar Gala <galak@codeaurora.org>,
	Josh Cartwright <joshc@codeaurora.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v7 1/4] Documentation: dt: add common bindings for hwspinlock
Date: Thu, 5 Feb 2015 16:34:06 -0800	[thread overview]
Message-ID: <CAJAp7Ojud6UM97eDYdUhZxzzjNRw_47e5kqh4UxwDBMwFZpuoQ@mail.gmail.com> (raw)
In-Reply-To: <54D406BA.6060403@ti.com>

On Thu, Feb 5, 2015 at 4:11 PM, Suman Anna <s-anna@ti.com> wrote:
> Hi Bjorn,
>
> On 02/05/2015 05:01 PM, Bjorn Andersson wrote:
[..]
>> Will you send out a new revision of the binding? I would love to get
>> this integrated so I can move on with the dependents.
>
> Yep, will do as soon as I hear from Ohad on what to do with the patch
> "hwspinlock/core: maintain a list of registered hwspinlock banks" that I
> dropped from v7. Without that and dropping hwlock-base-id, I can't get
> the translations done.
>

My suggestion is to replace the global id-tree with a list of hwlocks
and iterate over these if we ever get more than one driver registered.
As long as #hwlock-drivers < log(#total-hwlocks) this should be
faster.

I would however argue that clients that would notice any kind of
difference are using the API incorrectly.


Unfortunately this is a somewhat larger change than just slapping DT
support on the framework :/

Regards,
Bjorn

WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn-UYDU3/A3LUY@public.gmane.org>
To: Suman Anna <s-anna-l0cyMroinI0@public.gmane.org>
Cc: Ohad Ben-Cohen <ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Josh Cartwright <joshc-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v7 1/4] Documentation: dt: add common bindings for hwspinlock
Date: Thu, 5 Feb 2015 16:34:06 -0800	[thread overview]
Message-ID: <CAJAp7Ojud6UM97eDYdUhZxzzjNRw_47e5kqh4UxwDBMwFZpuoQ@mail.gmail.com> (raw)
In-Reply-To: <54D406BA.6060403-l0cyMroinI0@public.gmane.org>

On Thu, Feb 5, 2015 at 4:11 PM, Suman Anna <s-anna-l0cyMroinI0@public.gmane.org> wrote:
> Hi Bjorn,
>
> On 02/05/2015 05:01 PM, Bjorn Andersson wrote:
[..]
>> Will you send out a new revision of the binding? I would love to get
>> this integrated so I can move on with the dependents.
>
> Yep, will do as soon as I hear from Ohad on what to do with the patch
> "hwspinlock/core: maintain a list of registered hwspinlock banks" that I
> dropped from v7. Without that and dropping hwlock-base-id, I can't get
> the translations done.
>

My suggestion is to replace the global id-tree with a list of hwlocks
and iterate over these if we ever get more than one driver registered.
As long as #hwlock-drivers < log(#total-hwlocks) this should be
faster.

I would however argue that clients that would notice any kind of
difference are using the API incorrectly.


Unfortunately this is a somewhat larger change than just slapping DT
support on the framework :/

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: bjorn@kryo.se (Bjorn Andersson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 1/4] Documentation: dt: add common bindings for hwspinlock
Date: Thu, 5 Feb 2015 16:34:06 -0800	[thread overview]
Message-ID: <CAJAp7Ojud6UM97eDYdUhZxzzjNRw_47e5kqh4UxwDBMwFZpuoQ@mail.gmail.com> (raw)
In-Reply-To: <54D406BA.6060403@ti.com>

On Thu, Feb 5, 2015 at 4:11 PM, Suman Anna <s-anna@ti.com> wrote:
> Hi Bjorn,
>
> On 02/05/2015 05:01 PM, Bjorn Andersson wrote:
[..]
>> Will you send out a new revision of the binding? I would love to get
>> this integrated so I can move on with the dependents.
>
> Yep, will do as soon as I hear from Ohad on what to do with the patch
> "hwspinlock/core: maintain a list of registered hwspinlock banks" that I
> dropped from v7. Without that and dropping hwlock-base-id, I can't get
> the translations done.
>

My suggestion is to replace the global id-tree with a list of hwlocks
and iterate over these if we ever get more than one driver registered.
As long as #hwlock-drivers < log(#total-hwlocks) this should be
faster.

I would however argue that clients that would notice any kind of
difference are using the API incorrectly.


Unfortunately this is a somewhat larger change than just slapping DT
support on the framework :/

Regards,
Bjorn

  reply	other threads:[~2015-02-06  0:34 UTC|newest]

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14 20:58 [PATCH v7 0/4] hwspinlock core & omap dt support Suman Anna
2015-01-14 20:58 ` Suman Anna
2015-01-14 20:58 ` Suman Anna
2015-01-14 20:58 ` [PATCH v7 1/4] Documentation: dt: add common bindings for hwspinlock Suman Anna
2015-01-14 20:58   ` Suman Anna
2015-01-14 20:58   ` Suman Anna
2015-01-15 13:52   ` Mark Rutland
2015-01-15 13:52     ` Mark Rutland
2015-01-15 13:52     ` Mark Rutland
2015-01-15 13:55     ` Mark Rutland
2015-01-15 13:55       ` Mark Rutland
2015-01-15 13:55       ` Mark Rutland
2015-01-15 14:42       ` Rob Herring
2015-01-15 14:42         ` Rob Herring
2015-01-15 14:42         ` Rob Herring
2015-01-15 20:16         ` Suman Anna
2015-01-15 20:16           ` Suman Anna
2015-01-15 20:16           ` Suman Anna
2015-01-16  6:09         ` Ohad Ben-Cohen
2015-01-16  6:09           ` Ohad Ben-Cohen
2015-01-16  6:09           ` Ohad Ben-Cohen
2015-01-16 10:17           ` Mark Rutland
2015-01-16 10:17             ` Mark Rutland
2015-01-16 10:17             ` Mark Rutland
2015-01-17  0:46             ` Ohad Ben-Cohen
2015-01-17  0:46               ` Ohad Ben-Cohen
2015-01-17  0:46               ` Ohad Ben-Cohen
2015-01-20 18:05               ` Tony Lindgren
2015-01-20 18:05                 ` Tony Lindgren
2015-01-20 18:05                 ` Tony Lindgren
2015-01-21 12:41                 ` Ohad Ben-Cohen
2015-01-21 12:41                   ` Ohad Ben-Cohen
2015-01-21 12:41                   ` Ohad Ben-Cohen
2015-01-21 17:56                   ` Suman Anna
2015-01-21 17:56                     ` Suman Anna
2015-01-21 17:56                     ` Suman Anna
2015-01-22 18:56                     ` Mark Rutland
2015-01-22 18:56                       ` Mark Rutland
2015-01-22 18:56                       ` Mark Rutland
2015-01-29  3:58                       ` Suman Anna
2015-01-29  3:58                         ` Suman Anna
2015-01-29  3:58                         ` Suman Anna
2015-02-11 11:29                         ` Mark Rutland
2015-02-11 11:29                           ` Mark Rutland
2015-02-11 11:29                           ` Mark Rutland
2015-02-16 18:06                           ` Bjorn Andersson
2015-02-16 18:06                             ` Bjorn Andersson
2015-02-16 18:06                             ` Bjorn Andersson
2015-01-30 23:29               ` Bjorn Andersson
2015-01-30 23:29                 ` Bjorn Andersson
2015-01-30 23:29                 ` Bjorn Andersson
2015-01-31  5:41                 ` Ohad Ben-Cohen
2015-01-31  5:41                   ` Ohad Ben-Cohen
2015-01-31  5:41                   ` Ohad Ben-Cohen
2015-02-01 11:00                   ` Ohad Ben-Cohen
2015-02-01 11:00                     ` Ohad Ben-Cohen
2015-02-01 11:00                     ` Ohad Ben-Cohen
2015-02-02 21:14                     ` Suman Anna
2015-02-02 21:14                       ` Suman Anna
2015-02-02 21:14                       ` Suman Anna
2015-02-01 17:55                   ` Bjorn Andersson
2015-02-01 17:55                     ` Bjorn Andersson
2015-02-01 17:55                     ` Bjorn Andersson
2015-02-02 21:07                     ` Suman Anna
2015-02-02 21:07                       ` Suman Anna
2015-02-02 21:07                       ` Suman Anna
2015-02-05 23:01                       ` Bjorn Andersson
2015-02-05 23:01                         ` Bjorn Andersson
2015-02-05 23:01                         ` Bjorn Andersson
2015-02-06  0:11                         ` Suman Anna
2015-02-06  0:11                           ` Suman Anna
2015-02-06  0:11                           ` Suman Anna
2015-02-06  0:34                           ` Bjorn Andersson [this message]
2015-02-06  0:34                             ` Bjorn Andersson
2015-02-06  0:34                             ` Bjorn Andersson
2015-02-11 10:29                             ` Ohad Ben-Cohen
2015-02-11 10:29                               ` Ohad Ben-Cohen
2015-02-11 10:29                               ` Ohad Ben-Cohen
2015-02-11 11:35                               ` Mark Rutland
2015-02-11 11:35                                 ` Mark Rutland
2015-02-11 11:35                                 ` Mark Rutland
2015-02-16 20:30                   ` Bjorn Andersson
2015-02-16 20:30                     ` Bjorn Andersson
2015-02-16 20:30                     ` Bjorn Andersson
2015-01-16 10:19         ` Mark Rutland
2015-01-16 10:19           ` Mark Rutland
2015-01-16 10:19           ` Mark Rutland
2015-01-16 17:49           ` Suman Anna
2015-01-16 17:49             ` Suman Anna
2015-01-16 17:49             ` Suman Anna
2015-01-14 20:58 ` [PATCH v7 2/4] Documentation: dt: add the omap hwspinlock bindings document Suman Anna
2015-01-14 20:58   ` Suman Anna
2015-01-14 20:58   ` Suman Anna
2015-01-14 20:58 ` [PATCH v7 3/4] hwspinlock/core: add common OF helpers Suman Anna
2015-01-14 20:58   ` Suman Anna
2015-01-14 20:58   ` Suman Anna
2015-01-14 20:58 ` [PATCH v7 4/4] hwspinlock/omap: add support for dt nodes Suman Anna
2015-01-14 20:58   ` Suman Anna
2015-01-14 20:58   ` Suman Anna
2015-01-15 10:13 ` [PATCH v7 0/4] hwspinlock core & omap dt support Ohad Ben-Cohen
2015-01-15 10:13   ` Ohad Ben-Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJAp7Ojud6UM97eDYdUhZxzzjNRw_47e5kqh4UxwDBMwFZpuoQ@mail.gmail.com \
    --to=bjorn@kryo.se \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=joshc@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=ohad@wizery.com \
    --cc=robh+dt@kernel.org \
    --cc=robherring2@gmail.com \
    --cc=s-anna@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.