All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Murphy <lists@colorremedies.com>
To: Btrfs BTRFS <linux-btrfs@vger.kernel.org>,
	linux-lvm@redhat.com, Linux-RAID <linux-raid@vger.kernel.org>
Subject: Add udev-md-raid-safe-timeouts.rules
Date: Sun, 15 Apr 2018 19:04:15 -0600	[thread overview]
Message-ID: <CAJCQCtQ3r16BYYtrx9rVYauh7JeAp9omWidS4zzwxqvhU1bh+g@mail.gmail.com> (raw)

I just ran into this:
https://github.com/neilbrown/mdadm/pull/32/commits/af1ddca7d5311dfc9ed60a5eb6497db1296f1bec

This solution is inadequate, can it be made more generic? This isn't
an md specific problem, it affects Btrfs and LVM as well. And in fact
raid0, and even none raid setups.

There is no good reason to prevent deep recovery, which is what
happens with the default command timer of 30 seconds, with this class
of drive. Basically that value is going to cause data loss for the
single device and also raid0 case, where the reset happens before deep
recovery has a chance. And even if deep recovery fails to return user
data, what we need to see is the proper error message: read error UNC,
rather than a link reset message which just obfuscates the problem.


-- 
Chris Murphy

WARNING: multiple messages have this Message-ID (diff)
From: Chris Murphy <lists@colorremedies.com>
To: Btrfs BTRFS <linux-btrfs@vger.kernel.org>,
	linux-lvm@redhat.com, Linux-RAID <linux-raid@vger.kernel.org>
Subject: [linux-lvm] Add udev-md-raid-safe-timeouts.rules
Date: Sun, 15 Apr 2018 19:04:15 -0600	[thread overview]
Message-ID: <CAJCQCtQ3r16BYYtrx9rVYauh7JeAp9omWidS4zzwxqvhU1bh+g@mail.gmail.com> (raw)

I just ran into this:
https://github.com/neilbrown/mdadm/pull/32/commits/af1ddca7d5311dfc9ed60a5eb6497db1296f1bec

This solution is inadequate, can it be made more generic? This isn't
an md specific problem, it affects Btrfs and LVM as well. And in fact
raid0, and even none raid setups.

There is no good reason to prevent deep recovery, which is what
happens with the default command timer of 30 seconds, with this class
of drive. Basically that value is going to cause data loss for the
single device and also raid0 case, where the reset happens before deep
recovery has a chance. And even if deep recovery fails to return user
data, what we need to see is the proper error message: read error UNC,
rather than a link reset message which just obfuscates the problem.


-- 
Chris Murphy

             reply	other threads:[~2018-04-16  1:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-16  1:04 Chris Murphy [this message]
2018-04-16  1:04 ` [linux-lvm] Add udev-md-raid-safe-timeouts.rules Chris Murphy
2018-04-16 11:43 ` Austin S. Hemmelgarn
2018-04-16 11:43   ` [linux-lvm] " Austin S. Hemmelgarn
2018-04-16 15:02   ` Wol's lists
2018-04-16 15:02     ` [linux-lvm] " Wol's lists
2018-04-16 15:19     ` Roger Heflin
2018-04-16 15:19       ` [linux-lvm] " Roger Heflin
2018-04-17 11:15     ` Austin S. Hemmelgarn
2018-04-17 11:15       ` [linux-lvm] " Austin S. Hemmelgarn
2018-04-16 17:10   ` Chris Murphy
2018-04-16 17:10     ` [linux-lvm] " Chris Murphy
2018-04-16 17:33     ` Alan Stern
2018-04-16 17:33       ` [linux-lvm] " Alan Stern
2018-04-16 17:33       ` Alan Stern
2018-04-17 11:28     ` Austin S. Hemmelgarn
2018-04-17 11:28       ` [linux-lvm] " Austin S. Hemmelgarn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJCQCtQ3r16BYYtrx9rVYauh7JeAp9omWidS4zzwxqvhU1bh+g@mail.gmail.com \
    --to=lists@colorremedies.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-lvm@redhat.com \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.