From: Guo Ren <guoren@kernel.org> To: Marc Zyngier <maz@kernel.org> Cc: Samuel Holland <samuel@sholland.org>, Anup Patel <anup@brainfault.org>, Thomas Gleixner <tglx@linutronix.de>, Palmer Dabbelt <palmer@dabbelt.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-riscv <linux-riscv@lists.infradead.org>, devicetree <devicetree@vger.kernel.org>, Guo Ren <guoren@linux.alibaba.com> Subject: Re: [PATCH V6 2/2] irqchip/sifive-plic: Fixup thead,c900-plic dt parse in opensbi Date: Sun, 30 Jan 2022 23:11:44 +0800 [thread overview] Message-ID: <CAJF2gTROgAuj0j2qC6AZFgP+k3erU7erQRadH5ugaVPkj_=1hQ@mail.gmail.com> (raw) In-Reply-To: <87mtjdxoam.wl-maz@kernel.org> On Sun, Jan 30, 2022 at 10:59 PM Marc Zyngier <maz@kernel.org> wrote: > > On Sun, 30 Jan 2022 13:09:21 +0000, > Guo Ren <guoren@kernel.org> wrote: > > > > On Sun, Jan 30, 2022 at 6:28 PM Marc Zyngier <maz@kernel.org> wrote: > > > > > > On Sun, 30 Jan 2022 04:39:34 +0000, > > > Guo Ren <guoren@kernel.org> wrote: > > > > > > > > > +IRQCHIP_DECLARE(thead_c900_plic, "thead,c900-plic", plic_init); > > > > I think we should give clear info in /proc/interrupts. I hope we could > > > > keep thead_plic_init. > > > > > > Why? There is no material difference at the driver level, and > > > /proc/interrupts won't be the target of a branding exercise (which > > > this series seems to be all about). > > It's not a branding exercise, the series just correct the broken code > > & incorrect /proc/interrupts display. > > There is *nothing* incorrect in /proc/interrupt. If anything, changing > the string *is* an ABI change, for no good reason. I've minimized the modification to fix the problem, please have a look: https://lore.kernel.org/linux-riscv/20220130135634.1213301-3-guoren@kernel.org/T/#u > > M. > > -- > Without deviation from the norm, progress is not possible. -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/
WARNING: multiple messages have this Message-ID (diff)
From: Guo Ren <guoren@kernel.org> To: Marc Zyngier <maz@kernel.org> Cc: Samuel Holland <samuel@sholland.org>, Anup Patel <anup@brainfault.org>, Thomas Gleixner <tglx@linutronix.de>, Palmer Dabbelt <palmer@dabbelt.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-riscv <linux-riscv@lists.infradead.org>, devicetree <devicetree@vger.kernel.org>, Guo Ren <guoren@linux.alibaba.com> Subject: Re: [PATCH V6 2/2] irqchip/sifive-plic: Fixup thead,c900-plic dt parse in opensbi Date: Sun, 30 Jan 2022 23:11:44 +0800 [thread overview] Message-ID: <CAJF2gTROgAuj0j2qC6AZFgP+k3erU7erQRadH5ugaVPkj_=1hQ@mail.gmail.com> (raw) In-Reply-To: <87mtjdxoam.wl-maz@kernel.org> On Sun, Jan 30, 2022 at 10:59 PM Marc Zyngier <maz@kernel.org> wrote: > > On Sun, 30 Jan 2022 13:09:21 +0000, > Guo Ren <guoren@kernel.org> wrote: > > > > On Sun, Jan 30, 2022 at 6:28 PM Marc Zyngier <maz@kernel.org> wrote: > > > > > > On Sun, 30 Jan 2022 04:39:34 +0000, > > > Guo Ren <guoren@kernel.org> wrote: > > > > > > > > > +IRQCHIP_DECLARE(thead_c900_plic, "thead,c900-plic", plic_init); > > > > I think we should give clear info in /proc/interrupts. I hope we could > > > > keep thead_plic_init. > > > > > > Why? There is no material difference at the driver level, and > > > /proc/interrupts won't be the target of a branding exercise (which > > > this series seems to be all about). > > It's not a branding exercise, the series just correct the broken code > > & incorrect /proc/interrupts display. > > There is *nothing* incorrect in /proc/interrupt. If anything, changing > the string *is* an ABI change, for no good reason. I've minimized the modification to fix the problem, please have a look: https://lore.kernel.org/linux-riscv/20220130135634.1213301-3-guoren@kernel.org/T/#u > > M. > > -- > Without deviation from the norm, progress is not possible. -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/ _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-01-30 15:11 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-29 16:27 [PATCH V6 0/2] Add thead,c900-plic support guoren 2022-01-29 16:27 ` guoren 2022-01-29 16:27 ` [PATCH V6 1/2] dt-bindings: update riscv plic compatible string guoren 2022-01-29 16:27 ` guoren 2022-01-29 16:27 ` [PATCH V6 2/2] irqchip/sifive-plic: Fixup thead,c900-plic dt parse in opensbi guoren 2022-01-29 16:27 ` [PATCH V6 2/2] irqchip/sifive-plic: Fixup thead, c900-plic " guoren 2022-01-29 18:32 ` [PATCH V6 2/2] irqchip/sifive-plic: Fixup thead,c900-plic " Marc Zyngier 2022-01-29 18:32 ` [PATCH V6 2/2] irqchip/sifive-plic: Fixup thead, c900-plic " Marc Zyngier 2022-01-30 2:08 ` [PATCH V6 2/2] irqchip/sifive-plic: Fixup thead,c900-plic " Guo Ren 2022-01-30 2:08 ` Guo Ren 2022-01-30 2:50 ` Samuel Holland 2022-01-30 2:50 ` Samuel Holland 2022-01-30 4:39 ` Guo Ren 2022-01-30 4:39 ` Guo Ren 2022-01-30 10:28 ` Marc Zyngier 2022-01-30 10:28 ` [PATCH V6 2/2] irqchip/sifive-plic: Fixup thead, c900-plic " Marc Zyngier 2022-01-30 13:09 ` [PATCH V6 2/2] irqchip/sifive-plic: Fixup thead,c900-plic " Guo Ren 2022-01-30 13:09 ` Guo Ren 2022-01-30 14:59 ` Marc Zyngier 2022-01-30 14:59 ` [PATCH V6 2/2] irqchip/sifive-plic: Fixup thead, c900-plic " Marc Zyngier 2022-01-30 15:11 ` Guo Ren [this message] 2022-01-30 15:11 ` [PATCH V6 2/2] irqchip/sifive-plic: Fixup thead,c900-plic " Guo Ren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJF2gTROgAuj0j2qC6AZFgP+k3erU7erQRadH5ugaVPkj_=1hQ@mail.gmail.com' \ --to=guoren@kernel.org \ --cc=anup@brainfault.org \ --cc=devicetree@vger.kernel.org \ --cc=guoren@linux.alibaba.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=maz@kernel.org \ --cc=palmer@dabbelt.com \ --cc=samuel@sholland.org \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.