Re: [dpdk-dev] [PATCH 7/9] compress/octeontx: remove commented out code

[David Marchand <david.marchand@redhat.com>]

On Tue, Oct 1, 2019 at 3:05 PM Kevin Traynor <ktraynor@redhat.com> wrote:
>
> This code is commented out. Remove it.
>
> Fixes: 43e610bb8565 ("compress/octeontx: introduce octeontx zip PMD")
> Cc: ssahu@marvell.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
>  drivers/compress/octeontx/include/zip_regs.h | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/drivers/compress/octeontx/include/zip_regs.h b/drivers/compress/octeontx/include/zip_regs.h
> index 04c3d75e9..96e538bb7 100644
> --- a/drivers/compress/octeontx/include/zip_regs.h
> +++ b/drivers/compress/octeontx/include/zip_regs.h
> @@ -37,5 +37,4 @@ typedef union {
>  #endif /* Word 0 - End */
>         } s;
> -       /* struct zip_vqx_ena_s cn; */
>  } zip_vqx_ena_t;
>
> @@ -65,5 +64,4 @@ typedef union {
>  #endif /* Word 0 - End */
>         } s;
> -       /* struct zip_vqx_sbuf_addr_s cn; */
>  } zip_vqx_sbuf_addr_t;
>
> @@ -85,5 +83,4 @@ typedef union {
>  #endif /* Word 0 - End */
>         } s;
> -       /* struct zip_quex_doorbell_s cn; */
>  } zip_quex_doorbell_t;
>
> @@ -105,5 +102,4 @@ union zip_nptr_s {
>  #endif /* Word 0 - End */
>         } s;
> -       /* struct zip_nptr_s_s cn83xx; */
>  };
>
> @@ -198,5 +194,4 @@ union zip_inst_s {
>                 /** Beginning of file */
>                 uint64_t bf                    : 1;
> -               // uint64_t reserved_3_4          : 2;
>                 /** Comp/decomp operation */
>                 uint64_t op                    : 2;
> @@ -211,5 +206,4 @@ union zip_inst_s {
>                 uint64_t dg                    : 1;
>                 uint64_t ds                    : 1;
> -               //uint64_t reserved_3_4          : 2;
>                 uint64_t op                    : 2;
>                 uint64_t bf                    : 1;
> @@ -616,6 +610,4 @@ union zip_zres_s {
>  #endif /* Word 7 - End */
>         } /** ZIP Result Structure */s;
> -
> -       /* struct zip_zres_s_s cn83xx; */
>  };
>
> --
> 2.21.0
>

Reviewed-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand