Re: [dpdk-dev] [PATCH v2] build: list symbols exports in a single file

From: David Marchand <david.marchand@redhat.com>
To: dev <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	Bruce Richardson <bruce.richardson@intel.com>,
	 Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	 Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
	Dmitry Malloy <dmitrym@microsoft.com>,
	 Pallavi Kadam <pallavi.kadam@intel.com>,
	Ray Kinsella <mdr@ashroe.eu>,
	 Neil Horman <nhorman@tuxdriver.com>,
	Matan Azrad <matan@nvidia.com>,
	 Shahaf Shuler <shahafs@nvidia.com>,
	Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH v2] build: list symbols exports in a single file
Date: Thu, 8 Apr 2021 18:11:36 +0200	[thread overview]
Message-ID: <CAJFAV8xFXRbQrV=mOsSWT_UJVJZwgobA7HkzVj1kt+ngEax1+g@mail.gmail.com> (raw)
In-Reply-To: <20210406175910.24450-1-david.marchand@redhat.com>

On Tue, Apr 6, 2021 at 7:59 PM David Marchand <david.marchand@redhat.com> wrote:
>
> Rather than have two files that keeps getting out of sync, let's
> annotate the version.map to generate the Windows export file.
>
> Note: Existing version.map annotation achieved with:
> $ for dir in lib/librte_eal drivers/common/mlx5; do
>     ./buildtools/map-list-symbol.sh $dir/*.map |
>     while read file version sym; do
>       ! git grep -qw $sym $dir/*.def || continue;
>       sed -i -e "s/$sym;/$sym; # WINDOWS_NO_EXPORT/" $dir/*.map;
>     done;
>   done
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Tested-by: Tal Shnaiderman <talshn@nvidia.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>

Updated commitlog and sorted common/mlx5 updates (from offlist
comments with Thomas).

Applied, thanks.

-- 
David Marchand