All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tal Shnaiderman <talshn@nvidia.com>
To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
	Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: David Marchand <david.marchand@redhat.com>,
	Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
	Dmitry Malloy <dmitrym@microsoft.com>, dev <dev@dpdk.org>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Pallavi Kadam <pallavi.kadam@intel.com>,
	Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
	Matan Azrad <matan@nvidia.com>,
	Shahaf Shuler <shahafs@nvidia.com>,
	Slava Ovsiienko <viacheslavo@nvidia.com>,
	Ophir Munk <ophirmu@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH v2] build: list symbols exports in a single file
Date: Wed, 7 Apr 2021 11:38:23 +0000	[thread overview]
Message-ID: <DM6PR12MB39451F50643C8D18D7D61C2AA4759@DM6PR12MB3945.namprd12.prod.outlook.com> (raw)
In-Reply-To: <161779865.tXBAfqbjCS@thomas>

> Subject: Re: [PATCH v2] build: list symbols exports in a single file
> 
> External email: Use caution opening links or attachments
> 
> 
> 07/04/2021 10:53, Dmitry Kozlyuk:
> > 2021-04-07 10:16 (UTC+0200), David Marchand:
> > > On Tue, Apr 6, 2021 at 10:09 PM David Marchand
> > > <david.marchand@redhat.com> wrote:
> > > > We have exports missing in EAL for some series posted on the ml
> > > > waiting for merges.
> > > > I suspect some recent merged changes have issues too (but did not
> check yet).
> > > > This current patch does not address such issues and we need fixes
> > > > afterwards if this is what you mean.
> > >
> > > I did a first pass.
> > >
> > > I see symbols from rte_random.c and rte_version.c not exported,
> > > while those files are compiled for Windows.
> > > Could you explain why these are not exported?
> >
> > These are just forgotten, can be safely exported.
> 
> I prefer we don't mix fixes with this format rework.
> Please send fixes on top of this patch.
> Cc'ed Tal & Ophir for mlx5.
> 

Thanks David for resolving the duplication.

For mlx5, the functions mlx5_devx_cmd_*, mlx5_mp_* and mlx5_memory_stat_dump are compiled but currently not used.

I can send a separate patch exporting all of them to be more aligned with Linux, or we can export them whenever we'll actually start using them.

Regardless: 

Tested-by: Tal Shnaiderman <talshn@nvidia.com>

  reply	other threads:[~2021-04-07 11:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06 16:32 [dpdk-dev] [PATCH] build: list symbols exports in a single file David Marchand
2021-04-06 16:40 ` David Marchand
2021-04-06 16:50 ` Bruce Richardson
2021-04-06 16:53   ` David Marchand
2021-04-07 20:06   ` Kinsella, Ray
2021-04-06 17:59 ` [dpdk-dev] [PATCH v2] " David Marchand
2021-04-06 18:52   ` Thomas Monjalon
2021-04-06 20:09     ` David Marchand
2021-04-06 22:39       ` Thomas Monjalon
2021-04-07  8:16       ` David Marchand
2021-04-07  8:53         ` Dmitry Kozlyuk
2021-04-07  8:57           ` Thomas Monjalon
2021-04-07 11:38             ` Tal Shnaiderman [this message]
2021-04-08 14:51   ` Thomas Monjalon
2021-04-08 16:11   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB39451F50643C8D18D7D61C2AA4759@DM6PR12MB3945.namprd12.prod.outlook.com \
    --to=talshn@nvidia.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=dmitrym@microsoft.com \
    --cc=matan@nvidia.com \
    --cc=mdr@ashroe.eu \
    --cc=navasile@linux.microsoft.com \
    --cc=nhorman@tuxdriver.com \
    --cc=ophirmu@nvidia.com \
    --cc=pallavi.kadam@intel.com \
    --cc=shahafs@nvidia.com \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.