All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Wenwu Ma <wenwux.ma@intel.com>
Cc: Xiaoyun Li <xiaoyun.li@intel.com>,
	"Singh, Aman Deep" <aman.deep.singh@intel.com>,
	 Yuying Zhang <yuying.zhang@intel.com>, dev <dev@dpdk.org>,
	Jiayu Hu <jiayu.hu@intel.com>,
	 "Wang, Yinan" <yinan.wang@intel.com>,
	xingguang.he@intel.com
Subject: Re: [PATCH] app/testpmd: perform SW IP checksum for GRO packets
Date: Wed, 11 May 2022 09:27:58 +0200	[thread overview]
Message-ID: <CAJFAV8yDqiY7zKs8xM=KnsVBSkjD4VQp76VD5xpWvUe+5vVyuA@mail.gmail.com> (raw)
In-Reply-To: <20220511013705.24602-1-wenwux.ma@intel.com>

On Wed, May 11, 2022 at 3:40 AM Wenwu Ma <wenwux.ma@intel.com> wrote:
>
> The GRO library doesn't re-calculate checksums for
> merged packets. If users want the merged packets to
> have correct IP checksums, they should select HW IP
> checksum calculation for the port which the merged
> packets are transmitted to. But if the port doesn't
> support HW IP checksum, users may perform a SW IP
> checksum. This patch add the code about it.

It looks like a fix, please add a Fixes: line.
Out of curiosity, would there be an issue too when using the gso library?

>
> Signed-off-by: Wenwu Ma <wenwux.ma@intel.com>


-- 
David Marchand


  reply	other threads:[~2022-05-11  7:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-11  1:37 [PATCH] app/testpmd: perform SW IP checksum for GRO packets Wenwu Ma
2022-05-11  7:27 ` David Marchand [this message]
2022-05-11  9:00   ` Ma, WenwuX
2022-05-11  9:35 ` [PATCH v2] app/testpmd: perform SW IP checksum for GRO/GSO packets Wenwu Ma
2022-05-12  1:07 ` [PATCH v3] " Wenwu Ma
2022-05-12  1:33   ` Hu, Jiayu
2022-05-17  2:56   ` Ling, WeiX
2022-05-17 16:02   ` Zhang, Yuying
2022-05-19  8:23     ` Andrew Rybchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8yDqiY7zKs8xM=KnsVBSkjD4VQp76VD5xpWvUe+5vVyuA@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=aman.deep.singh@intel.com \
    --cc=dev@dpdk.org \
    --cc=jiayu.hu@intel.com \
    --cc=wenwux.ma@intel.com \
    --cc=xiaoyun.li@intel.com \
    --cc=xingguang.he@intel.com \
    --cc=yinan.wang@intel.com \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.