All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sjur Brændeland" <sjurbren@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] caif: fix a potential NULL dereference
Date: Fri, 2 Sep 2011 15:13:22 +0200	[thread overview]
Message-ID: <CAJK669bsA5Gx+9erJpQ1y-YX=F+XY9TJvg9U1ekCRkR0P2UsLQ@mail.gmail.com> (raw)
In-Reply-To: <1314965963.2573.23.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>

Eric Dumazet wrote:
> Commit bd30ce4bc0b7 (caif: Use RCU instead of spin-lock in caif_dev.c)
> added a potential NULL dereference in case alloc_percpu() fails.
>
> caif_device_alloc() can also use GFP_KERNEL instead of GFP_ATOMIC.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Looks good thanks,
Acked-by: Sjur Brændeland <sjur.brandeland@stericsson.com>

  reply	other threads:[~2011-09-02 13:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-02  8:07 [patch -next] caif: add error handling for allocation Dan Carpenter
2011-09-02  8:07 ` Dan Carpenter
2011-09-02  9:40 ` Sjur Brændeland
2011-09-02  9:40   ` Sjur Brændeland
2011-09-02 12:19   ` [PATCH] caif: fix a potential NULL dereference Eric Dumazet
2011-09-02 13:13     ` Sjur Brændeland [this message]
2011-09-16 22:56     ` David Miller
2011-09-02 15:51   ` [patch -next] caif: add error handling for allocation Dan Carpenter
2011-09-02 15:51     ` Dan Carpenter
2011-09-21  7:21   ` [patch v2] " Dan Carpenter
2011-09-21  7:21     ` Dan Carpenter
2011-09-23 10:38     ` Sjur BRENDELAND
2011-09-23 10:38       ` Sjur BRENDELAND
2011-10-03 17:46       ` David Miller
2011-10-03 17:46         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJK669bsA5Gx+9erJpQ1y-YX=F+XY9TJvg9U1ekCRkR0P2UsLQ@mail.gmail.com' \
    --to=sjurbren@gmail.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.