From: David Miller <davem@davemloft.net>
To: sjur.brandeland@stericsson.com
Cc: dan.carpenter@oracle.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] caif: add error handling for allocation
Date: Mon, 03 Oct 2011 13:46:11 -0400 (EDT) [thread overview]
Message-ID: <20111003.134611.1100932218414818334.davem@davemloft.net> (raw)
In-Reply-To: <81C3A93C17462B4BBD7E272753C105791D2BC1882D@EXDCVYMBSTM005.EQ1STM.local>
From: Sjur BRENDELAND <sjur.brandeland@stericsson.com>
Date: Fri, 23 Sep 2011 12:38:45 +0200
> [Dan]:
>> The allocation of "phyinfo" wasn't checked, and also the allocation
>> wasn't freed on error paths. Sjur Brændeland pointed out as well
>> that "phy_driver" should be freed on the error path too.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Looks good, thank you Dan.
> Acked-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: sjur.brandeland@stericsson.com
Cc: dan.carpenter@oracle.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] caif: add error handling for allocation
Date: Mon, 03 Oct 2011 17:46:11 +0000 [thread overview]
Message-ID: <20111003.134611.1100932218414818334.davem@davemloft.net> (raw)
In-Reply-To: <81C3A93C17462B4BBD7E272753C105791D2BC1882D@EXDCVYMBSTM005.EQ1STM.local>
From: Sjur BRENDELAND <sjur.brandeland@stericsson.com>
Date: Fri, 23 Sep 2011 12:38:45 +0200
> [Dan]:
>> The allocation of "phyinfo" wasn't checked, and also the allocation
>> wasn't freed on error paths. Sjur Brændeland pointed out as well
>> that "phy_driver" should be freed on the error path too.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Looks good, thank you Dan.
> Acked-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-10-03 17:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 8:07 [patch -next] caif: add error handling for allocation Dan Carpenter
2011-09-02 8:07 ` Dan Carpenter
2011-09-02 9:40 ` Sjur Brændeland
2011-09-02 9:40 ` Sjur Brændeland
2011-09-02 12:19 ` [PATCH] caif: fix a potential NULL dereference Eric Dumazet
2011-09-02 13:13 ` Sjur Brændeland
2011-09-16 22:56 ` David Miller
2011-09-02 15:51 ` [patch -next] caif: add error handling for allocation Dan Carpenter
2011-09-02 15:51 ` Dan Carpenter
2011-09-21 7:21 ` [patch v2] " Dan Carpenter
2011-09-21 7:21 ` Dan Carpenter
2011-09-23 10:38 ` Sjur BRENDELAND
2011-09-23 10:38 ` Sjur BRENDELAND
2011-10-03 17:46 ` David Miller [this message]
2011-10-03 17:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111003.134611.1100932218414818334.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sjur.brandeland@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.