[PATCH] ARM: dts: exynos: Cleanup Security Subsystem nodes for Exynos5

[PATCH] ARM: dts: exynos: Cleanup Security Subsystem nodes for Exynos5

[Łukasz Stelmach]

Move Security Subsystem nodes to exynos5.dtsi. Adjust clock entries for
Exynos 5250 and Exynos 54xx.

Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---
 arch/arm/boot/dts/exynos5.dtsi    |  6 ++++++
 arch/arm/boot/dts/exynos5250.dtsi | 13 +++++--------
 arch/arm/boot/dts/exynos54xx.dtsi |  6 ------
 3 files changed, 11 insertions(+), 14 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
index 66d22521c976..7da4a4285b24 100644
--- a/arch/arm/boot/dts/exynos5.dtsi
+++ b/arch/arm/boot/dts/exynos5.dtsi
@@ -204,5 +204,11 @@
 			#size-cells = <0>;
 			status = "disabled";
 		};
+
+		sss: sss@10830000 {
+			compatible = "samsung,exynos4210-secss";
+			reg = <0x10830000 0x300>;
+			interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
+		};
 	};
 };
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 8dbeb873e99c..8032d7e567fc 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -731,14 +731,6 @@
 			status = "disabled";
 		};
 
-		sss@10830000 {
-			compatible = "samsung,exynos4210-secss";
-			reg = <0x10830000 0x300>;
-			interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
-			clocks = <&clock CLK_SSS>;
-			clock-names = "secss";
-		};
-
 		sysmmu_g2d: sysmmu@10A60000 {
 			compatible = "samsung,exynos-sysmmu";
 			reg = <0x10A60000 0x1000>;
@@ -1084,4 +1076,9 @@
 	dma-names = "rx", "tx";
 };
 
+&sss {
+	clocks = <&clock CLK_SSS>;
+	clock-names = "secss";
+};
+
 #include "exynos5250-pinctrl.dtsi"
diff --git a/arch/arm/boot/dts/exynos54xx.dtsi b/arch/arm/boot/dts/exynos54xx.dtsi
index 0389e8a10d0b..d0124f45b66a 100644
--- a/arch/arm/boot/dts/exynos54xx.dtsi
+++ b/arch/arm/boot/dts/exynos54xx.dtsi
@@ -79,12 +79,6 @@
 			interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>;
 		};
 
-		sss: sss@10830000 {
-			compatible = "samsung,exynos4210-secss";
-			reg = <0x10830000 0x300>;
-			interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
-		};
-
 		/* i2c_0-3 are defined in exynos5.dtsi */
 		hsi2c_4: i2c@12ca0000 {
 			compatible = "samsung,exynos5250-hsi2c";
-- 
2.11.0

Re: [PATCH] ARM: dts: exynos: Cleanup Security Subsystem nodes for Exynos5

[Krzysztof Kozlowski]

On Thu, Nov 23, 2017 at 3:34 PM, Łukasz Stelmach <l.stelmach@samsung.com> wrote:
> Move Security Subsystem nodes to exynos5.dtsi. Adjust clock entries for
> Exynos 5250 and Exynos 54xx.

>From the code I can figure it out, but the commit msg should say why
you are doing this. Actually the "why" is more important then "what"
because I can easily see "what" the patch is doing.

Code itself looks ok.

Best regards,
Krzysztof

Re: [PATCH] ARM: dts: exynos: Cleanup Security Subsystem nodes for Exynos5

[Łukasz Stelmach]

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]

It was <2017-11-23 czw 17:16>, when Krzysztof Kozlowski wrote:
> On Thu, Nov 23, 2017 at 3:34 PM, Łukasz Stelmach <l.stelmach@samsung.com> wrote:
>> Move Security Subsystem nodes to exynos5.dtsi. Adjust clock entries for
>> Exynos 5250 and Exynos 54xx.
>
> From the code I can figure it out, but the commit msg should say why
> you are doing this. Actually the "why" is more important then "what"
> because I can easily see "what" the patch is doing.

Marek, can you tell us more? It was your idea ;-)

-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]

Re: [PATCH] ARM: dts: exynos: Cleanup Security Subsystem nodes for Exynos5

[Krzysztof Kozlowski]

On Thu, Nov 23, 2017 at 07:05:53PM +0100, Łukasz Stelmach wrote:
> It was <2017-11-23 czw 17:16>, when Krzysztof Kozlowski wrote:
> > On Thu, Nov 23, 2017 at 3:34 PM, Łukasz Stelmach <l.stelmach@samsung.com> wrote:
> >> Move Security Subsystem nodes to exynos5.dtsi. Adjust clock entries for
> >> Exynos 5250 and Exynos 54xx.
> >
> > From the code I can figure it out, but the commit msg should say why
> > you are doing this. Actually the "why" is more important then "what"
> > because I can easily see "what" the patch is doing.
> 
> Marek, can you tell us more? It was your idea ;-)

I believe that the purpose is to remove duplicated definitions of SSS
nodes. They are exactly the same between Exynos5250 and Exynos5420 so
moving them to common file gets rid of duplicated code.

Subject could be also rewritten in that way.

Best regards,
Krzysztof